GitLab

This CL:
- Fixes EventConverterEvdev::SetAllowedKeys() to block disallowed keys
- Dispatches a synthetic key release event for any blocked pressed keys when
  EventConverterEvdev::SetAllowedKeys() is called instead of waiting till the
  user releases the key.

BUG=465611
TEST=EventConverterEvdevImplTest.*

Review URL: https://codereview.chromium.org/992323004

Cr-Commit-Position: refs/heads/master@{#320170}

This a preventive CL. It does not actually fix the problem, which
happens rarely, but instead, it prevents the promo from being
displayed incorrectly.

BUG=465933

Review URL: https://codereview.chromium.org/997733002

Cr-Commit-Position: refs/heads/master@{#320169}

The experiment ended so let's tear down this wall of code.

BUG=326733

Review URL: https://codereview.chromium.org/978953002

Cr-Commit-Position: refs/heads/master@{#320168}

BUG=158752

Review URL: https://codereview.chromium.org/981843003

Cr-Commit-Position: refs/heads/master@{#320167}

base::android::Init(), it shouldn't be part of JNI
registration, So the embedded which doesn't require
to register JNI methods (like WebView) could still
work properly.

BUG=464008

Review URL: https://codereview.chromium.org/995313003

Cr-Commit-Position: refs/heads/master@{#320166}

In the future, we might also want a version of polymer that uses natural animations.

Review URL: https://codereview.chromium.org/998693002

Cr-Commit-Position: refs/heads/master@{#320165}

BUG=454198
R=mmenke@chromium.org

Review URL: https://codereview.chromium.org/998803003

Cr-Commit-Position: refs/heads/master@{#320164}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/cb251f1..97cd070

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/996323002

Cr-Commit-Position: refs/heads/master@{#320163}

BUG=453998
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/999653002

Cr-Commit-Position: refs/heads/master@{#320162}

Adding the base ChromotingInstance implementation and unittests.  This class will be used by the app remoting test driver in a subsequent checkin.

BUG=464808

Review URL: https://codereview.chromium.org/976233003

Cr-Commit-Position: refs/heads/master@{#320161}

Right now, we don't examine nsswitch.conf, but we assume it has a
standard (hosts: files dns) configuration for hostname resolution.

We should check that that's true before activating the internal
resolver, and fall back to the OS resolver if it's not.

In the meantime, however, just disable Async DNS on Linux so it doesn't
break for users with nonstandard configurations.

BUG=117655

Review URL: https://codereview.chromium.org/990063004

Cr-Commit-Position: refs/heads/master@{#320160}

Update SensorManagerChromeOS to implement the DeviceMotionEvent API. Begin
processing accelerometer events into device motion events.

Updated all previous unittests of orientations to also verify the according
device motion events.

TEST=SensorManagerChromeOSTest.MotionBuffer,
SensorManagerChromeOSTest.GravityFilterCompletesForStationaryDevice,
SensorManagerChromeOSTest.NonGravityAcceleration,
SensorManagerChromeOSTest.AccelerationAgainstGravity
BUG=427662

Review URL: https://codereview.chromium.org/934843002

Cr-Commit-Position: refs/heads/master@{#320159}

BUG=466285

Review URL: https://codereview.chromium.org/1001623002

Cr-Commit-Position: refs/heads/master@{#320158}

TEST= none
BUG= none

Review URL: https://codereview.chromium.org/990803003

Cr-Commit-Position: refs/heads/master@{#320157}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4dd513a..c900884

TBR=adamk@chromium.org,beverloo@chromium.org

Review URL: https://codereview.chromium.org/999863002

Cr-Commit-Position: refs/heads/master@{#320156}

EventConverterEvdev::SetAllowedKeys() and EvdevConverterEvdev::AllowAllKeys()
are only called for internal keyboards. GestureInterpreterLibevdevCros is not
used for internal keyboards. The current implementation of
GestureInterpreterLibevdevCros::SetAllowedKeys() and
GestureInterpreterLibevdevCros::AllowAllKeys() is buggy, so just remove it

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/1003523004

Cr-Commit-Position: refs/heads/master@{#320155}

Previously unittests using sinon were required to use sinon.$setupStub
in order to typecheck correctly. It was usable only for the case when
the test wants to stub a single method, but not when a whole object is
stubbed. This CL gets rid of $setupStub and adds $testStub() function
that simply casts parameter to the TestStub type.

Review URL: https://codereview.chromium.org/1002553002

Cr-Commit-Position: refs/heads/master@{#320154}

When the GL Context has been lost, GrContext::wrapBackendTexture returns NULL and ScopedWriteLockGr::InitSkSurface fails to initialize the SkSurface.

In this case, skip trying to draw to the SkSurface's canvas.

BUG=464933

Review URL: https://codereview.chromium.org/988953002

Cr-Commit-Position: refs/heads/master@{#320153}

BUG=462770

Review URL: https://codereview.chromium.org/974273004

Cr-Commit-Position: refs/heads/master@{#320152}

See go/external-token-handle for details.

BUG=462445
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/993103002

Cr-Commit-Position: refs/heads/master@{#320151}

BUG=466270
R=ellyjones@chromium.org

Review URL: https://codereview.chromium.org/1003523002

Cr-Commit-Position: refs/heads/master@{#320150}

BUG=

Review URL: https://codereview.chromium.org/1000773002

Cr-Commit-Position: refs/heads/master@{#320149}

Observing ConnectionType alone doesn't detect network
changes on some OEM platforms. Observe IP address
to address this.

BUG=

Review URL: https://codereview.chromium.org/995933002

Cr-Commit-Position: refs/heads/master@{#320148}

Since Roboto is known to be a little bit smaller than Noto, the font in the keyboard overlay
still looks smaller. Based on Kuscher@'s advice, increase the size a little bit.

BUG=465604
TEST=Manually checked

Review URL: https://codereview.chromium.org/996303002

Cr-Commit-Position: refs/heads/master@{#320147}

Revert of Add IsAlternativeServiceBroken(), remove is_broken. (patchset #4 id:60001 of https://codereview.chromium.org/995013004/)

Reason for revert:
Linux bots failing with:

Check failed: network_task_runner_->RunsTasksOnCurrentThread()

Original issue's description:
> Add IsAlternativeServiceBroken(), remove is_broken.
>
> Add HttpServerProperties::IsAlternativeServiceBroken(), remove
> AlternateProtocolInfo.is_broken.  An alternative service can be broken by
> itself, not with respect to an origin.
>
> BUG=392576
> R=rch@chromium.org
>
> Committed: https://crrev.com/c0844e78ad3dd640f6a2a84f57681ead31647b07
> Cr-Commit-Position: refs/heads/master@{#320116}

TBR=rch@chromium.org,bnc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=392576

Review URL: https://codereview.chromium.org/999893002

Cr-Commit-Position: refs/heads/master@{#320146}

When reording sync nodes for an update, treat sync nodes with implicit
parent folder as if they were linked directly under the directory root.
That is safe to do because only non-hierarchical datatype nodes might
have unset parent IDs and those nodes are OK to handle in any order.

BUG=438313

Review URL: https://codereview.chromium.org/993153002

Cr-Commit-Position: refs/heads/master@{#320145}

When computing a layer's screen-space transform, CalcDrawProps
currently flattens the target-to-screen-space transform used only if
the layer itself flattens transforms. However, a layer's
should_flatten_transform property is intended to affect flattening seen
by descendants, not flattening seen by the layer itself.

Since render surfaces act as a flattening point for their subtree, this
CL makes CalcDrawProps always flatten the full_hierarchy_matrix passed
by render surfaces to their children.

Review URL: https://codereview.chromium.org/995953002

Cr-Commit-Position: refs/heads/master@{#320144}

This is a followup to the update to disable Xvfb for OS=="linux"
use_x11==0 that converts additional targets.

BUG=440882
TEST=isolate.py run -s out_ozone/Debug/<various>
TBR=maruel

Review URL: https://codereview.chromium.org/996173004

Cr-Commit-Position: refs/heads/master@{#320143}

BUG=465868
NOTRY=true

Review URL: https://codereview.chromium.org/994183002

Cr-Commit-Position: refs/heads/master@{#320142}

These have all flaked and timed out at least once in the last week.

R=dmazzoni@chromium.org
BUG=336845,375910

Review URL: https://codereview.chromium.org/975143002

Cr-Commit-Position: refs/heads/master@{#320141}

BUG=23581

Review URL: https://codereview.chromium.org/940783002

Cr-Commit-Position: refs/heads/master@{#320140}

The code had undefined behavior, depending on what order the compiler chose to evaluate the arguments in.  Specifically, the call to RegisterProfile() required evaluation of two arguments: |profile->object_path()| and |base::Bind(success_callback, base::Passed(&profile))|.  If the latter was evaluated first, then |profile| would be null by the time that the prior was evaluated.

The crash stack is:

Program received signal SIGSEGV, Segmentation fault.
std::string::compare() const ()
StartsWithASCII()
dbus::IsValidObjectPath()
dbus::MessageWriter::AppendObjectPath()
chromeos::BluetoothProfileManagerClientImpl::RegisterProfile()
chromeos::BluetoothAdapterProfileChromeOS::Register()
chromeos::BluetoothAdapterChromeOS::UseProfile()
chromeos::BluetoothSocketChromeOS::RegisterProfile()

BUG=457978
TEST=(see bug, comment #14)
R=armansito@chromium.org, jamuraa@chromium.org

Review URL: https://codereview.chromium.org/997023002

Cr-Commit-Position: refs/heads/master@{#320139}

This is a rebase of crrev.com/413823002 by msw@.

Cache RenderText instances, avoid Canvas::DrawString*.
(avoids repeating itemization, layout, etc. on each paint)
Recalculate colors and reset the layout as needed.
Large cleanup; remove obsolete flag tests; update tests.

Update App List's CachedLabel views::Label subclass use.
(SchedulePaintInRect triggered paint with color changes)
Ensure SetTitleSubpixelAA is otherwise called as needed.
(skip early return; which breaks folder reorganization)

This will increase the performance of painting
significantly. See https://docs.google.com/document/d/1q4RrBjNO52l1pNTkIZPhQ60aPfBZnV4Af0vdQNr2Juc/edit#
for the detailed analysis.

BUG=240037, 125348, 450791
TEST=no appearance changes with performance improvement as:
  On daisy with 15 bookmarks, repainting of bookmark is
  decreased as 135msec -> 2.8msec
R=sky@chromium.org

Review URL: https://codereview.chromium.org/867003002

Cr-Commit-Position: refs/heads/master@{#320138}

Delete obsolete tests. Proposal Doc: https://docs.google.com/a/google.com/document/d/1AAl82Ik1LzgMARS73HTAmh7pccoRV-29y3JR1AY2brQ/edit?usp=sharing

BUG=459420

Review URL: https://codereview.chromium.org/995003003

Cr-Commit-Position: refs/heads/master@{#320137}

Also add more logging to SocketHostTcp for easier debugging.

BUG=463680

Review URL: https://codereview.chromium.org/976903002

Cr-Commit-Position: refs/heads/master@{#320136}

Long ago, Chromium used fts2 for history full-text search.  It was
later replaced by fts3, and even later that feature was deleted
entirely.  fts2 is no longer used in the browser at all, so stop
compiling it.

Since SQLite is used by WebSQL, in theory this could affect web
authors, but WebSQL uses an authorizer to allow only specific virtual
table types.  fts2 is not one of those types, I have verified manually
that fts2 tables cannot be created using WebSQL.

BUG=455817

Review URL: https://codereview.chromium.org/999573003

Cr-Commit-Position: refs/heads/master@{#320135}

Currently, this preference is not monitored such that any change through the extension api will require a restart of chrome.

landed fix for crbug.com/457629 is to expose extension api to allow this be changed dynamically.

Tested with the extension.

BUG=466197

Review URL: https://codereview.chromium.org/999833002

Cr-Commit-Position: refs/heads/master@{#320134}

BUG=460553

Review URL: https://codereview.chromium.org/980413003

Cr-Commit-Position: refs/heads/master@{#320133}

Reorder uses-sdk and uses-permission to above application tag.
Remove INJECT_EVENTS permission since we don't need it.

BUG=

Review URL: https://codereview.chromium.org/998003002

Cr-Commit-Position: refs/heads/master@{#320132}

Root cause:
Merge conflict introduced in https://codereview.chromium.org/955283002/

The error handler is now called with an object instead of a string.

BUG=465902

Review URL: https://codereview.chromium.org/999133002

Cr-Commit-Position: refs/heads/master@{#320131}