- 17 Mar, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 90fd0807. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13931 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=qyearsley No-Export: true Change-Id: Ia4bbca97799972b46cc9f468d6471b711642f216 Reviewed-on: https://chromium-review.googlesource.com/967725 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#543937}
-
Harald Alvestrand authored
This test would hang if anything ever went wrong, because failures were not being checked. Rewrote the test to always use failure callbacks. Also switched to using rtcp-mux. Tested by 120 runs on workstation. Bug: chromium:452623 Change-Id: Ie73c32edf22b4ca40e9f5e01b9e9fe5cc054623f Reviewed-on: https://chromium-review.googlesource.com/967761 Commit-Queue: Harald Alvestrand <hta@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#543936}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I81e01c6caf7b28c878f2271ab68f8edb7c00603b Reviewed-on: https://chromium-review.googlesource.com/967724Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543935}
-
Vaclav Brozek authored
pylint reports a number of issues for PRESUBMIT.py. One of them is a real error (using an undefined variable instead of a file name), the rest just nits. Still, good to fix them all to allow pylint discover new failures easily in the future. Bug: 821981 Change-Id: I857be0b4072bfe41687c52d38335d5efebcc952f Reviewed-on: https://chromium-review.googlesource.com/966502 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#543934}
-
Daniel Cheng authored
Change-Id: Ibff3db80b7da087e0ea7870e1ac445bdfd3c81c0 Reviewed-on: https://chromium-review.googlesource.com/967006 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#543933}
-
Sandeep Vijayasekar authored
Test: Build cast shell Bug: internal b/69007670 Change-Id: I1771fe2f7112da7f80d2b8c345bb63beca92b9d2 Reviewed-on: https://chromium-review.googlesource.com/967519 Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#543932}
-
https://webrtc.googlesource.com/src.git/+log/cdd2a97f5af1..8a1b20a21329 $ git log cdd2a97f5..8a1b20a21 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4ba5fb4997647bd36c4685c1099914f48c898ec0 Reviewed-on: https://chromium-review.googlesource.com/967661 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543931}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f2ff9cbcb973..d49af833556c $ git log f2ff9cbcb..d49af8335 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 gmeinke cbuildbot: add firmware key-id to metadata.json Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I58a06e0453b6154ccc0244975d63e3a20c031f0e Reviewed-on: https://chromium-review.googlesource.com/967606Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543930}
-
Koji Ishii authored
BlockPainter::PaintChild() calls LayoutBox::FlipForWritingModeForChild() which subtracts X() twice, so that child painter can add flipped block physical offset. Because LayoutNG does not apply flipped block to its Offset(), this resuts in incorrect paint offsets. I think ideally paint should be able to handle without flipped block throughout all painters, but I don't have enough knowledge to switch to, or to add, such a mode to all painters at this point. This patch matches NGBoxFragmentPainter's semantics to existing painters for flipped block physical coordinate. ~120 tests pass, ~10 new failures, but remaining failures indicate that paint offset needs more fixes. The semantics for floats, abspos, tables, etc. are not clear yet to me. Bug: 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I35857fff030452dc618a529a5c45169e6fac378b Reviewed-on: https://chromium-review.googlesource.com/966047 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#543929}
-
Tom Anderson authored
This cl adds an additional condition of use_sysroot=true to enable the app shell installer. This matches the Linux condition [1]. This is needed to fix gn bootstrap for Chromium packagers, who build without the sysroot. [1] https://cs.chromium.org/chromium/src/chrome/installer/BUILD.gn BUG=822321 Change-Id: Iae8ba0576525a51a3be91960deb939c760c80b86 Reviewed-on: https://chromium-review.googlesource.com/966967Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543928}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: If18e023f64654b3d5dcc2b5cb86649fb138c0d20 Reviewed-on: https://chromium-review.googlesource.com/967607Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#543927}
-
Xiaohui Chen authored
Bug: 822456 Test: ldd can resolve locally build library Change-Id: If5125576ce1c9a26e47ae98f6576a1f2371920c4 Reviewed-on: https://chromium-review.googlesource.com/963599 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543926}
-
Tarun Bansal authored
Bug: 821974 Change-Id: Icceeabb2e31c702341d898193f5ad6870b2d3f1e Reviewed-on: https://chromium-review.googlesource.com/967095 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#543925}
-
https://webrtc.googlesource.com/src.git/+log/317a5228766f..cdd2a97f5af1 $ git log 317a52287..cdd2a97f5 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I61e4328cbf06d04bdd346dbcd910b140961f7b4c Reviewed-on: https://chromium-review.googlesource.com/966970Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3ad8f333d567..f2ff9cbcb973 $ git log 3ad8f333d..f2ff9cbcb --date=short --no-merges --format='%ad %ae %s' 2018-03-13 dgarrett Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." Created with: roll-dep src/third_party/chromite BUG=821615 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I15450adb1a013377fa94601083205f8316ad3000 Reviewed-on: https://chromium-review.googlesource.com/967515Reviewed-by:
-
Gabriel Charette authored
Scripted cleanup for upcoming CL. Removes browser_thread_impl.h from all files that didn't have "BrowserThreadImpl". TBR=jam@chromium.org Bug: 815225 Change-Id: Ica66babda894ef3f43981227f48e84f659a57897 Reviewed-on: https://chromium-review.googlesource.com/967545Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#543922}
-
Karan Bhatia authored
This reverts commit 1f76c848. Reason for revert: WebViewTests/WebViewTest.DownloadCookieIsolation_CrossSession/0 is flaky with network service. Original change's description: > Fix webview tag's using an on-disk directory with the network service enabled. > > Bug: 769401 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Ia9ad46583b00f88631eccbc65c23cf6864134f26 > Reviewed-on: https://chromium-review.googlesource.com/965921 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543837} TBR=creis@chromium.org,jam@chromium.org,mmenke@chromium.org Bug: 769401, 822999 Change-Id: I0feb3dcddc8c7a767b1026c9f3a206419ab89225 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/967056Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543921}
-
Avi Drissman authored
It's unclear how much the "Start Speaking" on the whole page is used. It was implemented only three years ago and has never worked correctly. It's not clear what it even means to speak the entire web document for modern web pages. However, this makes a decent attempt at doing so. BUG=659753, 584798, 585164, 819773 TEST=as in 659753 Change-Id: I252f38c7c7879173c3c4e0afd9dc3a42c81b8a64 Reviewed-on: https://chromium-review.googlesource.com/956029Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#543920}
-
Karan Bhatia authored
BUG=821547 TBR=hajimehoshi@chromium.org Change-Id: I6be988b01770624e793d5571e2dc37400e99c0bd Reviewed-on: https://chromium-review.googlesource.com/967511 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Saman Sami authored
As long as DevTools eyedropper tool is concerned, a snapshot is useless if any sort of downscaling has happened on it. Add an option to disable auto-throttling so that we get the highest resolution possible in any circumstances. Also added a missing call to SetMinSizeChangePeriod. Bug: 813929 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9cca167e6f015bd12d8ce64c9ba04d87847f1c44 Reviewed-on: https://chromium-review.googlesource.com/963309 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Michael Giuffrida authored
AppShell's ShellNetworkDelegate shouldn't return a null pointer from GetWebRequestInfo() when ShellNetworkDelegate::OnBeforeURLRequest() hasn't been called for the request. This was happening when a <webview> had a URL like "ftp://example.com". AppShell was erroneously claiming that the URL would be handled by an external protocol handler, so ShellNetworkDelegate::OnBeforeURLRequest() wasn't called. Later, ShellNetworkDelegate::OnCompleted() would get called, where we expected to have already seen the URLRequest. A secondary fix is to stop pretending to support external protocol handlers. Bug: None Test: WebViewAPITest.TestLoadAbortUnknownScheme Change-Id: I776c6eaed4cfb58166ad7bf87bd87183507942f9 Reviewed-on: https://chromium-review.googlesource.com/966589 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#543917}
-
https://chromium.googlesource.com/catapult.git/+log/2fb447197524..fa0f0f2dd7e9 $ git log 2fb447197..fa0f0f2dd --date=short --no-merges --format='%ad %ae %s' 2018-03-16 nednguyen change ActualPageRunEndToEndTests.testTrafficSettings to use good3g for slow case Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I9ad46712f784b86c61d22f0aebc2489c337edc46 Reviewed-on: https://chromium-review.googlesource.com/967542Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543916}
-
Rob Dodson authored
Image: https://imgur.com/pv5mo8l Bug: 817199 Change-Id: I3f2fbdde41f5126be392e6197edbf5cf9cc44744 Reviewed-on: https://chromium-review.googlesource.com/961881Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Rob Dodson <robdodson@chromium.org> Cr-Commit-Position: refs/heads/master@{#543915}
-
Sammie Quon authored
Last one of spec. Animates the "drag to use splitview" labels (slide in and out and also fade in and out). Create a new child view, which is the one which will get a rotation transform. The parent view will be the layer that gets translated. Note: p1 p2 p3 are called "splitview: Animate phantom window". Test: manual Bug: 808283 Change-Id: I95e1cef7056c1ab4272c05fc8a1a32187576e6bd Reviewed-on: https://chromium-review.googlesource.com/961497Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#543914}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9f6698fc..dd20cd72 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7bc857ad8e939cc326bf76dae61458890d87c12a Reviewed-on: https://chromium-review.googlesource.com/967517Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#543913}
-
Donn Denman authored
Updates some experiment names for the field trial testing config to match what we want to use on the server. BUG=822087 Change-Id: Ieb710725624a7e8a1134d195fc8208b33d864336 Reviewed-on: https://chromium-review.googlesource.com/967347Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#543912}
-
https://pdfium.googlesource.com/pdfium.git/+log/502e85921306..30e0498962e8 $ git log 502e85921..30e049896 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 thestig Add more tests for FPDFText_CountRects(). Created with: roll-dep src/third_party/pdfium BUG=821305 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id8e1d30ede2827a56fe5df4d626a9ce81b353e82 Reviewed-on: https://chromium-review.googlesource.com/966965 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543911}
-
Eugene But authored
Progress track used to be a part of download state icon. Now that state icon is programatically drawn the track should be a part of RadialProgressView. Bug: 820178 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4b20faa6fbbc622de2763b962cc40539b22d24fc Reviewed-on: https://chromium-review.googlesource.com/966936 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543910}
-
Scott Chen authored
As of the time of this CL (M66), window's unload event doesn't not fire when the user navigates away with the back button. To make the behavior consistent between tab-closinng/reload/back, we instead listen to the beforeunload event. Bug: 806912 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I319683f14284e4d6884aa22c84c78fea08ac78ef Reviewed-on: https://chromium-review.googlesource.com/965251 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#543909}
-
Xiangjun Zhang authored
Add the video capture client implementation for the Mirroring service. It requests to start video capturing through the media::mojom::VideoCaptureHost interface, and receive the captured video frames through media::mojom::VideoCaptureObserver interface. Bug: 734672 Change-Id: I8007d9c8cbca1639eee8c5659f0b34a30c85e375 Reviewed-on: https://chromium-review.googlesource.com/954056Reviewed-by:
-
Maks Orlovich authored
This may hopefully make the next person seeing reports of strange 1-byte range requests for previously truncated files less flabbergasted. (And also documented some fields at high-level). Bug: 820862 Change-Id: I3bbb8fc46c2c5a015bf8669165add631df289486 Reviewed-on: https://chromium-review.googlesource.com/964981Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#543907}
-
Qiang Xu authored
changes: Per UI review, change snap height from 16 to 32. Bug: 812313 Test: manual test Change-Id: Ib55687b9105bd705ed081ccea9cb52d97f5442ff Reviewed-on: https://chromium-review.googlesource.com/963593 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#543906}
-
Mitsuru Oshima authored
ash is cros only so we don't need suffix any more. done by mass-rename.sh script. Display_animator_chromeos will be handled in a separate CL as I have to merge two files. BUG=None TEST=All test should pass. Change-Id: I824b69de4db0c787de926963a562cfb0dde64d70 Reviewed-on: https://chromium-review.googlesource.com/967457Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#543905}
-
Karan Bhatia authored
This reverts commit 07737e12. Reason for revert: The CL did not resolve the issue. It seems the tests need to be suppressed in the LeakExpectations file instead. Original change's description: > Marking failures of layout tests on Webkit Linux Trusty > > Bug: 821547 > Change-Id: Idd4bd103a12935599a811a3d02b6f0071637543d > Reviewed-on: https://chromium-review.googlesource.com/961443 > Commit-Queue: Luna Lu <loonybear@chromium.org> > Reviewed-by: Luna Lu <loonybear@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542892} TBR=loonybear@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 821547 Change-Id: I9fa56a82a2ddd4e2f7c1b77aa8fce09a8b01b428 Reviewed-on: https://chromium-review.googlesource.com/967521Reviewed-by:
-
Ahmed Fakhry authored
Moving from a tab of a display that has more modes to a tab of another display that has less modes, where the selected mode of the first display has index >= max index of the second display's modes, this would result in the first display's mode changing to the previous one in the slider. This CL fixes this issue by ignoring change callbacks when the various parameters of the currently selected display are still out of sync. BUG=822248 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I97d1a55b87ad99d9d6821270618609a7c4a880a7 Reviewed-on: https://chromium-review.googlesource.com/965630 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543903}
-
James West authored
Introduce a new CmaBackend interface that is used by the CMA pipeline instead of the public MediaPipelineBackend interface. The two implementations of CmaBackend are MediaPipelineBackendWrapper and MultizoneCmaBackend. Use AudioDecoderSoftwareWrapper to wrap MediaPipelineBackend::AudioDecoder in AudioDecoderWrapper instead of wrapping the audio decoder in the pipeline so that AudioDecoderSoftwareWrapper no longer wraps MultizoneAudioDecoder, which never requires upstream software decoding, and MultizoneAudioDecoder no longer has to handle creating an AudioDecoderSoftwareWrapper in passthrough mode. Bug: internal b/62147653 Test: cast_media_unittests and manual Change-Id: I63fedd14065cd665d89cef7917dcc44f21ce1fd0 Reviewed-on: https://chromium-review.googlesource.com/963493 Commit-Queue: James West <jameswest@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
-
Charles Harrison authored
These experiments have all landed as enabled by default. Bug: None Change-Id: I47f27ae2074d66e1a6454884253baae4443ab64f Reviewed-on: https://chromium-review.googlesource.com/965933Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543901}
-
https://skia.googlesource.com/skia.git/+log/0a86820f2fe3..876dd31483bc $ git log 0a86820f2..876dd3148 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 1c08cbb39..dfebe9b2d (4 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Iba52824b31f8095f04a7912b5611425f323512d6 Reviewed-on: https://chromium-review.googlesource.com/967460Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543900}
-
Muyuan Li authored
Bug: 820255 Test: Manual Change-Id: Ib0a2227350acceb2214e0ed77195473a546f245a Reviewed-on: https://chromium-review.googlesource.com/923179 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#543899}
-
Victor Vasiliev authored
Update the values of the feature flags Set FLAGS_quic_reloadable_flag_quic_streams_unblocked_by_session2 true Set FLAGS_quic_reloadable_flag_quic_disable_version_37 true Set FLAGS_quic_reloadable_flag_quic_disable_version_38 true FLAGS_quic_reloadable_flag_quic_min_rtt_ack_delay is deprecated. FLAGS_quic_reloadable_flag_quic_use_control_frame_manager is deprecated. Identify QUIC streams which should not be registered with the write blocked list using a constructor argument of the stream instead of checking the static_streams_ map in the QuicSession, which is not correctly populated when the check is performed. protected by FLAGS_quic_reloadable_flag_quic_register_streams_early2. Merge internal change: 188654154 https://chromium-review.googlesource.com/c/967182/ Remove unused typedef from BandwidthSampler code Merge internal change: 188514269 https://chromium-review.googlesource.com/c/967108/ Expore an accessor to initalized_ in QuicClient Merge internal change: 188509171 https://chromium-review.googlesource.com/c/967106/ In QUIC, stop sending a redundant PING every 20 acks, because a WINDOW_UPDATE is guaranteed to be sent. Protected by FLAGS_quic_reloadable_flag_quic_remove_redundant_ping. Although this WINDOW_UPDATE and PING will be bundled in the same packet, it is better to remove it. Merge internal change: 188486725 https://chromium-review.googlesource.com/c/967012/ Add bool return value to QuicSentPacketManager::OnIncomingAck() and ::OnAckFrameEnd() to indicate if a new packet has been ACKed. Merge internal change: 188389208 https://chromium-review.googlesource.com/c/967000/ Add IETF-format framer/deframer for the STOP SENDING Frame. Work done in preparation for developing the IETF version of QUIC Merge internal change: 188356015 https://chromium-review.googlesource.com/c/966998/ Let QUIC always discard outgoing packets after connection close. Protected by FLAGS_quic_reloadable_flag_quic_always_discard_packets_after_close. Merge internal change: 188341773 https://chromium-review.googlesource.com/c/966462/ Add Framer/Deframer for IETF QUIC Stream Reset frame Merge internal change: 188331903 https://chromium-review.googlesource.com/c/967002/ Replace a personalized TODO with a bug ID reference Merge internal change: 188320993 https://chromium-review.googlesource.com/c/963772/ Call OnSuccessfulVersionNegotiation earlier on server The server already has cases where version negotiation is completed without verifying authenticity of the packets from the client, but there was one case where it waited to do that before finishing. This changes the order of processing so that version negotiation (on a server) always completes before we have to decrypt a packet. This allows using OnSuccessfulVersionNegotiation as the signal to set the initial crypters for IETF QUIC. Changes when QUIC version negotiation completes on a server. Protected by FLAGS_quic_reloadable_flag_quic_server_early_version_negotiation Merge internal change: 188255217 https://chromium-review.googlesource.com/c/964806/ Deprecate FLAGS_quic_reloadable_flag_quic_use_control_frame_manager. Merge internal change: 188223533 https://chromium-review.googlesource.com/c/963855/ Fixed 3 DeadCode findings in 3 paths: //net/quic/quartc/quartc_stream.cc //net/quic/quartc/quartc_stream.h //net/quic/quartc/quartc_stream_interface.h * connection_error appears to be dead. (3 times) Merge internal change: 188124383 https://chromium-review.googlesource.com/c/964724/ Add QUIC_FLAG_COUNT macros for two flags The macros are added for FLAGS_quic_reloadable_flag_quic_store_version_before_signalling and gfe2_reloadable_flag_delay_quic_server_handshaker_construction. Merge internal change: 188083245 https://chromium-review.googlesource.com/c/964721/ Small refactor. Not flag protected. - Add WRITE_STATUS_MSGSIZE to gfe_quic::WriteStatus. But it is not set anywhere yet. - Add IsWriteError(WriteStatus status) to tell if |status| is an error. It is equivalent to the existing "status == WRITE_STATUS_ERROR" check since WRITE_STATUS_MSGSIZE is not set anywhere. - Add a QuicConnection::IsMsgTooBig(const WriteResult& result). It is equivalent to the existing check since WRITE_STATUS_MSGSIZE is not set anywhere. Merge internal change: 188062461 https://chromium-review.googlesource.com/c/964701/ Deprecate FLAGS_quic_reloadable_flag_quic_min_rtt_ack_delay. Merge internal change: 188050187 https://chromium-review.googlesource.com/c/963223/ R=rch@chromium.org Change-Id: Ib28a94eddbd95abff0b6b267c37d7f9f0a97bc95 Reviewed-on: https://chromium-review.googlesource.com/967100Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#543898}
-
