- 19 Mar, 2020 40 commits
-
-
Anand K. Mistry authored
Bug: None Change-Id: I28c0fe028f906807628e62c84a380e293b18fc9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105688Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#751595}
-
Ken Rockot authored
Bug: 1059389 Change-Id: I6fa56c1cdd6bfbc92b6954a05da232bcf61ecec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108617Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#751594}
-
Nicholas Hollingum authored
This is a reland of 9b8ade13 Original change's description: > Crostini Upgrader: Do not proceed if user cancels backup > > Previously if the user cancelled the backup, we would proceed with the > upgrade as though the user had elected not to backup at all. > > With this change, the flow will instead return to the initial screen > when the user cancels, rather than proceed. > > Bug: 1061203 > Change-Id: I7be99a2c7a6caa4b5fd143def5ba0c6f9b4d5004 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102935 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Commit-Queue: Nic Hollingum <hollingum@google.com> > Cr-Commit-Position: refs/heads/master@{#750833} Bug: 1061203 Change-Id: I983fc82b74db8cba6f2d2acf6997c8d0a2a25bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109431Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#751593}
-
Kelvin Jiang authored
Bug: 947591 Change-Id: I06b2ff6505ed0f1efd326df2a73cac8ee3ec35bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081363 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#751592}
-
Nancy Wang authored
This reverts commit e3e24fb5. Reason for revert: <INSERT REASONING HERE> Tree is close because of this CL: https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/24482?blamelist=1#blamelist-tab Original change's description: > [CrOS setting] Move OS routes into os_settings_routes.js > > Before this CL, routes for both browser and OS where in routes.js file. > This CL removes routes for chromeOS to a new file os_settings_routes.js > also updates references to SettingsRoutes to OSSettingsRoutes in all > chromeOS files. > > Fixed:967861 > > Change-Id: Ib3aea093fad90188699e7325632dc93610336f99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090794 > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > Cr-Commit-Position: refs/heads/master@{#751587} TBR=khorimoto@chromium.org,rbpotter@chromium.org,hsuregan@chromium.org,tjohnsonkanu@google.com Change-Id: I58359fa710ace42d2dc3c184d080263df8de1f51 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108452Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#751591}
-
Christopher Lam authored
This CL adds specificity to generated CSS variables. This is needed to override the variables defined in paper-styles/color.html and shared_vars_css.html. This will allow us remove deprecated colors and ensure that clashing color names will resolve to cros_palette colors. Bug: 1062154 Change-Id: I87fbd3013daae8f6553f3129ed44d27be51b18b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106041Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#751590}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d9ebe015405d..93bcaae44524 git log d9ebe015405d..93bcaae44524 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1386d9f5..d69529f5 (751294:751530) Created with: gclient setdep -r src/third_party/webrtc@93bcaae44524 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icfc054cf27b77adb1fe05b4c5da2abf797261f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108924Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751589}
-
Mei Liang authored
This CL enables TabSelectionEditor to show a List for low-end devices. Change-Id: Ie60c1e7ddcda09c2f32e23c4de52be7e642e09e0 Bug: 1042889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103313 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751588}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL, routes for both browser and OS where in routes.js file. This CL removes routes for chromeOS to a new file os_settings_routes.js also updates references to SettingsRoutes to OSSettingsRoutes in all chromeOS files. Fixed:967861 Change-Id: Ib3aea093fad90188699e7325632dc93610336f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090794Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#751587}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ibfa72892603bf293ad5777213cc02fe1e4bfb2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107917Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751586}
-
Hitoshi Yoshida authored
NotShared/MaybeShared templates are on-stack pointer wrappers to ensure the pointed ArrayBufferView is shareable between threads or not. We could not store these pointers as a part of objects because they are on-stack objects, and had to convert to a pointer with |.View()|. class KeepNotSharedABV : public GarbageCollected { using T = DOMUint8Array; void setFoo(const NotShared<T>& v) { m_ = v.View(); } NotShared<T> getFoo() const { return NotShread<T>(m_); } Member<T> m_; }; Because of it, it was not obvious if an object holds a shareable view or not. This CL makes these templates like smart pointers, and be able to be a part of GCed objects. So now we can make it like class KeepNotSharedABV : public GarbageCollected { using T = DOMUint8Array; void setFoo(const NotShared<T>& v) { m_ = v; } NotShared<T> getFoo() const { return m_; } NotShared<T> m_; }; Bug: 839389 Change-Id: Id3d47f1d6a01953b8c82316ebc0d2af68d1685b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104787 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#751585}
-
David Dorwin authored
Reduce the severity unless/until the underlying issue is addressed. Bug: 1061262 Change-Id: I73d2b5f74bafaab182bbd36394cecb2f2d29ef75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044525Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751584}
-
Jinsuk Kim authored
This CL moves EphemeralTabCoordinator field from ChromeActivity to TabbedRootUiCoordinator since it is UI a component for tabbed mode only. This aims to make the code structure better by slimming down ChromeActivity (no more getter for the object), hence one less usage of Tab.getActivity() in TabContextMenuItemDelegate, replaced with an injection of a dependency through the constructor. Bug: 1051184 Change-Id: I5856cb27030f3b7e7e17efd93a001d2e84335a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102029 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751583}
-
alanlxl authored
This CL moves json parsing to the isolated data_decoder::DataDecoder for security concerns. Bug: 1049886 Test: Pass the unittests Change-Id: Ifb41b269e219925768c69178c5af75e5048f868d Cq-Depend: chromium:1905044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050419Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#751582}
-
Nicholas Verne authored
Several tweaks made to upgrade flow to make it play better with the new terminal. Since the terminal launches its window prior to starting crostini, we move the upgrade availability check to an earlier phase of LaunchCrostiniApp. Also, when the user decides not to upgrade, we don't restart crostini twice. (Previously, this could happen because the upgrade process needs to shut down crostini first). Bug: 1024693 Change-Id: I46ee09877a7092d91894b80bc798ed99e4f855ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108300Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#751581}
-
Kent Tamura authored
It is referred only by ListBoxSelectType. SelectType::DidBlur(), which modifies last_on_change_selection_, is also moved to ListBoxSelectType. This CL has no behavior changes. Bug: 1052232 Change-Id: I6ccb206f3432f7c7dbc0685133ca7ae3a1abeca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105832 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#751580}
-
Jeremy Roman authored
This is a very common case, and this happens to produce smaller (and in theory, slightly faster) code. Change-Id: I33bbd12effe99d5890480d3d752fcd0df20f5486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106386 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751579}
-
Johann authored
Change-Id: I9977a7b2009c89438cf8b3191417325951d3ced1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105270Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#751578}
-
Allen Bauer authored
TBR=asvitkine@chromium.org Bug: 1056944 Change-Id: Id0b82d349e665dc91f21bf4db372fa3e5f7e58ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106813 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#751577}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/41a6191ed80e..8413a03c394c git log 41a6191ed80e..8413a03c394c --date=short --first-parent --format='%ad %ae %s' 2020-03-19 fancl@chromium.org Cache image for push-on-green Created with: gclient setdep -r src/third_party/catapult@8413a03c394c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: Iab8305c2cdd6ba46abd649d82aecd72f3882a519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109293Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751576}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Ie77639cc2e9de794cda6301911d9376142deb030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109261 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#751575}
-
Demetrios Papadopoulos authored
Subpages of people_page.html are not migrated yet, and will be in later CLs. For this reason unit tests are also not ported yet. Bug: 1026426 Change-Id: I4ae2d79ab2506e420a84f726078cc4be50f329f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107961 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#751574}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a55c361cbb3..fd01ffa2b6de Created with: gclient setdep -r src-internal@fd01ffa2b6de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586 Tbr: jbudorick@google.com Change-Id: Ieaec52c4038d034639bbaad63c62bc54814e3c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109290Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751573}
-
Kyle Milka authored
The bottom row is built based on the list of activity names provided as a variations param. Test with command line shown here: http://gpaste/5438423735205888 Bug: 1009124 Change-Id: Ic43106c1fc10fdb5178516e8e9812a73b35101f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086296 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751572}
-
Eric Willigers authored
On Mac, the New Window command could already open bookmark apps. We now also open web application windows, using the LaunchService. This change ensures behavior is preserved when we ship BMO - Desktop PWAs without Extensions crbug.com/877898 Bug: 913360,953540 Change-Id: I6575f4a9f78af474d48da2ed6baaf7e4887dbfde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107031 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#751571}
-
Zain Afzal authored
Bug: 996088 Change-Id: Icd5e667f216c4202d3144666e88313817f6ffabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108203Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#751570}
-
Tina Wang authored
Since profile card feature won't be launched in short term, remove the flag of it. Bug: 1062032 Change-Id: I0844f274f955d915940bb59014486ae62f8c3bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106473Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#751569}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/96241ef6..d3ac36c8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib58ff5189d47b589877c09c5e8ee3ecd74b48c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108841Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751568}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/78a85f2c1856..f955fb455585 git log 78a85f2c1856..f955fb455585 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 jmadill@chromium.org Roll chromium_revision 86e00b5d..fa9d5805 (743688:750702) 2020-03-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 6cd8cbdaab99..caeb15a056a0 (15 commits) 2020-03-18 courtneygo@google.com Vulkan: Must call vkFlush while memory is mapped 2020-03-18 tobine@google.com Vulkan:Set one-time bit on all command buffers 2020-03-18 courtneygo@google.com Be sure to clear all program state at unlink 2020-03-18 jmadill@chromium.org Capture/Replay: Fix MEC Query capture. 2020-03-18 jmadill@chromium.org Capture/Replay: Fix compressed texture subImage caching. 2020-03-18 jmadill@chromium.org Capture/Replay: Use zlib to compress data files. Created with: gclient setdep -r src/third_party/angle@f955fb455585 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ia9a55781a150e7529a90ef09935f2b53900f478a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109292Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751567}
-
Christopher Lam authored
This CL adds the WebAppFrameToolbarView to System Web Apps so that PageActionIconViews can anchor reasonably. This also makes the Zoom icon show when the page is zoomed and generally makes the SWA frame more consistent with PWAs. Bug: 1055736 Change-Id: I1d5eafa7f0e89a75be60b2df911fce3e0a46376e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089536Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#751566}
-
Johann authored
Most mojo Receiver/Remote objects are getting moved to the heap so they can be managed by Oilpan. Document exceptions. Change-Id: I55436d89ff1dd72273e42c1870e0b5c543ba8f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098152Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#751565}
-
Rakina Zata Amni authored
When ProactivelySwapBrowsingInstance is turned on with the level set to CrossSiteReuseProcess (see crrev.com/c/2043521), renderer-initiated navigations might trigger a BrowsingInstance swap which leads to a RenderView swap, etc, with a possibility of the current renderer process getting reused. Some parts of the TestRunner code does not expect this (they expect the main window RenderView change always go hand-in-hand with RenderProcess change, and that we always restart with a clean state after those navigations), so we are updating it. Bug: 977562 Change-Id: I469d28b2553b1a7d4e8025c30c3a5593267cb42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094480 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#751564}
-
Piotr Bialecki authored
Refactor part 2/2. Previous part: https://crrev.com/c/2087701 Separate anchor manager logic into "update" step and "obtain data" step, similarly to the approach found in plane manager. Change-Id: Ief886b53c1b933b7dae441bbe572b0302d82d28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107564 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#751563}
-
Charlene Yan authored
Bug: 1062678 Change-Id: I41e88343ab4cfa60443a9ce5fc883a90d53d154a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108917 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#751562}
-
Ken MacKay authored
Change-Id: I288e3b7becaf926bef5fb61cb0bdd1c215cca31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108986Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#751561}
-
rbpotter authored
Now that the old UI code has been deleted, remove the old summary format string, which is no longer used, and simplify the logic updating the header summary. Bug: None Change-Id: I3c5ee7bc94db5f886a397e79c955a3488ec3d315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108794Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#751560}
-
Donn Denman authored
Adds a new chrome://flags entry for Related Searches. This will initially be a demo based on Contextual Search, and available to Googlers only until it has evolved (exploration-only now). BUG=1062737 Change-Id: I262971e7fddd188b0af3d7146076454b3616ac76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108901Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#751559}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5a644f827636..464e9ff4f368 git log 5a644f827636..464e9ff4f368 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 sokcevic@google.com Add support for git_cl_tests on Windows platform Created with: gclient setdep -r src/third_party/depot_tools@464e9ff4f368 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I944cbf80aa81649a7790caff9caf54583559a7eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108899Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751558}
-
Keita Suzuki authored
This commit adds support to network service to consume websocket frame data from mojo datapipe produced from blink. To achieve this, this commit adds a new message SendMessage() in mojo WebSocket interface. It also adds SimpleWatcher to watch the consumer and be notified when needed, and add callback function OnReadable() to support this. This commit also adds ReadAndSendFrameFromDataPipe() to actually consume data from the datapipe. The producer side of the datapipe and the caller of SendMessage() are not implemented yet for security review. WIP CLs are uploaded here: https://chromium-review.googlesource.com/c/chromium/src/+/2082869 https://chromium-review.googlesource.com/c/chromium/src/+/2083777 Design Doc: https://docs.google.com/document/d/1YWj1z9r8wxemGdod6S2tkchudhp6PvNaH3qSO0oucfY/ Bug: 1056030 Change-Id: I580e3776bf0f1a27e8d83e5c92087f5542b19cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071189 Commit-Queue: Keita Suzuki <suzukikeita@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#751557}
-
George Burgess IV authored
This reverts commit 87f7c2f5. Sounds like this was fixed in the most recent clang roll by CrOS. Bug: 1031344 Change-Id: I6dbe1aedc914b828092814bbad77d658d437a485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109238Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#751556}
-