- 18 Sep, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I8d0c9abb6509d312070ef2e2ad88a9c183b1b095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418835Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808409}
-
Dave Tapuska authored
Implement RequestDecode solely in blink calling a ScheduleAnimationForWebTests after a decode is queued. This matches the previous WebWidgetTestProxy override and is a similar flow for ForcedDraw presentation callback. BUG=1097816 Change-Id: I0beed33165e4e3b7245c5221ddc3f50bd95b0763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416256Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#808408}
-
Allen Bauer authored
Bug: 938501 Change-Id: Id081d75d91818bf63c78f07dd457d282d510c7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415368Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#808407}
-
Andrew Grieve authored
Also: * Throws a more explicit exception for failed fetch. * Stops setting Cache-Control: no-cache Bug: None Change-Id: I380207b32497f1cb5467ff62bcd3c857dc03ff58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418799 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#808406}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf3ca769044b..ac3fc4afea5d 2020-09-17 tcwang@google.com cros_build_lib: Fix UncompressFile to cope with xz_auto If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: If85ad8b4275bbf81f92e1e288095744c07236824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418837Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808405}
-
Gayane Petrosyan authored
Add range to text fragment selector when selection is too long is spans across block boundaries. Gradually add words from beginning and end of the selection until unique match is found. Bug: 1102382 Change-Id: I71ce2623dae410aa7f21861bf2a6de6911cfe692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412698 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#808404}
-
rbpotter authored
Bug: 1128583 Change-Id: I2398ae172380f4bb8478c7d4a0c51fa981e5ebb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414681 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#808403}
-
Fabrice de Gans-Riberi authored
The test is flaky on multiple platforms. TBR=joedow@chromium.org Bug: 1126973 Change-Id: I4584e882fa96a9e442f01ad975c3acf92c406aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418977Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#808402}
-
Dan Harrington authored
- Offline pages integration with zine is not needed, since Zine is iOS only, and offline_pages is Android only. This includes code in both ntp_snippets/ and offline_pages/. - Remove SuggestionsEventReporter Java integration, none of these apply to the new Feed. Bug: 1069183 Change-Id: Icd538c9cac875c0f656e6a1f2893ef238e313142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405810Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#808401}
-
Michael Lippautz authored
Avoids the propagation of the detached'ness state of DOM nodes. Instead, the state is just passed in as embedder data field, which is then picked up by the DevTools front end to compute the same information. This allows a unified heap implementation in V8 to be independent of the detached'ness state of DOM nodes. Dependencies: - https://crrev.com/c/2332174 - https://crrev.com/c/2328862 Bug: chromium:1110816 Change-Id: Iecae3cfaf5177e53958e468ae7342548a8e4e184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332442 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808400}
-
John Abd-El-Malek authored
Also add comments for the delegate methods. Change-Id: I39119f7496c8b57d9c51dcc39b6fbf1b3afdf6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413017 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#808399}
-
Omar Morsi authored
This CL changes the behaviour of ManagedNetworkConfigurationHandler::RemoveConfiguration to respect network configurations done by policy by preventing removing them. Bug: 470104 Change-Id: Ica30268a979c27084a58fd86745e613de10fce51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410865Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#808398}
-
Eugene But authored
The data is retrieved from PreviousSessionInfo singleton and includes the following fields: - free_disk_in_kb - memory_warning_in_progress Bug: 1103752 Change-Id: I10e6fe758bfde8ad753cbbd363ab34afc1a52e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414784 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#808397}
-
Patrick Noland authored
CustomTabToolbar uses different theme coloring logic than the other browsing mode toolbars; it only distinguishes between light and dark, without any consideration of site-specific customizations. This means we should use the AppThemeColorProvider in this context, rather than the TabThemeColorProvider. Bug: 1128337 Change-Id: I613e81b5fb735689c313bb1c7579a35012cd74bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415370Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#808396}
-
Ben Mason authored
TBR=eugene@chromium.org Bug: 1129740, 1122955 Change-Id: I2b70502587c1c889388113f58c9987e737a19d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418851Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#808395}
-
Evan Stade authored
The changes broke signin. Bug: 11289611 Change-Id: Id39601cef6257eaffa3b4fb0a3b6fb2ddd22107f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418564Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#808394}
-
Kevin Marshall authored
This is a reland of 13c126e3 Addresses the size increase by removing the dep on //ui/base. All uses of ui::ResourceBundle in CastRunner are replaced with disk reads. Original change's description: > [bindings] Define cross-platform NamedMessagePortConnector impl. > > Refactors NamedMessagePortConnector into a platform-agnostic component, > which can be reused across FIDL, in-process, and testing contexts. > It uses Blink messages and message ports as a common basis for > message and port transport. > > * Implements some missing portions of the Blink/FIDL MessagePort > conversion layer. > * Adds a Fuchsia implementation of NMPC. > > Bug: 1104369 > Change-Id: I01e86c38963bfb114a7466c6f73b143e5302ad1e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293110 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806684} Bug: 1104369 Change-Id: I77dc7679030e0f0aa61ad4dba2050ce2cb6e22d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417492Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#808393}
-
Clayton Wilkinson authored
This updates the local-sdk.py script to build the terminal product vs. the core product. This is done to align local-sdk configuration with the configuration used when creating the prebuilt SDK images from Fuchsia. Change-Id: Icda16c36e2f850bd2ab595cbb35edc128657fa95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418848Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#808392}
-
Fabrice de Gans-Riberi authored
This reverts commit 34905419. Reason for revert: Causes crash in tests on linux-chromeos-dbg. First failing build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20491 Original change's description: > Add mock policy option to extension install mixin > > Add an option to initialize ExtensionForceInstallMixin with a > MockConfigurationPolicyProvider. > Use this option in ForceInstalledAffiliatedExtensionApiTest. > Add mixin support to ForceInstalledAffiliatedExtensionApiTest. > > Bug: 1090941 > Change-Id: Ieea931c108e091679be607045f405b55f4186a57 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416453 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: David Bertoni <dbertoni@chromium.org> > Reviewed-by: Omar Morsi <omorsi@google.com> > Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808281} TBR=emaxx@chromium.org,dbertoni@chromium.org,omorsi@google.com,fabiansommer@chromium.org Change-Id: I1b888be0d90a6ef99ac4f9e6c431296062bdb5cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419237Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#808391}
-
Rouslan Solomakhin authored
Before this patch, it was possible to delete the render frame host before the secure payment confirmation app, which owned an instance of an authenticator that must outlive the render frame host. This caused a crash. This patch makes secure confirmation app observe the render frame host deletion, so the app can delete the authenticator that it owns before the associated render frame host is deleted. The android implementation (currently behind chrome://flags/#enable-web-platform-experimental-features flag) has been changed to match the desktop implementation (behind origin trial in M-86) to create the authenticator on the main frame of the web page, so cross-origin web pages can exercise the payment credential, too. After this patch, the authenticator is deleted before the render frame host, which avoids the crash. Bug: 1125614 Change-Id: I83502b1b6bf23b838211687497a6498d5c4777ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410348Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808390}
-
Artem Sumaneev authored
Make IsManagedSessionEnabledForUser return default value when DeviceLocalAccountPolicyBroker is unavailable. IsManagedSessionEnabledForUser can crash while dereferencing nullptr broker. The crash can happen when: - DeviceSettingsProvider does not have a list of device local accounts in kAccountsPrefDeviceLocalAccounts, - and there is an attempt to autologin with public account before the device settings become available. The crash happens only during early initialization stage of browser. Specifically, upon call of ProfileManager::CreateInitialProfile(). Future calls of IsManagedSessionEnabledForUser (and there is a lot of them) will resolve default value into real policy value. Bug: 1061522 Test: manual with switches::kLoginUser and public account autologin Change-Id: Ia8b727fc96924da98003b7d06ff5f5397decb74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410867 Commit-Queue: Artem Sumaneev <asumaneev@google.com> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#808389}
-
Rahul Arakeri authored
This CL fixes an issue with thumb drag after a jump-click. When user does a jump-click (but doesn't let go of the pointer) and drags the thumb, the scroller doesn't scroll. This happens because the "drag_state_" doesn't get initialized when a jump-click is performed. The fix is to initialize the drag_state_ so that the thumb can be dragged. Bug: 1127561 Change-Id: I32d38007e15e923fedfeb7ef81e9af98632510d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416864Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#808388}
-
Chris Sharp authored
Change-Id: Icbeb93a8a537a7240e49a9180aae5d04d3e93796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418616Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#808387}
-
Patrick Noland authored
Change-Id: Icd08d8fde181ec3e867704d3e6a06278cad2c97b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414619Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#808386}
-
Guillaume Jenkins authored
Moves the DisableSafeBrowsingProceedAnyway from supported_on iOS 85 to future_on. This is the only policy that wasn't moved to future_on, other than EnableExperimentalPolicies. I believe it was an oversight. Without this change, the enterprise documentation page for the policy has a visual bug when displaying supported versions: https://screenshot.googleplex.com/7ZxKRy3mCmgCyut BYPASS_POLICY_COMPATIBILITY_CHECK="Moving the policy to future_on, since it hasn't truly been released" Bug: 1129888 Change-Id: I215afe151edc7379b60c85dcf2e1b31be00d625c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416852 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#808385}
-
Markus Handell authored
This reverts commit 6fc7c32c. Reason for revert: crbug.com/1128470 Original change's description: > [PTZ] Add macOS support > > This CL makes sure a USB Webcam device on macOS properly advertises its > PTZ support. When supported, the pan, tilt, and zoom controls (ranges > and values) are available to websites that user has granted access to. > > Bug: 934063 > Change-Id: I9d92d41fba0a6e9d518efb2501355d66cf77998f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368596 > Reviewed-by: François Beaufort <beaufort.francois@gmail.com> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: François Beaufort <beaufort.francois@gmail.com> > Cr-Commit-Position: refs/heads/master@{#807387} TBR=avi@chromium.org,beaufort.francois@gmail.com,reillyg@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 934063 Change-Id: I88b1a41d28f5ad34f149f489b22eae6753e051dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418577Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#808384}
-
Elaine Chien authored
Bug: 1129024 Change-Id: I4d56a24510e09875463485ba105cbd354bd5f58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414925Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elaine Chien <elainec@chromium.org> Cr-Commit-Position: refs/heads/master@{#808383}
-
Yunke Zhou authored
Bug: 1127546 Change-Id: Ib4797dc6d8f2b28c15c3b55fb1a122d1027d999f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416502 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808382}
-
Oleg Davydov authored
This is minor simplification in WallClockTimer: Instead of SetNow(Now() + delay) idiom use special SimpleTestClock method. Bug: None Change-Id: I035bfe44792c0e12c23373ded65ad520792d1824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418317 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808381}
-
Evan Stade authored
Bug: 1110811 Change-Id: Ic71790caad999db46b8a008f4194e4bf3ddab90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415090 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#808380}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ia566284652d587b7462a24638091c57af4350f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347034 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808379}
-
Denis Kuznetsov authored
Bug: 1102019 Change-Id: I5ec6f6a7467de2cb779984b9f1425f975c10f5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418377 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808378}
-
Kevin Ellis authored
Fixes regression introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2416390 Bug: 1129816, 129780, 1129664 Change-Id: I793a61710fdc1f1b05b15d84a0aec4b4fc08bde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418971Reviewed-by:
Eugene Girard <girard@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#808377}
-
Ioana Pandele authored
A few test cases require access to list elements that can be off-screen. Those tests should first attempt to scroll to the required element, so that its corresponding view actually exists in the hierarchy. Bug: 1129884 Change-Id: Ifa5df8bdd26823c244339197d70806843763cd13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418672 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808376}
-
Titouan Rigoudy authored
This change has the computation take into account the is_web_secure_context bit as set on the parent document, if any. It is not immediately clear what to do when the parent document has not committed a navigation yet. I suspect this ties in to crbug.com/1129326, in which we might want to look at the *current* frame's client security state instead, and inherit a value at frame creation time from the parent. Also stop computing the client security state for navigation requests served by the back-forward cache. Bug: chromium:1126856 Change-Id: I72a3ffddf53eaea04f579c87705eff68508474ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414249 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808375}
-
Roman Sorokin authored
It's not being reported to histograms Bug: none Change-Id: I1e6999cf4618cdeb9a7969e78d35a06b0d461c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418573Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808374}
-
Robert Sesek authored
- Note that a component build will not work. - Note that library validation is incompatible with self-signed identities. - Add troubleshooting steps for detached signatures. Change-Id: Iffe04daffb49b2332966325abf02f4b11344e6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416997 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#808373}
-
arthursonzogni authored
This reenable the two tests: CoopReportingOriginTrialBrowserTest.AccessReportingWithToken CoopReportingOriginTrialBrowserTest.CoopStateWithToken They aren't working on Android, because the OriginTrialPolicy is not set on this platform for BrowserTest in the browser process. See the comment in the code below. Bug: 1119555 Change-Id: I66cd03c9b8e1de26e9e21469149620eca43d67d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388120Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808372}
-
Alice Wang authored
This CL adjusts the strings used in web sign-in bottom sheet to the final version that has legal approval. Screenshots: https://crbug.com/1129810/#c1 Bug: 1129810 Change-Id: Ic628263227b108376a7d72efa5b71ce4d03442d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418314 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#808371}
-
Yuanyao Zhong authored
Update chromecast's copy of accessibility private API. Add AcceleratorAction to accessibility_private.json. This is another candidate for duplicate code cleanup efforts. (See crbug.com/837773) However, leaving this in place for now. This change is needed for downstream accessibility to work. Test: build chromecast Bug: None Change-Id: I643642b821f247c928c6df27a338fb9b20d5b16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416853Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Yuanyao Zhong <yyzhong@google.com> Cr-Commit-Position: refs/heads/master@{#808370}
-