- 29 Jan, 2010 19 commits
-
-
jorlow@chromium.org authored
Reviewed by Darin Fisher. StorageNamespaceProxy::copy() should be a no-op https://bugs.webkit.org/show_bug.cgi?id=34298 The comment in the code should make clear why. * public/WebViewClient.h: * src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespaceProxy::copy): git-svn-id: svn://svn.chromium.org/blink/trunk@54046 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Darin Adler. Change CSS 'page-break-inside' property from inherited one to non-inherited one because CSS specification defines so. Note: Currently, the 'page-break-inside' property is used only when parsing the CSS. That property is not used when rendering. https://bugs.webkit.org/show_bug.cgi?id=34195 * fast/css/getComputedStyle/computed-style-page-break-inside-expected.txt: Added. * fast/css/getComputedStyle/computed-style-page-break-inside.html: Added. * fast/css/getComputedStyle/script-tests/computed-style-page-break-inside.js: Added. 2010-01-28 Hayato Ito <hayato@chromium.org> Reviewed by Darin Adler. Change CSS 'page-break-inside' property from inherited one to non-inherited one because CSS specification defines so. Note: Currently, the 'page-break-inside' property is used only when parsing the CSS. That property is not used when rendering. https://bugs.webkit.org/show_bug.cgi?id=34195 * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::NonInheritedFlags::operator==): (WebCore::InheritedFlags::setBitDefaults): (WebCore::InheritedFlags::pageBreakInside): (WebCore::InheritedFlags::setPageBreakInside): * rendering/style/StyleInheritedData.cpp: (WebCore::StyleInheritedData::StyleInheritedData): (WebCore::StyleInheritedData::operator==): * rendering/style/StyleInheritedData.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54045 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Alexey Proskuryakov. ApplicationCache events should be deferred until after Document onload has fired. https://bugs.webkit.org/show_bug.cgi?id=29690 * http/tests/appcache/deferred-events-expected.txt: Added. * http/tests/appcache/deferred-events.html: Added. * http/tests/appcache/deferred-events-delete-while-raising-expected.txt: Added. * http/tests/appcache/deferred-events-delete-while-raising.html: Added. 2010-01-28 Michael Nordman <michaeln@google.com> Reviewed by Alexey Proskuryakov. ApplicationCache events should be deferred until after Document onload has fired. https://bugs.webkit.org/show_bug.cgi?id=29690 Test: http/tests/appcache/deferred-events.html * loader/FrameLoader.cpp: (WebCore::FrameLoader::handledOnloadEvents): Tells the ApplicationCacheHost to stop deferring events. * loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): Initialize m_isDeferringEvents to true. (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): Depending, defer or raise the event. (WebCore::ApplicationCacheHost::stopDeferringEvents): Raise any deferred events and reset the flag. * loader/appcache/ApplicationCacheHost.h: Declare new data members and method. 2010-01-28 Michael Nordman <michaeln@google.com> Reviewed by Alexey Proskuryakov. ApplicationCache events should be deferred until after Document onload has fired. https://bugs.webkit.org/show_bug.cgi?id=29690 * src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): Initialize m_isDeferringEvents to true. (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): Depending, defer or raise the event. (WebCore::ApplicationCacheHost::stopDeferringEvents): Raise any deferred events and reset the flag. git-svn-id: svn://svn.chromium.org/blink/trunk@54044 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kevino@webkit.org authored
implements pthread_t in a way that makes it impossible to check its validity, which is needed by ThreadingPthreads.cpp. git-svn-id: svn://svn.chromium.org/blink/trunk@54043 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Dimitri Glazkov. [V8] Generate header declaration for custom constructor callbacks https://bugs.webkit.org/show_bug.cgi?id=33680 Added handling of 'CanBeConstructed' and 'OmitConstructor' and a new extended attribute CustomConstructor'. Deleted implementation .cpp files for corresponding 'CanBeConstructed' extended attributes. These are now generated via CodeGeneratorV8.pm Treating 'OmitConstructor' and 'CustomConstructor' to be the same in CodeGeneratorJS.pm Cleaned idls that had 'CustomConstructor' and 'OmitConstructor' together, and same with CustomConstructor and CanBeConstructed. * Android.v8bindings.mk: * WebCore.gypi: Removed deps for classes being generated. * bindings/scripts/CodeGeneratorJS.pm: OmitConstructor and CustomConstructor have the same behavior in generator. * bindings/scripts/CodeGeneratorV8.pm: Generating the callbacks for constructors. * bindings/v8/V8DOMWrapper.cpp: Removed manual calls to SetCallHandler() for constructor callbacks. (WebCore::V8DOMWrapper::getTemplate): * bindings/v8/custom/V8CustomBinding.h: Removed manual declarations of constructor callbacks. * bindings/v8/custom/V8DOMParserConstructor.cpp: * bindings/v8/custom/V8EventSourceConstructor.cpp: (WebCore::V8EventSource::constructorCallback): * bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback): * bindings/v8/custom/V8SharedWorkerCustom.cpp: (WebCore::V8SharedWorker::constructorCallback): * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: (WebCore::V8WebGLArrayBuffer::constructorCallback): * bindings/v8/custom/V8WebGLByteArrayCustom.cpp: (WebCore::V8WebGLByteArray::constructorCallback): * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: (WebCore::V8WebGLFloatArray::constructorCallback): * bindings/v8/custom/V8WebGLIntArrayCustom.cpp: (WebCore::V8WebGLIntArray::constructorCallback): * bindings/v8/custom/V8WebGLShortArrayCustom.cpp: (WebCore::V8WebGLShortArray::constructorCallback): * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: (WebCore::V8WebGLUnsignedByteArray::constructorCallback): * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: (WebCore::V8WebGLUnsignedIntArray::constructorCallback): * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: (WebCore::V8WebGLUnsignedShortArray::constructorCallback): * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::V8WebKitCSSMatrix::constructorCallback): * bindings/v8/custom/V8WebKitPointConstructor.cpp: (WebCore::V8WebKitPoint::constructorCallback): * bindings/v8/custom/V8WebSocketCustom.cpp: (WebCore::V8WebSocket::constructorCallback): * bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::constructorCallback): * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::V8XMLHttpRequest::constructorCallback): * bindings/v8/custom/V8XMLSerializerConstructor.cpp: * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Deleted the file. Implementation now being generated. * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Deleted the file. Implementation now being generated. (WebCore::V8XSLTProcessor::constructorCallback): Deleted the file. Implementation now being generated. * css/WebKitCSSMatrix.idl: Added CustomConstructor attribute. * dom/MessageChannel.idl: Added CustomConstructor attribute. * html/canvas/WebGLArrayBuffer.idl: Added CustomConstructor attribute. * html/canvas/WebGLByteArray.idl: Added CustomConstructor attribute. * html/canvas/WebGLFloatArray.idl: Added CustomConstructor attribute. * html/canvas/WebGLIntArray.idl: Added CustomConstructor attribute. * html/canvas/WebGLShortArray.idl: Added CustomConstructor attribute. * html/canvas/WebGLUnsignedByteArray.idl: Added CustomConstructor attribute. * html/canvas/WebGLUnsignedIntArray.idl: Added CustomConstructor attribute. git-svn-id: svn://svn.chromium.org/blink/trunk@54042 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by David Levin. Add stub for AXObjectCache::contentChanged when HAVE(ACCESSIBILITY) is not defined https://bugs.webkit.org/show_bug.cgi?id=34271 No new tests, build fix only. * accessibility/AXObjectCache.cpp: Modified. Added HAVE(ACCESSIBILITY) guards around contentChanged * accessibility/AXObjectCache.h: Modified. (WebCore::AXObjectCache::contentChanged): Added stub git-svn-id: svn://svn.chromium.org/blink/trunk@54041 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Reviewed by Gavin Barraclough. DOM Objects shouldn't all require custom mark functions https://bugs.webkit.org/show_bug.cgi?id=34291 Make getAnonymousValue const-friendly * runtime/JSObject.h: (JSC::JSObject::getAnonymousValue): 2010-01-28 Steve Block <steveblock@google.com> Reviewed by David Levin. Use long long rather than int64 in V8Binding.h https://bugs.webkit.org/show_bug.cgi?id=34270 No new tests, build fix only. * bindings/v8/V8Binding.h: Modified. (WebCore::toInt64): Returns long long git-svn-id: svn://svn.chromium.org/blink/trunk@54040 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abecsi@webkit.org authored
* Scripts/webkitpy/committers.py: git-svn-id: svn://svn.chromium.org/blink/trunk@54039 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by David Levin. Use long long rather than int64 in V8Binding.h https://bugs.webkit.org/show_bug.cgi?id=34270 No new tests, build fix only. * bindings/v8/V8Binding.h: Modified. (WebCore::toInt64): Returns long long git-svn-id: svn://svn.chromium.org/blink/trunk@54038 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by David Levin. Unused variable in ThemeMac (followup to change 49103). https://bugs.webkit.org/show_bug.cgi?id=34274 Covered by existing tests. * platform/mac/ThemeMac.mm: (WebCore::setupButtonCell): git-svn-id: svn://svn.chromium.org/blink/trunk@54037 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enrica@apple.com authored
<rdar://problem/5195056> https://bugs.webkit.org/show_bug.cgi?id=34237 Reviewed by Maciej Stachowiak. WebCore: No new tests. It is a performance improvement. The performance of the plain text paste is now linear. We treat as a special case, a fragment that has been created from plain text. Finding VisiblePositions and applying style is greatly simplified, given the nature of the fragment. * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): * editing/markup.cpp: (WebCore::isPlainTextMarkup): * editing/markup.h: WebKit/mac: Mail is ignoring the fragment created from plain text or HTML that is passed to the delegate function, that creates a new one. This fix avoids creating the fragment twice. * WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): git-svn-id: svn://svn.chromium.org/blink/trunk@54036 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jorlow@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=34294 Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-28 Reviewed by Adam Barth. * storage/StorageMap.cpp: (WebCore::StorageMap::copy): git-svn-id: svn://svn.chromium.org/blink/trunk@54035 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Support kinetic scrolling on Maemo 5 https://bugs.webkit.org/show_bug.cgi?id=34267 Patch by Ralf Engels <ralf.engels@nokia.com> and Robert Griebl <rgriebl@trolltech.com> * Api/qwebview.cpp: (QWebViewKineticScroller::QWebViewKineticScroller): (QWebViewKineticScroller::eventFilter): (QWebViewKineticScroller::currentFrame): (QWebViewKineticScroller::scrollingFrameAt): (QWebViewKineticScroller::attachToWidget): (QWebViewKineticScroller::removeFromWidget): (QWebViewKineticScroller::positionRange): (QWebViewKineticScroller::position): (QWebViewKineticScroller::viewportSize): (QWebViewKineticScroller::setPosition): (QWebView::QWebView): git-svn-id: svn://svn.chromium.org/blink/trunk@54034 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by David Levin. Remove NULL char from input JS file because 'grep' fails if the file contains NULL char. https://bugs.webkit.org/show_bug.cgi?id=34252 * Scripts/make-script-test-wrappers: git-svn-id: svn://svn.chromium.org/blink/trunk@54033 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
bfulgham@webkit.org authored
* platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameCount): git-svn-id: svn://svn.chromium.org/blink/trunk@54032 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Laszlo Gombos. Fix for compilation error in WML enabled build introduced because of the changeset 53514. https://bugs.webkit.org/show_bug.cgi?id=34254 * wml/WMLDocument.cpp: (WebCore::WMLDocument::WMLDocument): git-svn-id: svn://svn.chromium.org/blink/trunk@54030 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Eric Seidel. Updates from CSS change for mathml.css * platform/mac/mathml/presentation/sub-expected.txt: * platform/mac/mathml/presentation/sup-expected.txt: * platform/mac/mathml/presentation/tables-expected.checksum: * platform/mac/mathml/presentation/tables-expected.png: * platform/mac/mathml/presentation/tables-expected.txt: 2010-01-28 Alex Milowski <alex@milowski.com> Reviewed by Eric Seidel. Update to CSS to remove unnecessary line-height settings * css/mathml.css: git-svn-id: svn://svn.chromium.org/blink/trunk@54029 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
steveblock@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=34276 Reviewed by David Levin. No new tests, build fix only. * platform/KURL.cpp: Modified. Include HashMap.h * platform/network/CredentialStorage.cpp: Modified. Include HashMap.h and HashSet.h * platform/network/ProtectionSpaceHash.h: Modified. Include HashTraits.h git-svn-id: svn://svn.chromium.org/blink/trunk@54028 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kov@webkit.org authored
git-svn-id: svn://svn.chromium.org/blink/trunk@54027 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 28 Jan, 2010 21 commits
-
-
kov@webkit.org authored
Reviewed by Gustavo Noronha. Pass cookies to the GStreamer HTTP source https://bugs.webkit.org/show_bug.cgi?id=34003 Test: http/tests/media/video-cookie.html * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): When using an appropiate GStreamer HTTP source element, pass the cookies for the media URI to it. This fixes playback of the YouTube HTML5 videos. git-svn-id: svn://svn.chromium.org/blink/trunk@54026 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ossy@webkit.org authored
* bridge/qt/qt_instance.cpp: (JSC::Bindings::QtRuntimeObjectImp::createStructure): * bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapRuntimeObjectImp::createStructure): * bridge/qt/qt_runtime.h: (JSC::Bindings::QtRuntimeMethod::createStructure): git-svn-id: svn://svn.chromium.org/blink/trunk@54025 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=34286 * platform/qt/Skipped: css2.1/t1505-c524-font-var-00-b.html skipped git-svn-id: svn://svn.chromium.org/blink/trunk@54024 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
Passing a JSValue to toRef on 32-bit builds can perform an allocation, so we need to make sure we hold a JSLock when that occurs. Reviewed by Oliver Hunt. * bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedScriptValueData::serialize): (WebCore::SerializedScriptValueData::deserialize): Moved JSLocks from here... (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::deserialize): ...to this higher level, from which toRef can be called. git-svn-id: svn://svn.chromium.org/blink/trunk@54023 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Reviewed by Gavin Barraclough. Simplify anonymous slot implementation https://bugs.webkit.org/show_bug.cgi?id=34282 A class must now specify the number of slots it needs at construction time rather than later on with a transition. This makes many things simpler, we no longer need to need an additional transition on object creation to add the anonymous slots, and we remove the need for a number of transition type checks. * API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure): * API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure): * API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure): * JavaScriptCore.exp: * debugger/DebuggerActivation.h: (JSC::DebuggerActivation::createStructure): * runtime/Arguments.h: (JSC::Arguments::createStructure): * runtime/BooleanObject.h: (JSC::BooleanObject::createStructure): * runtime/DateInstance.h: (JSC::DateInstance::createStructure): * runtime/DatePrototype.h: (JSC::DatePrototype::createStructure): * runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure): * runtime/GetterSetter.h: (JSC::GetterSetter::createStructure): * runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::createStructure): * runtime/InternalFunction.h: (JSC::InternalFunction::createStructure): * runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure): * runtime/JSActivation.h: (JSC::JSActivation::createStructure): * runtime/JSArray.h: (JSC::JSArray::createStructure): * runtime/JSByteArray.cpp: (JSC::JSByteArray::createStructure): * runtime/JSCell.h: (JSC::JSCell::createDummyStructure): * runtime/JSFunction.h: (JSC::JSFunction::createStructure): * runtime/JSGlobalObject.h: (JSC::JSGlobalObject::createStructure): * runtime/JSNotAnObject.h: (JSC::JSNotAnObject::createStructure): * runtime/JSONObject.h: (JSC::JSONObject::createStructure): * runtime/JSObject.h: (JSC::JSObject::createStructure): (JSC::JSObject::putAnonymousValue): (JSC::JSObject::getAnonymousValue): * runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure): * runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::createStructure): * runtime/JSString.h: (JSC::Fiber::createStructure): * runtime/JSVariableObject.h: (JSC::JSVariableObject::createStructure): * runtime/JSWrapperObject.h: (JSC::JSWrapperObject::createStructure): (JSC::JSWrapperObject::JSWrapperObject): * runtime/MathObject.h: (JSC::MathObject::createStructure): * runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure): * runtime/NumberObject.h: (JSC::NumberObject::createStructure): * runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure): * runtime/RegExpObject.h: (JSC::RegExpObject::createStructure): * runtime/StringObject.h: (JSC::StringObject::createStructure): * runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::createStructure): * runtime/Structure.cpp: (JSC::Structure::~Structure): (JSC::Structure::materializePropertyMap): * runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::anonymousSlotCount): * runtime/StructureTransitionTable.h: 2010-01-28 Oliver Hunt <oliver@apple.com> Reviewed by Gavin Barraclough. Simplify anonymous slot implementation https://bugs.webkit.org/show_bug.cgi?id=34282 Update JSGlue Structure usage to pass the anonymous slot count. * UserObjectImp.h: (UserObjectImp::createStructure): 2010-01-28 Oliver Hunt <oliver@apple.com> Reviewed by Gavin Barraclough. Simplify anonymous slot implementation https://bugs.webkit.org/show_bug.cgi?id=34282 Update the WebCore JS DOM bindings to correctly pass and propagate the anonymous slot count information. * bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::createStructure): (WebCore::DOMConstructorObject::createStructure): * bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure): * bindings/scripts/CodeGeneratorJS.pm: * bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure): * bridge/runtime_array.h: (JSC::RuntimeArray::createStructure): * bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure): * bridge/runtime_object.h: (JSC::RuntimeObjectImp::createStructure): git-svn-id: svn://svn.chromium.org/blink/trunk@54022 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kevino@webkit.org authored
git-svn-id: svn://svn.chromium.org/blink/trunk@54021 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
evan@chromium.org authored
Reviewed by David Levin. [chromium] hebrew vowel marks incorrectly positioned https://bugs.webkit.org/show_bug.cgi?id=34234 Add a layout test containing some Hebrew vowels. * fast/text/international/hebrew-vowels.html: Added. 2010-01-27 Evan Martin <evan@chromium.org> Reviewed by David Levin. [chromium] hebrew vowel marks incorrectly positioned https://bugs.webkit.org/show_bug.cgi?id=34234 Fix glyph metrics computation such that the glyph offsets are correct, so we can now make use of them. Test: fast/text/international/hebrew-vowels.html * platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::createGlyphArrays): initialize per-glyph offset table. (WebCore::TextRunWalker::setGlyphXPositions): use per-glyph offsets. * platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getGlyphMetrics): fix metrics computation such that per-glyph offsets are computed correctly. git-svn-id: svn://svn.chromium.org/blink/trunk@54020 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
laszlo.1.gombos@nokia.com authored
Unreviewed build fix. [Qt] Build fix if websockets support is turned off after r53947. * WebCore.pro: git-svn-id: svn://svn.chromium.org/blink/trunk@54019 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dglazkov@chromium.org authored
No review, rolling out r54012. http://trac.webkit.org/changeset/54012 https://bugs.webkit.org/show_bug.cgi?id=34266 Introduced 33 crashes in V8 traversal/ tests. * bindings/js/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState): * bindings/js/ScriptController.h: * bindings/js/ScriptState.cpp: * bindings/js/ScriptState.h: * bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack): * bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState): (WebCore::ScriptController::currentScriptState): (WebCore::ScriptController::clearWindowShell): * bindings/v8/ScriptController.h: * bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success): * bindings/v8/ScriptScope.h: * bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::scriptStateFromPage): * bindings/v8/ScriptState.h: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::frame): * bindings/v8/V8HiddenPropertyName.h: * bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::scriptState): * bindings/v8/V8IsolatedContext.h: * bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException): * bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback): * bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback): * inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId): git-svn-id: svn://svn.chromium.org/blink/trunk@54016 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aa@chromium.org authored
to send the full URL of the requesting context, as well as a pointer to the document if that context was a document. git-svn-id: svn://svn.chromium.org/blink/trunk@54015 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Adam Barth. Fix missing forward-declarations and includes in V8 bindings https://bugs.webkit.org/show_bug.cgi?id=34272 No new tests, build fix only. * bindings/v8/ScriptController.h: Modified. Forward-declare NPObject * bindings/v8/V8DOMWindowShell.cpp: Modified. Include CString.h and PlatformBridge.h * bindings/v8/V8DOMWrapper.h: Modified. Forward-declare V8Proxy git-svn-id: svn://svn.chromium.org/blink/trunk@54014 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dglazkov@chromium.org authored
Unreviewed, trivial baseline update. Update baseline for "Animated scaling of background-image is too slow" https://bugs.webkit.org/show_bug.cgi?id=33808 * platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum: * platform/mac/fast/backgrounds/size/backgroundSize16-expected.png: git-svn-id: svn://svn.chromium.org/blink/trunk@54013 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
Reviewed by Adam Barth. Remove ScriptState::frame which is only used for reporting exceptions in some cases in a way that diverges from the regular exception reporting in v8 bindings. Cache ScriptState directly on v8::Context instead of providing implementations specific for isolated worlds and ScriptController. https://bugs.webkit.org/show_bug.cgi?id=34266 * bindings/js/ScriptController.cpp: * bindings/js/ScriptController.h: * bindings/js/ScriptState.cpp: (WebCore::mainWorldScriptState): * bindings/js/ScriptState.h: * bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack): * bindings/v8/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): * bindings/v8/ScriptController.h: * bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success): * bindings/v8/ScriptScope.h: * bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::forContext): (WebCore::ScriptState::current): (WebCore::ScriptState::empty): (WebCore::ScriptState::weakReferenceCallback): (WebCore::mainWorldScriptState): (WebCore::scriptStateFromPage): * bindings/v8/ScriptState.h: * bindings/v8/V8HiddenPropertyName.h: * bindings/v8/V8IsolatedContext.cpp: * bindings/v8/V8IsolatedContext.h: * bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException): * bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback): * bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback): * inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId): git-svn-id: svn://svn.chromium.org/blink/trunk@54012 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aa@chromium.org authored
git-svn-id: svn://svn.chromium.org/blink/trunk@54011 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@webkit.org authored
Reviewed by David Levin. Remove XSSAuditor false positive for Google Translate https://bugs.webkit.org/show_bug.cgi?id=34242 Add a test that we allow attackers to inject directly into the href property of the base tag. * http/tests/security/xssAuditor/base-href-direct-expected.txt: Added. * http/tests/security/xssAuditor/base-href-direct.html: Added. * http/tests/security/xssAuditor/resources/echo-head-base-href-direct.pl: Added. 2010-01-28 Adam Barth <abarth@webkit.org> Reviewed by David Levin. Remove XSSAuditor false positive for Google Translate https://bugs.webkit.org/show_bug.cgi?id=34242 Google translate takes a base URL as a parameter, causing a false positive in the XSS filter. This patch removes the false positive by allowing direct injections into the href property of the base tag. Test: http/tests/security/xssAuditor/base-href-direct.html * page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL): git-svn-id: svn://svn.chromium.org/blink/trunk@54010 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
zimmermann@webkit.org authored
Reviewed by Dirk Schulze. Save additional memory in SVG*Element classes, by introducing SVGElementRareData https://bugs.webkit.org/show_bug.cgi?id=34268 Introduce SVGElementRareData, to remove the need to store any members in SVGElement/SVGStyledElement. This saves some additional MB for the svg-node-count-vs-scroll.xhtml testcase. SVGElementRareData works just like NodeRareData. Unlike ElementRareData, we're not inheriting from NodeRareData in SVG, as we don't need all the rare data stored there, unlike Element. * GNUmakefile.am: Add SVGElementRareData.h to build. * WebCore.gypi: Ditto. * WebCore.pro: Ditto. * WebCore.vcproj/WebCore.vcproj: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * dom/Node.cpp: Use Nodes bitfield to keep track wheter a SVGElement has a SVGElementRareData object associated. (WebCore::Node::Node): * dom/Node.h: Add m_hasRareSVGData flag, merged with the existing bitfield, 10 bits remaining now. (WebCore::Node::hasRareSVGData): * svg/SVGAnimateMotionElement.cpp: SVGElement::instancesForElement() now returns a const-reference to the HashMap instead of copying. (WebCore::SVGAnimateMotionElement::applyResultsToTarget): * svg/SVGAnimateTransformElement.cpp: Ditto. (WebCore::SVGAnimateTransformElement::applyResultsToTarget): * svg/SVGAnimationElement.cpp: Ditto. (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): * svg/SVGElement.cpp: Move the element instances HashSet and two cursor-related pointers into SVGElementRareData. (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::~SVGElement): (WebCore::SVGElement::rareSVGData): Modelled just like Node::rareData(). (WebCore::SVGElement::ensureRareSVGData): Dito. (WebCore::SVGElement::accessDocumentSVGExtensions): (WebCore::SVGElement::mapInstanceToElement): Route call through SVGElementRareData. (WebCore::SVGElement::removeInstanceMapping): Ditto. (WebCore::SVGElement::instancesForElement): Ditto. (WebCore::SVGElement::setCursorElement): Ditto. (WebCore::SVGElement::setCursorImageValue): Ditto. * svg/SVGElement.h: * svg/SVGElementInstance.cpp: Ditto. (WebCore::SVGElementInstance::invalidateAllInstancesOfElement): * svg/SVGElementRareData.h: Added. Based on NodeRareData - works exactly the same. (WebCore::SVGElementRareData::SVGElementRareData): (WebCore::SVGElementRareData::rareDataMap): (WebCore::SVGElementRareData::rareDataFromMap): (WebCore::SVGElementRareData::elementInstances): (WebCore::SVGElementRareData::instanceUpdatesBlocked): (WebCore::SVGElementRareData::setInstanceUpdatesBlocked): (WebCore::SVGElementRareData::cursorElement): (WebCore::SVGElementRareData::setCursorElement): (WebCore::SVGElementRareData::cursorImageValue): (WebCore::SVGElementRareData::setCursorImageValue): * svg/SVGStyledElement.cpp: Move m_instancesUpdatesBlocked into SVGElementRareData. (WebCore::SVGStyledElement::SVGStyledElement): (WebCore::SVGStyledElement::instanceUpdatesBlocked): (WebCore::SVGStyledElement::setInstanceUpdatesBlocked): * svg/SVGStyledElement.h: * svg/SVGUseElement.cpp: Adapt to element instances changes, now passed as const-reference. (WebCore::dumpInstanceTree): git-svn-id: svn://svn.chromium.org/blink/trunk@54009 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aa@chromium.org authored
Reviewed by Darin Adler. Expand the NotificationPresenter::checkPermission() interface to send the full URL of the requesting context, as well as a pointer to the document if that context was a document. https://bugs.webkit.org/show_bug.cgi?id=34238 * notifications/Notification.cpp: (WebCore::Notification::Notification): * notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::NotificationCenter): (WebCore::NotificationCenter::checkPermission): Pass the full URL and document from the requesting context when calling NotificationPresenter::checkPermission(). * notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::): Expand interface. 2010-01-27 Aaron Boodman <aa@chromium.org> Reviewed by Darin Adler. Send full URL and application id of requesting context to Chromium when checking notification permissions. https://bugs.webkit.org/show_bug.cgi?id=34238 * public/WebDocument.h: * src/WebDocument.cpp: (WebKit::WebDocument::applicationID): Implement applicationID() method. * public/WebNotificationPresenter.h: * src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission): * src/NotificationPresenterImpl.h: Send applicationID and full URL through to Chromium. 2010-01-27 Aaron Boodman <aa@chromium.org> Expand NotificationCenter::checkPermission() interface. It now passes the full URL instead of just the origin. https://bugs.webkit.org/show_bug.cgi?id=34238 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission): * WebCoreSupport/WebDesktopNotificationsDelegate.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54008 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jam@chromium.org authored
git-svn-id: svn://svn.chromium.org/blink/trunk@54007 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
simon.fraser@apple.com authored
Reviewed by Dan Bernstein. Video can overlap position:fixed element when scrolling https://bugs.webkit.org/show_bug.cgi?id=32180 When the scroll position changes, and we're using overlap to decide what gets composited, then we need to re-evaluate what gets compositing when scrolling in case fixed postion elements overlap composited elements (e.g. video). Test: compositing/geometry/video-fixed-scrolling.html * page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers): (WebCore::FrameView::scrollPositionChanged): Annotate the calls to updateCompositingLayers() with the type of change that occurred. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded): Ditto. * rendering/RenderLayerCompositor.h: * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): For scroll changes, check for hierarchy update if m_compositingConsultsOverlap is true, and do a geometry update. For other changes, always check for hierarchy updates. git-svn-id: svn://svn.chromium.org/blink/trunk@54006 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hyatt@apple.com authored
Fix for user stylesheet bugs where they get parsed using the wrong compatibility mode. This was a regression caused from Safari 3 -> 4 by the Acid3 fixes to create a real DOCTYPE in the DOM. Reviewed by Darin Adler. This patch makes style selector creation lazy, so that the selector isn't built unless someone asks for it. In order to avoid creating the style selector before the compatibility mode has been determined, document style is now created without having a dependence on an instantiated style selector. The creation of the style is now done as a static method on CSSStyleSelector called styleForDocument, and a couple of font-related functions have been made static as well so that they can be used by this method. m_styleSelector on Document is now an OwnPtr. Added userscripts/mixed-case-stylesheet.html * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForDocument): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForGenericFamilyChange): (WebCore::CSSStyleSelector::setFontSize): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): (WebCore::CSSStyleSelector::fontSizeForKeyword): * css/CSSStyleSelector.h: * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::recalcStyle): (WebCore::Document::createStyleSelector): (WebCore::Document::attach): (WebCore::Document::setVisuallyOrdered): (WebCore::Document::recalcStyleSelector): * dom/Document.h: (WebCore::Document::styleSelector): (WebCore::Document::visuallyOrdered): * html/HTMLDocument.cpp: (WebCore::HTMLDocument::determineParseMode): * loader/PlaceholderDocument.cpp: (WebCore::PlaceholderDocument::attach): git-svn-id: svn://svn.chromium.org/blink/trunk@54005 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Alexey Proskuryakov. Add layout tests to verify assignment to items of NodeList https://bugs.webkit.org/show_bug.cgi?id=34213 * fast/dom/NodeList/nodelist-item-assignment-expected.txt: Added. * fast/dom/NodeList/nodelist-item-assignment.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@54004 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-