GitLab

BUG=None

Review URL: https://codereview.chromium.org/1112493002

Cr-Commit-Position: refs/heads/master@{#329392}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/07bc404..ce7d951

TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1134903004

Cr-Commit-Position: refs/heads/master@{#329391}

This should have been part of https://codereview.chromium.org/1136493003.

BUG=419383

Review URL: https://codereview.chromium.org/1139913002

Cr-Commit-Position: refs/heads/master@{#329390}

This patch was autogenerated with https://codereview.chromium.org/1010073002/.

BUG=465354

Review URL: https://codereview.chromium.org/1127153003

Cr-Commit-Position: refs/heads/master@{#329389}

Replaces the DCHECK for validity of the upload url with an explicit runtime
check. If the check fails the client sends a FAILURE_INVALID_URL error to
DMServer and logs a message to the ui log.

BUG=480982

Review URL: https://codereview.chromium.org/1138063006

Cr-Commit-Position: refs/heads/master@{#329388}

[Smart Lock] Smart Lock branding in save password infobar should available only for signed in users and guarded by Finch.

Restrict new title for the smart lock infobar only to the signed in users, who belongs to experiment.

BUG=454815

Review URL: https://codereview.chromium.org/1134863002

Cr-Commit-Position: refs/heads/master@{#329387}

MessageLoopProxy is deprecated.
This basically does a search and replace:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

BUG=391045

Review URL: https://codereview.chromium.org/1130753002

Cr-Commit-Position: refs/heads/master@{#329386}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a442694..07bc404

TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1123373006

Cr-Commit-Position: refs/heads/master@{#329385}

WebRTC 9146:9174
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/6e78b8f..8052935

Libjingle 9147:9171
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/63f5a59..16f9a02

TBR=
BUG=

Review URL: https://codereview.chromium.org/1135213002

Cr-Commit-Position: refs/heads/master@{#329384}

Since each QuerySyncManager has its own cache, even a moderate
cache size expands to several hundred KB of memory usage. This makes
it slightly smaller to save some of that memory. It is believed
to be unlikely that the cache has to be big anyway.

In ad-hoc testing I've only seen 20 queries in total (unclear how
many of them were in parallel).

(This is alt #1 in bug 485536)

BUG=485536
R=reveman@chromium.org

Review URL: https://codereview.chromium.org/1138463003

Cr-Commit-Position: refs/heads/master@{#329383}

The only thing visible in the content area should be the "Turn on location in Android Settings" link.

BUG=486008

Review URL: https://codereview.chromium.org/1135773002

Cr-Commit-Position: refs/heads/master@{#329382}

BUG=440649

Review URL: https://codereview.chromium.org/1139723002

Cr-Commit-Position: refs/heads/master@{#329381}

BUG=485955
NOTRY=true

Review URL: https://codereview.chromium.org/1135213003

Cr-Commit-Position: refs/heads/master@{#329380}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2e4c5505..eaa355a9

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1139893002

Cr-Commit-Position: refs/heads/master@{#329379}

BUG=484997

Review URL: https://codereview.chromium.org/1129323005

Cr-Commit-Position: refs/heads/master@{#329378}

This CL is took over from issue 1112573005 at patchset 30001 (http://crrev.com/1112573005#ps30001)

BUG=476688
TEST=*ImportController*

Review URL: https://codereview.chromium.org/1126043005

Cr-Commit-Position: refs/heads/master@{#329377}

Revert of Disabled WebRtcBrowserTest.CanSetupCallAndSendDtmf (patchset #1 id:1 of https://codereview.chromium.org/1133063002/)

Reason for revert:
The test should now work with the more aggressive v8 gc() after a gc fix in the test (https://codereview.chromium.org/1138073003/)

Original issue's description:
> Disabled WebRtcBrowserTest.CanSetupCallAndSendDtmf
>
> TBR=tommi
> BUG=486654
>
> Committed: https://crrev.com/fc57f2cec564c344e3e17023b41c008f574b65a7
> Cr-Commit-Position: refs/heads/master@{#329147}

TBR=henrika@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=486654

Review URL: https://codereview.chromium.org/1141533002

Cr-Commit-Position: refs/heads/master@{#329376}

This changes RecorderPageTest class to pass CustomizeBrowserOptions to
a page test object if there is one.

BUG=486776

Review URL: https://codereview.chromium.org/1138763004

Cr-Commit-Position: refs/heads/master@{#329375}

This CL makes the FSP section a prerequisite for the permission. It also adds
a warning if a section is used without a permission.

TEST=unit_tests: *FileSystemProviderHandlerTest*"
BUG=474146

Review URL: https://codereview.chromium.org/1133013002

Cr-Commit-Position: refs/heads/master@{#329374}

BUG=486654

Review URL: https://codereview.chromium.org/1138073003

Cr-Commit-Position: refs/heads/master@{#329373}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1fe317c..a442694

TBR=yosin@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1139503003

Cr-Commit-Position: refs/heads/master@{#329372}

In chrome.launcherSearchProvider API, support iconUrl field in search result.
Currently only chrome-extension:// url is supported.

BUG=440649,486236
TEST=out/Release/unit_tests --gtest_filter=ExtensionBadgedIconImageTest.*

Review URL: https://codereview.chromium.org/1060733003

Cr-Commit-Position: refs/heads/master@{#329371}

TypedUrlChangeProcessor is a HistoryService observer and gets notified
about changes to all addresses, not just typed ones. This means that
when HistoryService::SetPageTitle() is called for a non-typed URL,
TypedUrlChangeProcessor::OnURLsModified() will be triggered and,
consequently, TypedUrlChangeProcessor::CreateOrUpdateSyncNode().
As the name suggests, if the modified node was not previously present
(because it was filtered out by ShouldSyncVisit() in OnURLVisited()),
it would be created.
End effect was that *all* URLs that had their title updated (which means
every page that has a <title> tag) were synced, even if they were not typed.

The solution is to return early in CreateOrUpdateSyncNode() if we detect
that the URL in question has no typed visits.

(Caused by https://codereview.chromium.org/1087773002/)

BUG=

Review URL: https://codereview.chromium.org/1126633005

Cr-Commit-Position: refs/heads/master@{#329370}

This CL in order to add the icon implements a cr.ui.ProvidersMenuItem class
since cr.ui.MenuItem doesn't handle icons with hidpi properly, nor it supports
well custom icons (setting a label overwrites any inserted DOM elements to the
menu item).

TEST=Tested manually.
BUG=474146

Review URL: https://codereview.chromium.org/1132843004

Cr-Commit-Position: refs/heads/master@{#329369}

This CL adds a UMA stat that tracks how far an opened app list search
result is from the top left of the search results view. This will provide
information on the quality of search result ranking.

BUG=485449

Review URL: https://codereview.chromium.org/1132943004

Cr-Commit-Position: refs/heads/master@{#329368}

Support more kinds of `pname` for these two interfaces.

BUG=429053

Review URL: https://codereview.chromium.org/1133033002

Cr-Commit-Position: refs/heads/master@{#329367}

Move setting of NSWindowHostsLayersInWindowServer to
ContentMainRunnerImpl::Initialize. Use the CoreFoundation API so
that it can be called from C code.

BUG=450173

Review URL: https://codereview.chromium.org/903943002

Cr-Commit-Position: refs/heads/master@{#329366}

BUG=479898

Review URL: https://codereview.chromium.org/1128083003

Cr-Commit-Position: refs/heads/master@{#329365}

The |mock_server_response_| field was being set in parallel with
actually running the query, so there was a race condition if the network
request came in before the response field is set.

Now sets the |mock_server_response_| before starting the query.

BUG=246136

Review URL: https://codereview.chromium.org/1137113002

Cr-Commit-Position: refs/heads/master@{#329364}

Ensures that all converted timestamps will be monotonically increasing
within a single call to GetWallClockTime.

Performance seems unchanged (unit tests take the same amount of time).

As part of this change, also does the following:
- VideoRendererImpl unit test switched to WallClockTimeSource to avoid
having to reimplement the vector conversion routine.

BUG=485042
TEST=new unittest.

Review URL: https://codereview.chromium.org/1136513004

Cr-Commit-Position: refs/heads/master@{#329363}

There's an expected ~443kB sizes regression in ChromiumFramework with
this. This is because large portions of views.dylib are still culled at
link time with -dead_strip, but this CL makes more symbols reachable.
For a full accounting see http://crbug.com/485854#c1 (nothing
unexpected).

The dialog is enabled by linking in app_info_dialog_views.cc to provide
functions previously provided (but NOTIMPLEMENTED()) by
app_info_dialog_cocoa.mm.

Note that the views CanShowAppInfoDialog() is implemented as
IsMacViewsAppListListEnabled(), so no user-visible changes occur unless
Chrome is run from the command line with --enable-mac-views-app-list.

With this flag, the `Details` link at chrome://extensions will show the
views-based (and offline-enabled) AppInfo dialog rather than taking the
user to the webstore URL. And the context menu for icons at
chrome://apps will have an `App Info` option.

(Note that the views-based App Launcher isn't currently linked in on
Mac, so the app launcher shown with --enable-mac-views-app-list
--show-app-list doesn't support this dialog yet).

Screenshot at http://crbug.com/485854#c2

BUG=485854

Review URL: https://codereview.chromium.org/1048343002

Cr-Commit-Position: refs/heads/master@{#329362}

In addition fixed an issue where <- button was shown when it should not.

BUG=472671
TEST=manually,tested FrE and recovery modes, button works as expected.

Review URL: https://codereview.chromium.org/1132043002

Cr-Commit-Position: refs/heads/master@{#329361}

Previously, MultiThreadedProxyResolverTest.ThreeThreads_Basic started
multiple requests in parallel and expected resolvers on three threads
to be created and used. However, the new resolver thread can take long
enough to become ready that it doesn't finish initializing its resolver
before all requests complete on other threads and the test finishes.
This CL fixes this by blocking the resolvers to force requests to run on
new resolver threads.

BUG=486257

Review URL: https://codereview.chromium.org/1132943003

Cr-Commit-Position: refs/heads/master@{#329360}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bedb2c7..1fe317c

TBR=yosin@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1133733006

Cr-Commit-Position: refs/heads/master@{#329359}

https://codereview.chromium.org/1126133003 changes the behavior of
Blink CSS file support; we need to send the proper MIME type, even in
quirks mode. This CL fixes the tests which broke when that patch
initially landed way back when.

BUG=419383
TBR=bbudge@chromium.org

Review URL: https://codereview.chromium.org/1136493003

Cr-Commit-Position: refs/heads/master@{#329358}

BUG=

Review URL: https://codereview.chromium.org/1129293003

Cr-Commit-Position: refs/heads/master@{#329357}

We now highlight (in bold) the part of the query that you typed, just as
we do with other types of queries.

Moved AppResult::UpdateFromMatch into SearchResult so it can be used by
any provider.

BUG=481837

Review URL: https://codereview.chromium.org/1110883003

Cr-Commit-Position: refs/heads/master@{#329356}

As mentioned in Issue 480666, touch effect should be square.
However, the newly-added sort button have the circle effect, so this CL fixes it.

BUG=none
TEST=manually

Review URL: https://codereview.chromium.org/1124403004

Cr-Commit-Position: refs/heads/master@{#329355}

This fixes the component=shared_library build on Chrome OS.

BUG=none
TEST=cros chrome-sdk --board=link
  GYP_DEFINES="$GYP_DEFINES component=shared_library" gclient runhooks
  ninja -C out_link/Release chrome chrome_sandbox

Review URL: https://codereview.chromium.org/1136123004

Cr-Commit-Position: refs/heads/master@{#329354}

It wasn't quite wide enough.

TBR=jyasskin@chromium.org
BUG=480750

Review URL: https://codereview.chromium.org/1135563006

Cr-Commit-Position: refs/heads/master@{#329353}