- 21 Sep, 2017 40 commits
-
-
Valery Arkhangorodsky authored
Makes ZoomBubbleView follow the layout from the mock in the bug. Fixes the vector icons (+ / -) to have sharp edges rather than using a rounded stroke. Bug: 651641 Test: Visual (compare to mock) Change-Id: I23bd9633037cf529e69f5b72ae9810ca5124da96 Reviewed-on: https://chromium-review.googlesource.com/673486Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Valery Arkhangorodsky <varkha@chromium.org> Cr-Commit-Position: refs/heads/master@{#503578}
-
Jana Iyengar authored
when QUIC connection migration is not enabled. Bug: 544156 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I6440c4833e798b61d2d83dcef2f1bf24869719be Reviewed-on: https://chromium-review.googlesource.com/655767Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Jana Iyengar <jri@chromium.org> Cr-Commit-Position: refs/heads/master@{#503577}
-
Helen Li authored
Idle socket reuse rate is high on Desktop (close to 50%) and on Mobile (~30% on Android). Newer memory instrumentation data do not show socket pool as a hotspot. There have been a few projects to reduce the amount of memory an idle socket retains (e.g. use CRYPTO_BUFFER Issue 671420 and lazy buffer initialization Issue 524258). I do not have any follow-up experiments that would use this histogram, so I am removing it. The histogram was added in crrev.com/2450463002. BUG: 620852 Change-Id: I1a7f858bfcafbcaad708366fa4d2bd5e967e14b0 Reviewed-on: https://chromium-review.googlesource.com/673272Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#503576}
-
Victor Costan authored
Bug: 730379 Change-Id: If3a5091481a9de983caece1cbc955714ba51f481 Reviewed-on: https://chromium-review.googlesource.com/676477Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#503575}
-
khmel authored
Bug: 767374 Test: Manually Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7f8ba3901dfcbd3f9728551cc375bda182a60eba Reviewed-on: https://chromium-review.googlesource.com/677410 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#503574}
-
Khushal authored
Changing the alpha type of an image should generate a new uniqueID. Skia expects images with the same uniqueID to have a constant alpha type. R=bsalomon@chromium.org Bug: 765877 Change-Id: Iba1196458fe523329e85776037767ab1411ba05d Reviewed-on: https://chromium-review.googlesource.com/675323Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#503573}
-
Yash Malik authored
This CL introduces TransientElement whose purpose is to hide its portion of the subtree after a set timeout. All the transient elements now have a TransientElement parent and UiSceneManager changes visibility on the parent instead of the child directly. Bug: 765775 Change-Id: I563a72a8d53507bfa91f5fef317ce6ff8ae4f136 Reviewed-on: https://chromium-review.googlesource.com/669009 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#503572}
-
rnephew authored
Test is failing because the story contains two interaction records. Smoothness benchmarks only support one record. TBR=nednguyen@google.com Change-Id: Idc910eb5c8010e431f33872ed0d4328d66f55167 Reviewed-on: https://chromium-review.googlesource.com/677492Reviewed-by:
rnephew <rnephew@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#503571}
-
Thanh Pham authored
This change: - Use DispatchKeyEventPostIME() mojo in InputMethodChromeOS. - Adds ui.mojom.TextInputClient.DispatchKeyEventPostIME(). This is because InputMethodDelegate::DispatchKeyEventPostIME() isn't really *Post* IME, and calls to it are sometimes intervened with the logic in InputMethodChromeOS to provide KeyDown and KeyUp events in addition to KeyPress events to textfields. This CL calls ui.mojom.TextInputClient.DispatchKeyEventPostIME() in these cases and continues the logic after the dispatch finishes in the client side. Diagram of this CL: https://drive.google.com/open?id=0B0MnJn1TtqqtaUVOZHVCTUtlYmM Bug: 723792 Change-Id: I97efc8dca9d772eabe38f979659d392ae796b903 Reviewed-on: https://chromium-review.googlesource.com/643746 Commit-Queue: Thanh Pham <thanhph@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#503570}
-
danakj authored
R=enne@chromium.org Bug: 722935 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3d6652af46f1d1008e570b0ec1336b69f17d9878 Reviewed-on: https://chromium-review.googlesource.com/677062Reviewed-by:
enne <enne@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#503569}
-
Tao Bai authored
Reland >WebView autofill test > > This patch add basic class for autofill test and a simple test. > more tests will be added. > > But unfortunately, we will not have Android O trybot until 2018, > This test will not be run in any trybot. > > Bug: 717658 This reverts commit e190e6a8. Bug: 717658, 766984 Change-Id: I4e331c37913e6735491f53da92dc206c810f2c96 Reviewed-on: https://chromium-review.googlesource.com/677090Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#503568}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/46fc3fa47dc5..3418f710f923 $ git log 46fc3fa47..3418f710f --date=short --no-merges --format='%ad %ae %s' 2017-09-21 dsinclair Rename CXFA_FFApp::GetWidgetMgr to make it clear the type 2017-09-21 dsinclair Move CFGAS_PDFFontMgr to the CXFA_FFDoc 2017-09-21 dsinclair Rename CXFA_DefFontMgr to CFGAS_DefaultFontManager 2017-09-21 dsinclair Move CFX_MaybeOwned to fxcrt::MaybeOwned 2017-09-21 dsinclair Move CFX_AutoRestorer to fxcrt::AutoRestorer 2017-09-21 dsinclair Move CXFA_PDFFontMgr to CFGAS_PDFFontMgr Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I3f7c5881e563d5c9094c0590137422af7224df99 Reviewed-on: https://chromium-review.googlesource.com/677576 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503567}
-
Karl Anders Øygard authored
This cl implements NG support for the line height quirk. There are some deviations from the behavior of the old layout code: - inline boxes with margins in the inline direction will now cancel the quirk, previously only borders and padding caused this. This is in line with Gecko and Edge. - in the existing layout engine, if there's a line break between two replaced elements separated by whitespace, the whitespace at the end of the line is preserved, in turn causing the line height quirk to be cancelled. The whitespace preservation appears to be in violation of CSS 2.2, 16.6.1, and does not exist in NG. A few test cases had to be altered to accommodate these differences. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3d8d7eaf0f2c17ef1cbd4545996c29d371aaf7c6 Reviewed-on: https://chromium-review.googlesource.com/664720 Commit-Queue: Karl Anders Øygard <karlo@opera.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#503566}
-
Jesse Doherty authored
Bug: 763208, 766952 Change-Id: I1451eb7dd378ee8e9e65dd5d0f9b0a8e75265d45 TBR: japhet@chromium.org Reviewed-on: https://chromium-review.googlesource.com/677628Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#503565}
-
Alex Newcomer authored
Enable AnswerCards and PlaystoreSearch by default on Eve only. Currently we rely on finch, which means the user must restart their device for the finch features to take effect. This approach is better, because we avoid the reboot step when unboxing Eve. Bug: 767190 Change-Id: Ie30bed9c1ca3078894d566236d7102407ba08018 Reviewed-on: https://chromium-review.googlesource.com/676194 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#503564}
-
Dave Schuyler authored
This CL fixes keyboard navigation to cr-link-row(s). A cr-icon class was added for the purpose of creating cr-icons that are not within a button. Bug: 766067 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I392a432c86313a81341deca4eda9e7505b5441e5 Reviewed-on: https://chromium-review.googlesource.com/671198Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#503563}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1de0eb7..6b164c3 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I25888cbbad857ed1c5910e2860126970f69424ab Reviewed-on: https://chromium-review.googlesource.com/677468Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#503562}
-
Joshua Pawlicki authored
This is the first step to standardize all installers on DCI. Bug: 726162 Change-Id: I35a114dd784abb893855c214bd0c5e05d99e65b7 Reviewed-on: https://chromium-review.googlesource.com/627237Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#503561}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e1aa3179fac3..68ce41b9bda2 $ git log e1aa3179f..68ce41b9b --date=short --no-merges --format='%ad %ae %s' 2017-09-21 charliea Make timeout_retry include the total timeout in the exception error Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I39df7d34a25f9dde11b853877be1a25c69213964 Reviewed-on: https://chromium-review.googlesource.com/676758 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503560}
-
Wenzhao Zang authored
Make views-based shelf 'pixel perfect'. Attached spec: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCEsH2HvLAyNFee2Qy7YOnr3 Bug: 701157 Change-Id: Idfe816d20ea3eb1f7abfbe147be90a8edc8cb18e Reviewed-on: https://chromium-review.googlesource.com/671474Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#503559}
-
Scott Chen authored
Bug: 749298 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I996f0b60c2a91b074c23d8848b43bb568f8810c1 Reviewed-on: https://chromium-review.googlesource.com/663763Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#503558}
-
rbpotter authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibdfc29cb4e5ffe9a4dae0efcc2dff69e4308e6cf Reviewed-on: https://chromium-review.googlesource.com/666183Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#503557}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c089d148..b7c5b115 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I05f81dc79a8b045b1488799208ede3a5afc125f7 Reviewed-on: https://chromium-review.googlesource.com/677275Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#503556}
-
John Budorick authored
Bug: 754496 Change-Id: I2847c0905d7349ce696019913108486d3f173640 Reviewed-on: https://chromium-review.googlesource.com/677125Reviewed-by:
Shenghua Zhang <shenghuazhang@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#503555}
-
Lei Zhang authored
PrinterSemanticCapsAndDefaultsToCdd() always return a DictionaryValue, so stop handling the case where it does not. Change-Id: I5bfbf857054eafcf1757f1587e75fa82b382f225 Reviewed-on: https://chromium-review.googlesource.com/675573Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#503554}
-
Joshua Bell authored
Via: run-bindings-tests --reset-results Following e9236131 the test interface that inherits from Document pulls in a new header file. TBR=mkwst@chromium.org NOTRY=true Change-Id: I3d05d69c88590e0561e269e9a018b5322f197be0 Reviewed-on: https://chromium-review.googlesource.com/677129Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#503553}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5fdbb8a8a76e..2fbf1bc8c96f $ git log 5fdbb8a8a..2fbf1bc8c --date=short --no-merges --format='%ad %ae %s' 2017-09-20 djsollen Add SK_API to APIs used by the android framework. 2017-09-21 bsalomon Fix wrap mode asserts in GrVkSampler::GenerateKey 2017-09-21 liyuqian Run the first bench for 1000ms to warm up the nanobench if FLAGS_ms < 1000. 2017-09-20 mtklein Teach TSAN directly about semaphore_t. 2017-09-21 angle-deps-roller Roll skia/third_party/externals/angle2/ 1b7ed0ef2..981f0f8f6 (4 commits) 2017-09-21 caryclark add missing param names to SkBitmap.h 2017-09-21 caryclark feedback 2017-09-21 caryclark regenerate includes 2017-09-21 robertphillips Remove pre-attachment of stencil buffers Created with: roll-dep src/third_party/skia BUG=725308 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ib8a043fe4d18794fc1b2b89dcba734df555aeaa6 Reviewed-on: https://chromium-review.googlesource.com/677494Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503552}
-
liberato@chromium.org authored
Bug: 618368 Change-Id: Ida7033ce771a2a7b29e0a49eb425ff67ace4791f Reviewed-on: https://chromium-review.googlesource.com/677408Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#503551}
-
rnephew authored
For benchmarks, this means moving to expectations. For unit tests this means moving to decorators.Enabled()/Disabled() TBR=bustamante@chromium.org Bug: 713222 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ia67b2ce6734740770d33d012f7b557879c47321d Reviewed-on: https://chromium-review.googlesource.com/663664 Commit-Queue: rnephew <rnephew@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#503550}
-
Eric Roman authored
This is based on svaldez's work in https://codereview.chromium.org/1849773002/. Bug: 649000,620005 Change-Id: I53eca60688eacb3e2b8472532e14af7c0af8e34e Reviewed-on: https://chromium-review.googlesource.com/676324Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#503549}
-
Helen Li authored
Bug: 766809 Change-Id: I18c670791e002139256abaf71dcc5c6312f2ba5d Reviewed-on: https://chromium-review.googlesource.com/677229 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#503548}
-
Rohit Rao authored
BUG=754050 TEST=No visible impact. Pages should still prerender properly, which can be tested by allowing a URL to inline autocomplete, waiting a few seconds for the prerendered page to load, then pressing Go in the omnibox and verifying that the page appears immediately. Change-Id: I6af103ce9d5bc4c50f912473bb76c37f0adacbba Reviewed-on: https://chromium-review.googlesource.com/675835Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#503547}
-
Pavel Yatsuk authored
Currently HistoryBackend::GetAllTypedURLs return urls with typed_count > 0 which omits urls in redirect chain. This causes such urls to not be displayed on history page. In this CL I'm changing the way how urls to sync are selected. I query visits with PAGE_TRANSITION_TYPED transition and build set of urls corresponding to these visits. BUG=740876 R=sky@chromium.org Change-Id: I15f0401972c9277082887d0989a13689ab23d4a8 Reviewed-on: https://chromium-review.googlesource.com/621421 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#503546}
-
Yuzhu Shen authored
TrackedScopedRefPtr has serveral CHECKs for investigating a memroy corruption issue. They haven't been triggered after 3 days on Canary. Therefore, this CL removes some of them. The remaining ones are not expected to be hit either, but they are left in the code to run on more users's machines to be extra sure. BUG=750267,754946 Change-Id: Icd7e6eaedde3c2a21ea4d89449185b144772b562 Reviewed-on: https://chromium-review.googlesource.com/677491Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#503545}
-
Charlie Andrews authored
Bug: 763263 Change-Id: I676208668f59efaab83ee8a26bad8ba30ff0e5f9 Reviewed-on: https://chromium-review.googlesource.com/677089Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#503544}
-
Ken Rockot authored
Convincing evidence of external memory stomping obviates the need for these checks. BUG=740044 Change-Id: If614e20f9f6417600603b54acb01bd47a9eef6d0 Reviewed-on: https://chromium-review.googlesource.com/676752Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#503543}
-
Lucas Garron authored
This change keeps the content-box centered when the window is between the width of the .content element (600px + padding, since it uses default box-sizing) and 720px. Below that width, it degrades the old behaviour of left alignment. The lack of centered alignment was visible on Incognito new tab pages for themes with a background. TEST=(1) Install a theme like [1] that has an Incognito NTP background image. (2) Open an incognito window. (3) Resize the window to just under 720px (4) Check that the dark box containing the new tab page message is centered. Bug: 767179 Change-Id: Id3229917f6311de8e47ff82062697c886efda5a2 Reviewed-on: https://chromium-review.googlesource.com/676131Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#503542}
-
Ian Vollick authored
This CL fixes a bug in UiElement::UpdateInheritedProperties where we were accidentally pulling the parent's local, not combined opacity. Bug: 767559 Change-Id: Ie8092299ec32229f73e89172b352959e75b7bfd6 Reviewed-on: https://chromium-review.googlesource.com/676664Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#503541}
-
Yuri Wiitala authored
When a GLHelper instance was created, it also constructed a GLHelperReadbackSupport instance. However, in doing so, there were certain calls being made on the GL context that were synchronous, which is: 1) bad to do during init time; and 2) really bad to do if the client code will never use the results anyway. Therefore, this change simply lazy-creates the GLHelperReadbackSupport instance upon first use. Bug: 760348, 760351 Change-Id: I44e63a71331f31b6d88305bb00f29af9928a722e Reviewed-on: https://chromium-review.googlesource.com/676945Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#503540}
-
Xiyuan Xia authored
If an auth code is issued for SAML flow, use it to perform the /MergeSession call to bootstrap the user session. Bug: 767143 Change-Id: Id42a37c84db468f155edfde557ad789b86ab2c4b Reviewed-on: https://chromium-review.googlesource.com/677485 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#503539}
-