GitLab

The pattern for *.typemap is missing in OWNERS. It causes warnings for CLs that change autofill_types.typemap

Review-Url: https://codereview.chromium.org/2755913002
Cr-Commit-Position: refs/heads/master@{#457420}

I believe this captures the purpose of the function more cleanly.

BUG=690006

Review-Url: https://codereview.chromium.org/2757603002
Cr-Commit-Position: refs/heads/master@{#457419}

The cursor would flash when the context menu is sent if the event is
preventDefaulted. With a change https://codereview.chromium.org/2637403012
this occurred more frequently because the move event would get suppressed.

Ultimately I found when this code was activated in
https://codereview.chromium.org/7270 and it seems it was mis-guided in
being added. I've check on Windows removing this code makes everything
work fine.

BUG=699232

Review-Url: https://codereview.chromium.org/2755783002
Cr-Commit-Position: refs/heads/master@{#457418}

On Windows' taskbar's jumplist, both "New window" and "New incognito window" links have main Chrome icon.
An Incognito icon is added to the repository and used instead of Chrome icon for new incognito window link.

BUG=680904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2660153002
Cr-Commit-Position: refs/heads/master@{#457032}
Committed: https://chromium.googlesource.com/chromium/src/+/596cbc2cc875076c361b1b77e840919a2697b67d

patch from issue 2660153002 at patchset 120001 (http://crrev.com/2660153002#ps120001)

In the previous attempt to land the CL, I had not updated the DEPS file of src-internal with the new icon and it broke the build.
Now the icon is added to Google Chrome by this CL: https://chromereviews.googleplex.com/573787013/
And DEPS file is updated in this CL: https://chromereviews.googleplex.com/569457014/

TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2750023002
Cr-Commit-Position: refs/heads/master@{#457417}

BUG=702171
TBR=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2747293006
Cr-Commit-Position: refs/heads/master@{#457416}

MockFormFetcherImpl currently appears in FormFetcherImpl unittest. Its purpose
is to ensure that ProcessMigratedForms is called on a FormFetcher if an
associated HttpPasswordMigrator receives results from PasswordStore.

This is not necessary. It is sufficient to check that (A) HttpPasswordMigrator
receiving results from PasswordStore calls ProcessMigratedForms on its
consumer, and (B), that forms which the FormFetcher ends up with are the
migrated ones. (A) is tested in HttpPasswordMigratorTest::TestFullStore, (B) is
tested in FormFetcherImplTest.TryToMigrateHTTPPasswordsOnHTTPSSites through
EXPECT_CALL(consumer_, ProcessMatches(...https_form...)).

Moreover, having a test double for the tested class is a bad practice, which
could result in the test bypassing the production code when it should not.

Therefore, this CL removes MockFormFetcherImpl.

BUG=571580

Review-Url: https://codereview.chromium.org/2756543004
Cr-Commit-Position: refs/heads/master@{#457415}

https://codereview.chromium.org/2743733002 already disabled several of
them, due to rounding errors on Android. There are two additional tests
that are failing on some of the Android bots. This CL disables them.

BUG=700007
TBR=kenrb@chromium.org, creis@chromium.org

Review-Url: https://codereview.chromium.org/2750343002
Cr-Commit-Position: refs/heads/master@{#457414}

Network traffic annotation is added to network request of
chrome/browser/extensions/api/dial/device_description_fetcher.cc.

BUG=656607

Review-Url: https://codereview.chromium.org/2738243003
Cr-Commit-Position: refs/heads/master@{#457413}

This CL addes flag for enabling/disabling video fullscreen detection. So
we can reduce the overhead of MediaCustomControlsFullscreenDetector if
the client side doesn't need it.

The downstream change will be in the subclass of AppHooks.java.

BUG=699565

Review-Url: https://codereview.chromium.org/2738893002
Cr-Commit-Position: refs/heads/master@{#457412}

This restores the old logic we had for blink to deal with these as mouse
move events but keeping the mouseleave events when we leave the window.

NotifyInferior messages are already dropped at the X11 desktop tree
host but I didn't want to risk breaking any views with addressing this
release block stable issue.

BUG=701637,450631,240300,352106,386896,569998,575208

Review-Url: https://codereview.chromium.org/2751833006
Cr-Commit-Position: refs/heads/master@{#457411}

https://skia.googlesource.com/skia.git/+log/b66fa526b882..f49b1e0ad955

$ git log b66fa526b..f49b1e0ad --date=short --no-merges --format='%ad %ae %s'
2017-03-15 halcanary FuzzCanvas: only valid ChannelSelectors
2017-03-15 iannucci Update recipes.py to f605e5c0bc2e748170ca851383cb552c7225316b

Created with:
  roll-dep src/third_party/skia
BUG=699379


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=borenet@chromium.org

Change-Id: I75b38ce9077100e93ad1c685382099face7c3f75
Reviewed-on: https://chromium-review.googlesource.com/455992Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#457410}

Both of LocalFrame and RemoteFrame have a WindowProxyManager.
We can move it into a base class Frame.

windowProxy->initializedIfNeeded() is moved into WindowProxyManager
from ScriptController and RemoteFrame.
WindowProxyManager::windowProxy(world) now always returns
an initialized global proxy.  It's safer than before, I think.
(But no behavioral change in this CL at all.)

Also the following renaming is done in order to emphasize that
the returned object may not be initialized.

  WindowProxyManagerBase
  => WindowProxyManager
  (Same naming as Frame, DOMWindow and WindowProxy)

  WindowProxyManager::mainWorldProxy
  => mainWorldProxyMaybeUninitialized

  WindowProxyManager::windowProxy
  => windowProxyMaybeUninitialized

By the way, we don't much use RemoteWindowProxyManager.
We can simply remove the class in a follow-up CL.

BUG=

Review-Url: https://codereview.chromium.org/2702273004
Cr-Commit-Position: refs/heads/master@{#457409}

Revert of [Cronet] Write effective experimental options to NetLog (patchset #5 id:80001 of https://codereview.chromium.org/2738813004/ )

Reason for revert:
The bot

Android Cronet Builder Asan

is reporting

Failed steps failed cronet_unittests failed cronet_test_instrumentation_apk

I suspect this patch might be why.

https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Builder%20Asan/builds/1791

Original issue's description:
> [Cronet] Write effective experimental options to NetLog
>
> This CL does the following:
> (1) Have a warning in Experimental Options parsing code if there is an
>     unrecognized option.
> (2) Make cronet_url_request_context_adapter use the new FileNetLogObserver which
>     allows writing polled data.
> (3) Put the effective experimental options in the polled data.
>
> BUG=584806,699567
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
>
> Review-Url: https://codereview.chromium.org/2738813004
> Cr-Commit-Position: refs/heads/master@{#457158}
> Committed: https://chromium.googlesource.com/chromium/src/+/3c275e0a2333511ec831b3c396dc9f38a161a8c6

TBR=kapishnikov@chromium.org,mgersh@chromium.org,xunjieli@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584806,699567

Review-Url: https://codereview.chromium.org/2751113004
Cr-Commit-Position: refs/heads/master@{#457408}

Network traffic annotation is added to network request of
components/autofill/core/browser/autofill_download_manager.cc.

BUG=656607

Review-Url: https://codereview.chromium.org/2740213003
Cr-Commit-Position: refs/heads/master@{#457407}

BUG=631966

Review-Url: https://codereview.chromium.org/2749583003
Cr-Commit-Position: refs/heads/master@{#457406}

Before this CL we used "memory-infra" category for memory coordinator
related events. Enabling "memory-infra" category triggers memory
dump tasks but in some cases we just want to record memory coordinator
related events without memory dumps to investigate performace impact of
memory coordinator (e.g. how purging memory affects tab switching).

This CL changes the category of memory coordinator related events to
"memory_coordinator" so that we can recard traces without memory dumps.

BUG=617492

Review-Url: https://codereview.chromium.org/2752153002
Cr-Commit-Position: refs/heads/master@{#457405}

While https://codereview.chromium.org/2749253002 took care of adding all
required includes and forward-declarations for unions inside records inside
other unions, it did not solve it for unions inside records which were _not_
inside other unions: in this case, v8_union is not used at all, so we need
to patch code_generator_v8.depending_union_type() instead.

BUG=685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2752223002
Cr-Commit-Position: refs/heads/master@{#457404}

In order to disable the global static defaults while having popular
sites enabled, a separate flag is necessary.

BUG=700872

Review-Url: https://codereview.chromium.org/2741413008
Cr-Commit-Position: refs/heads/master@{#457403}

Reland of [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3 (patchset #1 id:1 of https://codereview.chromium.org/2757563002/ )

Reason for revert:
The CL reverted was part of a two-sided CL, and the downstream part landed just before this got reverted. So the Android ToT roller bot is broken again. Let's land this CL again, so that everything goes back to green.

Original issue's description:
> Revert of [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3 (patchset #2 id:20001 of https://codereview.chromium.org/2728053002/ )
>
> Reason for revert:
> This is causing build failures on clang-clankium-tot-builder
> See:
> https://crbug.com/702086
> https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/clang-clankium-tot-builder/builds/43251
>
> Original issue's description:
> > [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3
> >
> > This CL:
> > - Changes GooglePlayWebApkInstallDelegate#installAsync() to return a
> >   WebApkInstallResult in the callback.
> > - Deletes unused GooglePlayWebApkInstallDelegate#canInstallWebApk().
> >
> > BUG=696132
> >
> > Review-Url: https://codereview.chromium.org/2728053002
> > Cr-Commit-Position: refs/heads/master@{#457300}
> > Committed: https://chromium.googlesource.com/chromium/src/+/19d929ae378491116d7683764baa6365d1ddd50d
>
> TBR=dominickn@chromium.org,pkotwicz@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=696132
>
> Review-Url: https://codereview.chromium.org/2757563002
> Cr-Commit-Position: refs/heads/master@{#457361}
> Committed: https://chromium.googlesource.com/chromium/src/+/6da294d05e78dcdd1109ae8dc763ea0485c714af

TBR=dominickn@chromium.org,pkotwicz@chromium.org,aelias@chromium.org,cblume@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=696132

Review-Url: https://codereview.chromium.org/2757543003
Cr-Commit-Position: refs/heads/master@{#457402}

Replace occurrences of "raise 'foo bar'" with "raise ValueError('foo bar')",
otherwise we get another exception ourselves:

    TypeError: exceptions must be old-style classes or derived from BaseException, not str

R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2751063004
Cr-Commit-Position: refs/heads/master@{#457401}

Though there seems to be a shared issue which makes many tests flaky,
we should disable each one for now not to slow down the CQ.

BUG=702119,699534,699978,700156,699083,698834,698772,699171
TEST=none

Review-Url: https://codereview.chromium.org/2754003003
Cr-Commit-Position: refs/heads/master@{#457400}

FlatTreeTraversal::nextSibling()/previousSibling() didn't handle
fallback content (nodes in <slot> where nothing is distributed).

This CL adds fallback content handling and a unit test case.

BUG=683776

Review-Url: https://codereview.chromium.org/2749033006
Cr-Commit-Position: refs/heads/master@{#457399}

BUG=701718
TBR=schenney@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2754813002
Cr-Commit-Position: refs/heads/master@{#457398}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/7867a4e..c0a0f8d

$ git log 7867a4e..c0a0f8d --date=short --no-merges --format=%ad %ae %s
2017-03-16 solenberg@webrtc.org (Re)move VoE specific enums from common_types.h.
2017-03-15 zijiehe@chromium.org DxgiOutputDuplicator should initialize num_frames_captured_
2017-03-15 pbos@webrtc.org Use VPX_ERROR_RESILIENT_DEFAULT constant.
2017-03-15 pbos@webrtc.org Remove unused RealTimeTemporalLayers.
2017-03-15 pbos@webrtc.org Remove dead VP8SequenceCoder.
2017-03-15 ehmaldonado@webrtc.org Add traces for some video events.
2017-03-15 jansson@webrtc.org Improve error handling for ffmpeg operations
2017-03-15 alessiob@webrtc.org Revert of C++ porting of the initial python script for conversational speech generation. (patchset #2 id:100001 of https://codereview.webrtc.org/2740063004/ )
2017-03-15 philipel@webrtc.org Release the critial section between recursive calls in FrameBuffer::NextFrame.
2017-03-15 solenberg@webrtc.org Remove VoEHardware interface.
2017-03-15 alessiob@webrtc.org C++ porting of the initial python script for conversational speech generation.
2017-03-15 ilnik@webrtc.org Reland of write frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2748643002/ )
2017-03-15 tommi@webrtc.org Return a long timeout value from TimeUntilNextProcess when the PacedSender is paused
2017-03-15 elad.alon@webrtc.org R/PLR calculation - time-based window
2017-03-15 philipel@webrtc.org Revert of Save width/height of SPS nalus and restore them on the first packet of an IDR. (patchset #6 id:100001 of https://codereview.webrtc.org/2750633003/ )
2017-03-15 solenberg@webrtc.org Remove VoEHardware interface usage.
2017-03-15 alessiob@webrtc.org FileUtilsTest DirExists function added
2017-03-15 sakal@webrtc.org Better handling of error condition in MediaCodecVideoEncoder.
2017-03-15 sakal@webrtc.org Try re-enabling two PeerConnectionClientTests:
2017-03-15 stefan@webrtc.org Fix broken test landed in r17243.
2017-03-15 stefan@webrtc.org Ignore packets sent on old network route when receiving feedback.
2017-03-15 tommi@webrtc.org TaskQueue[Win] DOS handling
2017-03-15 ilnik@webrtc.org Fix crash in vie_encoder when encoder configure fails Bad changes are from CL 2745523002.
2017-03-15 philipel@webrtc.org Save width/height of SPS nalus and restore them on the first packet of an IDR.
2017-03-15 terelius@webrtc.org Pass label and plot style to the TimeSeries' constructor.
2017-03-14 zijiehe@chromium.org Ignore unmoved moved_rects in DxgiOutputDuplicator
2017-03-14 minyue@webrtc.org Fixing a few tests for the upcoming Opus 1.2-alpha.
2017-03-14 tommi@webrtc.org Remove ReceiveCodec() getters from VideoCodingModule.
2017-03-14 dkirovbroadsoft@gmail.com Fixed problems in neteq when RTP and decoder timestamps increment with different sample rate frequency.
2017-03-14 oprypin@webrtc.org Add the ability to read/write to WAV files in FakeAudioDevice
2017-03-14 nisse@webrtc.org Delete support for sending RTCP RPSI and SLI messages.
2017-03-14 tommi@webrtc.org Change FrameBuffer::Stop to not require a critical section.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2754773002
Cr-Commit-Position: refs/heads/master@{#457397}

BUG=697709

Review-Url: https://codereview.chromium.org/2749943003
Cr-Commit-Position: refs/heads/master@{#457396}

This is the refactoring needed for new wakeup-based throttling
mechanism.

Remove friendship between BudgetPools and TaskQueueThrottler.

R=skyostil@chromium.org,alexclarke@chromium.org
BUG=699541

Review-Url: https://codereview.chromium.org/2742383005
Cr-Commit-Position: refs/heads/master@{#457395}

This rewrites FirstMeaningfulPaintDetectorTest's test case for the
network quiet timers, using TestingPlatformSupportWithMockScheduler.
Now it verifies that the timers are actually fired.

This also changes other test cases to use mock timer provided by
TestingPlatformSupportWithMockScheduler.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2755873002
Cr-Commit-Position: refs/heads/master@{#457394}

There are no problems with adding arbitrary content to an element with
display:table if it's not <table>.

This CL fixes broken editing/deleting/display-table.html.

Because we don't want to change TextIterator behavior, this CL copies the old
implementation of isDispalyInsideTable() to TextIterator.cpp.

BUG=697315

Review-Url: https://codereview.chromium.org/2757553002
Cr-Commit-Position: refs/heads/master@{#457393}

Fixes a bug in ProcessMetricsMemoryDumpProvider::RegisterForProcess
where if we get a duplicate pid we register an MDP but then immediately
destroy it. This later causes a crash. Instead we should not register
the MDP if we get a duplicate pid. This won't help the root problem
of why we are getting duplicate pids which will now just cause
information loss instead of crashing.

BUG=695731

Review-Url: https://codereview.chromium.org/2753723003
Cr-Commit-Position: refs/heads/master@{#457392}

The SVG 2's spec is: https://svgwg.org/svg2-draft/struct.html#UseElement

Because SVG spec has been updated to clarify that SVG's <use> element should
use a shadow tree as its implementation, we must use the *standard* shadow tree
which DOM Standard defines its behavior. That is either an open shadow root or
a closed shadow root. It should not be a user-agent shadow root because it is UA's
internal concept.

Though the SVG spec says nothing about which type of Shadow Root should be
used, this CL chose "closed" because it is more compatible to the behavior of
user-agent shadow root.  Eventually, the spec should clarify the type.

BUG=670572

Review-Url: https://codereview.chromium.org/2752763002
Cr-Commit-Position: refs/heads/master@{#457391}

BUG=699426,701922,701923
TEST=None

Review-Url: https://codereview.chromium.org/2747423003
Cr-Commit-Position: refs/heads/master@{#457390}

BUG=698235

Review-Url: https://codereview.chromium.org/2743203004
Cr-Commit-Position: refs/heads/master@{#457389}

BUG=

Review-Url: https://codereview.chromium.org/2747683002
Cr-Commit-Position: refs/heads/master@{#457388}

This CL adds support for blocking requests in NavigationRequest during
redirects. It also fixes an issue in NavigationHandle, without
PlzNavigate activated, where the NavigationHandle would not be properly
recognized at error page commit if the navigation was blocked by a
NavigationThrottle during a redirect.

BUG=685074, 695421
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2698623006
Cr-Commit-Position: refs/heads/master@{#457387}

Design doc: https://docs.google.com/document/d/1L5qRmCwjidiZWKmQRiuqMjZivBWV7XSW9RTypg9XxlI/edit?usp=sharing

BUG=635419

Review-Url: https://codereview.chromium.org/2711093002
Cr-Commit-Position: refs/heads/master@{#457386}

This test shows that the CSP of the navigating frame are used instead of
the CSP of the frame that has initiated the navigation.

This is a reland of: https://crrev.com/2747823002/

BUG=700964
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation,linux_chromium_browser_side_navigation_rel

Review-Url: https://codereview.chromium.org/2749233002
Cr-Commit-Position: refs/heads/master@{#457385}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=kinuko@chromium.org
BUG=671545, 670237

Review-Url: https://codereview.chromium.org/2752073005
Cr-Commit-Position: refs/heads/master@{#457384}

Whether the StyleResolver is created or not does no longer tell if we
have usable invalidation sets or not. Removing SubtreeStyleChange which
is presumably not necessary anymore.

Add a check for not scheduling any invalidation sets if the document is
already marked for full recalc.

Review-Url: https://codereview.chromium.org/2749273004
Cr-Commit-Position: refs/heads/master@{#457383}

The custom accessibility actions check for the existence of the ReadingListModel
entry when configuring a cell. This CL changes this behavior to do nothing when
the entry does not exist instead of reloading the UI.

BUG=676290, 701956

Review-Url: https://codereview.chromium.org/2750623006
Cr-Commit-Position: refs/heads/master@{#457382}

Prior to this CL, an IDL construct like this:

    void func((boolean or sequence<Element>) arg);

would generate two union files, BooleanOrElementSequence.cpp and
BooleanOrElementSequence.h. BooleanOrElementSequence.h contains declarations
such as:

    const HeapVector<Member<Element>>& getAsElementSequence() const;
    HeapVector<Member<Element>> m_elementSequence;

However, it does not forward-declare Element, nor does it include
Element.h (or V8Element.h). Only BooleanOrElementSequence.cpp includes
V8Element.h, leading to build failures.

This affected any types inside unions that require forward declarations
and additional headers to be included which were inside a container type,
such as a record or a sequence. For instance, the constructs below were all
problematic:
* (boolean or sequence<Element>)
* (float or sequence<(boolean or long)>)
* (double or record<ByteString, Element>)

Solve this by expanding v8_union._update_includes_and_forward_decls() and
making it more similar to code_generator_v8's depending_union_type() and
TypedefResolver:
* If we're parsing a container type (ie. a record or a sequence), we call
  the function recursively to make sure all headers/forward declarations are
  taken care of.
* If we're parsing a union type, the union was inside a container type (as
  otherwise it would have been broken up by us looping through flattened
  union members), in which case we forward-declare the union and include its
  header in the outer union's .cpp file.

BUG=701410
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2750003003
Cr-Commit-Position: refs/heads/master@{#457381}