- 24 Oct, 2019 40 commits
-
-
Bailey Berro authored
Updates the string used for the notification that appears when a user connects more monitors than their device can support. Bug: 1017375 Fixed: 1017375 Change-Id: Id88ae042e19e16f0739598f08dca98339e29f46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875519Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#709186}
-
Vlad Tsyrklevich authored
- Mention its backronym - Note that it is now enabled by default on macOS/Windows - List 2 more limitations I thought of Change-Id: I19108d66b8f3ec88732f62a10fe9777d675139d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879790 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#709185}
-
Nikita Podguzov authored
Bug: 992218 Change-Id: Ia5548a156040954aba3e902762f97967e211c7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879907Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#709184}
-
David Benjamin authored
This test does not produce much output, but the debugging information added to diagnose https://crbug.com/869227 caused this test to send too much output. Switch it to a TEST_P to divide it back up. Bug: 1017036 Change-Id: I54e5582859ae271401c69e3241f47bd5f12ff42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879971 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#709183}
-
Dana Fried authored
Previously, when animating layout manager was set to "animate bounds" mode (see SetShouldAnimateBounds()), it assumed it would always be given enough space for its preferred size at any point in the animation. This CL makes it so that an animation can stop short if the containing view stops granting the animating view more space. This allows a view with an AnimatingLayoutManager to be more easily embedded in a view that has, for example, a FlexLayout layout manager. The primary use case will be capping the size of the account icon container so the account name text is elided when the browser window is too narrow to show the entire text without making the Omnibox too small to effectively use. The current behavior is that when space runs out, the kebab/wrench icon slides off the right side of the window (see attached bug). A follow-up will actually engage this new functionality to fix the problem. Bug: 1012681 Change-Id: Ia8e41bb15776a72a8d0869a3c387703e5e443c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875107 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709182}
-
Kevin Bailey authored
Change fuzzer to avoid data we know AutocompleteInput isn't designed to handle. Change-Id: I755db8375adf0f629af6a656d9494033cae5bb39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876551Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#709181}
-
Peng Huang authored
With the this change, the https://crbug.com/1014236 will not be reproducible with Nvidia. Bug: 1014236 Change-Id: If6a82f7e797bca2c726359575a2134f206ae72fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879749 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#709180}
-
Xiaoqian Dai authored
Bug: 997885 Change-Id: Ib479e05d744d5e85c2319fb1873e1b94033320fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875553Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#709179}
-
Etienne Bergeron authored
Uniscribe based fallback fonts got removed and replaced by the Skia version, which is using DWrite. Thus, the locale is now supported on win7. Turn on the test on win7. Change-Id: Iae4017a8636333e95d3ff771323fe56ba4b48ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877911 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#709178}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/09b50796402d..f8df30f1ad44 git log 09b50796402d..f8df30f1ad44 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 sugoi@google.com Fix stencil+MSAA Created with: gclient setdep -r src/third_party/swiftshader@f8df30f1ad44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Idf76afabb4cd14e1b81daa032fa7aa980dce497d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879511Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709177}
-
Min Qin authored
When network service is enabled by default, page transition type is not propagated to download when intercepting a navigation. This CL fixes the issue by sending the transition type from NavigationRequest, and also fixes an issue that we only check for DownloadItem::HasUserGesture() when new download backend is enabled. BUG=1014451 Change-Id: Ie3d7614fbfc007a221c86125ac124087ac09a75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879612Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709176}
-
Carlos IL authored
Android webview interstitials will require this code. Moving it into components to avoid duplication. Bug: 1016581 Change-Id: I79c9f7f274f6880a7ae102f5b747b79acb72835d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872736Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#709175}
-
Avery Musbach authored
Change-Id: I5f7ee685fd794ec55685c55164a12eda6debf0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879557Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#709174}
-
Justin Cohen authored
iOS13 will commit a URL change when using window.open followed by a child.location change. If the browser triggers a reload here we shouldn't rewrite URLs to chrome, as window.open to chrome URLs are not allowed. Bug: 1017564 Change-Id: I09384f4e6825c9ae34523458516b20715d4b4961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879328Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709173}
-
Anastasia Helfinstein authored
This change adds error messages to all of the asserts in each existing JavaScript test and updating the testing infrastructure in small ways. Bug: 897365 Change-Id: Id83c9975d734d785524beb1370c5415ab4d0c900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865479 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#709172}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/20b416235aa6..6da1770507ec git log 20b416235aa6..6da1770507ec --date=short --no-merges --format='%ad %ae %s' 2019-10-24 yunchao.he@intel.com Fix ambiguous errors for bind group Created with: gclient setdep -r src/third_party/dawn@6da1770507ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ic6f0427ccf4819a962510581ee81ff8acd63a99a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879512Reviewed-by:
-
Ken Rockot authored
This caps JPEG decode size in the Data Decoder service at 1 GB of uncompressed image data in an attempt to stop excessively large image decodes from inducing OOM crashes. Bug: 1014022 Change-Id: Idb3dfed8cf383fbe58d9521093a1d11f7feee01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866208Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#709170}
-
Elly Fong-Jones authored
Currently, when a flag expires, it is hidden from chrome://flags but still stored inside the backend flags store, so that if the user un-expires flags their settings are not lost. However, the code for applying flag values by turning them into features/switches was not aware of flag expiration, so flags that were persisted this way would continue to apply, despite the user having no way to undo them. This change: 1) Adds an exclusion predicate to FlagsState, to allow client classes of FlagsState to prevent flags from having their values applied as features or switches; 2) Adds an implementation of that predicate in the //chrome FlagsStateSingleton that checks the flag expiration state; 3) Adds unit tests to cover the new behavior added in (1); 4) Adds a new AboutFlagsBrowserTest test to validate the end-to-end behavior described in this commit message by: a) Setting an expired flag to a non-default value b) Restarting (simulated via separate PRE_ vs regular tests here) c) Checking that the flag's switch isn't in the browser command line TBR=rohitrao@chromium.org Bug: 1009729 Change-Id: I7d0ee2e7660fa378b9ecec3b663cc794f7e776fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879431Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Lily Chen authored
This change swaps a default net::CookieOptions to an all-inclusive CookieOptions, which allows the test to set and get all cookies. Previously, using the default CookieOptions, SameSite cookies could not be set. This would be a problem when cookies become SameSite-by-default (see https://www.chromestatus.com/feature/5088147346030592), because the test would no longer be able to set and get the cookies it expects. This change will allow the test to keep working when cookies are SameSite-by-default. Bug: 1016512 Change-Id: I8915aea124b3f3debb2f84bc58f950175875ee52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875521Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#709168}
-
Omer Katz authored
Ephemeron tracing for the marking GC used a custom callback. This CL updates the tracing to go through the trace traits and reuse existing tracing code. Bug: 986235 Change-Id: If7ffebd3dd43196ff5271931919d5279f2c3ed3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872054Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#709167}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d4a217b1f81e..9d48adc199ee git log d4a217b1f81e..9d48adc199ee --date=short --no-merges --format='%ad %ae %s' 2019-10-24 eseckler@google.com processor: Update thread names using utids for TrackEvent traces Created with: gclient setdep -r src/third_party/perfetto@9d48adc199ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:130786981 Change-Id: Ic6bc43ce4c417fa4e160759ba1cfb7fdaf3a672e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879510Reviewed-by:
-
Tibor Goldschwendt authored
The first piece of information is the native libraries a module depends on. We will use this info in following CLs to auto-load the libraries on first module access. The Java is generated in the chrome_feature_module template via a new module_desc_java template. Module_desc_java lives in //components/module_installer since this component is using the Java and has expectations about its format. Modules that don't use module descriptors (e.g. they are packaged into base such as tab_management in this CL) have to manually create a module_desc_java to be able to use Module.java's loading goodies. APKs won't automatically have module_desc_javas. In order to make the Module.java API work in APKs (e.g. test APKs) we use stub descriptors. This should be fine as APKs already load all native libraries at startup. See go/native-dfm-load-v2 for more context and details. Also in this CL, moving native lib loading before impl initialization so that the module is fully set up by the time module code is handed control. Bug: 870055 Change-Id: I8b6112bfc57b7d49698702b4fc12d2874b55fa12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873911 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#709165}
-
ckitagawa authored
Because it is potentially unsafe to handle a proto generated in the renderer process in the browser process. The data should to be passed as a mojo struct instead. Bug: 1017350 Change-Id: I83c02eb65bdf7b0dc90412470c763bbfbe052462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875283Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#709164}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I57890f2304f08733a9c6e7c22e40050f5b4423ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877002Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#709163}
-
Anastasia Helfinstein authored
The Switch Access object has always had a singleton object that lived in the background page. Clarify where the object lives by accessing it through a static method on the class. Bug: None Change-Id: I5b131e9a5679d27b6ad10dffc342c39ec9f75edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875383Reviewed-by:
-
Henrique Nakashima authored
Bug: 995916 Change-Id: If09bacfa393160123376515e36d54c1540c5e1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879467Reviewed-by:
-
Mihai Sardarescu authored
This CL avoids passing the unifiedConsentEnabled as a loadtime variable to the ChromeOS settings javascript code. A follow-up CL will also remove the "unified-consent-enabled" argument from all JavaScript settings files. Bug: 1015805 Change-Id: I66da81aa163950594b120ba6a5100de42234bf61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871989Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#709160}
-
Evan Stade authored
Bug: 268984 Change-Id: I0f9d0ed9d2e7a156e2ebc03468deadf2fb0022c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877248 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#709159}
-
Jeroen Dhollander authored
This API can be used from both ash and browser tests, and exposes handlers to access, inspect and use the Embedded Assistant UI. In this CL I also update the Assistant code to use a specific set of view IDs. This makes it easier to find a specific view during the unittests (and removes the need for the |GetDescendantViewByName| methods that I introduced earlier). BUG: b/141264108 Change-Id: Ib50bae7be1f14c4ce3aabbb31b8a5689b6300619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873291 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#709158}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4a4400d9e9fa..e107faa062c4 git log 4a4400d9e9fa..e107faa062c4 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 halcanary@google.com SkRemoteGlyphCache Add tracing to diff canvas 2019-10-24 mtklein@google.com Reland "hide color filters from blitters" 2019-10-24 bsalomon@google.com Type usage improvements in GrTextureProducer classes Created with: gclient setdep -r src/third_party/skia@e107faa062c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: Id40bcbbbc4e41dec9d253493df9ed55a7f5e1bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879551Reviewed-by:
-
Caroline Rising authored
Bug: 1017821 Change-Id: I39fc6148524086fb45437911580a98d896263600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879694Reviewed-by:
-
Mike Dougherty authored
The context menu currently does not find elements inside the shadow DOM of another which are attached with the |attachShadow| API. Add support by looking inside an element's shadowRoot. Bug: 1017257 Change-Id: I720e54f1ef7157c3ae5200c8dd097302dcee7429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877602 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
Jonathan Freed authored
Bug: 998907, 1013648 Change-Id: I8925f0d1a4cf7a5c58097ecc0a6e2f31bebd8d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874092Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#709154}
-
Andrey Kosyakov authored
This fixes a regression after https://crrev.com/c/1861035 that caused a web page to require more printed pages due to an inconsistency of rounding directions. We used to implicitly round the rect returned by LayoutView::DocumentRect(), as it used to return a snapped-to-int rect. Now that we've started returning a PhysicalRect, it gets to ResizePageRectsKeepingRatio() as is and gets truncated there. So let's round sizes explicitly before passing to ResizePageRectsKeepingRatio(). BUG=650768, b/142742179 Change-Id: I55a9df6977f464452fc4878517796717761c5b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867126Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#709153}
-
Elly Fong-Jones authored
As of r708260 on Catalina these methods return the SYSTEM_PERMISSION_DENIED rather than PERMISSION_DENIED. Bug: 998755 Change-Id: I8fa29f08a93ec1b4df5cfd15d2343154f1985f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879774Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#709152}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=primiano@chromium.org Bug: 891670 Change-Id: Ic16025b9521d146818358f5dff16877088872b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878194 Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#709151}
-
Shimi Zhang authored
JsReplyProxy in testJsReplyProxyReplyToTheCorrectJsObject could be null sometimes, this is because we didn't use ScopedJavaGlobalRef to reference the corresponding Java object. If a full GC kicked in, the Java object will be collected, so native side JavaObjectWeakGlobalRef will return a null. Bug: 1015023 Change-Id: I66d0f5a9334f98a65e8fd9c05712b5b492a7f788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873389Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#709150}
-
Mikel Astiz authored
The patch reintroduces the logic reverted in 51be6f11, now behind a feature toggle. switches::kMergeBookmarksUsingGUIDs is reused because actually there's a fundamental coupling (which was overlooked before and the reason for crashes): using deterministic tmp IDs *requires* that the merge algorithm is aware of possible ID collisions (GUID equality). Bug: 978430,1004205 Change-Id: I7babdcebc2d1eae4433c93316abdcbd374ceba19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878148Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#709149}
-
Elly Fong-Jones authored
This is now a regular factory method on this class, called from a new override of BubbleDialogDelegateView::Init(). Bug: 1011446 Change-Id: Ie177b62c237dcb8fe53dcae385bc807977d223f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876550 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Mathieu Binette authored
Following up on comment in https://crrev.com/c/1876788. Change-Id: Ib98809802ac2d1634d8300569c1bed0d165dbedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879689 Auto-Submit: Mathieu Binette <mbinette@google.com> Commit-Queue: Mathieu Binette <mbinette@google.com> Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#709147}
-
