- 02 Jul, 2020 40 commits
-
-
Stepan Khapugin authored
Adds support for multiple levels of blocking UI in the same scene to simplify accounting. Provides a ScopedUIBlocker object that increments and decrements the blocking counter while it's alive. Bug: 1072408 Change-Id: I39e5713e3b23e0e233958389a5ec8f0c1263bf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259857 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#784830}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad0b2b8dd121..92c33f329a56 2020-07-02 reed@google.com document Make for paths, and move from pathbuilder into path If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: Icadb31c30ff0ad286219176e0f9ed8f58341846e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278299Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784829}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I040f38188c2296ecca55089cdcf54e8af57743d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278852Reviewed-by:
-
Thomas Tellier authored
Bug: 1066489 Change-Id: Ic997e1b8de256ab66ef28710ff41c2ff9299a378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219889 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#784827}
-
Elad Alon authored
Bug: 1100295 Change-Id: Id4dd2ef665e5ef6e03ef241f861bcdf37c28aa87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278263Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#784826}
-
Samuel Huang authored
The instructions to build caspian_web is failing due to wasmbuild.patch apply failure. This CL updates updates the patch to get things working again. Bug: 1040645 Change-Id: I2e204e622a29309915ca1086a89d42e9c146132a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272615 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#784825}
-
Matthias Körber authored
This reverts commit f2db4e69. Reason for revert: Bad name for finch study Original change's description: > [Autofill] Allow address profile import from unfocusable fields > > Currently, Autofill does not import address profile data from fields > that are not focusable. This is problematic because such fields are > often used in combination with synthetic form fields. To resolve this, > a finch flag is implemented that allows importing profiles from > unfocusable fields. > > R=battre@chromium.org > > Bug: 1101280 > Change-Id: If1027a26f0cb8f563bb02690d21142fc32d653dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276285 > Commit-Queue: Matthias Körber <koerber@google.com> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784599} TBR=battre@chromium.org,koerber@google.com,schwering@google.com Change-Id: I9669586f8b93c7613e00406b2b3fdba46dc29fe5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279770Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#784824}
-
Guido Urdaneta authored
These tests are flaky on ChromeOS. Bug: 1096082 Change-Id: I5abc6a1bcecac09737a1995ccecaf7a8721e3afa TBR: wtlee@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278057Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I4775b9cd30508288ce5e02ab3a963344e0d99cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279131Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784822}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ee1b328d6a78..53c05a8f0110 2020-07-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idcea12ba23cd52cded56ac6159ec99d0a4c49cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278297Reviewed-by:
-
Kushagra Sinha authored
Extend expiry of AccountManager.InitializationTime histogram by 1 year. Fixed: 1100369 Change-Id: I77d8ecbf749e4b59f424e573574fc6a0d0f108a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276268Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#784820}
-
Jeremy Roman authored
Expectations are now inherited by virtual test suites automatically: https://groups.google.com/a/chromium.org/d/msg/blink-dev/E6WX-D63UtE/vavMuD4DAAAJ This should fix webkit_lint failures on the bots: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/91823 Bug: 1101699 Change-Id: Ic10f0f7f9bbcd62fc4b39f288507ff4e912d5535 No-Try: true Tbr: hbos@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279690Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#784819}
-
OlivierLi authored
Verify wake-ups are independent on two seperate WakeUpBudgetPools when one of the two is empty. Bug: 1075553 Change-Id: If58baec2afc318c1f3d413ac2bc7dfb1d0159f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267435Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#784818}
-
Viktor Semeniuk authored
This change adds unit tests for Password Issues View Controller. This is follow up CL for https://chromium-review.googlesource.com/c/chromium/src/+/2257852 Bug: 1075494 Change-Id: I8cc23ce6e8ba90c8ba1741cdd30e5d952ff4b870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272325 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#784817}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c0bb99a..65c9ff30 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib6be7600d86aa2accd5b893ea1f7804fa2099165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277676Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784816}
-
Peter E Conn authored
The other half of the mojo API was added in: https://chromium-review.googlesource.com/c/chromium/src/+/2215865 Change-Id: I3e3c50c3ad51990cf56567728732e51149203592 Bug: 1096428 Binary-Size: Involves a Java mojo binding (https://crbug.com/1062647). Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250252 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#784815}
-
Benoit Lize authored
Currently, when CommitPages() fails in GigaCage, we crash "on the spot". This is the right behavior, as there is not much we can do at this level. However it short-circuits PartitionAlloc's regular OOM handling, which confuses crash reports. Let AddressPoolManager::Alloc() return nullptr, so that the higher levels crash as usual. Bug: 1086388, 1101447 Change-Id: I91a25bad2ff595dca7722a12765c7b42155be600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279111Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#784814}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I9b002b0fea2b93e44d51728a8972f49b5776ed6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218370 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#784813}
-
Mikel Astiz authored
This patch introduces factory functions that enforce how BookmarkPermanentNode instances are created, with consistent values, most importantly the GUID, which had a subtle implementation prior to this patch. The previously-existing function PermanentNodeTypeToGuid() was flawed when it came to the managed bookmark node, since there is no explicit value in enum BookmarkNode::Type to identify managed bookmarks, and FOLDER was used to conclude that it must be the managed bookmarks folder. Instead, it's cleaner and less fragile to force all callers of BookmarkPermanentNode's constructor to specify a GUID. Change-Id: Ife11f5289053fdcb99b1a65d38accf9d80c9e89e Bug: 1060311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083479 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#784812}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. Note that when crossing the Blink API boundary, references to WebMediaStreakTrack kept. BUG=704136 R=guidou@chromium.org Change-Id: Iec9e78e6329e6fa30c04b9d1ad30df4a7b398a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274594 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3cb0985983c1..29444c65244a 2020-07-02 hbos@webrtc.org [Adaptation] Multi-processor support for injected Resources. 2020-07-02 titovartem@webrtc.org Revert "Add rtc::Thread invoke policy." 2020-07-02 mbonadei@webrtc.org Revert "peerconnection: prefer spec names for signaling state" 2020-07-01 fippo@sip-communicator.org sdp: parse and serialize non-key=value fmtp lines 2020-07-01 dminor@webrtc.org Prevent undefined shift in TimestampWrapAroundHandler::Unwrap 2020-07-01 titovartem@webrtc.org Add TimeController to the CreatePeerConnectionE2EQualityTestFixture API 2020-07-01 alessiob@webrtc.org Revert "Fix data channel message integrity violation" 2020-07-01 lennart.grahl@gmail.com Fix data channel message integrity violation 2020-07-01 titovartem@google.com Add rtc::Thread invoke policy. 2020-07-01 landrey@webrtc.org Add av sync metrics to pc level tests 2020-07-01 tommi@webrtc.org Add 1 sec timer to ModuleRtpRtcpImpl2 instead of frequent polling. 2020-07-01 landrey@webrtc.org Add sync group mapping to TrackIdStreamLabelMap 2020-07-01 sprang@webrtc.org Reland "Lets PacingController call PacketRouter directly." 2020-07-01 philipp.hancke@googlemail.com Build: Disable the iLBC audio codec by default 2020-07-01 landrey@webrtc.org Add Start method with TrackIdStreamLabelMap to PeerConnectionE2EQualityTestFixture::QualityMetricsReporter 2020-06-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 037e07fe..a6259aec (784045:784160) 2020-06-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4b369c17..037e07fe (783936:784045) 2020-06-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2c0b70ba..4b369c17 (783820:783936) 2020-06-30 perkj@webrtc.org Ensure CreateTimeControllerBasedCallFactory use simulated time in Call::SharedModuleThread 2020-06-30 tommi@webrtc.org Update a few places in DataChannel to clarify RTP vs !RTP. 2020-06-30 mbonadei@webrtc.org Inclusive language in PRESUBMIT.py. 2020-06-30 philipp.hancke@googlemail.com peerconnection: prefer spec names for signaling state 2020-06-30 mbonadei@webrtc.org Inclusive language in //sdk/android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101263 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0c53e923de3933b7c5fb0406f8c7bf6c39211d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278294Reviewed-by:
-
Viktor Semeniuk authored
This change adds a new screen to Settings > Passwords. This screen shows the user a list of compromised credentials found during password check. Unit tests will be added in follow up CL. Bug: 1075494 Change-Id: I05c4a15a01e27007ece7503d0df54987588d0305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257852Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Benoit Lize authored
Aligned allocations are required to use PartitionAlloc as malloc(). Move the support from dispatch_to_partition_alloc.cc to partition_alloc.h, and add a test. Bug: 998048 Change-Id: Ie3f47f84c1c61adbfb429c3fa40d7a3ecacdd9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277820 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Stephen Nusko authored
The problem is this test became flaky after http://crrev/c/2201762 landed (and stayed landed after reverts), because it moved some code onto the threadpool by default. Whereas before we would serialize and deserialize on the current sequence. However since both get posted to a different sequence we end up having different threads serialize the CopyOutputResult and they both invoke their respective callbacks which share the |results_count| variable between them. Creating a data race. Where sometimes both threads would read the value 0 and we'd lose an increment. The fix is to simply make the increment atomic when we share the same variable across multiple callbacks (which can run on different sequences). Bug: 1098372 Change-Id: I94bb3931e3375196c6fe972b419c963010385576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279229 Auto-Submit: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784807}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie5761759bafb3e3159100aa4202e41f7b27885ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278850Reviewed-by:
-
Guido Urdaneta authored
This reverts commit fd0e9fe3. Reason for revert: The affected bot got green before the revert had an effect. Original change's description: > Revert "base/synchronization: Always Try() in LockImpl::Lock()." > > This reverts commit 6cabb581. > > Reason for revert: Speculative revert to see if it fixes a failure in the win-asan bot. > > First failure: https://ci.chromium.org/p/chromium/builders/ci/win-asan/13067 > > Original change's description: > > base/synchronization: Always Try() in LockImpl::Lock(). > > > > The current implementation of base::Lock on Windows and POSIX assumes > > that base::LockImpl::Try() performs a kernel call, which is not true on > > Linux, macOS and Windows at least, since they all use a variant of "fast > > user-space mutexes" (e.g. futex() on Linux). > > > > Since these calls are cheap (On Android for instance, an external call > > to libc and a compare-and-exchange with acquire ordering), do them all > > the time. An alternative is to remove the branch altogether, as > > base::debug::ScopedLockAcquireActivity checks whether it is enabled as > > well. However it still does a non-zero amount of work, so we may as well > > avoid it, assuming that locks are mostly uncontended. > > > > All in all, assuming that the lock is not held and that ActivityTracker > > is not enabled, this replaces: > > - 2 acquire loads (for the if, and then in ScopedLockAcquireActivity) > > - A predictable branch > > - A call to to Try() > > > > with a single call to Try() (as the native lock() call will effectively > > try() first). > > > > Change-Id: Ie77392db4008966b6379eaadb5d20d1ebfcbc276 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270203 > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Reviewed-by: Wez <wez@chromium.org> > > Reviewed-by: Brian White <bcwhite@chromium.org> > > Commit-Queue: Benoit L <lizeb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#784736} > > TBR=wez@chromium.org,bcwhite@chromium.org,brucedawson@chromium.org,lizeb@chromium.org > > Change-Id: I852b5565512ef12fe8ce324193846c18a2a03aca > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279118 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784776} TBR=wez@chromium.org,bcwhite@chromium.org,brucedawson@chromium.org,lizeb@chromium.org,guidou@chromium.org # Not skipping CQ checks because this is a reland. Change-Id: I8eafbc431a8398b6d28fc3d0fd03f56c626d3130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279202Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#784805}
-
Omar Morsi authored
This is reland of CL:2270069. It was reverted in CL:2277117 because it broke linux-chromeos-chrome compile. The main reason was CL:2275879 that was merged before it and used a string token id. Original change's description: > Refactor platform keys service token ID > > This CL changes how platform keys service expects token IDs from the > service consumers and makes it clear what to expect in special cases > like empty/unprovided token IDs. > > Before this CL, platform keys service was accepting token IDs as strings > which is not as clear as enums especially for the cases of empty > strings. > > Bug: 1073512 > Change-Id: I4cbdfdc8f22b23ce0297314915e52804b2e495f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270069 > Commit-Queue: Omar Morsi <omorsi@google.com> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Michael Ershov <miersh@google.com> > Cr-Commit-Position: refs/heads/master@{#784448} Bug: 1073512 Change-Id: I0d3a16b0badb6e9f298c2fed609f15f3b9731973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278247Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#784804}
-
Antonio Gomes authored
... instead of WebMediaStream. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I1287e1133852bb31cdd14d9ef691ec1e32c0a777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274593 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593669511-c77d2c9f422efcfcb90a8ce75cea7f179d0c9414.profdata to chrome-mac-master-1593691206-548af819b8cfe30fe22b1fc296124301aa7acbe0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifb169f46f47993acf8d7e04a391e7875c2274219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278295Reviewed-by:
-
Matthias Körber authored
Website are quite capable of determining the users country and even their state using GeoIp. Therefore, fields of those types are excluded from the mechanism that resets values address form import when they have not changed since page load. Bug: 1100231 Change-Id: I3371ae7a2a8f56e872e6bdbd988d1318a5545cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270449Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#784801}
-
Mikel Astiz authored
A lot of code around SyncedBookmarkTracker can be simplified if Entity::has_final_guid() can be assumed to always return true. This would also unblock further steps to adopt client tags for bookmarks, in particular the adoption of the GUID (or client tag hash) as key in the entity tracker, instead of the currently-used sync ID. The absence of final GUIDs only affects bookmarks that are already being sync-ed, since new remote updates always include this information. Therefore, the missing piece to achieve the desired invariant (all final GUIDs known) is the validation of persisted sync metadata upon startup. This patch introduces the logic to make this validation more strict, behind a feature toggle disabled by default. If the new validation fails, sync metadata for bookmarks will be discarded and all bookmarks will be redownloaded from the server (initial merge). Change-Id: I837587fdce3fa92a96e5cc830edad66b03161904 Bug: 1032052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278250 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#784800}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/60421845f430..ee1b328d6a78 2020-07-02 aerotwist@chromium.org [Watch] Changes autoninja target If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098694 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6c21a816a94f76424fce7adc8699521024550f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279189Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cbcc500fa426..45c2272230c0 2020-07-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7ff733fd65d7 to bda422c594d4 (5 revisions) 2020-07-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from dca47063ccd2 to 57002d0447df (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I86917d7e7c8479ba493df841186485d6f675cf75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279173Reviewed-by:
-
Christian Dullweber authored
To display the number of cookies in use, pass this number to observers. Bug: 1077766 Change-Id: I3bea652cccf013e38c88884fb6c7c8adfebb047d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275444 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#784797}
-
Fredrik Söderqvist authored
Cut away the overhead of the CSSComputedStyleDeclaration "wrapper" and and eliminate the "use override computed style" mechanism in favor of just calling the appropriate method directly. This also means that we can remove the override of VirtualEnsureComputedStyle on SVGElement. Bug: 1017723 Change-Id: Iea3dfb024ab2e421e493ab0bdeb9e893dbaa5442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274616Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#784796}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: Ia467310f7afcdfbf2055d8b551eb9ef4df30d5d4 Fixed: 1076786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279194Reviewed-by:
-
Colin Blundell authored
When I changed embedder-initiated navigations to be of type link rather than user typing, I also changed the ExternalNavigationTest case that tested handling of intents initiated via onLoad() in a page that is reached via an embedder-initiated navigation to expect an intent being launched rather than blocked. This makes sense since it is only for navigations initiated by user typing that such intents would be blocked. I should have also changed this test to expect that the visible URL would revert to that of the original URL, since in this case WebLayer eliminates the navigation entry that corresponds to the intent being launched. I neglected to do this and the test itself didn't complain because it wasn't set up to wait long enough for the navigation to the page launching an intent to fully complete, including the elimination of the corresponding navigation entry. There is no production problem here; this is simply a matter of test precision that nator@ uncovered. Change-Id: If1443d202cffd0863af2600094bd46a2663bf2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279200Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#784794}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/57002d0447df..a70f7dea7718 2020-07-02 johnkslang@users.noreply.github.com Merge pull request #2268 from lriki/hlsl-pack_matrix 2020-07-02 johnkslang@users.noreply.github.com Merge pull request #2303 from ben-clayton/limit-public-2 2020-07-02 cepheus@frii.com Bump revision. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Icaaac1021d269b27207e0ec68e41ce5e8168c4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279182Reviewed-by:
-
Yuki Shiino authored
Implements property installation APIs for V8 context snapshot and also fixes the export declaration. Bug: 839389 Change-Id: I2bc83495960f139f28e134480b9bbe5e8a9acbd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277656Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#784792}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2dc51d54..8c0bb99a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I83cd8c838afa8fab2c820721dd78ec06a847cfd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278893Reviewed-by:
-
