- 18 Nov, 2019 40 commits
-
-
Owen Min authored
The feature is going to be rolled out in M79. Raise the expire milestone just in case. Bug: 1009677 Change-Id: I3adb6592641674ca2f7cb790e885b024b176e175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918272Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#716172}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/954888135395..430d4059adb3 git log 954888135395..430d4059adb3 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src d42d0747ee1b..ba6cbb047868 (1 commits) Created with: gclient setdep -r src/third_party/angle@430d4059adb3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: chromium:None Change-Id: I5b2dcafab09d2ed6d1d33201c0d60b120d87e329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716171}
-
Joe Mason authored
* Always test with registry keys found. * No need to test all combinations of crash point x prompt user values. Cuts the number of test combinations from 38 to 11. R=proberge Bug: 1016939 Change-Id: Ib3a039f42aaf3a83dd2ccc3fba088667cd3d43b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918947 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#716170}
-
Andrew Grieve authored
Fixes incremental_install=true on Android Q Bug: 1025117 Change-Id: I8945f8dbc5327f5cdbcd13b43ebf09dba8978768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919728 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#716169}
-
Chris Lu authored
Exposing this property will be necessary when the banner is presenting while an Infobar action is processing and the modal should not be opened. Bug: 1014959 Change-Id: I964d5ec1d2513cefd4b84cf04377877ac3ac8ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907594 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#716168}
-
Sebastien authored
Upon installation of the Games component, the installer will update this pref with the paths to data files. This CL adds the consumption side of the pref, where the GamesService will check for the existence of the pref as a sign that the component was correctly installed. Bug: 1018201 Change-Id: I24253170228beb8247cb8317d405b6ce54029781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912808Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#716167}
-
Fredrik Söderquist authored
Add a DecodeSVG API to Blink's WebImage to provide for decoding, parsing and rendering of a blob of (hopefully) SVG data. In the process, relocate WebImage to public/web (from public/platform), since that makes it easier to interface with SVGImage (which is in the "core complex"), and there appears to be no strong ties on the WebImage interface as such to have it in public/platform. The ImageDownloader component is extended to be able to decode data with the MIME type using the new WebImage::DecodeSVG API. The WebContents::DownloadImage interface (as used for favicons and other things) is extended to allow specifying a "preferred size". This size is used when determining which size to render a scalable image format into. This is different from the pre-existing "max (bitmap) size" which acts as hard upper bound on (either of) the dimensions of the rendered results. Based on some of the users of this interface there seems to be a need to have both. Intent-to-Implement-and-Ship thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/IKe_SAgdNAA/discussion Bug: 294179 Change-Id: I8d4f27c563b97cdd57e3fe9d42d3c82f1e087eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541185Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#716166}
-
Jonathan Ross authored
Recently the two tests concerned here were suppressed on [ mac no-passthrough ] however they also fail on Android. I'm updating to be just [ no-passthrough ] until the root cause can be addressed. TBR=ynovikov@chromium.org TEST=webgl2_conformance_tests WebglExtension_WEBGL_draw_instanced_base_vertex_base_instance WebglExtension_WEBGL_multi_draw_instanced_base_vertex_base_instance Bug: 1025719 Change-Id: Ia6389b4456b4a231e26014e18dccb28fa9b0165c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921558Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#716165}
-
Raphael Kubo da Costa authored
Instead of having a TODO with my name in it, point to the relevant bug I filed at the time so that it is easier to follow up in the future. TBR=haraken, yukishiino Change-Id: Ieadd90b2d1fa8991b62abf5d7d87a11c5fb01a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921975Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#716164}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /components/network_session_configurator This CL was uploaded by git cl split. R=bnc@chromium.org Bug: 1018667 Change-Id: I4ec74dfa5fb2806f959aa9598498aedb574eca8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917505 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#716163}
-
Fredrik Söderquist authored
After d663ac73, this test should no longer be timing out. Re-enable for desktop platforms first. Bug: 1000473 Change-Id: I7de6f9912254e02c7cc5f1795666d93b7da690d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886615 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#716162}
-
Vadym Doroshenko authored
This test is flaky on Mac. Here is an example of a failure https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/44820 TBR=robertogden@chromium.org Bug: 1025737 Change-Id: I106e314e5f400fe802ae4774dccf1770c719287c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917174Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#716161}
-
Robert Kaplow authored
Mostly a revert of https://codereview.chromium.org/1283243002 Bug: 1016906 Change-Id: I607d74ed4800b18f4067b3b34a7f65a317d8c10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917659Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Auto-Submit: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#716160}
-
haozhe authored
Chrome pass and firefox failed 4 tests Bug report filed: https://bugzilla.mozilla.org/show_bug.cgi?id=1593813 Bug: 900581 Change-Id: I52f133b6662fda4a5342a630307cc761a922c898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887231Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#716159}
-
Maks Orlovich authored
Appear to have become unused since: https://chromium-review.googlesource.com/c/chromium/src/+/1725049 (This showed up as unused by coverage in a CL that changed signature of CreateURLLoaderFactory...) Change-Id: Id9e2b25371828d618beec135de82a5c12cb78196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918387 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#716158}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f66be5a8dcf8..650a1a772186 git log f66be5a8dcf8..650a1a772186 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 lalitm@google.com Merge "trace_processor: add copy/move constructors to potentially fix compile" 2019-11-18 treehugger-gerrit@google.com Merge "Add process uid to the trace processor" Created with: gclient setdep -r src/third_party/perfetto@650a1a772186 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ifa4776a8ed90d631bc44a9a0c379b6838f689670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921557Reviewed-by:
-
Tina Wang authored
This reverts commit c2314471. Reason for revert: The auto import causes multiple failures on Builder Linux Test (dbg). See: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29?limit=100 First failure because of auto-import is suspected: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/84608 Bug: 1025582 Original change's description: > Import wpt@0b3b3e7c6135fcecae5c29f80dc1b8db723f28c0 > > Using wpt-import in Chromium aa63b9ce. > With Chromium commits locally applied on WPT: > 788a3004 "Fix failing Fetch Metadata WPT" > b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." > e83dd93c "Limit backtracking on regexp called from blink." > 6e3e930c "Change `sec-fetch-mode` from `no-cors` to `navigate` for <embed> / <object>." > c8b6e1ce "Chromedriver] Fix PerformAction to support multi touch points cases" > > > Note to sheriffs: This CL imports external tests and adds > expectations for those tests; if this CL is large and causes > a few new failures, please fix the failures by adding new > lines to TestExpectations rather than reverting. See: > https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md > > NOAUTOREVERT=true > TBR=foolip > > No-Export: true > Change-Id: I060ec7549656a215e0f98897ba7c9fb1461efaec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917051 > Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#715924} TBR=foolip@chromium.org,wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I73c88e8889ec263f4dc3ae7a54208140f3d64d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921693Reviewed-by:
Tina Wang <tinazwang@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#716156}
-
Andrew Grieve authored
Also removes unused --bootclasspath option Bug: 693079 Change-Id: I4b684a54f2fef90d15885a6644df9e672cc06c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921297 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#716155}
-
Nick Harper authored
Change-Id: Iad9ea5e58b3dfc4d5fb6ebc635af88f65f9513c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921850 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#716154}
-
Luca Hunkeler authored
Android version and device model are not expected to change within the same interaction. Therefore we can simply get them when the service is initialized and keep them cached. (in the same way we are currently handling the rest of the ClientContext) Bug: b/143519300 Change-Id: I66aa7aeb6d26774fedb2f37f77a221571f70c4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910084Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#716153}
-
Andrew Grieve authored
Bug: 693079 Change-Id: Ie50b217c572ff63b6a8b1db233e2ede0d7741b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921547 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Hans Wennborg authored
This reverts commit 29c801b5. Reason for revert: The official/chrome/chrome_android recipe (which does not show up on internal code search) uses this, and that recipe also builds the M78 and M79 branches , so can't be migrated to use the new update.py flag yet. We'll have to keep this around until all builds are targeting M80 or later. Original change's description: > Remove tools/clang/scripts/download_objdump.py > > All uses have been replaced by calls to update.py --package=objdump. > > Bug: 884608 > Change-Id: Icb820782786a256c0a3586e8a23f62d463689afb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917517 > Auto-Submit: Hans Wennborg <hans@chromium.org> > Commit-Queue: Reid Kleckner <rnk@chromium.org> > Reviewed-by: Reid Kleckner <rnk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715750} TBR=hans@chromium.org,rnk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 884608, 1025703 Change-Id: Ib048dfcbd91f4f5201a6b77525189e6185dc7e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921977Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#716151}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fd0e32a87a4e..4186603902fc git log fd0e32a87a4e..4186603902fc --date=short --no-merges --format='%ad %ae %s' 2019-11-18 handellm@webrtc.org Always record timestamp of keyframe request. 2019-11-18 mbonadei@webrtc.org Reland "Force Chromium deps on the WebRTC component." 2019-11-18 yvesg@google.com Revert "Add AV1 RtpDepacketizer class" 2019-11-18 danilchap@webrtc.org Add AV1 RtpDepacketizer class 2019-11-18 mbonadei@webrtc.org Revert "Force Chromium deps on the WebRTC component." 2019-11-18 jonaso@webrtc.org p2p_transport_channel_unittest : put frequently used checks into functions. 2019-11-17 jerome.humbert@microsoft.com Add missing assert.h for win no-test build 2019-11-16 hta@webrtc.org Make SCTPtransport enter "closed" state when DTLStransport does. 2019-11-16 handellm@webrtc.org VideoFrame: Store a reference to an encoded frame 2019-11-15 thaloun@chromium.org Use GetDefaultAudioEndpoint for the default communications device as well as the vanilla default device 2019-11-15 qingsi@webrtc.org Make ICE transports injectable. 2019-11-15 mbonadei@webrtc.org Force Chromium deps on the WebRTC component. 2019-11-15 peah@webrtc.org Correct the upmixing of mono to stereo in ACM2 Created with: gclient setdep -r src/third_party/webrtc@4186603902fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1013590,chromium:None,chromium:1013590,chromium:b/144524502,chromium:1024965,chromium:b/144458371 Change-Id: Ib258985c0cc41c04dbdba7aeba67644656f2dcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921556Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be605ce3..6c6d66df Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id18e17215397d47fe01407d3565ef102b8885064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921417 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716149}
-
Yoichi Osato authored
As we got to send WebSocketHandshakeResponse, selected_protocol and extensions at the same time ([1]), let's merge it on mojo. This reduces redundant member declarations in WebRequestProxyingWebSocket. [1] "[WebSocket] Do not send response headers for failed handshake.": https://chromium-review.googlesource.com/c/chromium/src/+/1847592 Change-Id: Ib109f2342e85216e7702a51c136f3f940fa8759c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903236Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#716148}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/aba1020d3914..8df0aaf24931 git log aba1020d3914..8df0aaf24931 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 swiftshader.regress@gmail.com Regres: Update test lists @ aba1020d Created with: gclient setdep -r src/third_party/swiftshader@8df0aaf24931 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I1edaeaa7f6ab8de2933c18ab8e5667f69b7c6507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921866Reviewed-by:
-
Greg Thompson authored
This reverts commit 11936b31. Reason for revert: Crashy. Original change's description: > Browser shutdown cleanups (no functional changes). > > - Make ShutdownType an enum class. > - Introduce browser_shutdown::HasShutdownStarted as a convenience. > - Move some Win-specific relaunch code from AttemptRestart, which runs > fairly early in a restart that may never actually happen, into > upgrade_util::RelaunchChromeBrowserImpl, which performs the actual > restart. > - Switch from UMA macros to functions for one-shot metrics. > > BUG=958865 > > Change-Id: I75cd08c712d8bb7c674b4b5e413d79abc874bc39 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910098 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Auto-Submit: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715730} TBR=treib@chromium.org,bcwhite@chromium.org,holte@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 958865,1025638,1025634 Change-Id: Ia97829abe61fcfb362720ce74741a5d375bb811e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921973Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#716146}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8d735c19a560..b2ac8dce6358 Created with: gclient setdep -r src-internal@b2ac8dce6358 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1953c437ac4b9eaa68de4595a5ddcd523ea39caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921208Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716145}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /components/omnibox This CL was uploaded by git cl split. R=mpearson@chromium.org Bug: 1018667 Change-Id: Idb0b248873001282c98db87a6dfc6381d45bbbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917229 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#716144}
-
Findit authored
This reverts commit aeec2ba1. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 716101 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWVlYzJiYTE3NWI5Y2JlZmRhNWQ3ZDQxNmVkZmY2ODRmMmRiOTdlZgw Sample Failed Build: https://ci.chromium.org/b/8896451843858020336 Sample Failed Step: webkit_layout_tests (experimental) Sample Flaky Test: virtual/legacy-client-hints/external/wpt/client-hints/accept-ch-feature-policy-navigation.https.html Original change's description: > [client-hints] Allow 3P legacy Client-Hints to work with Feature Policy > > Currently there are two different flags that control sending Client Hints > to cross-origin resources: Feature Policy delegation (off-by-default) and > a build flag that sends legacy hints on Android. > > This CL makes sure that these two flags play nice together, and adds > virtual test suites to exercise them. > > BUG: 1022366 > Change-Id: I00ed4e9ed5a64e378def3d90227f238b9b3eb374 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893196 > Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716101} Change-Id: I4974dd0e5342a90f97734fddfb9ddaa6fd4fdb22 No-Presubmit: true No-Tree-Checks: true No-Try: true BUG: 1022366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920472 Cr-Commit-Position: refs/heads/master@{#716143}
-
David Roger authored
This is a fix for the following scenario: - user signs in or opens Chrome - image starts downloading - user signs out - image download completes - pill is shown while signed out The fix is to check that the user is still signed in when the download completes. Fixed: 1025674 Change-Id: I780731d23b6e89beba343c27c947c284172584ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919920Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#716142}
-
Oriol Brufau authored
The test fails because the baseline of an empty cell is the top content edge instead of the bottom one. Bug: 1024207, 799016 Change-Id: Iaffac133eee62a2f8f330fbcfe7a2b738837f6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921971Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#716141}
-
Carlos Caballero authored
navigation_handle->IsErrorPage() will always be false in DidStartNavigation as the error state is set upon commiting the navigation. Change-Id: Ib8bd7e49a49b87e26a795080a45038f255295c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895348 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#716140}
-
Daniel Vogelheim authored
Bug: 951536 Change-Id: Ia2f65ff3318ac71debba16d6d50e19d28ac5b071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917532Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#716139}
-
Mathias Carlen authored
Before this patch we locally modified the Bundle to forward the actionId of a dynamic action. That implicit behavior is confusing and led to a bug when an extras Bundle passed to performDirectAction from a calling assist app was null, the map here would be immutable. This patch just plainly passes along the actionId as a function argument. R=szermatt@chromium.org Bug: b/138833619 Change-Id: I4a884a5ad288533f55b13937433d8f6ba3d18418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919353Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#716138}
-
Greg Thompson authored
This reverts commit 2c98cab9. Reason for revert: Parent change causing crashes. Original change's description: > Suppress beforeunload and in-progress download prompts for forced restarts. > > This change introduces RelaunchIgnoreUnloadHandlers and uses it in > RelaunchNotificationController when the deadline for a forced relaunch > is reached. This new function is to AttemptRelaunch as > ExitIgnoreUnloadHandlers is to AttemptExit. > > This also introduces browser_shutdown::ShouldIgnoreUnloadHandlers(), > which is a convenience for code that needs to know whether or not an > in-progress shutdown should ignore unload handlers. > > BUG=958865 > > Change-Id: I91a9832d745e95b7436b176d78f5e39ed14addd2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914380 > Commit-Queue: Greg Thompson <grt@chromium.org> > Auto-Submit: Greg Thompson <grt@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715901} TBR=treib@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 958865,1025638,1025634 Change-Id: I0584904da38d150481e8450aacaff0f909a53d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919356Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/14e51ec7bc7a..f66be5a8dcf8 git log 14e51ec7bc7a..f66be5a8dcf8 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 lalitm@google.com Merge "trace_processor: remove ts/dur DCHECK on span join" Created with: gclient setdep -r src/third_party/perfetto@f66be5a8dcf8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ia0f2089decdf8d32e2000c010332253847993e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921860Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bbdabb3b9b0a..954888135395 git log bbdabb3b9b0a..954888135395 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src f8ea20adee82..e2441190bb0c (42 commits) Created with: gclient setdep -r src/third_party/angle@954888135395 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: chromium:None Change-Id: I7abb86fbac18e4193551c3f2da8719883c461153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921861Reviewed-by:
-
Greg Thompson authored
BUG=980487 Change-Id: Idfeaacd4f5d1e295cc26301eedfee33c1d733ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920045 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Move BrowserDMToken from browser/ to DMToken in components/ in order to be able to use DMToken in components/. Also makes the Create*Token BrowserDMToken functions private to avoid misuses by callers and instead expose *TokenForTesting functions to make their intended usage more explicit. This CL is mostly restructuring the new DM token classes and doesn't change functionality. Bug: 1020296 Change-Id: Ied05c56807352c0bddc4d8ecb11e148d05608e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906901 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#716133}
-
