- 23 Oct, 2018 40 commits
-
-
Becky Zhou authored
TBR=twellington@chromium.org Bug: 898165 Change-Id: Id519840866ae56a2ee795ee73ba505a1a3645559 Reviewed-on: https://chromium-review.googlesource.com/c/1297057Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#602091}
-
James Wallace-Lee authored
To prevent lag and stuttering, limit hittests on mousemove events to 50ms = 20Hz. Bug: 853581 Change-Id: I28f1f142df4c96be9c95d87cfd69c052d776a870 Reviewed-on: https://chromium-review.googlesource.com/c/1289297 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602090}
-
Stephane Zermatten authored
This reverts commit 0602efcc. Reason for revert: We don't actually want to stop scripts when the overlay is tapped. Original change's description: > [Autofill Assistant] Initial impl of OnClickOverlay > > Bug: 806868 > Change-Id: I22b21ccbb386e89d5ac2b0cd8d80e53cc14b447a > Reviewed-on: https://chromium-review.googlesource.com/c/1282362 > Commit-Queue: Ganggui Tang <gogerald@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599980} TBR=rouslan@chromium.org,gogerald@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 806868 Change-Id: Id8b55687d2faead941f82ce0c4889606539dd9c6 Reviewed-on: https://chromium-review.googlesource.com/c/1296602Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#602089}
-
Emircan Uysaler authored
Bug: 898286 Change-Id: I4f3b40696968aabe712a95424d2bb725d35ef4e1 Reviewed-on: https://chromium-review.googlesource.com/c/1297252Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602088}
-
Robert Liao authored
I helped start this, so I guess it's fair that I also do the reviews. BUG= Change-Id: Ic3622f28207380159626903ffbbe34f60bd73b43 Reviewed-on: https://chromium-review.googlesource.com/c/1297350 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#602087}
-
Aiden Benner authored
Previously the generated jni method name for org.chormium.jni_example.foo() would collide with the name org.chromium.jni.example.foo() because . would be replaced with _, but _ in class/package/method names were not escaped. Change-Id: I3911a278c1b5d67269e4c746e114262c4fb36629 Bug: 898261 Reviewed-on: https://chromium-review.googlesource.com/c/1297075Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Aiden Benner <abenner@google.com> Cr-Commit-Position: refs/heads/master@{#602086}
-
Joey Arhar authored
Bug: 896828 Change-Id: I6376b04e01e962e45e1b1218097e8446d26dc3b3 Reviewed-on: https://chromium-review.googlesource.com/c/1289511Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#602085}
-
Mike Wasserman authored
Close touch selection ui in Mash on events outside the browser window. (global pre-target handlers are not supported in window service clients) This follows and refines the new pattern in TouchSelectionControllerImpl. Bug: 896973, 884394 Test: Text touch selection ui hides as expected in Views and Content. Change-Id: Iedba63a7ce5d5f70f9763cf540d26ee69cee5f28 Reviewed-on: https://chromium-review.googlesource.com/c/1292274 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#602084}
-
Ken Rockot authored
This races with session initialization and can cause display prefs to fail to be saved properly. Exposed pretty consistently when making subtle changes to Mojo dispatch timing. The fix forces DisplayPrefs to wait for the first user session to be started if a storage attempt happens prior to that. Bug: 872074 Change-Id: I40f9070b6a6421e8fa3bef2da44ab9e854d3d3c8 Reviewed-on: https://chromium-review.googlesource.com/c/1296547Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#602083}
-
gogerald authored
This CL is based on: https://chromium-review.googlesource.com/c/chromium/src/+/1292430 Bug: 806868 Change-Id: Ib5f1f7eb55d899161d43d60b685f126c51f0c85a Reviewed-on: https://chromium-review.googlesource.com/c/1292590 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
-
Jun Mukai authored
When window is hiding, there are several mojo messages are exchanged and then Ash will pick up the new focused window and notifies to the client through OnWindowFocused(). If the OnWindowFocused() happens between SetFocus(nullptr) and its response, the client will ignore the new focus. Since SetFocus(nullptr) is anyways ignored on the server, this means the client shouldn't send SetFocus(nullptr). It should reset the focus within the client, but it shouldn't propagate to the server. BUG=897875 TEST=manually checked, the edits on the tests clarify the case too Change-Id: I33439664354ee8fad646fe4b96682e6b726a794c Reviewed-on: https://chromium-review.googlesource.com/c/1296680Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#602081}
-
Steven Bennetts authored
This CL removes RootWindowController::ActivateKeyboard and DeactivatteKeyboard and replaces them with calls into AshKeyboardController, simplifying the relationship. Bug: 843332 Change-Id: I78cde4b9b22ba1c9406cbc44dc90af41d4ce37bb Reviewed-on: https://chromium-review.googlesource.com/c/1294691 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#602080}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f4c4ce79c2d8..76181e617aa7 git log f4c4ce79c2d8..76181e617aa7 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 hidehiko@chromium.org Update paladin board assignment for bvt-tast-cq. Created with: gclient setdep -r src/third_party/chromite@76181e617aa7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I295e003e754de5d83be04c06d812fb3165c23ee2 Reviewed-on: https://chromium-review.googlesource.com/c/1297003Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602079}
-
Michael Spang authored
This uses some deprecated Intel mesa APIs but isn't actually Chrome OS specific. Remove it to minimize Chrome OS #ifdefs. Bug: 898234 Test: compile Change-Id: I855e734646e0ff7b57150cf9d342156ea5a693aa Reviewed-on: https://chromium-review.googlesource.com/c/1297239Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602078}
-
Siddhartha authored
If the sampler stoped a thread at prolog of a chrome function, use the LR register to find the next return address. BUG=859260 Change-Id: Ic20d793ee11a8b0fe3edc9438c0f12ccc19f487c Reviewed-on: https://chromium-review.googlesource.com/c/1265560 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#602077}
-
Stephen McGruer authored
This CL renames AnimationWorkletThread to a new class, AnimationAndPaintWorkletThread, in preparation for doing off-thread PaintWorklet. The idea is that both AnimationWorklet and PaintWorklet will share the same thread, since both do similar operations and we don't need a separate thread for each. Bug: 890759 Change-Id: Id9c78fa726ee2c04336ffc824cf9cdff285eed5c Reviewed-on: https://chromium-review.googlesource.com/c/1286285Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#602076}
-
Roger Tawa authored
Bug: 896530 Change-Id: Ifb2c9fae46e8a8c0c02d23fd5a3f36cd1a183cff Reviewed-on: https://chromium-review.googlesource.com/c/1294392 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I6afca89e560fcfb120e034541e406c82f6d61d01 Reviewed-on: https://chromium-review.googlesource.com/c/1297015Reviewed-by:
-
Evan Stade authored
Bug: 898169 Change-Id: I2cd883b81a111242691b038ff512652e5faa2a94 Reviewed-on: https://chromium-review.googlesource.com/c/1297055Reviewed-by:
-
Aaron Krajeski authored
Bug: 894043 Change-Id: I903e42cd2e3673d945864fff6e8386890d4eb410 Reviewed-on: https://chromium-review.googlesource.com/c/1293760 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#602072}
-
Bret Sepulveda authored
TBR=japhet@chromium.org Bug: 898050 Change-Id: I1f64b414a4e699104ed855cd1a048c1be604c4ec Reviewed-on: https://chromium-review.googlesource.com/c/1297230Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#602071}
-
David Black authored
This CL: - Stops ChromeVox from speaking when the mic is opened for Assistant. - No longer focuses ActionView when switching to voice input modality. Bug: b:116139555, b:116143886 Change-Id: Ibdd316f6ed83b856adeaae7fd3ddd3796951348f Reviewed-on: https://chromium-review.googlesource.com/c/1263564 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#602070}
-
Aiden Benner authored
When the generated jni methods are hashed it's difficult to debug jni headers. This change adds javadoc comments to the generated jni methods with type information. e.g. class GEN_JNI { /** * org.chromium.example.jni_generator.SampleForAnnotationProcessor.bar * @param sample (org.chromium.example.jni_generator.SampleForAnnotationProcessor) * @return (org.chromium.example.jni_generator.SampleForAnnotationProcessor) */ public static final native Object MYz$E75A(Object sample); } Change-Id: Ia0ffa2f36de9f20aae8841c1e25e9d02517f861f Bug: 898261 Reviewed-on: https://chromium-review.googlesource.com/c/1296989 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: -
chrome://accessibilityJames Wallace-Lee authored
When the "Copy tree" button is pressed, request a new tree dump and copy to clipboard directly from the response. If the tree is displayed on the page, update it there as well. Users can copy the tree immediately, rather than clicking "Show tree" and then copying from the DOM. Change-Id: Iace12fac301e860571067645c7cf42ab76be7051 Reviewed-on: https://chromium-review.googlesource.com/c/1277552 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
This might be causing cascading failures in the suite, which I'm unable to reproduce locally. TBR=skyostil@chromium.org Bug: 867447 Change-Id: Ia34f8a01386f21df0550f146c5cac544fba96c90 Reviewed-on: https://chromium-review.googlesource.com/c/1297180Reviewed-by:
-
Scott Violet authored
Prior to this patch the window-service would send keyevents to clients without waiting for an ack. This is problematic for a number of reasons, primarily that it can lead to out of order keyevents. Out of order happens because some events are acked earlier than others from IME. This patch also wires up making the window service wait until the renderer respond to events as well, which is crucial to ensure ash's post-processing accelerators work. BUG=891489 TEST=covered by tests Change-Id: Ifbc852633e996cf9175c2796c6e61ebda027d00a Reviewed-on: https://chromium-review.googlesource.com/c/1292001 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Nate Chapin authored
This reverts commit 1af94601. Reason for revert: Broke some layout tests (https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzFhZjk0NjAxZGE0YzNhZTA1MTE2NGRhYmUyNzcxMjUyYTFlYjc5OGUM) Original change's description: > Include the fragment in error urls from top-level worker scripts > > Bug: 655458 > Change-Id: I7131b6246231d5322e104626bf490b36b2f52c7c > Reviewed-on: https://chromium-review.googlesource.com/c/1287260 > Commit-Queue: Nate Chapin <japhet@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601967} TBR=hiroshige@chromium.org,japhet@chromium.org,kouhei@chromium.org,leszeks@chromium.org Change-Id: Ie97652d552159371fa30b71b16fa5d9be3249f76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 655458 Reviewed-on: https://chromium-review.googlesource.com/c/1297244Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#602065}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/edf3f7cb5e2e..4624f363d41a git log edf3f7cb5e2e..4624f363d41a --date=short --no-merges --format='%ad %ae %s' 2018-10-23 oysteine@google.com Merge "Chrome TracedValue proto messages" Created with: gclient setdep -r src/third_party/perfetto@4624f363d41a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I57650791786d9c2fd78711969164f408105da246 Reviewed-on: https://chromium-review.googlesource.com/c/1297012Reviewed-by:
-
Gabriel Charette authored
Extracted from https://chromium-review.googlesource.com/c/1278631 after the change to this file become no longer necessary in the reland. TBR=zhongyi@chromium.org Bug: None Change-Id: I00d32602db9fdf582281a7368cc7da214f6c636a Reviewed-on: https://chromium-review.googlesource.com/c/1297132Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#602063}
-
Johannes Henkel authored
This is in preparation of referencing this type from the code generated by third_party/inspector_protocol/code_generator.py. My overall WIP change is in here, and happy to explain more: https://chromium-review.googlesource.com/c/chromium/src/+/1244719 Bug: chromium:891377 Change-Id: I74836b74df4a3009670d8193c6b6bbd179c22fb8 Reviewed-on: https://chromium-review.googlesource.com/c/1280210Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium db533a7b. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26609 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I7cb02d2d5abc4ee69b4f63712de205ba22e719d9 Reviewed-on: https://chromium-review.googlesource.com/c/1296813 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#602061}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7d5d4ab1dd6f..df56c1dae15e git log 7d5d4ab1dd6f..df56c1dae15e --date=short --no-merges --format='%ad %ae %s' 2018-10-23 chiniforooshan@chromium.org Telemetry: detect telemetry target renderers Created with: gclient setdep -r src/third_party/catapult@df56c1dae15e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890757 TBR=sullivan@chromium.org Change-Id: I990e0cd37b20572248f5c1699b002cd3ba6adf50 Reviewed-on: https://chromium-review.googlesource.com/c/1297112Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 888922 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icb6a31e501a5fbad60faa06cf8577c5212624e96 Reviewed-on: https://chromium-review.googlesource.com/c/1265090 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602059}
-
Carlos IL authored
Bug: 752372 Change-Id: Id083cb05a837169140b2b3b7464b92aebfa7a409 Reviewed-on: https://chromium-review.googlesource.com/c/1297004 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#602058}
-
Nico Weber authored
Bug: 324079 Change-Id: I06c556660ab05975b5a0726cf7e3e72afa9ed070 Reviewed-on: https://chromium-review.googlesource.com/c/1296675Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602057}
-
Stephen Chenney authored
R=rkaplow@chromium.org,holte@chromium.org Change-Id: I38032ef08548a443e09591dcf6f4f9e9523e6568 Reviewed-on: https://chromium-review.googlesource.com/c/1293793Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#602056}
-
Shimi Zhang authored
P SDK is rolled to public, we can inline these two methods now. Bug: 850652 Change-Id: Ib2828752bdda8be5ba4f1e1d5fc84c7fd315db79 Reviewed-on: https://chromium-review.googlesource.com/c/1289434Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#602055}
-
Tom Anderson authored
This is to green up the Google Chrome Linux bot [1]. NaCl now has the same SIs as Chrome [2]. They are: WelsThreadPool.cpp atomicops_internals_x86.cc debugallocation_shim.cc iostream.cpp spinlock.cc [1] https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/36988 [2] https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_Linux_x64/36988/+/recipes/steps/sizes/0/stdout BUG=896171 R=thakis Change-Id: Ibcb553b9790b08e46e46b6eb343183f4de60b888 Reviewed-on: https://chromium-review.googlesource.com/c/1296049 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602054}
-
rbpotter authored
Print Preview's destination and capabilities update process works as follows: (1) The destination associated with the destination-list-item selected by the user is sent to the destination store. Call this item-destination. (2) destination store sets |selectedDestination_| to the destination in its destinations map that has a matching key to item-destination, and requests capabilities for item-destination. (3) When capabilities are returned from the handler, the store updates |selectedDestination_| if item-destination, the destination for which they were retrieved, matches |selectedDestination_|. (4) This update transitions the UI to a ready state. When the user signs in successfully, the destinations map is completely reset. The Save as PDF destination is recreated just after reset and the recreated Save as PDF printer is added to the map. However, this was not triggering an update to the destination associated with the destination-list-item displaying the Save as PDF printer, because the new Save as PDF destination has all the same properties as the old one. As a result, if this destination was selected, the capabilities were retrieved for the old Save as PDF destination, while the |selectedDestination_| was the new destination. This mismatch caused the destination update event to never be fired, so the UI was stuck in a non-ready state. This CL forces the destination list used by the destination-list-items to update when the destination store updates its map, which ensures the list item for the Save as PDF printer gets the updated Save as PDF destination from the destination store's map. Bug: 895769 Change-Id: I1052609eddb2c240ece4e3132b829fb6b10ef35c Reviewed-on: https://chromium-review.googlesource.com/c/1284708 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Adrienne Walker authored
These were including cases where we have no mask layers at all, which throws off the numbers. Bug: 590373 Change-Id: If8d05478737416a2f073598210c8fbc549fafce7 Reviewed-on: https://chromium-review.googlesource.com/c/1295591 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#602052}
-
