- 03 Dec, 2020 40 commits
-
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012030600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/SDoonf2Hkjiq08J3Ms2EUYh3QtvIsKK630F0L4wd46gC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/173978830,b/174603791,b/174637068 Tbr: media-app@grotations.appspotmail.com Change-Id: I4b2504c38e7441bd375fc733e3f4bf8c6a9980f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568299Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833328}
-
Bruce Dawson authored
Windows 7 no longer works for building Chromium and nobody has volunteered to add support and Windows 7 is an unsupported OS so this change formalizes that Windows 10 is now required in order to build Chromium. This updates the documentation and modifies one of the build scripts so that a readable error message will be displayed when building on Windows 7 is attempted. Chromium and its derivatives still run on Windows 7. This only affects developers. Bug: 1150302 Change-Id: I1874c691a1405482232323bef025aba4b3ac74b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570075Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#833327}
-
Sigurdur Asgeirsson authored
TBR=sky@chromium.org Bug: 1145565 Change-Id: I1d75d411e4ba1ded30bcd20f194ad50947802858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564390 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#833326}
-
Camillo Bruni authored
Add ScriptResource::ScriptType in preparation for module streaming and stop sharing ScriptResources with different ScriptTypes. Currently the ScriptResource creates the ScriptStreamer which in turn is responsible for creating the v8::ScriptCompiler::ScriptStreamingTask. To support module streaming compilation we need to pass on the script type from the fetch location to V8. Bug: 1061857 Change-Id: I6d8d032b0f42dca904493f1e80b0ff31878aa123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556942 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#833325}
-
Ewann authored
This CL moves utils to /ui/table_view/*. ChromeTableViewStyle() was defined in Settings utils except this method will apply to all TableViews. Bug: 922511 Change-Id: I3f86ff0b346448ccbce134e56750b2996fc00ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567885Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#833324}
-
Scott Violet authored
BUG=none TEST=none, this is purely a documentation change. Change-Id: I4ae57d20be33b23a4d3bf3398e3bd3586621caba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567340Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#833323}
-
Hiroshige Hayashizaki authored
Reflecting https://github.com/WICG/import-maps/pull/227 Bug: 848607, https://github.com/WICG/import-maps/issues/166 Change-Id: Ide80e105fc57dfa35a66051b241b699fa969fcec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491594 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#833322}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ee0f9db82db..c9f76ea16b75 2020-12-03 alexrudenko@chromium.org Capture page screenshot on e2e timeout errors 2020-12-03 tvanderlippe@chromium.org Add missing semicolons in TypeScript files 2020-12-03 andoli@chromium.org Add documentation to ActionRegistration interface If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9f74741076d6a35cdf69ab63edfa29df974261c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571188Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833321}
-
Liquan (Max) Gu authored
PaymentUiService provides two APIs, getPaymentApps, getPaymentAppsInPaymentAppList, which returns a list of EditableOptions, PaymentApps respectively. This CL combines the two APIs for simplicity and made necessary changes to the use cases. Bug: 1025619 Change-Id: I88d5e9cf8ce881fdd87266c077482ae65c32669f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570748Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833320}
-
Ankit Kumar 🌪️ authored
Add AccessibilityTextRunInfo in pdf/ to replace usage of PrivateAccessibilityTextRunInfo. PrivateAccessibilityTextRunInfo is a Pepper struct. The new struct ensures that PrivateAccessibilityTextRunInfo is scoped to parts specific to Pepper implementation. Bug: 1144444 Change-Id: Id3efb8ba95a25b3955213f9ddf2ed0f5d5d55232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560092 Auto-Submit: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#833319}
-
Hans Wennborg authored
Bug: 1155145 Change-Id: I017435298a7e860f42f3d36ac27c6fc7a2e55841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571098 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4b10d58fc905..f9433fa316c9 2020-12-03 jlavrova@google.com Fixing some round problems with metrics If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I273434292646a8a39e4752d09e76cd6f0064d68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570130Reviewed-by:
-
Hiroshige Hayashizaki authored
WPT side: https://github.com/web-platform-tests/wpt/pull/26733 WICG side: https://github.com/WICG/import-maps/pull/237 After these PRs, the data-driven JSON files are identical in the WPT and WICG repositories. This CL (WPT side) mostly imports changes from WICG repository. -expected.txt are added because the spec-side updates corresponding to the newly imported tests are not yet implemented in Chromium, and will be removed in upcoming Chromium CLs: https://chromium-review.googlesource.com/c/chromium/src/+/2491594/ https://chromium-review.googlesource.com/c/chromium/src/+/2570012/ Bug: 848607 Change-Id: Iad3e04a785474ad5844bfcd47dcc7c65691a9a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570445 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833316}
-
Hiroshige Hayashizaki authored
Just to plumb message correctly. Bug: 848607 Change-Id: I753963ba5a25da085e60c7ac0bd2f8466aaa3aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570020Reviewed-by:
-
Michele Mancina authored
[AutofillAssistant] Switch from the now deprecated TextSmall_Disabled text style to the textsmall_secondary. Screenshot of the before and after, which received our UX greelight, is in the linked bug. Bug: 1118226 Change-Id: I19a04fe6bb79597d62fff05b9d41e00051abf533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567167 Auto-Submit: Michele Mancina <micantox@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Michele Mancina <micantox@google.com> Cr-Commit-Position: refs/heads/master@{#833314}
-
Arthur Hemery authored
Adds tests verifying that fetch takes into account the CORS-RFC1918 restrictions regarding secure contexts. These tests are ran with the CORS-RFC1918 flag as a virtual suite because the flag currently breaks other non related tests due to inheritance rules not being implemented. Bug: 1138907 Change-Id: I0b5241c0ed13b4b6247310f19fdd0889351ee54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517593 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#833313}
-
Jan Wilken Dörrie authored
This change removes WellKnownChangePassword from fieldtrial_testing_config.json. The feature is fully launched via Finch, and the feature flag is enabled by default. Bug: 927473 Change-Id: I8911caedf02b22b1c0f4d466f71487be4268c4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571361 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#833312}
-
Michael Lippautz authored
Bug: 1154667 Change-Id: I8a838150309b3ebab3b41fe9d07cb6ab1fd7114c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571282 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#833311}
-
Sergei Glazunov authored
This CL fixes a performance regression introduced by r829145. When both partition cookies and reference counts are disabled at compile time (which is the current default configuration), |AdjustSizeForExtrasAdd| and similar functions become no-op. Make the compiler aware of that. Bug: 1150917 Change-Id: I24e91177d4575a5ea013a9c647641c6389aa01a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571281Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Sergei Glazunov <glazunov@google.com> Cr-Commit-Position: refs/heads/master@{#833310}
-
Colin Blundell authored
Following sky@'s feedback on a similar API, this CL adds version checks and proper javadoc comments to two APIs that were added on Navigation in 89. Bug: 1145983 Change-Id: I13f5171bd979829e28e9fea3915aa48048f1cfc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570373Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#833309}
-
Colin Blundell authored
This CL adds showing of the (now-componentized) ads blocked infobar in WebLayer. This presentation is made in //weblayer's SubresourceFilterClientImpl as directed by //components/subresource_filter. The implementation is adapted from that of //chrome's ChromeSubresourceFilterClient, but simplified: - We leave interaction with content settings for followup work - We do not track whether the infobar has previously been shown for the current navigation. The reason is that ContentSubresourceFilterThrottleManager already does such tracking itself in its MaybeShowNotification() method, so the client should never actually receive a duplicate request to show a notification for a given navigation. We also add a browsertest that the infobar is presented when a resource is blocked and is removed when navigating away from the page with a blocked resource. Note that while it would be useful to also add tests in Java, we can't at this time due to crbug.com/899903. We leave implementation of the reload functionality that the user can trigger via the infobar for a followup CL. Bug: 1116095 Change-Id: Icb182143b0d27de5f03efc88ce8013be3c5c91d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563549 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#833308}
-
Javier Ernesto Flores Robles authored
Tests that actions are correctly parsed as startup parameters and the right histograms are recorded. Fixed: 1144460 Change-Id: I67ce19d41f1bef8f41357ccd075f426303d74964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568753Reviewed-by:
-
sczs authored
The NTP refactoring will move quite a lot of code from content_suggestionswhere I'm already an Owner. Also, this way I'll be able to reviews these changes. Bug: 1114792 Change-Id: Ie82ea0525aafcb6c87c2c1a4bd9cce1188e238e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570089 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Marc Treib authored
Many parts of DataTypeManagerImpl that talked about "downloading" actually had little to do with downloading (mainly, it was about calling ModelTypeConfigurer::ConfigureDataTypes(), which does the actual downloading). This CL replaces "download" with "configuration" in those places, to make clearer what's going on. In particular, StartNextDownload is renamed to StartNextConfiguration, and DownloadCompleted to ConfigurationCompleted. Bug: 1102837 Change-Id: Ibcdb85f9f1177689e05e915d597b4241576f3b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570370 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#833305}
-
sebsg authored
Bug: 1155125 Change-Id: I7552959b6a7c8b9e3f82f49f63556d23e31f7c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570747Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833304}
-
Sean Gilhuly authored
The LapTimer in RendererPerfTest is initialized from a command line flag, but the LapTimer in SurfaceAggregatorPerfTest is only default constructed. Move LapTimer initialization to a VizPerfTest superclass to unify the setup logic. Bug: 1154343 Change-Id: I6fd02b26396368b82d3f1360129ef5f38c1a2c7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567625 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#833303}
-
Anton Bikineev authored
GCed optionals on stack are fine. Change-Id: If5a6fd603f06c376167a93b790df4970289a2663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566937Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#833302}
-
Daniel Libby authored
The alleged bug no longer hits, so these tests can be re-enabled and the bug closed (last reference to this in the source tree). Bug: 545547 Change-Id: I74469684932ba2bb61a8ac91a522024ac24dc328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570540 Auto-Submit: Daniel Libby <dlibby@microsoft.com> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#833301}
-
ckitagawa authored
This might save on binary size, but regardless it is good to change. This was made a static_library at project start and should have been a source_set. Change-Id: I925848a98d299c106e007f1770d54b984f414e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570239 Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833300}
-
Nohemi Fernandez authored
This patch adds a metric to track when the user attempts to add an account to the web when they are already signed in to Chrome. This situation is possible when all GAIA cookies are removed from the web during a user session. Bug: 1154244 Change-Id: I3818d6ad6fcae014d381ccaf67ab9e0a46025ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566755 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#833299}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9d937e6cbed6..877fbcb69179 2020-12-03 primiano@google.com Merge "Docs: improve reference" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia0971f586e027c45609fb77f007bf589b9442871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567428Reviewed-by:
-
Clark DuVall authored
Now that bundletool has been updated and isolated splits support JNI in DFMs, we can bring back the vr module. This requires telling the native code which split to load the vr module from. See crbug.com/1145287 for more context. Bug: 1145287 Change-Id: I594d98b1cff002e5966700487fd906f25de109cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569783 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#833297}
-
Etienne Pierre-doray authored
Previously, job_task lifetime in gin was bound to handle. This was fine until we exposed CancelAndDetach, where worker_task are allowed to run beyond handle lifetime. job_task lifetime must thus be extended to match worker_task. This CL also adds a gin test. Drive by: Fix IsRunning->IsValid calls in tests. Change-Id: I1f67d9c759e5b1a6fbc98de909a194df2001f087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566724Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#833296}
-
Francois Doray authored
Experiment results: https://docs.google.com/document/d/1Fpq31rNHiMHorCygu_1krpIun_0J1ePfef6lf1l4PLA/edit?usp=sharing Bug: 1075553 Change-Id: I63b893fb7e4fef9269d498c03f95b4cd201133b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568213Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#833295}
-
Antonio Gomes authored
... instead of pixels. It happens today that WaylandCursorPosition stores the last mouse position in pixels, instead of DIP. In lacros, this position is queried by the call to `display::Screen::GetScreen()->GetCursorScreenPoint()` in `ImmersiveFullscreenController::UpdateLocatedEventRevealedLock()`, for instance by hovering the mouse cursor over the upper display boundary in immersive fullscreen mode, so that the tabstrip slides down. When a high DPI display is used, the mismatch occurs. This CL changes WaylandCursorPosition to store the last mouse cursor position in DIP, instead of pixels. BUG=1153998, 1113900 R=msisov@igalia.com Change-Id: Id37ee61de4d22b8ffd190b403df91fd87e198007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569775Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#833294}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a45552c0f29d..9d937e6cbed6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0db11aede2dfac049c7bdadc2ba23f7e871236ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571059Reviewed-by:
-
Eric Willigers authored
Web apps on Chrome OS may use the Web Share API to send title, text and/or url, in addition to files. If title, text and/or url ShareData fields have been supplied, they are used to set the text and title for the Intent. If the web app is sharing both a text string and a URL, we combine them into a single string, with a space separator. The same approach is already taken on Android: https://source.chromium.org/chromium/chromium/src/+/master:components/browser_ui/share/android/java/src/org/chromium/components/browser_ui/share/ShareHelper.java;drc=28d989a1fc83edb779c034cad48572775696bc66;l=357 Not yet implemented or tested: sharing title/text/url without files. Design doc: https://docs.google.com/document/d/1EjpgseTbBhT9ogQv6HV6sLlBl4hpb2viOcmPtFJorMQ/edit# Bug: 1127670 Change-Id: Ie56a372816602b71ff386dc1094be61610d70a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569329 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#833292}
-
Michael Lippautz authored
Bug: 1154667 Change-Id: I421ba6c9d6513dae3a66bddfd50a2de67e4046eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571283 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#833291}
-
Antonio Sartori authored
This reverts commit a1e3b5ad. Reason for revert: Breaks browser_tests All/SharesheetBubbleViewBrowserTest.InvokeUi_Default on Linux Chromium OS ASan LSan Tests (see https://crbug.com/1155058) Original change's description: > [Sharesheet] Refactor SharesheetServiceDelegate. > > This CL refactors sharesheet_service_delegate to be identified > by its native_window. This is so that we can ensure only one > sharesheet for any one native_window at any time. > > Bug: 1142706 > Change-Id: I7892bb5b95f6ab4fa17c772e173084b11e3ab69f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563010 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833098} TBR=dominickn@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,melzhang@chromium.org Change-Id: I9ed8d55ae616d952f3c53d1f459ae8c65be43507 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569747Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606975184-aefe3d214a47b5e57d9dcedd54737f7057f97fb8.profdata to chrome-linux-master-1606996231-dddb4c2fad470c1e447a44fedd130c4825b70fb9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I20c30a20e2220737c1266f33afc639feabafa6ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571186Reviewed-by:
-
