GitLab

Note that there will be a separate CL with password page formatting
because it requires some additional tweaks.

Specs:
https://drive.google.com/file/d/1UqHV67OrdGT0_G0L98nV5IVr26OkHu9F/view?usp=sharing

New change screenshots:
Start Setup Page: http://screen/1PkWGgTYmVG
Setup Complete Page: http://screen/drwnruTOBNw

Bug: 878646, 878644
Change-Id: Idf2afceb75dbb1c5b0157ffd8405fceea59cff46
Reviewed-on: https://chromium-review.googlesource.com/1246781Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594468}

This change adds Start/ContinueReadDirectory methods to
SmbProviderClient. These map 1:1 to corresponding smbprovider daemon
methods.

Bug: chromium:757625
Change-Id: Idb33b81492949b5499fb402686c211948d736f00
Reviewed-on: https://chromium-review.googlesource.com/1228438
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594467}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b07993ebf420..bfcdc913c418


git log b07993ebf420..bfcdc913c418 --date=short --no-merges --format='%ad %ae %s'
2018-09-26 antiagainst@google.com [ci] Checkout a specific Google Test commit (#1931)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@bfcdc913c418

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I8cb0a648eb3496c3191c27a89892a961b60faf40
Reviewed-on: https://chromium-review.googlesource.com/1246478Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594466}

Corresponded V8 change was rolled to Chromium.

TBR=pfeldman@chromium.org

Bug: v8:8200
Change-Id: If887514a6baa6fb293a8ed600a2ca0477debbcb7
Reviewed-on: https://chromium-review.googlesource.com/1246365Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594465}

TBR=dtseng@chromium.org

Change-Id: Ie4a1691308224d015856d93cbee256f6420a0b51
Reviewed-on: https://chromium-review.googlesource.com/1246663Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594464}

This call makes no sense. There's no reason that loading the
speech synthesis component extension should trigger enabling
the filesystem in guest mode for a related, but entirely different,
extension (ChromeVox).

If ChromeVox needs EnableFileSystemInGuestMode, we should be calling
this from code that loads the ChromeVox component extension, but I suspect
that it doesn't need it at all.

As far as I can tell this was accidentally added here as part of a
refactoring:
  https://codereview.chromium.org/1162283002

Note that OnceClosure() would be better, but that'd require a big cleanup
of many other functions, so I don't want to do that as part of the same
change.

Bug: none
Change-Id: I1f67b78548048fffa9194083b10e0ff5c5aaa863
Reviewed-on: https://chromium-review.googlesource.com/1246364Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594463}

Follow-up from original review.

Change-Id: I375b2f266d3712f20efc769fc822df67701297a3
Reviewed-on: https://chromium-review.googlesource.com/1246836Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594462}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a53f1444701..1b71de973c63


Created with:
  gclient setdep -r src-internal@1b71de973c63

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I8b3480c33e076d89f23e5f059d998e31ea6c4b86
Reviewed-on: https://chromium-review.googlesource.com/1246474Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594461}

It's the exact same code, but no sense in implementing it twice.

Bug: none
Change-Id: Ie3688b2d56c80b1d513fc5eab37b04aa365417ee
Reviewed-on: https://chromium-review.googlesource.com/1246271Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594460}

This CL adds a new flag, UseSurfaceLayerForVideoPIP, which will
switch to SurfaceLayer only when entering PIP mode.  The player does
not switch back when exiting PIP.

When doing this, the VideoFrameCompositor, VFS, etc. all run on
the compositor impl thread rather than a dedicated media thread.
This is to simplify the switchover.

This CL also changes the default from Use...Video to Use...PIP.

This is based on
https://chromium-review.googlesource.com/c/chromium/src/+/1219948

Bug: 883931

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibb612d83df721712929aeab42aba790e32c1a8ea
Reviewed-on: https://chromium-review.googlesource.com/1220562Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594459}

Bug: 832676
Change-Id: Ife9b271854db2b4379d9df1869cc51eb9c2dbaa0
Reviewed-on: https://chromium-review.googlesource.com/1246722
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594458}

This reverts commit 525b54bb.

Reason for revert: Major changes to input behavior required, pushing
to later milestone.

Original change's description:
> Print Preview Refresh: Make pages a dropdown
>
> Make pages a dropdown, and only show the custom input if "Custom"
> page range is selected
>
> Bug: None
> Change-Id: If29a941ca2ff9d75f08bc1e103ac3d0a836e540c
> Reviewed-on: https://chromium-review.googlesource.com/1237241
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594076}

TBR=dpapad@chromium.org,rbpotter@chromium.org

Change-Id: Id2bbfedbf7ab5406a7a583c9acaf9fd5eeac930b
No-Presubmit: true
No-Tree-Checks: true
No-Try: false
Bug: 889382, 889383, 889389
Reviewed-on: https://chromium-review.googlesource.com/1246407Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594457}

This patch adds two fields, _initiator and _priority, to each entry in
each HAR file. I chose to use underscores in the exported names because
they are not part of the HAR standard and the other non-standard fields
we export also have underscores.

I tested by importing this new type of HAR file in chrome 69, importing
a chrome 69 HAR file with this new patch applied, and by exporting and
importing with all types of initiators.

Bug: 654536
Change-Id: Ibd96eb6374900f29b03880d3292933b539708f18
Reviewed-on: https://chromium-review.googlesource.com/1232374
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594456}

This CL removes an un-necessary included header file in the
touch_action_filter.h, there is no behavior change.

TBR=nzolghadr@chromium.org

Bug: None
Change-Id: Iebc8e3269cc96c101392a60f2717662a49b80f21
Reviewed-on: https://chromium-review.googlesource.com/1246410Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594455}

This reverts commit 701add99.

Reason for revert:  The tests introduced in original CL was failing because it was not
being run with the right flags. This happened because CL landed at the same time
as another CL which migrated all the tests. Moving test and updating expectations
accordingly.

https://chromium-review.googlesource.com/c/chromium/src/+/1237235

Original change's description:
> Revert "[animation-worklet] Transfrom related worklet animations should respond to zoom"
>
> This reverts commit dec72e86.
>
> Reason for revert:
> virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html seems to be failing most of the time on all platforms.
>
> Sample failures:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/91172
> https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/146546
> https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/193114
>
> Original change's description:
> > [animation-worklet] Transfrom related worklet animations should respond to zoom
> >
> > Worklet animation compositing state should be updated when a zoom or viewport
> > resize changes css pixel to dip ratio.
> >
> > The fix is to simply match what we already do for regular animations for worklet
> > animations.
> >
> > TEST=virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html
> >
> > Bug: 879107
> > Change-Id: I0b74bd8297e83b18afd087247f09339aedcc618b
> > Reviewed-on: https://chromium-review.googlesource.com/1237133
> > Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
> > Reviewed-by: Majid Valipour <majidvp@chromium.org>
> > Commit-Queue: Majid Valipour <majidvp@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#593171}
>
> TBR=majidvp@chromium.org,smcgruer@chromium.org
>
> Change-Id: I9eaf621c931ad9003fd7413aeea9f2ec3a7824a4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 879107
> Reviewed-on: https://chromium-review.googlesource.com/1239773
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593414}

TBR=mmenke@chromium.org,majidvp@chromium.org,smcgruer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 879107
Change-Id: Ib174c0e257c893d9cd5df3d1e6c5157b04603f44
Reviewed-on: https://chromium-review.googlesource.com/1243572Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594454}

Partners will frequently share debug logs to provide context when filing
a bug or diagnosing a problem. Feedback reports have this information,
but it's not stored in any of the files that are packaged up with debug
logs.

This commit follows the CL below, which makes debugd responsible for
fetching the lsb release contents:
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1217083

BUG=chromium:880851
TEST=Manually checked chrome://system to ensure that lsb release
contents are present even after removing them from the chrome source.
Also checked that chrome://system loads properly and with correct output
when both debugd and chrome are reporting the lsb release contents.

Change-Id: I4651c5168c26ac696d5799c44126e5dcd6b4ce19
Reviewed-on: https://chromium-review.googlesource.com/1217344Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594453}

This CL makes sure DetectedText interface is serializable so that
DetectedText can easily be transfered from workers.

Change-Id: Ic5ac034ae4f472c34ae75ec001cfda5af97cf6a9
Reviewed-on: https://chromium-review.googlesource.com/1243023
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594452}

This allows some Java code to be compiled on CQ that wasn't
previously.

Bug: None
Test: build cast_shell_apk
Change-Id: Icaa97f7fef8a805942355aac14634a270bff57e3
Reviewed-on: https://chromium-review.googlesource.com/1241847Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594451}

Relax redirect safety checks, which exist in the network
service but were not present in URLRequestJob, to allow
the loading of a file/filesystem scheme to redirect to
the file/filesystem scheme.

One example of a redirect is where the following URL:

  file:///path/to/directory

during reload is redirected to:

  file:///path/to/directory/

This change also fixes redirects of Windows file links
(with network service) as it redirects back to the client
before following the redirect. This avoids an infinite
recursion bug triggered by circular symbolic links.

Bug: 884277,887039
Change-Id: I13923fc29397b1d3aa6679d861e9edc3af1c816b
Reviewed-on: https://chromium-review.googlesource.com/1234335Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594450}

Changed ScriptDuration to exclude recalc style and layout durations.

Introduced OtherTasksDuration metrics that tracks task time that is
is not accounted for in other metrics.

Change-Id: Id68d8eaaf4fa0264eeae7995d71632e71b212537
Reviewed-on: https://chromium-review.googlesource.com/1244245Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594449}

From what I can tell, we changed the translate UI on desktop from an infobar
to a bubble; this transition is completed with macviews.

Try to make this a bit more explicit in the code.

Also rename SESSION_CRASHED_INFOBAR_DELEGATE_MAC_IOS to SESSION_CRASHED_INFOBAR_DELEGATE_IOS
since it's no longer used on Mac, and remove a browser_test for it
that was dead code.

Bug: 832676
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id979dc996a49dabe5a073e53d1b3f60616316878
Reviewed-on: https://chromium-review.googlesource.com/1246024Reviewed-by: Rachel Blum <groby@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594448}

https://skia.googlesource.com/skia.git/+log/03a36fd1b06d..6c6bd073ee01


git log 03a36fd1b06d..6c6bd073ee01 --date=short --no-merges --format='%ad %ae %s'
2018-09-26 benjaminwagner@google.com Revert "[infra] Enable QuadroP400 bots on rack:2"
2018-09-26 robertphillips@google.com Fix bug in GM's DDL drawing mode


Created with:
  gclient setdep -r src/third_party/skia@6c6bd073ee01

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=bsalomon@chromium.org

Change-Id: I9c19b7d5763560ea168ad7ede72077b3729e173f
Reviewed-on: https://chromium-review.googlesource.com/1246475Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594447}

This reverts commit 9594a943.

Reason for revert: https://crrev.com/c/1217506 is causing crashes in Canary (https://crbug.com/889422). Reverting this CL is necessary in order to be able to revert that CL.

Original change's description:
> [FileSystem] Add support for selecting multiple files or directories.
> 
> Bug: 878581
> Change-Id: I65fc0029da2e3951495a6cd96704085e5c1b942c
> Reviewed-on: https://chromium-review.googlesource.com/1227366
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594132}

TBR=dcheng@chromium.org,dmurph@chromium.org,mek@chromium.org

Change-Id: I8af7db79f5156bc354ade87b2ac5e31955b41cc3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878581
Reviewed-on: https://chromium-review.googlesource.com/1246862Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594446}

it's flaky.

TBR=rsesek@chromium.org

Bug: 888308
Change-Id: If250e1233fe58cc699358e879cbedc2ff797760c
Reviewed-on: https://chromium-review.googlesource.com/1246829Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594445}

A lot of c/b/u/cocoa/fullscreen is still used to implement views-mode
fullscreen.

Bug: 832676
Change-Id: I58ae4caff28d69c1be047c079b1ea95ae7a486e0
Reviewed-on: https://chromium-review.googlesource.com/1246601Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594444}

Change-Id: Ie928765aba5e902396fa2272b56ed322386d8f29
Reviewed-on: https://chromium-review.googlesource.com/1241772Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594443}

Change-Id: Ic2248c098bf0f7c965ae09ebcbf552a0bebf430e
Bug: 886965
Reviewed-on: https://chromium-review.googlesource.com/1245703
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594442}

This makes sure the MediaPlayerId of the Picture-in-Picture video is
reset when user closes Picture-in-Picture window manually or when user
requests Picture-in-Picture several times.

Bug: 879592, 889011
Change-Id: I3ceea8de7fc5ee0e2c81268154daaa065b29b92b
Reviewed-on: https://chromium-review.googlesource.com/1236276Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#594441}

http://crbug.com/866739 changed local Chromium builds to use a real "version name"
instead of "Developer Build".
WebAPKs determine whether a candidate host browser is WebAPK-compatible based on
the host browser's version-name. This CL removes the special case logic for
browsers with version-name "Developer Build".

BUG=817263

Change-Id: I0b92e78adb2e57128ee958e8b12f61c196c6c874
Reviewed-on: https://chromium-review.googlesource.com/1244360Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594440}

https://chromium.googlesource.com/angle/angle.git/+log/c84510f4a313..af8b73c9e632


git log c84510f4a313..af8b73c9e632 --date=short --no-merges --format='%ad %ae %s'
2018-09-26 jmadill@chromium.org Roll dEQP (September 2018)
2018-09-26 geofflang@chromium.org Vulkan: Expose EXT_debug_marker and stub out the implementation.


Created with:
  gclient setdep -r src/third_party/angle@af8b73c9e632

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Change-Id: I7d427fe3ef1c2c0e5c3ab5265aac887f20bb521f
Reviewed-on: https://chromium-review.googlesource.com/1246236Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594439}

This reverts commit bef92b91.

Reason for revert: Suspected cause of build failure on Android Cronet Builder:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20Cronet%20Builder/47611

Original change's description:
> Define basic Trichrome build targets.
> 
> This defines basic build targets for a Trichrome build using the
> upstream package names/configuration. The shared library APK contains
> the 32-bit version of libmonochrome.so and a few autogenerated Java
> pieces only at this stage, which means the total size of the three APKs
> is significantly larger than Monochrome at present.
> 
> Bug: 887078
> Change-Id: I3fcdfd6d7f717665a15c05dbb53602deda526b73
> Reviewed-on: https://chromium-review.googlesource.com/1135546
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Commit-Queue: Richard Coles <torne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594394}

TBR=digit@chromium.org,torne@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,tobiasjs@chromium.org,tiborg@chromium.org

Change-Id: I1b20b37aa40558e28c3c8e98aeb7a8a2b8220cf2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 887078
Reviewed-on: https://chromium-review.googlesource.com/1246833Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594438}

This CL adds methods to get set and remove wallet metadata from the
autofill table. These methods will be used by the new USS bridges.

Next CL will update existing code to use these new methods.

Change-Id: I611ad84dca5ca9daacde4aafeefc3cce4f459182
Reviewed-on: https://chromium-review.googlesource.com/1244816
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594437}

If NSApp is used prior to instantiation of the NSApplication subclass, then the
subclass will never be instantiated.

This CL adds a CHECK to confirm that the subclass is correctly instantiated.

This CL found several tests which were unnecessarily instantiating a UI Message
Loop early in the lifetime gtest subclass, which ends up calling NSApp prior to
NSApplication subclass instantiation.

Change-Id: I8868d253b6ec6eff4f8ecdda3176d839aa1826a5
Reviewed-on: https://chromium-review.googlesource.com/1246861Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594436}

Update the config for OfflineIndicator and IncognitoStrings features

Disable OfflineIndicator feature in one FullscreenManagerTest.java due
to that the appearance of offline indicator will  prevent the test from
getting certain UI element.

Bug: none
Change-Id: I1abb884a4e76838bc5dd2e9134de51697a4e9c43
Reviewed-on: https://chromium-review.googlesource.com/1241201
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594435}

This reverts commit 5f552b39.

Reason for revert: This is still breaking sizes tests
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/37804

Original change's description:
> Reland "Simplify static initializer test"
> 
> This reverts commit 239e5b82.
> 
> > The old sizes.py perf test used to check for a whole set of performance
> > regressions. This is now handled elsewhere with the exception of the SI
> > check. The SI check is fairly simple, however, and doesn't require all
> > of the the perf_expectations infrastructure which is now obsolete.
> >
> > This CL removes the obsolete perf_expectations, hard codes the expected
> > number of SIs in the script, and removes the windows and android code
> > as it doesn't actually do anything.
> >
> > Bug: 572393
> 
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng
> TBR=dpranke
> 
> Bug: 572393
> Change-Id: Iad25e02aba593632f167bb534be95ba6a5691446
> Reviewed-on: https://chromium-review.googlesource.com/1241935
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594389}

TBR=thakis@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org

Change-Id: Ifc842badf0f8630009ded00c37119eff7eaf9b1c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 572393
Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1246788Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594434}

This should allow stack traces written to stderr by base::debug::StackTrace to
show up in swarming output.

R=csharp

Bug: 871924
Change-Id: I9016603330fc2108837852a43fd17b7a04f2dffb
Reviewed-on: https://chromium-review.googlesource.com/1244552
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594433}

Change-Id: I23307974a3699c5c46cad7ccaabc83d4708ed22d
Reviewed-on: https://chromium-review.googlesource.com/1246041Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594432}

Under diff mode, previously the HTML Viewer would report very large
method (delta) counts. This was caused by the Python code assigning a
delta count of 1 (instead of 0) for changed symbols. Moreover, to
support delta count of 0, the JavaScript code change needs to be
updated to read it (i.e., cannot use "||" to assign defaults).

This CL fixes the above problems. Moreover, to reduce .ndjson file
size, 0 is used as the default symbol count under diff mode (1 is still
the defalut if one .size file is used to generate the .ndjson file).

Bug: 884985
Change-Id: I8038f8b8298073c8ced5ccf9100cf9911e533861
Reviewed-on: https://chromium-review.googlesource.com/1246280Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594431}

This is a reland of 23066c81

Original change's description:
> Enable more content_browsertests tests
>
> After crrev.com/c/1233174, failures/time outs in the associated
> bugs are gone. Enable more tests in single process mash.
>
> Bug: 877496, 884389, 884393
> Change-Id: I35a96699fbee450e0522ff84267842e96fb7c29c
> Reviewed-on: https://chromium-review.googlesource.com/1243194
> Reviewed-by: James Cook <jamescook@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594046}

Bug: 877496, 884389, 884393
Change-Id: If452611db11c3b5e6f92e66e9a1f6890acac52f7
Reviewed-on: https://chromium-review.googlesource.com/1246152Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594430}

Remove SkiaRenderer's bool that tracks whether we are drawing root
render pass or child render pass. Also leads to deleting function on
SkiaOutputSurface since it knows the current render pass id and both
functions share majority of code.

Bug: 644851
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I332012ed89f5edc825acaee4230f28bdfc271044
Reviewed-on: https://chromium-review.googlesource.com/1241734
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594429}