- 11 Oct, 2018 40 commits
-
-
Michael Moss authored
This has been migrated to tryserver.chrome.win on LUCI. BUG=731383 Change-Id: Ic74dcc5ec53ce4b44b461a182caf91a8a934f012 Reviewed-on: https://chromium-review.googlesource.com/c/1271580Reviewed-by:
Eric Foo <efoo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#598856}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2ca2969a. With Chromium commits locally applied on WPT: 65d72632 "Make DTMF tone change more deterministic" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25949 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy rego@igalia.com: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I6e3e98012f97dded6c88efb258237ea4811783dd Reviewed-on: https://chromium-review.googlesource.com/c/1276827 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#598855}
-
Sergey Ulanov authored
By default zx_vmo_create() creates VMOs that can be resized. This is potentially hazardous (process that tries to access mapped and resized VMO may crash) while we never need to resize VMOs in chromium. This change updates SharedMemoryFuchsia and PlatformSharedMemoryRegionFuchsia to pass ZX_VMO_NON_RESIZABLE to zx_vmo_create(). Change-Id: Idf48f3c21ad9b253da1c3a99ff79bcdebacccde4 Reviewed-on: https://chromium-review.googlesource.com/c/1275131Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#598854}
-
Samuel Huang authored
Change-Id: Ie637e2bfbf8ad67fbd3fb0334043a15bc477dc34 Reviewed-on: https://chromium-review.googlesource.com/c/1265127Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#598853}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f81170b48fd4..cdc959fb4240 git log f81170b48fd4..cdc959fb4240 --date=short --no-merges --format='%ad %ae %s' 2018-10-11 ilnik@webrtc.org Compute video freeze metrics on rendered frames instead of on decoded 2018-10-11 srte@webrtc.org Moves pushback controller to GoogCC Created with: gclient setdep -r src/third_party/webrtc@cdc959fb4240 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I59b30225d024b0f6d97a93c005dea272b09d3d7d Reviewed-on: https://chromium-review.googlesource.com/c/1276555Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#598852}
-
Mike Klein authored
Change-Id: Ib1ed6433c4166f42df1728d3f5e9322806a7128d Reviewed-on: https://chromium-review.googlesource.com/c/1273523Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#598851}
-
Michael Spang authored
The swapbuffers call got lost in f8ffa6f2 ("viz: Separate SkiaRenderer's code path by compositing mode") in the conversion from if/else to switch/case. Bug: 644851 Test: content_shell --enable-vulkan --disable-gpu Change-Id: I93e030f9d0f5db10b9cb05e443c8454e0ded73de Reviewed-on: https://chromium-review.googlesource.com/c/1274897Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#598850}
-
Min Qin authored
Android defaults target determination to prompt. However, in the case of resumption, we should not prompt user. Instead, we should simply uniquify the file name The issue is fixed in https://codereview.chromium.org/2618743006/ But reintroduced by https://chromium-review.googlesource.com/c/chromium/src/+/465566 BUG=894134 Change-Id: If05394eb9970f79c91770a29fc7761d41228c92e Reviewed-on: https://chromium-review.googlesource.com/c/1275129Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#598849}
-
Rayan Kanso authored
Re-resubmit cr/1261477 The issue was that there is a race condition between the abort going through, and the downloaded file being persisted on disk. I added an extra check in the WPT test. Change-Id: I98aa005b4637c08f60a126a6c7c896c1c0edfddf Reviewed-on: https://chromium-review.googlesource.com/c/1276557 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#598848}
-
Anders Hartvoll Ruud authored
The test registered-property-computation.html fails on wpt.fyi, because it assumes that the tests are run in a viewport with specific dimensions. This CL fixes that by using a standard property as a reference. For instance, to figure out the expected value in pixels for '10vw', we compute min-height:10vw and use that result as the expected value. Also added some generally useful utils, and rewrote the test using those utils to make the test more understandable. R=futhark@chromium.org Bug: 641877 Change-Id: Ie1ceb334eefee6e76015447f24148638ad8c55a6 Reviewed-on: https://chromium-review.googlesource.com/c/1275893Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#598847}
-
Pedro Amaral authored
Hide HTS toggle when accessibility is enabled. Also fixed accessibility string for tabs. I had originally followed what AccessibilityTabModelWrapper.java did but it turned out there was a bug in that class: https://bugs.chromium.org/p/chromium/issues/detail?id=886975 Bug: 892638 Change-Id: Ief4a3c65b46d75ef3ffc9eb3786c0d26eac94c7d Reviewed-on: https://chromium-review.googlesource.com/c/1275028Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#598846}
-
Anand K. Mistry authored
Better type safety, and helps minimise changes in the eventual minizip uprev. BUG=889703 Change-Id: Ie05f7fcf2d83d792326b728a0cb54d3a4b628b10 Reviewed-on: https://chromium-review.googlesource.com/c/1273996 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#598845}
-
Tanja Gornak authored
* The service shouldn't unregister from the topics, when handler the Handler is unregistering from topic (as stated in the documentation for for UnregisterHandler). * Sync shouldn't unregister on browser shutdown Bug: 801985, 876274 Change-Id: I857da7b0fbfa0a0f2e1ad05708cc24cdc9386a76 Reviewed-on: https://chromium-review.googlesource.com/c/1196522 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#598844}
-
Christian Fremerey authored
This CL moves reusable mocks for interfaces living in media/capture/video to media/capture/video, and mocks for interfaces living in services/video_capture/public/mojom to services/video_capture/public/cpp. Change-Id: I7acf2c00fd80ea079c9804e706ef2f2cb1aee0e1 Reviewed-on: https://chromium-review.googlesource.com/c/1263119Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#598843}
-
Nico Weber authored
Bug: 101600 Change-Id: Ie02ecb8c01a02be0717843c7bf064a26bc5018b8 Reviewed-on: https://chromium-review.googlesource.com/c/1276687Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#598842}
-
Shakti Sahu authored
The image view shrinks from full-width after an update. Fixed this bug. Bug: 894312 Change-Id: I71863fd36860434848d00790d189c271fe6187e5 Reviewed-on: https://chromium-review.googlesource.com/c/1275291Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#598841}
-
Michael Ludwig authored
Takes advantage of clear optimization from https://skia-review.googlesource.com/c/skia/+/160768, which is not detected when clearing is initiated via drawRect(). Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I911d4d0239dd401273f0e45b5cd3ccd3c8664859 Reviewed-on: https://chromium-review.googlesource.com/c/1271544Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#598840}
-
Mugdha Lakhani authored
of updates in failure_reason and result, everytime these change. This CL also has the effect of sending the onprogress event when failure_reason and result change upon completion of the background fetch. Change-Id: I137a73bbbddda56994b4914b677bec9cc7183993 Reviewed-on: https://chromium-review.googlesource.com/c/1264589 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#598839}
-
Stephane Zermatten authored
Scripts can include an initial_prompt value in their presentation, which should be displayed at the same time as the script is displayed. This patch adds support for that functionality. Bug: 806868 Change-Id: I8a2eafc3a257d3c52934fe5611a9f9dea5ccd8e3 Reviewed-on: https://chromium-review.googlesource.com/c/1276647 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#598838}
-
Theresa authored
Requesting layout changes while in a layout pass causes issues on JB. Making modifications to the views during the measure phase instead. Also, use the Configuration width/height to determine layout so that the view doesn't need to be measured before setting layout properties. BUG=739789 Change-Id: I85298135880c83a0308328ca1506b85b917232d4 Reviewed-on: https://chromium-review.googlesource.com/c/1276829Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#598837}
-
mrefaat authored
I also removed the tests for empty URL and invalid URL from the coordinator as it's not the responsibility of the coordinator (at least based on the code that exist now) to check for the validity of the URL. (also these tests would never fail as [application_ openURL:] was never stubbed/mocked which means it will always return NO). Bug: 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3e8946de6c520eb0a14477d625d7bb280671043e Reviewed-on: https://chromium-review.googlesource.com/c/1276888Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#598836}
-
Luke Zielinski authored
Its usage is replaced with constant kSafeBrowsingScoutReportingEnabled, which is the only pref going forward. Bug: 662944 Change-Id: Idd3603f430994262d8a5ecc5faf3dbf1aac30d64 Reviewed-on: https://chromium-review.googlesource.com/c/1273274Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#598835}
-
Anand K. Mistry authored
It isn't needed, and the logic can be folded up into the destructor. BUG=889703 Change-Id: I5734dfa886772382d8909769f0ce06c552bde4bf Reviewed-on: https://chromium-review.googlesource.com/c/1273951 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#598834}
-
Sergio Villar Senin authored
JpegCodec and JpegCodecRobustSlow both define some helper structures in anonymous namespaces. That works pretty good unless you build jumbo in which case both files could be packed together making the anonymous namespace separation not effective any more. Change-Id: Id431f830f077465de8ef198ef2e76fe6ff282529 Reviewed-on: https://chromium-review.googlesource.com/c/1275953Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#598833}
-
ccameron authored
This reverts commit b0587ce3. Reason for revert: crbug.com/894380 Original change's description: > Remove FlushForDriverCrashWorkaround > > This should be changed from an ifdef-OS_MACOSX to a gpu driver bug > workaround. > > Before making this change, disable the workaround entirely, to see if > we are still affected by the issue (the issue started seemingly > spontaneously, and may have gone away just as spontaneously). > > It will also be interesting to see the interactions between this bug and > OOP-D and OOP-R. > > Bug: 863817 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I32204403a68fecc643593813e84f0b142c16b7e0 > Reviewed-on: https://chromium-review.googlesource.com/c/1271378 > Reviewed-by: Victor Miura <vmiura@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598042} TBR=ccameron@chromium.org,vmiura@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 863817 Change-Id: Id8c275f4c515f876e795b7190c1f87bf1e0c11b5 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1276948Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#598832}
-
Rayan Kanso authored
Bug: 894525 Change-Id: I8393725c235f9d19ca3f4dfa02969bc8183abcba Reviewed-on: https://chromium-review.googlesource.com/c/1275303 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#598831}
-
Egor Pasko authored
A trivial one liner to correct the name of the function referenced. Bug: None Change-Id: If56cd25438cb55ce4919f833af1d4ceae136f483 Reviewed-on: https://chromium-review.googlesource.com/c/1276766Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#598830}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 850176 Test: none Change-Id: I4ff1cf26c2c50c7da6a8df64598877fdfa55b76d Reviewed-on: https://chromium-review.googlesource.com/c/1275142 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#598829}
-
Toni Barzic authored
The main objective is to improve test coverage in demo mode session unittests - given that cros component manager was not being set up in demo session unittests, they did not exercise code that loaded the demo mode resources component during demo session start up (instead, demo session code would default to loading the pre-installed component by direct calls to imageloader, a path that is not really expected to be hit - pre-installed component, if present, should be supported by cros component manager itself). This cl introduces a fake cros component manager and starts using it in demo_session_unittests and demo_extension_external_loader_unittests. The CL adds CrOSComponentManager interface for CrOSComponentInstaller, together with a fake implementation intended to be used in tests. Adds BrowserProcessPlatformPartTestApi class for Chrome OS BrowserProcessPlatformPart that can be used to inject the fake cros component manager in tests. This approach should support injecting the fake cros component manager in both unit and browser tests. Alternatively, the fake could be injected by a testing BrowserProcessPlatformPart override, but that would work in unit tests only. Change-Id: I8046311b4dc8a44dcbb1b10cb06e7e15cbe33dba Reviewed-on: https://chromium-review.googlesource.com/c/1267237Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiaochu Liu <xiaochu@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#598828}
-
Xiaoqian Dai authored
When a dialog is added to a window that's currently showig in splitscreen, we should adjust the dialog bounds to show the dialog aligned within its own side of the split, rather than across the divider bar. Note the divider is still placed on top of the snapped windows and its transient children if they are placed in default container. Bug: 878268 Change-Id: Ibdd71f1d42aac419ef73ae9f7a2f78af6bf36880 Reviewed-on: https://chromium-review.googlesource.com/c/1274197 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#598827}
-
Peter K. Lee authored
Check user installation date against intended launch date of the version of Chrome with Firebase integration. Bug: 892880 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I80cecdf45bac26f4ee92d5e87a184a05d863141b Reviewed-on: https://chromium-review.googlesource.com/c/1272598 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#598826}
-
Alexander Hendrich authored
On shutdown we remove remaining PolicyCertificateProviders from NetworkCertLoader. This triggered OnCertCacheOrPolicyCertsUpdated(), which also read from the user's NSS database, which might be deleted during shutdown already. This CL fixes this by adding an additional cache |all_certs_from_cache_|, which gets updated by updates from the CertCaches (triggered from NSS database). Removing a PolicyCertificateProvider will only read from |all_certs_from_cache_| instead of reading from the deleted NSS database again. Bug: 893642 Change-Id: I26d7ec5a66df9c9bd97929ca19c5cefa0183f06f Reviewed-on: https://chromium-review.googlesource.com/c/1276985 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#598825}
-
Roger McFarlane authored
Autofill will not query/upload form information for form URLS having a non HTTP(S) scheme. Bug: 607907, 894428 Change-Id: Ic03afbec002e3cf005d22ac25fd96e90b0be1273 Reviewed-on: https://chromium-review.googlesource.com/c/1257184 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#598824}
-
Travis Skare authored
Bug: 894283 Change-Id: I65e208513b836c84de2c258d34935c47e4f88afe Reviewed-on: https://chromium-review.googlesource.com/c/1274903Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#598823}
-
Greg Kerr authored
This is a reland of 5c4908e8 Original change's description: > macOS V2 Sandbox: Remove the feature flags. > > The V2 sandbox is now default for all but the network and GPU processes > on macOS. This CL deletes the feature flag. A new experiment will be > introduced for the GPU process. The default case for the sandbox profile > switch is removed, because previous CHECK() failures were confusing to > diagnose. All profiles must now be handled explicitly, so Chrome won't > build if a new profile type isn't handled. > > Bug: 749839 > CQ-Depend: 1268671 > Change-Id: I0860d3a5148b0085be6a99dc01c4971602ee5582 > Reviewed-on: https://chromium-review.googlesource.com/c/1269996 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598128} CQ-DEPEND=CL:1268671 Bug: 749839 Change-Id: I91544907b640c572823f3aae3e29c0cfa003da51 Reviewed-on: https://chromium-review.googlesource.com/c/1274888Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#598822}
-
Josh Karlin authored
When determining if a particular script is an ad, the execution context should be considered and any script running in an ad context should be considered an ad script. This provides enhanced coverage when an ad script then reaches into another context to run a function. Bug: 894080 Change-Id: I69de3343b004b6ef7b7edfe24c7cbda67c925101 Reviewed-on: https://chromium-review.googlesource.com/c/1273823Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#598821}
-
Annie Sullivan authored
I found these additional cases in an audit of the code for bug 889220. Bug: 889220 Change-Id: I649200d91625c2a47848132b79a846174fa4a3e1 Reviewed-on: https://chromium-review.googlesource.com/c/1276551 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#598820}
-
Jeffrey Cohen authored
This view will house the webUI that will display Happiness Tracking Surveys. and it is currently being triggered from the NTP. There is still work to be done to ensure the extensibility of the hats service. but that will be tackled after the first survey is established. Bug: 807714 Change-Id: If61103b72eb0a8c87d42fee7d2b22f765c28e8ae Reviewed-on: https://chromium-review.googlesource.com/c/1257553 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#598819}
-
Jonathan Backer authored
This reverts commit d77817c5. Reason for revert: Land change after M71 branch point to mitigate risk. Original change's description: > Use RasterDecoder for CPU raster > > This CL uses RasterDecoder for CPU rasterization (one-copy and > zero-copy) on worker background raster threads in two cases: > > (1) in renderers whenever GPU raster is blacklisted or cannot create > GrContext (similar to > LayerTreeHostImpl::GetGpuRasterizationCapabilities) > > (2) in browser whenever GPU raster is not requested > > This CL copies some of the logic in LTHI::GetGpuRasterizationCapabilities > to RenderThreadImpl::SharedCompositorWorkerContextProvider. > I copied it so that if we fail GPU rasterization using GLES2Decoder, we > can fallback to CPU raster using a RasterDecoder. > > This change should be safe because we have been fuzzing all > RasterDecoder entry points for about 1 quarter. > > When testing this CL, I noticed that chrome://gpu was reporting > rasterization status incorrectly with --force-gpu-rasterization flag, > so I fixed that too. > > Bug: 880911 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I8d93b9d0bfe30e9ee0d5e522be0d9f8155a28726 > Reviewed-on: https://chromium-review.googlesource.com/c/1258206 > Commit-Queue: Jonathan Backer <backer@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598801} TBR=backer@chromium.org,piman@chromium.org Change-Id: Icd39538a7c98d9d9bb5fff13ddfda12dd46fa05a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880911 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1277267Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#598818}
-
chrome://flagsTanja Gornak authored
Bug: 801985 TBR=sdefresne@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3818337ec7868677429cc0130e00d061d2cfecbe Reviewed-on: https://chromium-review.googlesource.com/c/1269873 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#598817}
-