GitLab

Refactor.

BUG=357693

Review URL: https://codereview.chromium.org/296703011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272595 0039d316-1c4b-4281-b951-d872f2087c98

Now that StreamAsFile() has moved out of the trusted plugin, we can remove the
support in FileDownloader for downloading to a file and providing file
information as output.

This makes FileDownloader quite a bit smaller and easier to read.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/292323007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272593 0039d316-1c4b-4281-b951-d872f2087c98

Add a timer, point, and function drag selection helpers.
Respect ScopedAnimationDurationScaleMode for TextfieldTest.DragToSelect.
Comment and function order cleanup; fix timer.h indentation.

TODO(followup): Make the scrolling "animation" smoother.

BUG=373886
TEST=Dragging to select beyond the left or right ends of the omnibox, find bar textfield, etc. continuously scrolls and modifies the selection.
R=pkasting@chromium.org,thakis@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/290733007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272591 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374216
TEST=none
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/296013005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272590 0039d316-1c4b-4281-b951-d872f2087c98

Caused layout tests (when run with check-sys-deps) to hang on Windows
with a stuck content_shell process. See Issue 376929.

BUG=376929

> Mojo: nuke EnvironmentData
> 
> With this change, Mojo applications that link against mojo_environment_chromium
> do not need to instantiate mojo::Environment. We rely on AtExitManager for all
> finalization of singleton objects. This frees us up to use the familiar
> base::Singleton and base::LazyInstance for any such state. Tests can use
> ShadowingAtExitManager to clean the environment between test runs.
> 
> It becomes a link error to use mojo::Environment if you are not linking against
> mojo_environment_standalone. I plan to follow this up with a change that buries
> mojo::Environment for the case where you are linking against
> mojo_environment_standalone. Ideally, this means no one will ever need to think
> about mojo::Environment again.
> 
> Review URL: https://codereview.chromium.org/281353005

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/299263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272589 0039d316-1c4b-4281-b951-d872f2087c98

The original r272259 was reverted for test failures on Windows XP.
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/31296

FocusTraversal[OnInterstitial] times out on Windows XP with no output:
[ RUN      ] BrowserFocusTest.FocusTraversal
[3796:3464:0522/144031:ERROR:gpu_info_collector_win.cc(103)] Can't retrieve a valid WinSAT assessment.
[3796:380:0522/144031:WARNING:embedded_test_server.cc(230)] Request not handled. Returning 404: /favicon.ico
[397/398] BrowserFocusTest.FocusTraversal (TIMED OUT)

As InterstitialFocus passes, TestFocusTraversal is probably at fault.
I disabled that helper on XP with a comment for Issue 376635.
The original description is otherwise accurate as follows:

========================================

Fix FocusTraversal[OnInterstitial] except *OnInterstitial on Mac :(
Fix InterstitialFocus and FindFocusTest.

Add a TestFocusTraversal helper function consolidated from tests.
Simplify TestInterstitialPage and add a WaitForInterstitial helper.
Move test server init to a common SetUpOnMainThread.
Remove unnecessary helpers and includes.

TODO(followup): Fix more tests!
TODO(followup): s/DisableFindBarAnimationsDuringTesting/ScopedAnimationDurationScaleMode/?

BUG=60973, 62544, 67301, 81451, 109770, 163931, 376635
TEST=Automated tests work and stay enabled...
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/292363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272588 0039d316-1c4b-4281-b951-d872f2087c98

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/296453015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272587 0039d316-1c4b-4281-b951-d872f2087c98

Call WebContentsObserver::RenderFrameCreated for frames created
via RenderFrameHostManager::CreateRenderFrame.

During WebContentsImpl destruction, make sure that RenderFrameDeleted
is always called, by destroying the frame tree and all proxies before
clearing the observer list.

BUG=364974,374491

Review URL: https://codereview.chromium.org/292363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272586 0039d316-1c4b-4281-b951-d872f2087c98

- AttachmentDownloader interface is similar to AttachmentUploader interface.
  No implementation yet.
- AttachmentStore::Read guarantee should be stronger. It should attempt
  to read all attachments and return list of attachment ids that can't
  be loaded locally. Those need to be downloaded from server.

R=maniscalco@chromium.org
BUG=376073

Review URL: https://codereview.chromium.org/293143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272585 0039d316-1c4b-4281-b951-d872f2087c98

There may be remaining messages in the deferred queue on unclean teardown.
Delete those.

Also, a little bit of cleanup in the area:
- GpuChannel doesn't need to be refcounted
- It's ok to copy WeakPtr across threads, as long as they're only dereferenced
on the thread that the factory is destroyed. So no need for the extra
indirection.

BUG=374843

Review URL: https://codereview.chromium.org/299003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272584 0039d316-1c4b-4281-b951-d872f2087c98

1) Remove unused CopyPPVar function from MessageChannel
2) Remove mostly-duplicate NPVariantToPPVar from MessageChannel.
3) Separate V8VarConverter::FromV8Value implementation from calling the callback (so I can have a sync path later, and this is shorter anyway).
4) Simplify NaCl in-process to out-of-process transition. Now, we just queue stuff for in-process (nobody but NaCl uses Messaging in-process), and if/when we switch to out-of-process (handing off to a NaCl app) we drain the queues then.
5) Some other renames/tweaks to how MessageChannel queues pending conversions.

BUG=367896
R=raymes@chromium.org

Review URL: https://codereview.chromium.org/290553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272583 0039d316-1c4b-4281-b951-d872f2087c98

This removes some unnecessary manifest_id storage and passing to make manifest
behavior clearer in the trusted plugin. Helper NaCl Modules (llc and ld) always
use the "Pnacl Manifest" for resolving keys, as there is no relevant
json-formatted NMF available.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/292743011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272582 0039d316-1c4b-4281-b951-d872f2087c98

Forgot to do this in r271968 - https://codereview.chromium.org/296153002

BUG=None
TEST=None
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/299203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272581 0039d316-1c4b-4281-b951-d872f2087c98

Revert of cc: Stop blocking the main thread in CreateAndInitializeOutputSurface. (https://codereview.chromium.org/287193003/)

Reason for revert:
This may be causing mac browser test flakiness: https://code.google.com/p/chromium/issues/detail?id=376649



Original issue's description:
> cc: Stop blocking the main thread in CreateAndInitializeOutputSurface.
> 
> The ThreadProxy does not need to block the main thread anymore, instead
> have it post back DidInitializeOutputSurface() with the result of the
> process.
> 
> We would delete all contents textures on the compositor thread during
> OutputSurface creation, which doesn't really make sense, cuz the
> ResourceProvider won't be the same one anymore, and this required
> blocking the thread.
> 
> We also notified the main thread that the OutputSurface was lost when
> creating the new output surface.
> 
> Instead, post a DidLoseOutputSurface() to the main thread to inform
> the LayerTreeHost right away, and have that block and clean up
> the contents textures immediately (to be removed when we always do
> impl-side painting).
> 
> R=enne
> BUG=374287
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272276

TBR=enne@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=374287

Review URL: https://codereview.chromium.org/299233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272580 0039d316-1c4b-4281-b951-d872f2087c98

In the future, BrowserPluginGuest will no longer be a WebContentsDelegate, and so special handling for guests that relies on the internal implementation details of BrowserPlugin should be moved to chrome.

BUG=364141, 330264

Review URL: https://codereview.chromium.org/296703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372920,245025
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/282903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272577 0039d316-1c4b-4281-b951-d872f2087c98

Modifying CustomFrameView to layout window controls based on user configurations. For linux begin observing the configs and changes. For other systems fall back on a default ordering.

This reland addresses changes to custom_frame_view_unittest.cc that landed before the original patch. Causing a build failure.

Original code review: https://codereview.chromium.org/281353009/
Revert code review: https://codereview.chromium.org/294473016

Revert "Revert 272352 "Reland Linux Window Control Alignment""
This reverts commit b6f34fbe.

TBR=oshima, sadrul

TEST=CustomFrameViewTest
BUG=351917

Review URL: https://codereview.chromium.org/296283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272576 0039d316-1c4b-4281-b951-d872f2087c98

There's no need to eagerly install the file_poller. This ensure we only do it
when we're running a measurement that needs it.

BUG=

Review URL: https://codereview.chromium.org/298873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272575 0039d316-1c4b-4281-b951-d872f2087c98

Fills out more targets in the Android build.

BUG=
R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/297793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272574 0039d316-1c4b-4281-b951-d872f2087c98

I accidentally passed an empty string here and got a weird error processing the path.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/292123012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272573 0039d316-1c4b-4281-b951-d872f2087c98

and removed unwanted extension:: prefix.

BUG=None

Review URL: https://codereview.chromium.org/290293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272572 0039d316-1c4b-4281-b951-d872f2087c98

I "cleverly" used std::copy assuming it would not malloc or lock, but it does in the debug build of the STL (at least) to do some verification. This causes the fork to hang on Posix.

This version matches the base code.

BUG=
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/299003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373325

Review URL: https://codereview.chromium.org/297803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272570 0039d316-1c4b-4281-b951-d872f2087c98

A Views textfield hides touch text selection handles on command
execution. Omnibox overrides command execution for some commands without
calling textfield's implementation; so, it needs to hide the handles for
those commands.
Also, introduced TextfieldTestApi class for accessing private members of
Textfield class in tests.

BUG=373532

Review URL: https://codereview.chromium.org/297733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272569 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY because comments only.

BUG=None
NOTRY=1

Review URL: https://codereview.chromium.org/297043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272567 0039d316-1c4b-4281-b951-d872f2087c98

SimpleGeolocation unittest should less depend on timings.

BUG=245075
TEST=unittest

Review URL: https://codereview.chromium.org/296853009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272566 0039d316-1c4b-4281-b951-d872f2087c98

Instead of creating an infinite number of sync queries, which will
eventually cause performance issues, log an error message and block
until oldest query has passed when reaching 16 pending queries.

BUG=371530,373360

Review URL: https://codereview.chromium.org/280543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272565 0039d316-1c4b-4281-b951-d872f2087c98

Build failure looks like it was actually unrelated.

> Revert 272371 "Add UMA Counts for number of IPv4 and IPv6 interf..."
>
> Reason: build failure on Mac ASan 64
>
> > Add UMA Counts for number of IPv4 and IPv6 interfaces detected for PeerConnection.
> >
> > R=sergeyu@chromium.org
> > BUG=N/A
> >
> > Review URL: https://codereview.chromium.org/299103002
>
> TBR=mallinath@chromium.org
>
> Review URL: https://codereview.chromium.org/299843008

TBR=mallinath@chromium.org

Review URL: https://codereview.chromium.org/296903010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272564 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces no semantic change, only renames PasswordManagerLogger
to LogReceiver, to better reflect the purpose of that interface.

BUG=347927

Review URL: https://codereview.chromium.org/264793010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272563 0039d316-1c4b-4281-b951-d872f2087c98

The added test failed on Mac 10.7.

> Add test for action_runner.BeginInteraction and action_runner.EndInteraction.
> 
> BUG=368767
> 
> Review URL: https://codereview.chromium.org/294943006

TBR=nednguyen@google.com

Review URL: https://codereview.chromium.org/284183014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272560 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/294283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272558 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=sky@chromium.org

Review URL: https://codereview.chromium.org/292423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272557 0039d316-1c4b-4281-b951-d872f2087c98

Added api into privet/info response. 

NOTRY=true

Review URL: https://codereview.chromium.org/296303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272556 0039d316-1c4b-4281-b951-d872f2087c98

The CL introduced unit test failures on Chromium OS ASan LSan Tests(3)
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/1499

Failing tests:
EventRewriterTest.TestRewriteFunctionKeys
EventRewriterTest.TestRewriteModifiersDisableSome

> Add native event testing to chromeos::EventRewriter unit tests.
> 
> Most tests (not having state) are converted to a table-driven form,
> so that multiple test operations can be done on the same test data.
> Additional tests based on X11 native events are done on these cases.
> 
> The fallback X11 keycode to keysym mapping is expanded, because the
> X server used by some automated tests does not support some of the
> keycodes used by ChromeOS top-row special keys.
> 
> 
> R=sadrul@chromium.org
> 
> Review URL: https://codereview.chromium.org/270633012

TBR=kpschoedel@chromium.org

Review URL: https://codereview.chromium.org/295243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272553 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376814
TBR=jbauman@chromium.org

Review URL: https://codereview.chromium.org/298463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272552 0039d316-1c4b-4281-b951-d872f2087c98

This really should be in nacl-newlib, but it's easier to land here now and
remove it later when it lands in newlib and rolls into the SDK.

This implementation does not support symlinks, but neither does nacl_io
currently.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/295933009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272551 0039d316-1c4b-4281-b951-d872f2087c98

This removes a significant amount of code from the trusted plugin and
simplifies the callbacks that are used in PluginReverseInterface.

I was confused at first by the existing use of url_file_info_map_; it looks
like it was intended to serve as a cache for retrieved files, but I think the
files would be reopened every time, even if the file was already open. For
simplicity, I didn't try to add any caching behavior in this change.

Note that this changes progress events to be rate limited at 10ms per-file,
not 10ms per-plugin. It's a bit simpler to write this way, but I can
change that limit to be per-plugin if that makes more sense.

BUG=370556
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/294633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272550 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368767

Review URL: https://codereview.chromium.org/294943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272549 0039d316-1c4b-4281-b951-d872f2087c98

Allow strike register to ensure we have high probability of 0-RTT connects,
and proceed toward using Connection ID to track connections.
r=rch
BUG=376108

Review URL: https://codereview.chromium.org/294903011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272548 0039d316-1c4b-4281-b951-d872f2087c98

Whitelisting an extension per: crbug.com/374965

BUG=374965
TEST=None
R=miket@chromium.org

Review URL: https://codereview.chromium.org/297603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272547 0039d316-1c4b-4281-b951-d872f2087c98