GitLab

Added checks to see if the test is being run on windows and if so
replaced the backslashes with forward slashes. I also changed the file
open to write the file in binary so that line endings are not
converted.

Change diffing tool being used from diff(1) to Python's difflib module.
diff(1) is a Unix diffing tool so it does not run on Windows.
Python's difflib module will work on all computers and the speed of
the module won't be an issue because there is a fairly small number
of test files.

Bug: 929019
Change-Id: I24e43f6599a8ce839af4dc2cec18dc56acd13bad
Reviewed-on: https://chromium-review.googlesource.com/c/1479309Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Allison Pastewka <alpastew@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#636956}

Bug: 936565
Change-Id: I7314b645e7076b17b08b93ab9353f49c08679712
Reviewed-on: https://chromium-review.googlesource.com/c/1492036Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636955}

Change-Id: I8b109f7992797d796495829d16c5db4906587fb8
Reviewed-on: https://chromium-review.googlesource.com/c/1492431
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636954}

Extend the implementation of base::SamplingHeapProfiler to support:
  * PSEUDO and MIXED call stack modes
  * Allocation context recording
  * Thread name recording

Switch SamplingProfilerWrapper to use base::SamplingHeapProfiler for the
in-process mode.

TBR=dcheng@chromium.org
BUG=923459

Change-Id: I9783a9c60f287332d5fb7410fbe672ee83010ece
Reviewed-on: https://chromium-review.googlesource.com/c/1492951
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636953}

This adds a developer guide for the WebView shell. This covers building
and installing, but also shows how to interact with the shell via the
commandline.

This cross-links to the shell's folder (adding a README.md), but keeps
primary documentation under android_webview/docs/ to improve
discoverability.

Bug: 918221
Test: tools/md_browser/md_browser.py
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I6216bb70a42989910044cfc56e56314a4e2bc781
Reviewed-on: https://chromium-review.googlesource.com/c/1490909
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636952}

The menu item should not be shown in some cases (e.g., for secondary
users).

Bug: 931608
Change-Id: I81a8bcb57905584c3806738d61c694bfb8d7a6a6
Reviewed-on: https://chromium-review.googlesource.com/c/1470743
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636951}

https://skia.googlesource.com/skia.git/+log/1223e7fc0a3c..436d47d5bde9


git log 1223e7fc0a3c..436d47d5bde9 --date=short --no-merges --format='%ad %ae %s'
2019-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 1dc32aec..cddf8925 (456 commits)
2019-03-01 halcanary@google.com SkQP: Fix report
2019-03-01 mtklein@google.com update high-contrast color filter for tagged SW destinations
2019-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a1924739029e..dd1e37e31d68 (1 commits)
2019-03-01 ianloic@google.com Clean up SkFontMgr_fuchsia.cpp after FIDL API change
2019-03-01 reed@google.com fix docs for fitsInBytes
2019-03-01 kjlubick@google.com [canvaskit] Roll 0.4.1
2019-03-01 mtklein@google.com fix labels in P3 gm


Created with:
  gclient setdep -r src/third_party/skia@436d47d5bde9

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I4f069c211df0f8adeaeb0c8db28748adf74d9a22
Reviewed-on: https://chromium-review.googlesource.com/c/1495730Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636950}

https://swiftshader.googlesource.com/SwiftShader.git/+log/dd1e37e31d68..37c024a6a7fd


git log dd1e37e31d68..37c024a6a7fd --date=short --no-merges --format='%ad %ae %s'
2019-03-01 capn@google.com Remove src/Vulkan directory from CMake include path


Created with:
  gclient setdep -r src/third_party/swiftshader@37c024a6a7fd

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: Ia6a52981644c49da147c8dd29dec29487b85eee8
Reviewed-on: https://chromium-review.googlesource.com/c/1496960Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636949}

In crc32c BUILD.gn file, it sets -march flag to armv8-a+crc+crypto
in order to support some special instructions. However, on Chrome OS,
it also sets -march flag for ARM64 which might mask the flag set by
GN file. This CL fixes this problem by passing "crc" and "crypto"
directly to clang through "-target-feature" flag. As suggested by
the reviewers, the CL changes to flag to clang only and applies to
all platforms.

CL crrev.com/c/1489392

Bug: chromium:934016
TEST: Tested on Chrome OS with tryjobs kevin64 and arm64 with testing
Change-Id: Ifb4a50308f230a7d8198f3cd4b92301e63724e6d
Reviewed-on: https://chromium-review.googlesource.com/c/1492489
Commit-Queue: Tiancong Wang <tcwang@google.com>
Auto-Submit: Tiancong Wang <tcwang@google.com>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636948}

Summary of changes:
 - Switch from synchronous to asynchronous mutations when called on the compositor thread.
 - Use appropriate queue strategy depending on which tree is being animation.
 - Wait until mutation request is resolved before requesting impl frame and draw.
 - Split status for successful completion of a mutation cycle to include if any updates were performed to avoid unnecessary paints.
 - Plumbing of mutation callback to the layer tree host and scheduler.

Bug: 791280
Change-Id: I9cba2bfe8ac51a541fc63d6dd96df17e0bf67bb9
Reviewed-on: https://chromium-review.googlesource.com/c/1481738
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636947}

This allows modifying the settings according to the output of
ShouldApplyHighContrastSettings() in a follow-up CL.

Bug: 925949
Change-Id: I2bff529a360ffd39923e0b3e120f2d07fc3bf3a6
Reviewed-on: https://chromium-review.googlesource.com/c/1490444Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#636946}

Driven-by CL, and follow up of jbroman's remark in [1].

This CL simplifies TargetIsFrame function in core/input/event_handler.cc,
given that it produces two values, and the usage always checks both,
even though the function returns true if it produces a non-null value.

[1] https://crrev.com.com/c/1487391/3/third_party/blink/renderer/core/input/event_handler.cc

BUG=None

Change-Id: Ib556803d078fad3fd5b48dbdb1e6a4e5e6a1ed15
Reviewed-on: https://chromium-review.googlesource.com/c/1496215
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636945}

This CL extends the sandbox to feature policy integration by adding
support for CSP or any DocumentInit related sandbox flags. These flags
are applied with the header policies.

The change fixes some WPT/LayoutTests under the virtual suite
FeaturePolicyForSandbox.

Bug: 812381, 926247, 926248, 926249, 929678
Change-Id: I2ba7d47b4f3d0f70f246a8c0902e2617c7e10332
Reviewed-on: https://chromium-review.googlesource.com/c/1492483Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636944}

Splitting up long SetCopies test and moving to a separate file. Also
restoring testing of collate checkbox visibility via a new
CollateVisibility test.

Change-Id: If6891f29e597a2d8dd1e628a946c555b61b1441d
Reviewed-on: https://chromium-review.googlesource.com/c/1493393
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636943}

This change implements UIA_FlowsFromPropertyId for
IRawElementProviderSimple::GetPropertyValue and adds associated unit and
browser tests. Additional test helper methods are introduced to
AXPlatformNodeWinBrowserTest.

Bug: 844149
Change-Id: I7c88a938e203d04fb2fdb5c83ce8ab4fd90d5746
Reviewed-on: https://chromium-review.googlesource.com/c/1493514
Commit-Queue: Frank Poole <frpoole@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636942}

R=piman@chromium.org

Bug: 889328
Change-Id: I5270d343bbbd48fd250863929e42c47186ef0ff0
Reviewed-on: https://chromium-review.googlesource.com/c/1496597
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636941}

addJavascriptInterface() won't be able to inject JavaScript interface
soon enough to be called by an immediate evaluateJavascript(). This CL
moved addJavascriptInterface() to before loading web page, since we
wait until onPageFinished() to call evaluateJavascript(), it should
be enough to finish addJavascriptInterface().

Bug: 937116
Change-Id: I8b6a70b32af638921f79648d6924346f31685bd4
Reviewed-on: https://chromium-review.googlesource.com/c/1496451
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636940}

When the tab switch button was "focused", the tab key wasn't working
because the routine involved was returning true, saying that it had
handled the tab key. This CL changes that.

Arrow keys still need to return true in this case, so
'AtEndWithTabSwitch()' was broken up into 'BidirAtEnd()' and
'SelectedSuggestionHasTabSwitch()' so that the tab key can
ignore the first condition, while arrow keys consider it.

Bug: 936851
Change-Id: I84b8b2e41f2601c978d31405b727eb60ea3c78c0
Reviewed-on: https://chromium-review.googlesource.com/c/1495198
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636939}

This allows for branch urls to be added to the CQ.

Bug: 922150
Change-Id: Ic4380a87610949fbc0443d0a17b0021821e390e9
Reviewed-on: https://chromium-review.googlesource.com/c/1497180
Commit-Queue: Karen Qian <karenqian@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636938}

Bug: 929973
Change-Id: Idbe28468069455b9f460728820bed6a9c4397cf1
Reviewed-on: https://chromium-review.googlesource.com/c/1494891
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636937}

UserInitiatedChromeCleanups was enabled by default in M67.

Change-Id: I98b9b3da11bc7bbb44e58e9101b589cf6b666788
Reviewed-on: https://chromium-review.googlesource.com/c/1491852
Commit-Queue: Veranika Liaukevich <veranika@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/master@{#636936}

Since M59, this URL simply forwards to chrome://history. This CL
removes the redirect.

reached" page.

Bug: None
Test: Visit chrome://history-frame, should see "This site can’t be
Change-Id: I6642b4be8b1b28ba9471b1dc64aa24a444aaeed2
Reviewed-on: https://chromium-review.googlesource.com/c/1496494
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636935}

- Enabled/implemented IsOffscreen property for UIA in
AXPlatformNodeWin::GetPropertyValue and assoicated browser tests.
GetPropertyValue calculates isOffscreen status by utilizing
AXTree::RelativeToTreeBounds, which looks at the bounds of the
node relative to its ancestor and rootWebArea bounds to determine
the isOffscreen status.

- Modified AccessibilityWinBrowserTests::FindNodeInSubtree to take
into account of StringAttribute::kValue when finding the node.

Bug: 844149
Change-Id: Ied62e00814957a6ca97b1849935ec692f1acf03a
Reviewed-on: https://chromium-review.googlesource.com/c/1481800
Commit-Queue: Victor Fei <vicfei@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636934}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/19dd955a0744..b2b876f75ba1


git log 19dd955a0744..b2b876f75ba1 --date=short --no-merges --format='%ad %ae %s'
2019-03-01 chrome-bot@chromium.org Update config settings by config-updater.
2019-03-01 dgarrett@google.com chromeos_config: Change packages for old factorybranches.


Created with:
  gclient setdep -r src/third_party/chromite@b2b876f75ba1

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I4868d817bc7911e01f11b339b6ef66952d40e228
Reviewed-on: https://chromium-review.googlesource.com/c/1496103Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636933}

Now checking for nullptr before assigning the char* result from
ippGetName.

Bug: chromium:935873
Test: Unittests still pass.
Change-Id: Ic5d665b69e41821dd44abb41efcee6276655cf13
Reviewed-on: https://chromium-review.googlesource.com/c/1490753Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636932}

The URL to the new flake portal will be https://analysis.chromium.org/p/chromium/flake-portal
"Flake Portal" refers to the set of tools that Findit provides to deal with flakiness.

In Findit, the data in /p/chromium/flake-portal/flakes are flaky tests only, because successful and consistently failed tests are filtered out.
Besides, Findit has following features:
1) Flake Report: aggregation of flakiness data by crbug component.
2) Flake Analysis: find the culprit commit for a flaky test; verify flake fixes.
3) Flake bug management: auto-create flake bugs, comment on existing bugs filed by human, auto-merge flake bugs if the root cause is the same culprit, etc.

Also reworded the original "Flakiness Dashboard" to "Legacy Flakiness Dashboard".
It shows the full history of a specific test.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ChromeVoxLiveRegionsTest.LiveStatusOff

Bug: 934569
Change-Id: Ib05c43b67bf0f87307c135ca3f630200a7daf78f
Reviewed-on: https://chromium-review.googlesource.com/c/1482113
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636931}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7ccfee2ef7c..6ecc5174ac93


Created with:
  gclient setdep -r src-internal@6ecc5174ac93

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:937214,chromium:937241
TBR=mmoss@chromium.org

Change-Id: Ice2f3a35edbd3033d1aaf996e57df32bd7dbed79
Reviewed-on: https://chromium-review.googlesource.com/c/1496959Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636930}

When service worker context initializes, add the corresponding
entry to ProcessManager and remove it when the context stops.

Introduce IPC for worker initialization
(DidInitializeServiceWorkerContext) and modify worker
stop IPC (DidStopServiceWorkerContext) as necessary.

Note that we cannot use loadstop
(DidStartServiceWorkerContext) for PM entry addition because it
can be too late as extension API calls might arrive in browser
process before this.

Also add SW information cleanup on render process termination as
termination doesn't trigger stop worker messages (where the
regular cleanup in PM happens).

This CL will enable extension messaging in future CLs.

Add tests for shutdown and termination behavior.

Bug: 925918
Change-Id: I9442bac9a1e9acf01063084a1e6ef2fac3279e09
Reviewed-on: https://chromium-review.googlesource.com/c/1455267Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636929}

This reverts commit 0bfee16c.

Reason for revert:
New test times out on Linux official builds and clang ToT builds:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20trunk/builds/15834
https://ci.chromium.org/p/chromium/builders/ci/ToTLinux/5415

Original change's description:
> Add integration test for butter credit card save dialog
> 
> Tests upload scenario and local save because payments rejected the card.
> 
> Bug: 876301,915216
> Change-Id: I8c73ea867872dc99fee3f2dcbb10bb0a6f123472
> Reviewed-on: https://chromium-review.googlesource.com/c/1486336
> Commit-Queue: Florian Uunk <feuunk@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#635529}

TBR=vasilii@chromium.org,sebsg@chromium.org,feuunk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 876301, 915216
Change-Id: I49b54f21b0286b946be2b72fd26d3b98fac08067
Reviewed-on: https://chromium-review.googlesource.com/c/1497185Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636928}

This is another example of WKWebView loading slowly, or not at all, when removed
from the view heirarchy.  On restore, the tab is swapped out, but since there's
an NTP visible after a crash, the restore underneath may stall if the new tab's
webState view isn't swapped into the BrowserViewContainerView.

Bug: 848789
Change-Id: I62020b3ebd2fd4e9ab8ded003f0cc62d35104374
Reviewed-on: https://chromium-review.googlesource.com/c/1496539
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636927}

This will cause the device to stay unlocked for the amount of time set in the duration and locked afterwards.

Bug: 934923
Change-Id: Ia05d7e74ac0d89d682e332c3a248d802bd5df0ef
Reviewed-on: https://chromium-review.googlesource.com/c/1477826
Commit-Queue: Leonardo Padilha <ldaguilar@chromium.org>
Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636926}

The OWNERS file in question has a list that mostly replicates the main
Autofill OWNERS file, in //components. However, this list has not been
updated regularly to reflect team changes. I think it makes the most
sense to simply use the same OWNERS for both places.

I'm leaving the per-file OWNERs for the password team, which is
consistent with what we've done in various other places in the codebase.

Change-Id: Ia183a78392c4623ea9cd4525cb59d175e80f69ff
Reviewed-on: https://chromium-review.googlesource.com/c/1497184
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Auto-Submit: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636925}

This CL updates oudated comments, with no production code changes.

TBR: chcunningham@
Change-Id: Ie12fb6ba08048c7ca2a14c49f0daee8636e058db
Reviewed-on: https://chromium-review.googlesource.com/c/1497175
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636924}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ib65dce096d41e2a965628b8dd3f1bbd5fdc4b23a
Reviewed-on: https://chromium-review.googlesource.com/c/1495729Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636923}

https://android.googlesource.com/platform/external/perfetto.git/+log/ab0bd92ed40d..640200f64d14


git log ab0bd92ed40d..640200f64d14 --date=short --no-merges --format='%ad %ae %s'
2019-03-01 costan@google.com Merge "test: Migrate googletest TEST_CASE APIs to TEST_SUITE."


Created with:
  gclient setdep -r src/third_party/perfetto@640200f64d14

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I314813b03d823b8a18d4ce80e2f15880463c5cb6
Reviewed-on: https://chromium-review.googlesource.com/c/1497114Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636922}

Change-Id: I552ed0de86b5dc7aa9e10e61877e601ba2b42b22
Reviewed-on: https://chromium-review.googlesource.com/c/1496956
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636921}

******************************Resource Sizes Diff******************************
Specifics:
       +58,488 bytes main lib size
      +436,504 bytes main dex size
      +159,240 bytes secondary dex size
      +938,740 bytes normalized apk size
InstallSize:
      +345,802 bytes APK size
    +1,042,823 bytes Estimated installed size (Android Go)
    +2,752,607 bytes Estimated installed size
InstallBreakdown (+2,751,322 bytes):
        +2,124 bytes Native resources (no l10n) size
        +2,400 bytes unwind_cfi (dev and canary only) size
        +2,224 bytes Non-compiled Android resources size
       +58,488 bytes Native code size
          +653 bytes Package metadata size
    +2,668,649 bytes Java code size
       +16,784 bytes Compiled Android resources size
Dex:
        +3,155 entries fields
        +4,868 entries methods
        +1,599 entries types
        +3,291 entries strings

Change-Id: I56ddb01aa0be9582936ca3abbb37755a6b86e82f
Reviewed-on: https://chromium-review.googlesource.com/c/1496600Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636920}

This allows optimizing away the String creation in
css_parsing_utils::ConsumePath, while also being slightly more generic.

Change-Id: Iba17ca82e45304dd217487cb526cf8ba692c3276
Reviewed-on: https://chromium-review.googlesource.com/c/1497001Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#636919}

This value is needed in extensions, so we can use NSUserDefaults to
store it.

Bug: 913958
Change-Id: I4cacfb56c62e84e97a6529797bb97473715b5eb0
Reviewed-on: https://chromium-review.googlesource.com/c/1488911Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#636918}

Follow-up work for https://chromium-review.googlesource.com/c/chromium/src/+/1493084

Also remove some outdated comments.

Bug: None
Change-Id: I5c01528a334d2924b80f9fa4954777795d847fc9
Reviewed-on: https://chromium-review.googlesource.com/c/1496517Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636917}