- 21 Aug, 2018 5 commits
-
-
Jennifer Apacible authored
TBR=dtseng@chromium.org NOTRY=true (disabling test) Bug: 876145 Change-Id: I689855e1c34de5735dde20e235bf1e8d09dbeb17 Reviewed-on: https://chromium-review.googlesource.com/1182784Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#584587}
-
Patrick Monette authored
Bug: 876096 Change-Id: I85a7d7d5529270a829d9849a8bb638d9d02b7813 Reviewed-on: https://chromium-review.googlesource.com/1182341 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#584586}
-
Minh X. Nguyen authored
Now that the update client can return update service error details, this information can be used to understand more about what kind of service errors the update service may encouter when doing update checks. Bug: 869663 Change-Id: I10c693b05ebbe6c1f804606c4749acb0a178e7bd Reviewed-on: https://chromium-review.googlesource.com/1180076Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584585}
-
Xu Xing authored
Also refactor HasFallbackSurface to unify DelegatedFrameHost and DelegatedFrameHostAndroid. Bug: 859977 Change-Id: I5cea0013b4f52dbe4b6c8a6a9841bacc7b13e381 Reviewed-on: https://chromium-review.googlesource.com/1176970Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#584584}
-
Dmitry Gozman authored
TimeClamper is only used by Performance, so there is no need to put it as low as platform/. Change-Id: I531be082528f2e569bbff08a5ace42076d9bb845 Reviewed-on: https://chromium-review.googlesource.com/1157174Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584583}
-
- 20 Aug, 2018 35 commits
-
-
Christopher Cameron authored
When updating the views::View size, ensure that the NSWindow size be updated first (otherwise we end up with strange mismatches). Add a TODO about merging methods here. This requires access to the BridgedNativeWidget from BridgedContentView, so make BridgedNativeWidget store a pointer to BridgedContentView (from which it can access BridgedContentViewHost), rather than storing a pointer to BridgedContentViewHost. Also change one instance where we pulled the BridgedContentView from the NSWindow to use the pointer directly. Bug: 875776, 875731 Change-Id: Ia9c3d4238f6824e5595baa5d4e856c34ead0fb75 Reviewed-on: https://chromium-review.googlesource.com/1181926 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#584582}
-
gogerald authored
Bug: 806868 Change-Id: I60b3d97e7418a7b5eccc5c9f4ee96be8e6e0b187 Reviewed-on: https://chromium-review.googlesource.com/1182198Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#584581}
-
Martin Kreichgauer authored
This introduces PlatformAuthenticatorInfo as a parameter object to FidoRequestHandlerBase::SetPlatformAuthenticatorOrMarkUnavailable. The struct holds the existing std::unique_ptr<FidoAuthenticator>, which is the platform authenticator itself, and an additional bool indicating whether the authenticator has a matching credential for GetAssertionRequest. The bool is plumbed through to TransportAvailabilityInfo for consideration by the UI. Bug: 847985 Change-Id: Ice46685eef31eb29cb8fdcb0d471e4b40bfb97b3 Reviewed-on: https://chromium-review.googlesource.com/1179088 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584580}
-
Tibor Goldschwendt authored
This fixes a startup crash of the Chrome modern bundle where uncompress_shared_libraries was erroneously set to false for the Chrome modern base module. Bug: 875872 Change-Id: Ie9817ea350f4703950608eff35e5b6129cb9e508 Reviewed-on: https://chromium-review.googlesource.com/1181936 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#584579}
-
Ned Nguyen authored
TBR=mythria@chromium.org, ulan@chromium.org NOTRY=true Bug: 875159 Change-Id: I3e8df16078427553a28a7df8daf7a798453e0dcf Reviewed-on: https://chromium-review.googlesource.com/1182481Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#584578}
-
Jacob Dufault authored
Calling the shortcut may cause chrome to crash, as the chrome-side handler assumes the login screen is active. Bug: 875778 Change-Id: Ib297d5239c9198d0cd047bd2b5e240dbc1d49ca8 Reviewed-on: https://chromium-review.googlesource.com/1182184Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#584577}
-
Anders Hartvoll Ruud authored
When we inherit a set of custom properties, without modifying that set, we don't need to resolve those properties again. Also, we only need to resolve at all if any values with var()-references have been observed. This CL simply stores a flag which indicates whether the Style[Non]InheritedVariables instance contains unresolved var()- references or not. This fixes a performance issue where variables specified on :root would be re-resolved for all elements in the tree. Bug: 875123 Change-Id: I1f68b4c78465c1c09a2b4951207f8bf4eb855e45 Reviewed-on: https://chromium-review.googlesource.com/1180209 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#584576}
-
Tommy Steimel authored
This reverts commit 0c629790. Reason for revert: The crashes are still occurring and I realized I misinterpreted the initial crash reports. Going to land a different CL which fixes the actual problem. Original change's description: > [Media Controls] Prevent ComputedStyleRef crash in overlay play button > > This CL adds a check in MediaControlOverlayPlayButtonElement that > prevents a call to ComputedStyleRef is ComputedStyle is null. This > prevents a crash we're seeing in certain cases on Windows and Mac. > > Bug: 870490 > Change-Id: Ia45a7239084b267ce8a352fc0a825b5c992c5eea > Reviewed-on: https://chromium-review.googlesource.com/1173471 > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583523} TBR=hayato@chromium.org,beccahughes@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870490 Change-Id: Ied6ea0c564c478ade8f670f72c5369785bb4cacf Reviewed-on: https://chromium-review.googlesource.com/1181681Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584575}
-
Miguel Casas authored
ClusterFuzz encountered an issue if a given VideoFrame comes and causes a change of OutputFormat: in the bug below, an I420 VF was received after a series of I420A ones, and caused a crash when the alpha channel was accessed. This might happen more generally if the received VideoFrames cause a change of OutputFormat and we access what we don't have. This CL addresses that by comparing the current |output_format_| with what is derived out of the incoming VideoFrame. If they differ, we just bail. Bug: 875158, 875670 Change-Id: I961b5bf95651a3888482957ee0b7acd48149d467 Reviewed-on: https://chromium-review.googlesource.com/1180543 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#584574}
-
Xianzhu Wang authored
This relands commit 8a53cc3a with the following change compared to the original CL: - SetShouldCheckForPaintInvalidationWithoutGeometryChange() no longer unconditionally calls GetFrameView() ->ScheduleVisualUpdateForPaintInvalidationIfNeeded() but SetShouldDoFullPaintInvalidationWithoutGeometryChange() does. This logic is the same as the current ToT before this CL, and the same as before the reverted CL. This fixes the performance issue that is caused by too frequent calls to ScheduleVisualUpdateForPaintInvalidationIfNeeded() from SetShouldCheckForPaintInvalidation(). Original change's description: > Revert "[CI] Cleanup paint invalidation flags" > > This reverts commit 8a53cc3a. > > Reason for revert: Performance regressions crbug.com/875321. > > BUG=875321 > > Original change's description: > > [CI] Cleanup paint invalidation flags > > > > - Use separate flags HasDelayedFullPaintInvalidation and > > SubtreeShouldDoFullPaintInvalidation in LayoutObject instead of using > > paint invalidation reasons kSubtree and kDelayedFull to simplify logic > > handling them. > > > > - Other cleanup and simplications > > > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I0946c042c80195dd6cf1d4a9e8c3554dbad1871d > > Reviewed-on: https://chromium-review.googlesource.com/1123018 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#583772} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I6f12dd7fe621f88e5a0fe1b96637b2ecc813e78e > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1180305 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584248} Change-Id: I22ff44656c7994e7814565330042e08832f30f91 Bug: 875321 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1180309Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584573}
-
Tommy Martino authored
This CL adds the flag, feature, and parameters for an upcoming experiment which will modify the layout of the Autofill dropdown on Desktop. It also adds the capability to display the icon on the left, rather than the default right, of each row of the dropdown, which is the expected behavior under certain experiment groups. Change-Id: I90ceb546887a76eb836e4aac19ae96ba1a9d107e Bug: 870342 Reviewed-on: https://chromium-review.googlesource.com/1152217 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584572}
-
Devlin Cronin authored
Introduce an ExtensionsAPIProvider that contains knowledge of generated APIs and extension features. The ExtensionsClient contains multiple ExtensionsAPIProviders, and queries these providers for features and generated API schemas. This allows the registration of APIs from outside the extensions system, which will be necessary for moving Chrome Apps API registration outside of extensions code. This also more effectively wraps the logic relating to the generated features within a single location, minimizing the burden for consumers to add/check multiple generated sets. Create an API Provider for each set of code that generates unique features and APIs: - Core Extension APIs (defined in //extensions) - Chrome Extension APIs (defined in //chrome) - Shell Extension APIs (defined in //extensions/shell) - Cast Extension APIs (defined in //chromecast) When the corresponding ExtensionsClient type is constructed, it registers the appropriate providers. Bug: 873937 Change-Id: I198e5e5cbd6ab53bff9e335ea1551bdcfe59f521 Reviewed-on: https://chromium-review.googlesource.com/1172000Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584571}
-
Amirhossein Simjour authored
Fixed the typo in the code that was showing screen_capture_indicator instead of the bluetooth_in_use indicator. This was introduced here: https://chromium-review.googlesource.com/1151711 Change-Id: I7e541b835f37489b78b901e53df91967fa78e434 Reviewed-on: https://chromium-review.googlesource.com/1182004Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#584570}
-
Joe Downing authored
A recent CL added a Mojo dependency to our host binaries. This caused a crash on Linux/MacOS (crbug.com/875462) which was recently fixed. I then saw a crash in the NMH on Windows when starting the CRD App. This is due to the same root problem but in our Me2Me NMH binary this time. I've fixed the init problem and verified I can set up a host again. I've also tested It2Me on Windows and it works fine. BUG=875953 Change-Id: Ia22e45aa2d9ed0b1e27595e1cee1038676278b70 Reviewed-on: https://chromium-review.googlesource.com/1181928Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#584569}
-
Eric Karl authored
This reverts commit 8d5f940b. Reason for revert: Causing crashes as the new helper functions don't check for a null |group_| before using it. Original change's description: > Use texture manager and mailbox manager helper functions > > Bug: None > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ic817611158f48229c031161e4c8a6e7ac949b918 > Reviewed-on: https://chromium-review.googlesource.com/1161601 > Commit-Queue: Xing Xu <xing.xu@intel.com> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583170} TBR=xing.xu@intel.com,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874788 Change-Id: I0118144f2fa5c186bbabd7f61b7377d2e201631b Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1181585 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#584568}
-
Kevin Marshall authored
A new directory "third_party/qemu" was added to the checkout as of https://chromium-review.googlesource.com/1178975 . This CL adds "qemu" to the .gitignore file to keep Git from thinking it's an untracked directory. TBR=sergeyu@chromium.org Change-Id: I6db095ce30dd13268f3720de7aa86a48920ed481 Reviewed-on: https://chromium-review.googlesource.com/1182183Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584567}
-
Donn Denman authored
Refactors the Contextual Search Component to use the layered directory layout recommended for iOS support. This CL splits the top-level directories into /core and /content. A few files that are clearly not dependent on any content have been moved to /core/, and everything else is moved to /content/. There will be some additional /core/ files landing soon. This CL doesn't change any logic or functionality, it just moves source files. BUG=646019,825428 Change-Id: Ia4bf5cdecaabf7d9515b2d4fca855db29b1c4b1c Reviewed-on: https://chromium-review.googlesource.com/1173019Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Kenneth Russell authored
Mark: conformance2/textures/misc/tex-mipmap-levels.html failing on 10.12 with AMD GPUs. The previous failure suppression covered this configuration, and it turns out it's unacceptably flaky there, too. Mark: conformance2/textures/misc/tex-base-level-bug.html failing on 10.13 with AMD GPUs. When the test fails, it fails three times in a row. Tbr: cblume@chromium.org Bug: 870856 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibe020fabc74661dc4c8d8553a292ca5f8666ea77 Reviewed-on: https://chromium-review.googlesource.com/1181655Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#584565}
-
Kyle Qian authored
This CL includes concrete implementations for the abstract classes AtomicBoolean and AtomicReference defined in the Nearby library. An AtomicBoolean is a boolean value that may be updated atomically, and an AtomicReference is an object reference that may be updated atomically. Because the actual Nearby library has yet to be merged into the CrOS directory, this CL includes stand-in Nearby abstract classes under the temporary directory //chromeos/components/nearby/library. This directory will be removed after the Nearby library gets imported to //third_party (in-progress CL: https://chromium-review.googlesource.com/c/chromium/src/+/1113198). Bug: 861813 Change-Id: Ibbda1bd35e3fb63eed0ae492ecebb3d61fa43050 Reviewed-on: https://chromium-review.googlesource.com/1142478 Commit-Queue: Kyle Qian <kyleqian@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#584564}
-
Kenneth Russell authored
SwiftShader isn't available on 32-bit ARM yet. Bug: 875172 Change-Id: I3ddeec51d8ef156def5f5194c75cec31a4aa9412 Reviewed-on: https://chromium-review.googlesource.com/1181767Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584563}
-
Tom Anderson authored
"Some compilers offer an extension that allows ## to appear after a comma and before __VA_ARGS__, in which case the ## does nothing when the variable arguments are present, but removes the comma when the variable arguments are not present: this makes it possible to define macros such as fprintf (stderr, format, ##__VA_ARGS__)" [1] This is problematic for Chromium since ##__VA_ARGS__ doesn't swallow the preceding comma in standards-compliant mode on gcc [2]. Since we use this feature in Chromium (eg base), switch the gcc config back to -std=gnu*. C++20 adds a standards-compliant macro called __VA_OPT__ that we can use to replicate the behavior of ##__VA_ARGS__ when we eventually enable it. [1] https://en.cppreference.com/w/cpp/preprocessor/replace [2] https://github.com/gcc-mirror/gcc/blob/6d6279f88e9678c458bc22ea3be03e73f462f9e7/libcpp/macro.c#L1167 R=thakis Change-Id: I6c0f3e64ad21b6270822011733d44098537b8f02 Reviewed-on: https://chromium-review.googlesource.com/1181657Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Jennifer Apacible authored
NOTRY=true (disabling test) Bug: 876050 TBR: mlamouri@chromium.org Change-Id: I194461ae3a8ca045dd0b9201331c191bc644ec5b Reviewed-on: https://chromium-review.googlesource.com/1182293Reviewed-by:
-
Fady Samuel authored
This CL converts some not so useful CHECKs in AsyncLayerTreeFrameSink into DCHECKs that can be caught in debug builds by developers. We would like to merge this CL into M69 as well to eliminate a source of renderer crashes. Bug: 871450 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I235d068ea72774b020ba7a241507d0f4201d8dc0 Reviewed-on: https://chromium-review.googlesource.com/1181766Reviewed-by:
-
Brian Sheedy authored
This reverts commit 4b3c7082. Reason for revert: Causing XR tests to disappear/not be listed https://bugs.chromium.org/p/chromium/issues/detail?id=875909 Original change's description: > Replace enum with @IntDef (javatests) > > @IntDef/@StringDef annotation are preferred way for declaring > set of String/int values. > > 1. they need less space in APK than enum, see > https://developer.android.com/topic/performance/reduce-apk-size#remove-enums > 2. they give more control over allowed values than "static final" values > > Main goal of patch is writing "static final" values, enum > and some classes in one common @IntDef/@StringDef form: > > 1. with @IntDef/@StringDef first, @Retention second > and related @interface third > 2. with values inside @interface > 3. with NUM_ENTRIES declaring number of entries if necessary > 4. with comment about numbering from 0 without gaps when necessary > 5. with @Retention(RetentionPolicy.SOURCE) > 6. without "static final" in the @interface > > Change-Id: I6aeb3571f6e72dd3599a4a6055189a227312d5c4 > Reviewed-on: https://chromium-review.googlesource.com/1154527 > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> > Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> > Cr-Commit-Position: refs/heads/master@{#584198} TBR=tedchoc@chromium.org,asimjour@chromium.org,agrieve@chromium.org,marcin@mwiacek.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2acb8a9712d544e86bcbcf4ace09f0bcb9ccb77e Reviewed-on: https://chromium-review.googlesource.com/1181802Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584559}
-
Peter Collingbourne authored
These programs will be used to extract resource whitelists from PDBs. Not creating a new package because llvm-undname at our pinned revision cannot demangle resource whitelist function names without crashing. Bug: 684788 Change-Id: I75bb11abcaca456adbea53799359a3259b942b17 Reviewed-on: https://chromium-review.googlesource.com/1180646Reviewed-by:
-
Nico Weber authored
Bug: 330260 Change-Id: I7e2d9d6d12f28d92ef157911edab9f3a0769cae2 Reviewed-on: https://chromium-review.googlesource.com/1181871Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584557}
-
Rayan Kanso authored
TBR=peter@chromium.org Change-Id: Id0351debe9c0c99f885ce5fd324068279e050e4e Reviewed-on: https://chromium-review.googlesource.com/1181601Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#584556}
-
Jeremy Klein authored
R=azeemarshad@chromium.org Bug: 850823 Change-Id: If8779b18e39f498c75798b092816adb79b1a7bfb Reviewed-on: https://chromium-review.googlesource.com/1180487 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
-
Bailey Berro authored
Bug: None Change-Id: Ibaa0d86ef700576a96d8b5a40e04c8cb4fb8b850 Reviewed-on: https://chromium-review.googlesource.com/1181769Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#584554}
-
Miguel Casas authored
crrev.com/c/1171566 got reverted due to a mishmash of performance improvements and regressions. Instead of relanding it verbatim, the innocent/innocuous parts were landed in crrev.com/c/1180295; this CL gets the tough parts, including restricting it to VP9 and Kabylakes. I also repeated the power consumption results (https://goo.gl/r88qPf), and in a nutshell I see improvements: w/ this CL: 1.88 0.63 0.41 0.52 (pkg - pp1 - gfx - dram) ToT : 2.72 0.76 1.03 0.57 Savings : 30.78% 17.51% 59.95% 7.60% TBR=dcastagna@, hoegsberg@ Original CL description ----------------------------------------------- vaapi: decode on client NativePixmaps This CL teaches VaVDA to use client VASurfaceIDs to decode onto, saving a buffer copy and removing a costly blit (DownloadFromSurface) on the GPU Main thread. Three groups of changes: 1. In AssignPictureBuffers(): if |vaapi_picture_factory_| Create()s a VaapiPicture with a VASurfaceID, we use those to decode onto and set a new flag: |decode_using_client_picture_buffers_| 2. When the decoder calls CreateVASurface(), instead of giving it the first |available_va_surfaces_|, we need to figure out the first VASurfaceID in this |available_va_surfaces_| such that the corresponding VaapiPicture in |pictures_| is available (i.e. in |available_picture_buffers_|). Reason: libva holds on to some VASurfaceIDs, there's no simple one-to-one correspondence like on ToT. 3. When we're ready to OutputPicture() to |client_|, instead of using the first |available_picture_buffers_|, we find the corresponding one for the passed |va_surface_id| (we could search all over |pictures_| but there's always less |available_picture_buffers_|. Some other notable developments: - s/output_buffers_/available_picture_buffers_/ - OutputPicture() loses a parameter. - |decode_using_client_picture_buffers_| is still false for e.g. VP9 Profile 2 or the ImportBufferForPicture() path. Bug: 822346, 717265 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icf1a9a1fa71264a7367fa351e3b7d28fab346744 Reviewed-on: https://chromium-review.googlesource.com/1181464Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#584553}
-
Balazs Engedy authored
Bug: 875903 Change-Id: I82c0e154101e7fee7c74262eadfc1ce974ae0a67 Reviewed-on: https://chromium-review.googlesource.com/1181566Reviewed-by:
-
Mohamed Heikal authored
Toolbar inflation currently takes around 200-300ms on the critical path during startup. This cl creates the class AsyncViewStub so that the toolbar stub is inflated on a background thread outside of the critical path. This leads to an improvement of 60ms for startup and 50ms for startup to contentful paint. Improvements are less than the 200ms being saved due to the remeasure+redraw caused by adding new views to the view hierarchy after startup. Design doc https://docs.google.com/document/d/1lwfhlWqp6os_QhikuqCx60LW5FdSbJ-40Es8ACGd4fI/edit?usp=sharing Change-Id: I1841f5adbb01a853e952b2e61dedfd4c951e125e Bug: 762120 Reviewed-on: https://chromium-review.googlesource.com/1136797Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#584551}
-
Anna Offenwanger authored
Runtimes should only be handled by the XRRuntimeManager. Moving the logic which handles getting current display info as well as checking for session supports out of XRDeviceImpl is a step in that direction. Bug: 842025 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I95bd331a30c91deb665aa12853f8a80d79c0e51b Reviewed-on: https://chromium-review.googlesource.com/1181535Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#584550}
-
John Z Wu authored
This should alleviate flaky errors when translating on iOS. When translate is tapped, translate_ios.js polls translate.js to wait for translate element ready and then later polls again to wait for the translation result. Polling can often time out due to network slowness. Bug: 869729 Change-Id: I7e0e46fe279571f21b3aa0dd18f241dc83afee90 Reviewed-on: https://chromium-review.googlesource.com/1178691Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#584549}
-
chrome://interstitialschrome://chrome-urlsMustafa Emre Acer authored
Bug: 875623 Change-Id: I746ddd20e991615f875ca479aab4abca921f123c Reviewed-on: https://chromium-review.googlesource.com/1181659Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#584548}
-
