- 17 Jan, 2020 40 commits
-
-
David Staessens authored
This CL moves the IsCtrlExposed function to the V4L2 device, so it can be reused at other places. Additionally this reduces the number of IOCTLS executed directly inside the VEA, to provide a better abstraction of the V4L2 device. TEST=./video_encode_accelerator_unittest on hana BUG=None Change-Id: I37981e0b75adcd386a6065f25560dd89dce41791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969083Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#732674}
-
liberato@chromium.org authored
The SmoothnessHelper now measures how many consecutive windows have a proportion of dropped frames that's over a threshold. It outputs a training example with maximum such number found over a playback. Additionally, it now assumes that it will be created when playback starts, and will be destroyed when it ends, rather than taking an explicit "is playing" signal. If the feature vector changes, then the SmoothnessHelper should be destroyed / reconstructed too. Change-Id: I8ceef55f33d6d8164f4a6e2d0e1c77fdbbce53e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004071 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#732673}
-
Ted Meyer authored
Share some of the helper macros from MediaLogProperties with these two new types in the media_log_type_enforcement.h file, which replaces media_log_properties_helper.h Bug: 794255 Change-Id: I7c709c5ac881b3bf03ba327d850e0c58824cec57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006130 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#732672}
-
Kenichi Ishibashi authored
This is similar to crrev.com/c/1999974 but for FindRegistrationForId{,Only}(). ServiceWorkerStorage::DidFindRegistrationForId() became identical to DidFindRegistration() so it was merged into a single method. This CL also changes some tests not to use ServiceWorkerStorage directly. Use ServiceWorkerRegistry instead. FindInstallingRegistrationXXX() are now private methods because ServiceWorkerStorage doesn't use them anymore. Bug: 1039200 Change-Id: Ia218afc7109b5f697933956719890442de68d51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004350Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732671}
-
Hesen Zhang authored
- Change handleUpdateIntent to onUpdateAvailable, and pull it out to UpdateUtils for both implementation to use. Bug: 1013685 Change-Id: I5474e4c8c025ce97b8cec74dfa7bbfb0f9f7bcef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001065 Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#732670}
-
Tim Song authored
BUG=1042946 Change-Id: I665dbfa33d041c870a18433c7f69225cc4e00c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006192 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732669}
-
Md. Hasanur Rashid authored
Currently, if we can't retrieve the app's icon or the app has no icons, we use the app's start URL to generate an icon. This change use the app's name when available to generate the icon. Bug: 904280 Change-Id: I6233ea5ee90f32de6e270123239055f425edd257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989435Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Cr-Commit-Position: refs/heads/master@{#732668}
-
Peter Kotwicz authored
This CL: - Adds @Inject constructor to WebApkUpdateManager - Makes WebApkUpdateManager listen for activity destruction instead of having WebApkActivity call WebApkUpdateManager#destroy() BUG=1042147 Change-Id: I803900ffe2eaf7c8999dc54248676c93caf5b0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001360 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#732667}
-
Domenic Denicola authored
This updates the parsing of the feature policy parts of the origin policy manifest to mostly match the latest spec draft at https://wicg.github.io/origin-policy/, in particular https://wicg.github.io/origin-policy/#parsing. That is, it moves away from "content-security-policy": [{ "policy": "string", "report-only": boolean }] to "content_security": { "policies": ["...CSP strings"], "policies_report_only": ["...CSP strings"] }. Additionally, it removes the failure on parsing errors, as those are no longer in the spec. This does not yet properly parse the CSP string as a CSP; instead it still treats it as a header (so, commas are allowed inside). A failing test is added for that case, which will be addressed in a followup CL. Bug: 751996 Change-Id: I8d14815b486afd4a5622bc4b25874c81418fd38c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977148 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#732666}
-
Xiaohan Wang authored
Currently when |use_media_player| is true, we'll add FactoryType::kMediaPlayer as the base factory type. But we didn't set |use_default_renderer_factory| to be false, so later we'll add FactoryType::kDefault as the base factory type again, which overrides the FactoryType::kMediaPlayer one we just added. This CL makes sure we set |use_default_renderer_factory| to be false so that this bug doesn't happen. This function is still hard to read and error prone. In the future we should improve this function further. Bug: 1040456 Test: Manually tested. Change-Id: Iade8a45426b3ff9835bb2b6cbc415f4df8a0cf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005090Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#732665}
-
Peter Collingbourne authored
Bug: 891999 Change-Id: I028fc04d68a5a1c7da1c44933346001630274235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997651 Auto-Submit: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#732664}
-
Ted Meyer authored
This just helps out the next CL in line which adds the new types for media log and needs to serialize some of the buffering state types. Bug: 794255 Change-Id: Id83d79108edc0021316fc362a222eadab7d3f032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005818Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#732663}
-
Roman Aleksandrov authored
Bug: 873114 Change-Id: I05cef0d2a7e53c1bc965764e2b83aefd502753cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993828Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#732662}
-
Alex Turner authored
Enables memoryMetric when a benchmark argument is provided, setting the appropriate options. These metrics are put behind a flag as it adds over 300 metrics, which may crowd the output unnecessarily. Bug: 1042404 Change-Id: I05c5e9d2434c5a07a3d2aa632c64f0d077c2443c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002761 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732661}
-
shrekshao authored
TBR=kbr@chromium.org Bug: 1042897 Change-Id: I0c3d58eae57c808afdcd4569e154038db595f609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005826Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#732660}
-
Jarryd authored
Bug: 1034579 Change-Id: I0e1b87efb157b2117b04d49e5888f29bc84edfbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978425 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#732659}
-
Josh Nohle authored
Bug: 951969, 936273, 933656 Change-Id: I9101d47dddd434f9a4c756bc3153d2980d2b2686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980508 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#732658}
-
Dale Curtis authored
Plumbs AudioCodecProfile into AudioDecoderConfig and uses it in a few key locations: - FFmpegAudioDecoder will now reject xHE-AAC content to ensure we get faster startup of MediaCodecAudioDecoder for this content. - MediaCodecBridgeImpl will use this to avoid parsing the ESDS extra data on its own. Bug: 1019299 Change-Id: Ib9c3da758ca2520e70569e73037217843a2d2a04 Tests: Updated unittests. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999625 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#732657}
-
Jeremy Roman authored
No functional change. Change-Id: I3c60d5c1f8b2f2f750c61137cc3db6d2d9744b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005824 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#732656}
-
Ilya Sherman authored
Change-Id: I35f0290322be962918a92a1866974ffe61b955ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006448 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732655}
-
David Bokan authored
This reverts commit ffff10c5. Reason for revert: Temporary CL served it's purpose. ScrollNodes marked as inner_viewport aren't the same as InnerViewportScrollNode. Original change's description: > Add CHECKs to debug crash > > It looks like this crashes because of a null outer viewport scroll node. > That should never happen here because we have an inner viewport scroll > node. > > There's a few ways this could be going wrong: > > - A ScrollNode is marked as the inner scroll node even though it wasn't > registered as one in viewport_property_ids_ > - The ScrollNode doesn't exist in the property tree even though it was > registered. > - We're getting this bad combination from Blink. > > I've turned a few DCHECKs into release CHECKs to narrow down which of > these it might be. > > Bug: 1037759 > Change-Id: I972582da6e18725557859063da0889d465063c77 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981268 > Commit-Queue: David Bokan <bokan@chromium.org> > Auto-Submit: David Bokan <bokan@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728220} TBR=wangxianzhu@chromium.org,bokan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1037759 Change-Id: I64811d9a30b6ba98b395f6e4ea434958afa0b706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006248Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732654}
-
Jinsuk Kim authored
HistoryNavigationLayout is a top level layout class of gesture navigation feature, and is a child view of Tab's ContentView. This CL moves it one level up in the view hierarchy so that it becomes a child of CompositorViewHolder instead. This has a few benefits: 1) Many native pages included HistoryNavigationLayout in its layout definition. This caused undesirable dependencies on gesture navigation, blocking component-wise modularization efforts. Once it is removed from native page layout, it becomes much easier to build each component as its own target. 2) Gesture navigation-related UI doesn't have to be instantiated for each tab. A single set of instances can be used for all, each tab only needing to provide with navigation delegate objects that have dependency on tab when it goes foreground. 3) When the layout is added to Tab's content view, the UI (especially arrow's fade-away animation when navigation starts) is visible as long as its parent view is alive, but navigation between rendered and native page swaps out the content view. This keeps the navigation and animation from starting simultaneously. The refactoring gets rid of this limitation. Major changes are: - CompositorViewHolder dispatches touch event to HistoryNavigationLayout. If the right gesture is detected, lets it consume the following events. - HistoryNavigationLayout in native pages are either removed or all replaced with FrameLayout. This is basically reverting relevant parts of the past CLs: https://crrev.com/c/1249530 Implement gesture navigation on Android https://crrev.com/c/1423477 Android: More native pages become navigable https://crrev.com/c/1547547 Android: Trigger history navigation with edge swipe https://crrev.com/c/1554200 Android: Enable overscroll navigation in explore site page - Rendered pages also make use of HistoryNavigationLayout (previously SwipeRefreshHandler had its own NavigationHandler) and reference the NavigationHandler that the layout provides. This helps consolidate most of the navigation event handling logic in the layout. Bug: 1003914 Change-Id: I62ed28bd8f6aab39ca7a47f2e3fdce7a131fbfb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961351 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#732653}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bdb0f8a52414..d968972519ba git log bdb0f8a52414..d968972519ba --date=short --first-parent --format='%ad %ae %s' 2020-01-16 jonahr@google.com Suppress UniformsBenchmark perftest on Win/NVIDIA/Vulkan 2020-01-16 m.maiya@samsung.com EGL: Add support for EGL_EXT_pixel_format_float extension 2020-01-16 sugoi@google.com Blendable check 2020-01-16 jmadill@chromium.org Vulkan: Make ContextVk own ResourceUseList. 2020-01-16 jdarpinian@chromium.org Require DEBUG_TRACE to enable expensive state validation 2020-01-16 jdarpinian@chromium.org Remove literal tab characters from generate_parser_tools.py 2020-01-16 jmadill@chromium.org Vulkan: Add ResourceUseList helper. Created with: gclient setdep -r src/third_party/angle@d968972519ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1041672 Tbr: jonahr@google.com Change-Id: Ia0f06af0bc2907b9450fe060b331dc482a14eb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006328Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732652}
-
Ryan Hamilton authored
Change-Id: I0b35b89c0b9721b11932925451e2e8a2c5024740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005825 Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732651}
-
Martin Kreichgauer authored
The onEnrolling_() method and its EnrollmentStatus argument type were conflating two logically separate events: fingerprint sample status updates ("sensor was touched") and handling the final enrollment response. Splitting the type in two (SampleResponse / EnrollmentResponse), and handle them in separate methods simplifies the code. Also improve error handling in both cases: - failure status codes in a SampleResponse cause a "try again" message in the enrollment sheet to be shown - CTAP2 errors on the EnrollmentResponse make the dialog proceed to the error sheet Bug: 974046 Change-Id: Ib8492aae493374f84b368bb6eca6b9eb439af685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999268 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#732650}
-
Sergey Ulanov authored
glyph_cache_max_texture_bytes was passed to PaintOpBufferSerializer as max_texture_bytes in RasterImplementation::RasterCHROMIUM(). max_texture_bytes is not actually used for anything after crrev.com/688282. This means that max_texture_bytes doesn't need to be passed to PaintOpBuffer and glyph_cache_max_texture_bytes() can be removed as well. Change-Id: Id13234fbfcf4ece578fbd89d57fd15a018590444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995614 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732649}
-
John Williams authored
Change-Id: I1e5f451d72b5710f05d08ea80e0b70620df735ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990445 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#732648}
-
Alex Newcomer authored
Change-Id: I186d1194c1c02d1629371a90cbfc59663a6a247e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006414 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#732647}
-
Henrique Nakashima authored
Register them in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: I37170d334330199bfd996791934c4e5e6f0763d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003752Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#732646}
-
Regan Hsu authored
This CL creates a placeholder for the OS settings strings provider and Shared settings strings provider. Strings used exclusively by OS settings will be moved to the OS settings provider, and strings used by both the browser and OS will be moved to the shared settings string provider. Follow-up CLs will start transferring strings page-by-page from the browser strings provider to either the OS or shared string provider. As an example, this CL divides the A11y page strings between browser, OS, and shared string providers. Bug: 967888 Change-Id: I2f558cca8b17a66b88af184bb5643cabdef7fee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001850 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#732645}
-
Alex Newcomer authored
Just remove this old code that is no longer used. Change-Id: If6a75621e262f89f4fdc6154e8eddbbc9fa9cb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006411 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#732644}
-
Raymond Toy authored
The limits for the detune AudioParam have been updated to use the same limits as OscillatorNode.detune. The gain AudioParam limits have been reduced so as not to cause overflow since the gain is in dB. Tests in audioparam-nominal-range.html updated with new results. We also took this opportunity to fix a few minor style issues. (Use mostPositiveFloat instead of literal value, and add space between prefix and message for clipped values. See WebAudio spec issues: https://github.com/WebAudio/web-audio-api/issues/2113 https://github.com/WebAudio/web-audio-api/issues/2087 Chrome Status: https://www.chromestatus.com/feature/6567195645575168 This CL makes the implementation conform to the spec. Bug: 1018303 Change-Id: I42c7ec2883fc20dbd59bc6c011ce865159648359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968293 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732643}
-
Jeroen Dhollander authored
This scrollbar showed up on small devices when retraining the voice match (settings -> Search and Assistant -> Google Assistant -> "Ok Google" -> Voice match -> Retrain). After investigating I also noticed the header on every Assistant screen was 12px lower than the headers on the other OOBE screens. Fixing that also fixed the scrollbar issue, as now the screen is small enough to fit. Note that the OOBE spec does not specify the height between the top-left icon and the header, but it is set to 20px here so I copied that: https://osscs.corp.google.com/chromium/chromium/src/+/master:chrome/browser/resources/chromeos/login/oobe_dialog.css;l=30?q=oobe-title&ss=chromium Bug: b/147691810 Change-Id: I1fa872c16e4a2ba55f06cb8316b1511ca5fbb28d Tests: Manually deployed and tested Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001162Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#732642}
-
Gyuyoung Kim authored
This CL replaces .mojom.h includes with .mojom-forward.h in some sub-directories of chrome/browser to reduce the pre-processed size of header files and shorter build time. The sub-directories are following, - chrome/browser/devtools - chrome/browser/download - chrome/browser/engagement - chrome/browser/extensions - chrome/browser/guest_view - chrome/browser/language - chrome/browser/lookalikes This CL has no behavior changes. Bug: 1001360 Change-Id: I72c3e4a30c561487b07ea9d94f3d88be93e30ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977882Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#732641}
-
Steven Bingler authored
Changed cookie names and values in test case vectors to assist with finding failing test cases. Change-Id: If7a7ffa3f2547e81658675184434a5a2ea27e6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002745Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#732640}
-
Meredith Lane authored
This reverts commit 1a7be35f. Reason for revert: Deterministically fails on linux-chromeos-chrome, starting: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/1806 Original change's description: > Enable SafeBrowsingIsRealtimeReportingEnabledTest on Chrome OS. > > Previously no setup was done for Chrome OS and the tests assumed that > RealtimeReporting is never enabled on Chrome OS. > Now it covers the same scenarios as on other platforms, but requires > some extensive setup. > > In a follow-up CL I'll add Chrome OS specific tests for different > scenarios, e.g.device/user managed/non-managed and etc. > > Bug: 1012048 > Change-Id: I810ae8c541fa0040ff63a8d7377129246a5473c8 > Tests: Unit test updated. > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002514 > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732562} TBR=poromov@chromium.org,drubery@chromium.org Change-Id: I569a1e59f1c823d49b0b2f3c465276215ad7c49b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1012048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006274Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#732639}
-
Etienne Bergeron authored
Lift the location into the InitScopedBlockingCall to allow debugging slow cases with slow-reports. Bug: 1027929 Change-Id: Ife752fab110d11fac07a0646e0bc2353e9396ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003213Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#732638}
-
Weilun Shi authored
Create entropy_state_provider to record low_entropy_source and old_low_entropy_source values to system profile for every metrics logs as well as the local persistent file. Bug: 1013707 Change-Id: Ie7fe38b023ada65e92e113aafaa49705b4931c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994098 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#732637}
-
Meredith Lane authored
This reverts commit 9bce3656. Reason for revert: Failing on Mac10.12, starting at: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31135 Original change's description: > Collect enterprise UMAs on the Mac. > > Collect basic information as to whether the Mac is joined to a domain, > or if it is controlled by MDM. > > Fixes: 1040630 > Change-Id: Ie8de61e83dc6a4174311970a59798b451335b14f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994122 > Commit-Queue: Avi Drissman <avi@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732512} TBR=avi@chromium.org,pastarmovj@chromium.org,asvitkine@chromium.org,mark@chromium.org Change-Id: I15e1ca7dc3e10ac7577cd9f916b09b3b33fe1885 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006273Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#732636}
-
Dale Curtis authored
Android P+ includes support for xHE-AAC decoding. Unfortunately, ffmpeg does not have support for decoding this content yet. So we can only add support on Android at this time. xHE-AAC uses an "audio object type" value of 42, which can't be written into an ADTS header (only 2 bits in size), which required disabling ADTS wrapping for src= and MSE when xHE-AAC content is detected. For some reason our MediaCodec code has always been deconstructing the ESDS package and only sending bits of it out. Per the MediaCodec docs we should just send the entire ESDS. Since this may break things, I've only done this for xHE-AAC profiles in this CL. No metrics are added in this change, that will be done in a follow up. Bug: 1019299 Test: Various new unittests; though no bots run P+ unfortunately. Test: https://www2.iis.fraunhofer.de/AAC/xhe-aac.html on P+ manually. Change-Id: I4343f202f2444dc0f3f391085da0ecc33a72be72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992006Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732635}
-