GitLab

/LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of the WPO build without affecting the code quality and the performance, see https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incremental-developer-build-scenario/ for more details on this.

Review-Url: https://codereview.chromium.org/2045683002
Cr-Commit-Position: refs/heads/master@{#398153}

Remove a couple of possible sources of dangling pointers and make the
tests cleaner and more compact.

Review-Url: https://codereview.chromium.org/2038183002
Cr-Commit-Position: refs/heads/master@{#398152}

Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

BUG=526586

Review-Url: https://codereview.chromium.org/2034013002
Cr-Commit-Position: refs/heads/master@{#398151}

This CL replaces some uses of the non-existent
--google-grey-600 with --paper-grey-600

BUG=589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2010283003
Cr-Commit-Position: refs/heads/master@{#398150}

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see this CL's comments).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=dtrainor@chromium.org

Review-Url: https://codereview.chromium.org/2034703003
Cr-Commit-Position: refs/heads/master@{#398149}

This relands parts of https://codereview.chromium.org/1947183004/
Now that clobber runs as a separate step before runhooks, swarming should work
on gn clobber bots.

BUG=498033

Review-Url: https://codereview.chromium.org/2043743003
Cr-Commit-Position: refs/heads/master@{#398148}

Image changed notifications are used by animated images to notify
LayoutObject clients that they need to repaint. These notifications
typically result in paint invalidations. Animated bitmap images have
some logic[1] to handle "falling behind" which would synchronously
fire image changed notifications during paint. This results in missed
paint invalidations as well as a changing layout tree out from under
the paint system.

This patch moves the synchronous image change notifications to an
immediate task which occurs after paint has completed.

[1] When painting animated gifs on a heavily loaded system (or a debug
build), pauses in the system can cause the animation to get behind.
When this happens, we want to advance the animation and catch-up but
prevent the next frame from using the same catch-up logic which could
get us in an infinite catch-up loop.

BUG=616700

Review-Url: https://codereview.chromium.org/2038243002
Cr-Commit-Position: refs/heads/master@{#398147}

TBR=dtu@chromium.org
BUG=605318

Review-Url: https://codereview.chromium.org/2045693003
Cr-Commit-Position: refs/heads/master@{#398146}

BUG=604568

Review-Url: https://codereview.chromium.org/2032253004
Cr-Commit-Position: refs/heads/master@{#398145}

Revert of mac: ensure ui::Compositor exists for visible RWHVs (patchset #12 id:220001 of https://codereview.chromium.org/2005013002/ )

Reason for revert:
Causes blank tabs, tab switching perf tests

BUG=617497,617427

Original issue's description:
> mac: ensure ui::Compositor exists for visible RWHVs
>
> RenderWidgetHostViewMac is careful about creating ui::Compositor and so
> currently only does this in Show and SwapCompositorFrame.  However, if
> it the RenderWidgetHostView is created while the RenderWidgetHost is
> visible, then Show will early out and never create a ui::Compositor.
>
> This causes problems with begin frame scheduling, which wants to have
> the Display (which is created as part of creating the ui::Compositor's
> output surface currently) own the real begin frame source that drives
> everything.  In that world, if no ui::Compositor exists, no frames ever
> are sent or swapped.  So, the ui::Compositor needs to be created first.
>
> Also, if the ui::Compositor is correctly created during Show (or the
> constructor), then there's no need to ensure that it exists during
> swap compositor frame, and so that can be safely removed.
>
> R=asvitkine@chromium.org,ccameron@chromium.org
>
> Committed: https://crrev.com/9af6c23da7070f9423d5cf25856ed27f7d5d8e5e
> Cr-Commit-Position: refs/heads/master@{#397755}

TBR=phajdan.jr@chromium.org,asvitkine@chromium.org,ccameron@chromium.org,danakj@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2040013002
Cr-Commit-Position: refs/heads/master@{#398144}

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2034123002
Cr-Commit-Position: refs/heads/master@{#398143}

OpenGL compiles shader code as text at runtime. It is inconvienent to
edit shader code as const char[] inside the C++ source code.

This CL contains script that reads file contents, turns them into const
char[], and combine them into a header file.

BUG=385924

Review-Url: https://codereview.chromium.org/2036023003
Cr-Commit-Position: refs/heads/master@{#398142}

1. Changed the icon for the "Manage people" button;
2. Changed the icon for sync error on the titlebar.

See design doc here: https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.6xesoh23gozz

This CL is dependent on https://codereview.chromium.org/2028473002/

BUG=615893

Review-Url: https://codereview.chromium.org/2019053002
Cr-Commit-Position: refs/heads/master@{#398141}

Revert of Remove use of deprecated MessageLoop methods in ipc. (patchset #1 id:1 of https://codereview.chromium.org/2037853002/ )

Reason for revert:
MessageLoopForIO::current() has a DCHECK but ThreadTaskRunnerHandle::Get() doesn't. See discussion https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/Wj_cNO2l2qE

Original issue's description:
> Remove use of deprecated MessageLoop methods in ipc.
>
> MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
> are deprecated. This CL makes the following replacements to
> remove some uses of these methods:
>
> "MessageLoop(ForUI|ForIO)::current()->PostTask" ->
>   "ThreadTaskRunnerHandle::Get()->PostTask"
> "MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
>   "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
> "MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
>   "ThreadTaskRunnerHandle::Get()->DeleteSoon"
> "MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
>   "ThreadTaskRunnerHandle::Get()->ReleaseSoon"
>
> In files where these replacements are made, it adds these includes:
>   #include "base/location.h"
>   #include "base/single_thread_task_runner.h"
>   #include "base/threading/thread_task_runner_handle.h"
>
> And removes this include if it is no longer required:
>   #include "base/message_loop/message_loop.h"
>
> Why ThreadTaskRunnerHandle::Get() instead of
> MessageLoop::current()->task_runner()?
>  - The two are equivalent on threads that run a MessageLoop.
>  - MessageLoop::current() doesn't work in base/task_scheduler
>    because the scheduler's thread don't run MessageLoops.
>    This CL will therefore facilitate the migration of browser
>    threads to base/task_scheduler.
>
> Steps to generate this patch:
> 1. Run message_loop_cleanup.py (see code on the bug).
> 2. Run tools/sort-headers.py on modified files.
> 3. Run git cl format.
>
> BUG=616447
> R=cpu@chromium.org
>
> Committed: https://crrev.com/2eb9714a01e03a8b091a8ea34f023e24f62e5a9f
> Cr-Commit-Position: refs/heads/master@{#398040}

TBR=cpu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616447

Review-Url: https://codereview.chromium.org/2038363004
Cr-Commit-Position: refs/heads/master@{#398140}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8f31b02e7cdf..2b7a13d86594

$ git log 8f31b02e7..2b7a13d86 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2044663002
Cr-Commit-Position: refs/heads/master@{#398139}

BUG=599327

Review-Url: https://codereview.chromium.org/2040043002
Cr-Commit-Position: refs/heads/master@{#398138}

Revert of Reland of Move side-loaded test data /sdcard -> /sdcard/gtestdata (patchset #3 id:300001 of https://codereview.chromium.org/2018663002/ )

Reason for revert:
Breaking quota-related tests in content_browsertests
https://crbug.com/617213

Original issue's description:
> Reland of Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root
>
> Reason for reland:
> Updated webview tests that broke (WebViewLayoutTest.java)
>
> And use delete_device_stale=True when pushing. This will prevent tests
> mistakenly passing when they depend on stale data files from a previous test.
>
> TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org
> BUG=607169
>
> Committed: https://crrev.com/2524a0db714a44fbce723e00f6ed914e6d143cb6
> Cr-Commit-Position: refs/heads/master@{#396479}

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=607169,617213,616155

Review-Url: https://codereview.chromium.org/2044523003
Cr-Commit-Position: refs/heads/master@{#398137}

The feature was already shipped, and there is no relevant trial
on trunk source code.

Note: This configuration looks wrong. Since the study used FeatureList
API, it should have an enable_features field to enable it correctly.

BUG=n/a

Review-Url: https://codereview.chromium.org/2046463002
Cr-Commit-Position: refs/heads/master@{#398136}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6aed5443..f8c7729d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2039963002
Cr-Commit-Position: refs/heads/master@{#398135}

TraceStackFramePointers() function, which unwinds stack using frame pointers,
sometimes crashes on Android when it dives deep into JVM internals and finds
bad stack pointer there. See details here: crbug.com/602701#c18

This CL adds checks to make sure only valid stack pointers are dereferenced.

BUG=602701

Review-Url: https://codereview.chromium.org/1975393002
Cr-Commit-Position: refs/heads/master@{#398134}

Tests included for dialog.
Screenshots in bug.

BUG=607348
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2015463003
Cr-Commit-Position: refs/heads/master@{#398133}

This CL uses WeakPtrFactory to post task in
net::BidirectionalStream.

BUG=606394

Review-Url: https://codereview.chromium.org/2043863002
Cr-Commit-Position: refs/heads/master@{#398132}

R=davidben@chromium.org

Review-Url: https://codereview.chromium.org/2047483002
Cr-Commit-Position: refs/heads/master@{#398131}

BUG=586390

Review-Url: https://codereview.chromium.org/2020293003
Cr-Commit-Position: refs/heads/master@{#398130}

Review-Url: https://codereview.chromium.org/2041113002
Cr-Commit-Position: refs/heads/master@{#398129}

Learn more at: https://docs.google.com/document/d/1-OEDCDZPjWQHpmuGzaNxz9cRH4bEQXCo4x04ydazYtQ/edit

BUG=612422

Review-Url: https://codereview.chromium.org/1984173002
Cr-Commit-Position: refs/heads/master@{#398128}

https://chromium.googlesource.com/skia.git/+log/09f5cd44ae30..dc27a648d2ff

$ git log 09f5cd44a..dc27a648d --date=short --no-merges --format='%ad %ae %s'
2016-06-06 msarett Add SkDefaultXform as a catch-all to handle color conversions
2016-06-06 scroggo Use Options object passed to startScanlineDecode
2016-06-06 scroggo Revert of Make SkPngCodec decode progressively. (patchset #26 id:520001 of https://codereview.chromium.org/1997703003/ )
2016-06-06 msarett Gamma sanity checks

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review-Url: https://codereview.chromium.org/2043873002
Cr-Commit-Position: refs/heads/master@{#398127}

GetOutsets provided imprecise -- or possibly incorrect -- outsets for certain
reference filters, such as <feOffset>. Instead RenderSurfaceImpl should
explicitly specify that it wants forward mapping here.

Also fix this to incorporate scale factors in the filter rect calculations
(e.g. due to a high DPI display), and add unit tests.

BUG=600821
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2018983003
Cr-Commit-Position: refs/heads/master@{#398126}

R=sky@chromium.org
BUG=617315

Review-Url: https://codereview.chromium.org/2040783002
Cr-Commit-Position: refs/heads/master@{#398125}

The original author can't remember why this post was necessary. Since
the actual result callback is posted immediately afterwards any
side-effects (such as synchronizing with another message loop) should
already be achieved.

Review-Url: https://codereview.chromium.org/2044603002
Cr-Commit-Position: refs/heads/master@{#398124}

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2031743005
Cr-Commit-Position: refs/heads/master@{#398123}

BUG=b/27776147

Review-Url: https://codereview.chromium.org/2033373003
Cr-Commit-Position: refs/heads/master@{#398122}

Although Chromium wisely disables this ancient UNIX bug, the net stack is part
of Cronet which may be used in other consumers. Rather than modify the global
signal dispositions (bad manners for a library) or propagate this requirement
to the callers (also bad manners, if sound), make an attempt to suppress the
signal on a per-socket basis.

Unfortunately, iOS/OSX and Linux kindly have different APIs for this, so we
need to touch two places.

BUG=467132

Review-Url: https://codereview.chromium.org/2034433002
Cr-Commit-Position: refs/heads/master@{#398121}

The HTTP request headers normally used by Chrome for Android are
generated in the native layer. We do not want to load native when the
Physical Web is resolving URLs in the background, so we cannot access
these values directly. Instead, they are reconstructed from values
accessible from the Java layer.

BUG=607660

Review-Url: https://codereview.chromium.org/1989963003
Cr-Commit-Position: refs/heads/master@{#398120}

Only the network prediction enabled preference should be used to
schedule or cancel periodic GCM task. The GCM task itself will run only
when suitable for precaching.

BUG=616956

Review-Url: https://codereview.chromium.org/2037913002
Cr-Commit-Position: refs/heads/master@{#398119}

BUG=584342

Review-Url: https://codereview.chromium.org/1966643002
Cr-Commit-Position: refs/heads/master@{#398118}

Reverted after its own LayoutTests timed out in WebKit Win7 bot.
This is due to media/mojo/interfaces not being in the generated
bindings path, and that's being addressed in
https://codereview.chromium.org/2045573002/.

Original landed as https://crrev.com/2027023002
Original description ---------------------------------------------------
ImageCapture: move mojom from WebKit/public to media/

This CL moves image_capture.mojom from
{third_party/WebKit/public/platform/modules => media/mojo/interfaces}
so the generated data types (e.g. PhotoCapabilities{Ptr})
can be used from both Blink and media/capture locations.

Also capture.gypi is trivially relocated to capture/ folder.

Note that gyp files are -yay!- close to being finally
removed.

BUG=518807
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel

TBR=rockot@chromium.org, avi@chromium.org, dcheng@chromium.org, haraken@chromium.org, xhwang@chromium.org  (no code changes).

Review-Url: https://codereview.chromium.org/2040963004
Cr-Commit-Position: refs/heads/master@{#398117}

BUG=612828

Review-Url: https://codereview.chromium.org/2014463003
Cr-Commit-Position: refs/heads/master@{#398116}

BUG=617701

Review-Url: https://codereview.chromium.org/2011213002
Cr-Commit-Position: refs/heads/master@{#398115}

RenderFrame no longer knows about WebElement or WebNode, yay!

R=esprehn
BUG=

Review-Url: https://codereview.chromium.org/2002683002
Cr-Commit-Position: refs/heads/master@{#398114}