- 17 Jul, 2020 40 commits
-
-
Peng Huang authored
I guess the problem is because the gpu_preferences_mojom_traits.h doesn't depends on "ui/base:features", so gpu_preferences_mojom_traits.h may get used before ui/base/buildflags.h is generated. Bug: 1106530 Change-Id: Ieb7b9dd34ffe217bcd7cf9f71d5d75e0e483e172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304770 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#789618}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4181.3-1594638142-benchmark-86.0.4203.0-r1 to 86-4181.3-1594638142-benchmark-86.0.4204.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I20eea36b119287b1ae9104e3df71a08d6b9d1f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305056Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789617}
-
Dave Tapuska authored
The last sent VisualProperties is available as a member on RWHI, add an accessor and adjust the test to use that. We need move this message to mojo and is is easier to read the last sent value than adding a mojo interceptor. BUG=1097816 Change-Id: I3c27a452f3fcbafdec80c092abd9a2b6e65e1d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302449 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#789616}
-
manuk authored
Adds the 8/0/9 and 8/0/10 variations (traditional limit / URL count / dynamic limit). Change-Id: I417255ac3e5495aa0c0e919fe0422ec2c06f4754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304163Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#789615}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If809c21377edd8653e9be4014940af0f1fd5facf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304663Reviewed-by:
-
Swapnil authored
We want to improve the installation time for force installed extensions. For this, we need to first gather the statistics regarding which installation stages are time consuming. We collect the UMA statistics for the time taken to download and parse the update manifest successfully. Following histogram is added: Extensions.ForceInstalledTime.DownloadingStartTo. ManifestDownloadComplete Bug: 1102369 Change-Id: I40137e7551216ebce5bb97046b1e1735184220b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282588 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#789613}
-
Brandon Wylie authored
Bug: 1041576 Change-Id: Iec606ac11fe44ac985d67304c94851a589dd6a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303594Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#789612}
-
Peter Kasting authored
* AnimateStateTransition() is never called; remove. * OpenDownload(), Reenable(), DrawIcon(), UpdateColorsFromTheme(), GetErrorIconSize(), and ReleaseDropdown() are only referenced in one function apiece. Inline them into their callers, which in many cases will provide future refactoring opportunities. In a couple of cases (OnPaint() and ButtonPressed()) the callers are unwieldy as a result; these will be refactored in an upcoming CL. * Reorder a few other functions to try and group related functions together more. * Improve .h comments slightly. Bug: none Change-Id: Ic6801d70b3dadd1c696ee0d97fb8daf5b23f85c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303863 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Aleks Totic authored
Final supporting class for NGTableLayoutAlgorithm. Mostly computes inline/block table constraints. Made NGLayoutInputNode::NextSibling const. Added needed table accessors to NGLayoutInputNode. Bug: 958381 Change-Id: I0a958c81b87da374cd18457cc6f93405e456632b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285840 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#789610}
-
Mario Sanchez Prada authored
Following the lead of crrev.com/c/2140593, this CL moves the logic that serializes a child frame's AXTreeID from //content/renderer into Blink itself, and removes WebElement::GetEmbeddingToken() from Blink's public API. Bug: 1094150, 1068668 Change-Id: I7ea4def5c65be6135e7e3c956f4a25071831d506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302890 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789609}
-
Antonio Gomes authored
... in favor of WTF::Vector. BUG=704136 R=guidou@chromium.org Change-Id: I0a992e355e57b02195c0ac9484e396e89e456e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303298 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#789608}
-
Mustafa Emre Acer authored
Bug: 1095120 Change-Id: Ib911850d7a0900583e763553307065c46f27c367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304193Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#789607}
-
Tim Judkins authored
Adds user actions for each of the options in the extension context menu site access section. These are: - On click - On specific site - On all sites - Learn more Also adds a user action for clicking the three dot menu for an extension in the extensions menu. Bug: 1102658 Change-Id: Id24ae2cfdb409d819f6a1f8da9865236cc8c421d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284263 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/5515d2a0c20c..28652ef368ef 2020-07-17 bclayton@google.com License checker (#1104) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I6c9b2cbd5715394bf1dd99bf80c12ca359eda379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304804Reviewed-by:
-
Henrique Nakashima authored
Bug: 1090052 Change-Id: I17e352f1ac56e035568fd24c442b1045040ed5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250953 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
Kramer Ge authored
OzonePlatformGbm::AddInterfaces() sets the DrmDevice mojo binder callback to run on the calling thread. It takes 2 thread hops before mojo endpoint arrives at DRM thread. This is causing deadlocks when the calling thread is blocked on DRM thread while DRM thread doesn't have the mojo endpoint (so it does not have a DRM device yet). This CL makes AddInterfaces check if in DRM thread is running, and set the callback to run on DRM thread, skipping the extra thread hop. In multi-process mode AddInterfaces is called from VizMainImpl::CreateGpuService, and DRM thread is started right after sandbox entry. Thus deadlock can be avoided. Also change the running thread of binder callbacks to be gpu thread if drm thread is not started. Previously it runs on the calling thread of AddInterfaces and it can introduce cache incoherency on |drm_thread_started_|. Bug: 1090071 Change-Id: I9b0d3918889e4eaa54d3ae231c94402ee5368dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288335Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#789603}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cc5513855cc5..5a4af4624777 2020-07-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 7221ccf85e26 to 680c77fa6c81 (2 revisions) 2020-07-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 4f72970ed3e0 to f3cb1896971f (1 revision) 2020-07-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7548cbeabfa7 to 412b1b7dd18c (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Iad02c929ddcac1a4c40c16058e13997431e65fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304674Reviewed-by:
-
Alex Cooper authored
Though the vr_pixeltests were previously removed from Windows 7 bots, this didn't remove them from all known Windows 7 bots nor new Windows 7 bots. Given that VR is not supported on Windows 7, we don't need to run these tests there, so simply skip them if we're not running on Windows 7. Bug: 1106809 Change-Id: I65d74d4f4c02c25cb37b7488880f78f6dcb27fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304097 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789601}
-
Evan Stade authored
Bug: 1071603 Change-Id: Icbb428e40d2dad8b807ce2298da0a3c01ffcf11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288328 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#789600}
-
Evan Stade authored
Bug: 1071603 Change-Id: Ib53af1b0ed6ca217b0e3b78a5fd41c5eefe240af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304136Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#789599}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/47d86db05ea3..0d8628ddce9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC atotic@google.com,seblalancette@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106750 Tbr: atotic@google.com,seblalancette@google.com Change-Id: I5fed5445088d94270365f34b26dead4e61be3337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304801Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789598}
-
James Long authored
A new component has been made for class details, similar to how the package graph has a panel for package details. This component contains the link to the class' package and a list of the class' build targets. Bug: 1106496 Change-Id: I71b34fa973256cf43984b351769ca95b2fb6bb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303985Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: James Long <yjlong@google.com> Cr-Commit-Position: refs/heads/master@{#789597}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit ed8ef709. Reason for revert: space after "," is buggy Original change's description: > Amend dom-distiller script for bug ID handling > > "None" would be ignored, and add space after ",". > > Bug: None > Change-Id: I85167f2e9ba0cea7affd754825fd34e817568bd5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304337 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789569} TBR=dmazzoni@chromium.org,wychen@chromium.org Change-Id: I9be25d3af31be50e0ee3a608091c31a5b1c2ff6e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304960Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789596}
-
Aya ElAttar authored
Changed PolicyMap::Set to the newer version, which passes value as base::Value instead of unique_ptr. Bug: 2270317 Change-Id: I206b53f5a055ca97fa3077db5990d2b5a0f32b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301771 Auto-Submit: Aya Elsayed <ayaelattar@google.com> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#789595}
-
Torne (Richard Coles) authored
setBackgroundColor and setLayerType were using PostTask instead of adding their tasks to the mFactory queue like the other WebViewChromium methods; make it consistent. Change-Id: I37c92eb764079121443401676b4f762599a6a5c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302947Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789594}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit 033b5754. Reason for revert: introduced an uninitialized variable when pushing to dist is skipped Original change's description: > Use code review in DOM distiller dist repo > > Before this CL, this script builds DOM distiller, pushes the compiled > artifacts to the dom-distiller/dist repo, and generates a local commit > for rolling. The local commit needs to be uploaded as a CL. > > In order to avoid pushing without reviewing, we want to generate a CL > in the dom-distiller/dist repo instead of directly pushing to it. > > When reviewing the CL in the dom-distiller/dist repo, the reviewer > needs to run update_domdistiller_js.sh in validation mode to make sure > the artifacts in the CL are identical to local output. > > Bug: None > Change-Id: Ia29c1686106c3516f341e4d826aca69842ac5668 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304338 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789575} TBR=dmazzoni@chromium.org,wychen@chromium.org Change-Id: I6cc088d43d5e2d18a5e744a9239e4c44cb1c88e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304100Reviewed-by:
-
Eric Ye authored
BUG=b/156411764 TEST=Flash to device, check sysfiles Change-Id: I8f6b4fa0d937bc584dd32718bd2cf3cca42d2877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298319 Commit-Queue: Eric Ye <ericye@google.com> Auto-Submit: Eric Ye <ericye@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#789592}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/233589f2e73f..320ceb93a21c 2020-07-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ie6d5988705811ad8901ebb5fd51640e50bdeb6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304805Reviewed-by:
-
Scott Violet authored
These were marked obsolete long ago, but never actually removed. TEST=none BUG=1097644 Change-Id: Ia79bcacfc1de72876f78553e1b4436d969156f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300233 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#789590}
-
Josh Nohle authored
Bug: b/154863110 Change-Id: Iad98d2a12dd07e596ea97f361abe3aaaf2a6dabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280596 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#789589}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15a3a6c5..9109ad22 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id45a9942b439aa20f8fb9d72a287bb0f4ac69d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302815Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789588}
-
Nicolás Peña Moreno authored
Change-Id: I823ea7b854598a7f8d908c917f02105c2f31f1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304771 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789587}
-
Sammie Quon authored
This is a reland of 44052b91. Original is in patch set 1. Use a ImplicitAnimationObserver, which probably has more of these edge cases handled. Original change's description: > overview: Animate the clip header while the window animates. > > This was previously animated after the main animation for performance > reasons. With the improvements to overview, we think we run this > animation at the same time as the window animation, and add it to the > exit animation as well. > > Since we now need to animate removing clipping (clip rect = gfx::Rect()), > this CL adds an observer which first animates the clip rect to the size > of the layer, and the removes the clip. Otherwise the animation will > contract hide everything before reshowing on the last frame. To help > with this, windows with no clip in overview will have a clip the size > of the window (visually equal to no clipping). This will avoid us > changing to and from real no clip (clip = gfx::Rect()) which would > make the logic more confusing and we would need to create more self > deleting observers. > > Also refactors some logic so that this clipping, and the aspect ratio > clipping (clips windows that will open in splitview so they have the > same ratio as a splitview window), so they share more code. > > Test: manual > Change-Id: I900f9a1801f9dd2e9847101e4c52d54f0ba41292 > Fixed: 952158, 1103621 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277331 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#787412} Change-Id: Ia957d13237f3516b1dd1a4d097bad184c293e89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296251Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#789586}
-
W. James MacLean authored
This CL adds unit tests to make sure SiteInfo's comparison operators work as expected, and that SiteInfo functions correctly as a key for std:;map and std::set. Bug: 1067389 Change-Id: I736b53908689517252ca5bdeaa4b79e1eec10760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304159Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#789585}
-
David Black authored
Bug: b:161161492 Change-Id: Ib57a9e04d20e5f43a67a3ff9ef6832199b324603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300502 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789584}
-
Xianzhu Wang authored
Previously to avoid paint and raster invalidation on subpixel movement of composited layers, we excluded the subpixel accumulation of the composited layer from the visual rects of the contents, and added the subpixel accumulation back when mapping the visual rect into the layer space. This avoided change of visual rects on such movement. We also needed to ignore subpixel paint offset changes during paint invalidation, which actually mistakenly also ignored non-composited subpixel movement which might cause change of painted results. Because now we have moved paint invalidation away from depending on visual rects, we don't need the visual rect subpixel accumulation exclusion logic, so it's removed. Also create more accurate logic for ignoring subpixel paint offset changes under composited layer. PaintPropertyTreeBuilder calculates the paint offset subpixel delta of the directly composited container, and if a descendant has the same paint offset delta, the paint offset change will be ignored for paint invalidation. We reset the paint offset subpixel delta when crossing objects that don't propagate subpixel accumulation, so that the descendants under these objects won't ignore any paint offset change. Bug: 1104064, 833083 Change-Id: I9c640a180a1b6d7718de264443e444f43d579854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298725 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#789583}
-
Liquan (Max) Gu authored
Change: * Move some UI members of PaymentRequestImpl into PaymentUIsManager; replace their instances in PaymentRequestImpl with setter & getter. Bug: 1102522 Change-Id: I86c0c646132a0a8d94181fff193eb007d0a83648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304095Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#789582}
-
Jonah Ryan-Davis authored
This CL changes the helper function in gl_test_utils from InitializeEGLGLES2 to the more general InitializeGL which will pick either EGLGLES2 or EGLANGLE depending on which implementations are available. Fixes crashes on linux passthrough for GpuOESEGLImageTest and GpuMemoryBufferTestEGL. Bug: chromium:1099766 Change-Id: Id17eca294b6cecf7f76f2ec8c4f895ff1fb13fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285245 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#789581}
-
Michael Ludwig authored
DrawRPDQParams now just holds on to an SkShader that represents the mask image and the local matrix that needs to be applied to it. This removes a use of SkShaderMaskFilter that tried to combine the mask shader into the SkPaint of the draw. Instead, the mask is always applied by using SkCanvas::clipShader, which helps unify the code between a layer-needing RPDQ, an image RPDQ, and a solid color RPDQ. Having a mask image also no longer impacts whether or not a saveLayer() is needed because it is applied last (as desired), so skia_renderer no longer has to juggle the order that effect is applied in. Change-Id: I3d9ce085d498fabec42e112b0cb36e9707b96c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303672Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#789580}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b228a72cf564..2d7afd4824c6 2020-07-17 nifong@google.com fix heap-buffer-overflow by not returning string from reportBackendType 2020-07-17 brianosman@google.com fuzz: Add 'loops' option to run multiple times 2020-07-17 westont@google.com Add updated provisioning_profile_ios that includes iphone 11s. 2020-07-17 herb@google.com create SkAtlasSubRun API subclass SkMaskSubRun 2020-07-17 herb@google.com make prepareGrGlyphs private If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: Ie5bd4de3c532d880305b65acc66fadbffe2fc2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304800Reviewed-by:
-
