GitLab

CSS3 Text spec about text-align-last has been modified
as the property only can affect to the last line when test-align is justify.

http://www.w3.org/TR/css-text-3/#text-align-last-property

BUG=248839

Review URL: https://codereview.chromium.org/59753002

git-svn-id: svn://svn.chromium.org/blink/trunk@179082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move Node::enclosingBlockFlowElement() / inSameContainingBlockFlowElement() to
htmlediting.h as this is only needed for editing.

R=leviw@chromium.org, yosin@chromium.org

Review URL: https://codereview.chromium.org/421293004

git-svn-id: svn://svn.chromium.org/blink/trunk@179081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/417953002

git-svn-id: svn://svn.chromium.org/blink/trunk@179080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL moves SelectorFilter::ParentStackFrame from a private section to a public section to use a WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS macro.

BUG=340522

Review URL: https://codereview.chromium.org/422143005

git-svn-id: svn://svn.chromium.org/blink/trunk@179079 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since the issue was opened, the validity of removing
RenderObject::positionFromPaintInvalidationContainer
was questioned and it was determined that it's
probably not such a good idea anyway.

BUG=368416

Review URL: https://codereview.chromium.org/423943002

git-svn-id: svn://svn.chromium.org/blink/trunk@179078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

During error recovery after failing to start a server, there might actually
not be an error log where we think there should be one.

TBR=eseidel@chromium.org
BUG=378444

Review URL: https://codereview.chromium.org/421413002

git-svn-id: svn://svn.chromium.org/blink/trunk@179077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The optimization prunes SVG subtree paint invalidation walking if
the container's transform changed. However, the transform changed
flag is only updated during layout causing:
- If multiple layouts before an invalidation, later layouts may
  clear the flag set by previous layout;
- For paint-only invalidation (after we use unified invalidation)
  the flag may remain uncleared if there is no layout causing
  incorrect pruning of tree walking.

SvgCubics doesn't show visible performance change with this patch.

BUG=394619

Review URL: https://codereview.chromium.org/412083003

git-svn-id: svn://svn.chromium.org/blink/trunk@179076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the first step in switching to the mocha testing framework.

We'll use the Chai assertion library, which provides should-style,
expect-style, and assert-style assertions. We should avoid 'should',
since it modifies Object.prototype. 'expect' is more readable and
flexible than 'assert', although the (optional) chaining keywords can
make it overly verbose. For a full comparison, see:
http://chaijs.com/guide/styles/

I've used 'expect' in the two example tests, but left out the unnecessary
chaining keywords. This makes the most sense to me but feel free to
disagree.

Finally, Karma is a test runner that allows us to remotely run unit tests
in Chrome from the command line. We may need to use some trickery to have
this work for both Chrome and Chromium, but that is for another patch.

R=esprehn@chromium.org,ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/411763003

git-svn-id: svn://svn.chromium.org/blink/trunk@179075 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently RecordingImageBufferSurface determines whether
the canvas was cleared by tracking opaque draws.  For this
purpose we need all draw operations that completely
overwrite the destination pixels to be treated as opaque
even though the resulting pixels may not be opaque
(alpha = 1). To solve this problem we introduce an alternate
mode of operation in OpaqueRegionSkia, which was renamed to
RegionTracker, to reflect its new more generic vocation.

BUG=397205
TEST=blink platform unit test RecordingImageBufferSurface.clearRect

Review URL: https://codereview.chromium.org/413313002

git-svn-id: svn://svn.chromium.org/blink/trunk@179074 bbb929c8-8fbe-4397-9dbb-9b2b20218538

-x/y were swapped. Create a mock canvas context so we actually
test this code path.
-The zoomer was below the test list. z-index:1 to put it above.

NOTRY=true

Review URL: https://codereview.chromium.org/423703002

git-svn-id: svn://svn.chromium.org/blink/trunk@179073 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing to increase code readability.
This CL focuses on DeleteSelectionCommand.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/420053002

git-svn-id: svn://svn.chromium.org/blink/trunk@179072 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix the loop condition in BidiRunList::replaceRunWithRuns to check if a
next run exists before accessing it.

R=inferno@chromium.org
BUG=397479

Review URL: https://codereview.chromium.org/421383002

git-svn-id: svn://svn.chromium.org/blink/trunk@179068 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use new Traversal<> API more in the code base to simplify code a bit and
increase readability.

R=esprehn@chromium.org, adamk@chromium.org

Review URL: https://codereview.chromium.org/420193007

git-svn-id: svn://svn.chromium.org/blink/trunk@179067 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL replaces Document* pointers in objects with Member<Document>s.

- Move TextAutosizer to oilpan's heap.
- Move FastTextAutosizer to oilpan's heap.
- Make FastBulider STACK_ALLOCATED.
- Make ViewportStyleResolver::m_document a Member.

BUG=340522

Review URL: https://codereview.chromium.org/420273005

git-svn-id: svn://svn.chromium.org/blink/trunk@179066 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The functions have been converted to ConvertableToTraceFormat
since this comment was introduced but it wasn't removed.

Review URL: https://codereview.chromium.org/423943004

git-svn-id: svn://svn.chromium.org/blink/trunk@179065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove Traversal<Element> template specializations for lastWithin() /
previous() as they are now identical to the generic implementations after
r178540.

R=esprehn@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/413133008

git-svn-id: svn://svn.chromium.org/blink/trunk@179064 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These calls do nothing and in fact cause extra cycles
in Element::styleForRenderer().

Review URL: https://codereview.chromium.org/419033002

git-svn-id: svn://svn.chromium.org/blink/trunk@179063 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move Node::lastDescendantOrSelf() to NodeTraversal and rename to
lastWithinOrSelf() as this is a node traversal utility function and it avoids
code duplication with NodeTraversal::lastWithin().

R=esprehn@chromium.org, adamk@chromium.org

Review URL: https://codereview.chromium.org/420323002

git-svn-id: svn://svn.chromium.org/blink/trunk@179062 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use ContainerNode::hasChildren() instead of firstChild() in conditionals to
increase code readability a bit.

R=rob.buis@samsung.com

Review URL: https://codereview.chromium.org/428533006

git-svn-id: svn://svn.chromium.org/blink/trunk@179061 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=391177
R=dsinclair@chromium.org

Review URL: https://codereview.chromium.org/403723004

git-svn-id: svn://svn.chromium.org/blink/trunk@179060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When an object is being removed, it calls
paintInvalidationForWholeRenderer() which previously invalidated the
current repaint rect only. However if the object has been layouted
after the last invalidation, we'll miss invalidation of the object's
previous location.

Now let the method also invalidate the previous paint rect if possible.

BUG=392794, 394004
TEST=fast/repaint/remove-block-after-layout.html
TEST=fast/repaint/remove-inline-after-layout.html
TEST=fast/repaint/remove-inline-layer-after-layout.html
R=dsinclair@chromium.org, jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/395463003

git-svn-id: svn://svn.chromium.org/blink/trunk@179059 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We've shipped unprefixed (e.g. indexedDB, IDBKeyRange, etc) for almost
two years. Time to at least try to wean the web off of them.

Intent to Deprecate:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6TD2jjqAJs0

Review URL: https://codereview.chromium.org/415753002

git-svn-id: svn://svn.chromium.org/blink/trunk@179058 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Traversal<*Element>::lastWithin() is incorrect after r178540 because it
changed from using ElementTraversal::lastWithin() to using Node.lastChild()
when doing node traversal. The proper API for this is
NodeTraversal::lastWithin() as we want the last descendant, not the last
child.

This was not caught by layout tests because this template specialization
is currently unused. Current callers are using the simpler Traversal<Element>
template specialization.

R=abarth@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/416933002

git-svn-id: svn://svn.chromium.org/blink/trunk@179057 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL inlines clearChildNodeListCache() in the caller as there is only one to
avoid an unnecessary isChildNodeList() virtual call. The calling method is
invalidateNodeListCachesInAncestors(), which this CL moves from Node to
ContainerNode to make sure it is only called for ContainerNodes (Only
ContainerNodes' node lists have caches that need invalidation).

R=adamk@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/413763004

git-svn-id: svn://svn.chromium.org/blink/trunk@179056 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove ContainerNode overload for NodeTraversal::nextSkippingChildren() as it
adds no benefit compared to the one taking a Node in argument.

The nextSkippingChildren() implementation does not involves visiting the
children (and thus calling firstChild() / lastChild()). Therefore, there is no
benefit to knowing that the argument is a ContainerNode (unlike for
NodeTraversal::next()).

This CL also does the same for ElementTraversal::nextSkippingChildren().

R=esprehn@chromium.org, adamk@chromium.org

Review URL: https://codereview.chromium.org/420603012

git-svn-id: svn://svn.chromium.org/blink/trunk@179055 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I need this to be able to remove blink_common_resources from Chromium.

BUG=338338
TEST=None
R=brettw@chromium.org,
TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/424503002

git-svn-id: svn://svn.chromium.org/blink/trunk@179053 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We are not yet able to use inspector agents when the top-level frame is
in another process. This patch prevents a crash in that scenario.

BUG=357747

Review URL: https://codereview.chromium.org/422943002

git-svn-id: svn://svn.chromium.org/blink/trunk@179052 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As a part of ScopedStyleTree removal (issue 392018),
remove all private members in ScopedStyleTree.

|m_cache| is no longer necessary as ScopedStyleResolver
lookup from an element no longer require ascending the
DOM tree up, thanks to <style scoped> removal.

Unfortunately |m_authorStyles| cannot be removed completely
- StyleResolver still has to clear ScopedStyleResolvers
which are associated with TreeScopes, and thus moved from
ScopedStyleTree to StyleResolver (and renamed
|m_scopedStyleResolvers| to match what it contains).

BUG=392018
TEST=no layout test failures

Review URL: https://codereview.chromium.org/418833002

git-svn-id: svn://svn.chromium.org/blink/trunk@179051 bbb929c8-8fbe-4397-9dbb-9b2b20218538

used during a single invalidation.

These makes makes its intended object data lifetime clearer and avoids possible bugs.

BUG=379908

Review URL: https://codereview.chromium.org/416243003

git-svn-id: svn://svn.chromium.org/blink/trunk@179050 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently hitting Ctrl-Shift-O on any typescript/python/C++ file in
DevTools will result in opened bookmarks tab (at least on linux).
Almost all the time, if user is editing code in Sources Panel and hitting
Ctrl-Shift-O, he expects outline dialog to be shown.

As we are not capable of supporting all the fancy file formats yet, the patch
suggests swallowing Ctrl-Shift-O for those content types that we do not support.

R=vsevik, apavlov, pfeldman

Review URL: https://codereview.chromium.org/422023002

git-svn-id: svn://svn.chromium.org/blink/trunk@179049 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Remove WebSettings::setDisallowFullscreenForNonMediaElements(bool) (https://codereview.chromium.org/416013002/)

Reason for revert:
We need this for the Android WebView

Original issue's description:
> Remove WebSettings::setDisallowFullscreenForNonMediaElements(bool)
> 
> It is never called from Chromium.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178831

TBR=jochen@chromium.org,qinmin@chromium.org,philipj@opera.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/422923002

git-svn-id: svn://svn.chromium.org/blink/trunk@179048 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was added as a part of this patch
https://codereview.chromium.org/13937017

It was reverted here
https://chromiumcodereview.appspot.com/23072015

Review URL: https://codereview.chromium.org/357663002

git-svn-id: svn://svn.chromium.org/blink/trunk@179047 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Initial -webkit-text-emphasis-color (correctly) uses
StyleColor::currentColor, like most of the other colors.

Also, initialTextEmphasisColor returns TextEmphasisFillFilled, which is not a Color.

Review URL: https://codereview.chromium.org/425763002

git-svn-id: svn://svn.chromium.org/blink/trunk@179046 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=395531

Review URL: https://codereview.chromium.org/376873004

git-svn-id: svn://svn.chromium.org/blink/trunk@179045 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Clarify comments for methods added in r178921 as per follow-up review comments.

R=pdr@chromium.org

Review URL: https://codereview.chromium.org/423823005

git-svn-id: svn://svn.chromium.org/blink/trunk@179044 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change makes CallbackPromiseAdapter bypass resolving/rejecting a promise
if ExecutionContext is gone and calls WebType::dispose() to clean up passed
WebType instance.


BUG=385906,386501
TEST=run_webkit_tests.py --debug --enable-leak-detection http/tests/serviceworker/chromium/resolve-after-window-close.html
TEST=run_webkit_tests.py --debug --enable-leak-detection push_messaging/push-messaging-resolve-after-detached.html
TEST=manual (run crash.html in the issue)

Review URL: https://codereview.chromium.org/396963002

git-svn-id: svn://svn.chromium.org/blink/trunk@179043 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink side changes to support NumCopies print preset option.
Copies in print preview dialog should be set to value set for
NumCopies in pdf source document.

BUG=169120

Review URL: https://codereview.chromium.org/379793002

git-svn-id: svn://svn.chromium.org/blink/trunk@179042 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Minor cleanup: some suggestions didn't make it in the final version of
https://codereview.chromium.org/412353003/

R=schenney@chromium.org

Review URL: https://codereview.chromium.org/428573003

git-svn-id: svn://svn.chromium.org/blink/trunk@179039 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=393516

Review URL: https://codereview.chromium.org/424723002

git-svn-id: svn://svn.chromium.org/blink/trunk@179038 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Hide RenderBox::isBox() / RenderText::isText() to catch useless type checks
at compile time.

R=pdr@chromium.org

Review URL: https://codereview.chromium.org/425503002

git-svn-id: svn://svn.chromium.org/blink/trunk@179037 bbb929c8-8fbe-4397-9dbb-9b2b20218538