- 10 Aug, 2018 40 commits
-
-
vitaliii authored
TBR=meacer@chromium.org Bug: 872332 Change-Id: I46c863d9b00e76f45c2e6dd4adfd29cd0ec0865a Reviewed-on: https://chromium-review.googlesource.com/1170770 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#582132}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0d25dda9b148..ce9fa204b82d git log 0d25dda9b148..ce9fa204b82d --date=short --no-merges --format='%ad %ae %s' 2018-08-10 sullivan@chromium.org Revert "Configure gae_ts_mon in chromeperf dashboard." 2018-08-10 perezju@chromium.org [dashboard] Report templates for system health benchmark Created with: gclient setdep -r src/third_party/catapult@ce9fa204b82d The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:873102,chromium:867060,chromium:870324 TBR=sullivan@chromium.org Change-Id: I610b49c80a5dcc958f6491b47518d67c5ea817fa Reviewed-on: https://chromium-review.googlesource.com/1169938Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582131}
-
erikchen authored
The semantics of TabStripModel::closing_all() [both in the header comments, and in usage by callsites] is that it should only be set to |true| when CloseAllTabs() has been called. However, it was also being set to |true| in TabStripModel::DetachWebContentsImpl. This was incorrect. It appears to have been present in the initial commit of chrome/ to the Chromium repository: 09911bf3. Bug: 871977 Change-Id: Ied0dcb79611f1c2b144657dec897551d3734a38a Reviewed-on: https://chromium-review.googlesource.com/1169622Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582130}
-
Rayan Kanso authored
This change reports storage errors for most database tasks. The ones not included are: - GetMetadataTask (this is always a subtask) - GetSettledFetchesTask & DeleteRegistrationTask The latter two are not included since they are being refactored in https://chromium-review.googlesource.com/c/chromium/src/+/1165149 which will make error reporting significantly easier. More extensive tests will be added once the last two tasks will also report errors, since it is hard to simulate CacheStorage errors in tasks other than those. Bug: 780025 Change-Id: I83cc076da67aadeed5c78de39bd6f8e250f011d9 Reviewed-on: https://chromium-review.googlesource.com/1165552Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#582129}
-
Maks Orlovich authored
All other methods do the same, and so it was surprising when doing AddResponse with same arguments that would work in SimulateResponseForPendingRequest produced a fetch failure (especially when many layers were involved). Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I9faf75cb3ea415f2b04d87aa7f8fcd895bfc7438 Reviewed-on: https://chromium-review.googlesource.com/1169312Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#582128}
-
Dave Tapuska authored
In anticipation of adding a few more overloads to the postMessage APIs in https://github.com/whatwg/html/issues/3799 ensure that the code doesn't use the PostMessage extended attribute. Since the extended attribute doesn't support overloading it was decided that these implementations should really be reading the transferable argument themselves not in the bindings code. Make two versions one that is used by service workers that causes transferables to be copied and another that is used by workers, and message_ports that treat them as moveable types. BUG=861735 Change-Id: I82720aae73a1285d74b5c8f10b244c719290e2d9 Reviewed-on: https://chromium-review.googlesource.com/1165835 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582127}
-
Kouhei Ueno authored
This CL fixes a clusterfuzz crash which fails to minimize. Bug: 872320 Change-Id: Ied4ba2d6143573a4b66fc85fc4fc0fd3b2fbc0ec Reviewed-on: https://chromium-review.googlesource.com/1170160Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#582126}
-
Greg Kraynov authored
It only needs main thread scheduler to initialize, MessageLoop was unnecessary there. Bug: 828835 Change-Id: I70235bbd06af1ca6c576cc77e3e4722a27225069 Reviewed-on: https://chromium-review.googlesource.com/1169211Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Kevin Schoedel authored
Ports the ash version change crrev.com/580666 If we do decide to retain edge earcons, they will be triggered by CastGestureHandler rather than TouchExplorationController. Bug: 854321, internal b/112073644 Test: manual Change-Id: If7c2b21a9b8f477e76c21890ac5425fab7d3ed21 Reviewed-on: https://chromium-review.googlesource.com/1167477 Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#582124}
-
Noel Gordon authored
READ_METADATA was defined in the NaCL C++ but wasn't defined in the JS code. It is a requirement of the ZipArchiver design that the operation values are defined, and have the same values, in the C++ and JS code. This is likely causing crashes in the field: it certainly caused CHECK stop crashes in DEBUG C++ NaCL code in integration test (ZipArchiver's unit_tests did not exhibit the bug at all). Define READ_METADATA in the JS, add protective code to check operation validity (make it throw, if not) when constructing pack messages in JS that will be sent to the NaCL module C++ code. Re-enable the zip integration tests that were disabled due to this bug in issue 867738. (Those tests discovered bug 867842). Test: browser_test --gtest-filter="Zip*FilesApp*" No-try: true Bug: 867842, 867738 Change-Id: Ide44e60a47d9e87322115dc66017e8e0313b2162 Reviewed-on: https://chromium-review.googlesource.com/1169485 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582123}
-
Elad Alon authored
WebRTC event log upload is now controlled by a Chrome policy; the relevant network annotation is updated to reflect that. Bug: 775415 Change-Id: I2949c1f58ef37c922f4b0dfabfe756db814849e8 Reviewed-on: https://chromium-review.googlesource.com/1163706Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#582122}
-
Christos Froussios authored
The flag currently indicates that the field was autofilled, regardless of the trigger for autofilling. We will now identify two triggers separately. 1. AUTOFILLED_ON_USER_TRIGGER. This refers to Fill On Account Select in the context of the password manager. It also the current default behaviour for Autofill. 2. AUTOFILLED_ON_PAGELOAD. Password manager determined that a password form is a login form and filled the credentials as soon as the page was loaded. Any conditions which took AUTOFILLED into account are made to work with either of the new flags. Bug: 867348 Change-Id: I2eb5fea7219ce784822174de24e76b3e1e4f1f15 Reviewed-on: https://chromium-review.googlesource.com/1169060Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#582121}
-
Hajime Hoshi authored
This is a part of efforts to forbid V8 execution on the default task runner of the main thread. Bug: 870606 Change-Id: I3aa11f7cb4f8d6da6b0015d8b5516b1b2ba53bbf Reviewed-on: https://chromium-review.googlesource.com/1169037Reviewed-by:
-
Kevin Schoedel authored
Ports the ash version change from crrev.com/580666 Bug: 869921, internal b/112073644 Test: manual Change-Id: I85e68b53f13ff190d1f90f39f96f85f43699f20a Reviewed-on: https://chromium-review.googlesource.com/1167651 Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
-
vitaliii authored
This reverts commit 68947d74. Reason for revert: this may break interactive_ui_tests (CrSettingsSyncPageTest.All) on multiple builders. Original change's description: > Reland "[Settings] UserEvents depends on history and passphrase" > > This is a reland of 13143b64ae10001dd25dcb8b2d8e707b9e439382 > > Original change's description: > > [Settings] UserEvents depends on history and passphrase > > > > The user events UI toggle should be grayed out and turned off > > when there is a passphrase or when history sync is disabled. > > Note that this is purely a UI change: the internal sync datatype > > is not really turned off in that case, and we assume that the Sync > > engines will correctly stop syncing user events in these cases, > > even if the preference is still ON. > > > > Bug: 865522, 865537 > > Change-Id: I04844e2ab9c631300e88f02bbedd712f7618bc32 > > Reviewed-on: https://chromium-review.googlesource.com/1160658 > > Reviewed-by: Scott Chen <scottchen@chromium.org> > > TBR=droger > > Bug: 865522, 865537 > Change-Id: Ifae79eaf00a42c3b536bc54fa5d23cbcbcabd18a > Reviewed-on: https://chromium-review.googlesource.com/1170202 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582078} TBR=droger@chromium.org,scottchen@chromium.org Change-Id: I2187610fb6ebbeaefff001b858b3585b786ed181 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865522, 865537, 873110 Reviewed-on: https://chromium-review.googlesource.com/1170782Reviewed-by:
-
Michael Lippautz authored
PSA: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9YCeDToqDU8 Bug: chromium:757440 Change-Id: Ie53f3a5f68ace78bc47828cfb441d5d0a53fd9aa Reviewed-on: https://chromium-review.googlesource.com/1170692Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#582117}
-
Kevin Schoedel authored
Edge-passthrough was necessary in the past when the touch exploration event rewriter preceded the cast system gesture event rewriter. Now the touch exploration runs last, so this code is unused. Bug: internal b/112073644 Test: manual Change-Id: I3372a3ac15b31ac68b7d2a8603182f1e19a4934a Reviewed-on: https://chromium-review.googlesource.com/1167545 Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3e655b0ac271..fa55f08ba456 git log 3e655b0ac271..fa55f08ba456 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 dgarrett@google.com cros tryjob: Improve --cbuildbot. Created with: gclient setdep -r src/third_party/chromite@fa55f08ba456 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I51dd94886296b224033b61a2e745842d6d2add15 Reviewed-on: https://chromium-review.googlesource.com/1170571Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582115}
-
Peter Beverloo authored
This was approved in the following blink-dev thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/PNTQCliD2oA/discussion Bug: 599859, 834580 Change-Id: I5419f4b804d864f7837487ec881fb5542d9304df Reviewed-on: https://chromium-review.googlesource.com/1169477Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#582114}
-
Ned Nguyen authored
This reverts commit a92b95bb. Reason for revert: suspect this causes dashboard internal error. BUG:chromium:873102 Original change's description: > Maximize the number of parallel processes for processing & uploading perf data > > A big portion of perf data uploading latency is due to I/O operation (uploading), > hence maximize the number of parallel processes to improve the wall-time. > > Bug:857283 > Change-Id: I0c3246849676a56801fe99846ade7265d13d94c0 > > TBR=simonhatch@chromium.org > > Change-Id: I0c3246849676a56801fe99846ade7265d13d94c0 > > NOTRY=true # android_arm64_dbg_recipe flake > > Change-Id: I0c3246849676a56801fe99846ade7265d13d94c0 > Reviewed-on: https://chromium-review.googlesource.com/1170083 > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Reviewed-by: Ethan Kuefner <eakuefner@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581991} TBR=simonhatch@chromium.org,eakuefner@chromium.org,nednguyen@google.com Change-Id: I02d1e84a065bd9c315ec2242fc6a8a0bbd6593a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 857283 Reviewed-on: https://chromium-review.googlesource.com/1169800Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#582113}
-
Morten Stenshorne authored
These tests don't exist. TBR=kojii@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8040cb301de29f54ad047184f540b2ca31de5ef6 Reviewed-on: https://chromium-review.googlesource.com/1170697 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#582112}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I0da28cbce779f0b1e859f8c3d88932046730448e Reviewed-on: https://chromium-review.googlesource.com/1170579 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582111}
-
Eric Willigers authored
The LongTaskObserver API enables applications to detect presence of “long tasks” that monopolize the UI thread for extended periods of time and block other critical tasks from being executed. https://codereview.chromium.org/2685183002 https://www.chromestatus.com/feature/5738471184400384 BUG=688439 Change-Id: Ibfa8745abd6ff4a670fa94859b7d211d10ab489c Reviewed-on: https://chromium-review.googlesource.com/1166621Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
-
Oscar Johansson authored
Without jumbo, password_manager takes around 3.6 CPU minutes to build. With jumbo and chunk size 50, password_manager takes around 11 seconds to build, a decrease by around 94 %. This commit enables jumbo support in components/password_manager. Bug: 869381 Change-Id: Icce9d9800a01d452d63ba137c52c2a0495359da8 Reviewed-on: https://chromium-review.googlesource.com/1166963 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by:
-
Donna Wu authored
This CL introduced blink::mojom::WebUsbService implemented by WebUsbServiceImpl in chrome/browser/usb which used to be WebDeviceManager. Paralleling with device::mojom::UsbDeviceManager, the new interface aims to simplify the interactions with Blink, and a meaningless argument of GetDevices() method has been reduced in this CL. device::mojom::UsbChooserService will be merged to this interface in subsequent CLs. BUG=699790 Change-Id: I891c56460425c20d2e8d067f9335091f6945ae7d Reviewed-on: https://chromium-review.googlesource.com/1151065 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582108}
-
vitaliii authored
device_orientation/motion/detached-frame.html TBR=rmcelrath@chromium.org NOTRY=true Bug: 873078 Change-Id: I58d98a331c8d56937313d8f2db27652355c1a4f7 Reviewed-on: https://chromium-review.googlesource.com/1170696Reviewed-by:
-
Jia authored
Bug: 862461 Change-Id: If75e6c2b4a608c94c4d12dedb88d23ccee8e3847 Reviewed-on: https://chromium-review.googlesource.com/1166769 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#582106}
-
Oscar Johansson authored
//components/autofill takes 6.6 CPU minutes to compile. With jumbo and chunk size = 50 the build time is reduced by around 54 %. This commit enables jumbo support in components/autofill. Bug: 869381 Change-Id: Iba405b8c2199f68c11a13ee0872bfaae87943d7f Reviewed-on: https://chromium-review.googlesource.com/1170689Reviewed-by:
-
Haruka Matsumura authored
This CL changes the system of callback registration to slot-based as with references. Anytime HeapLinkedHashSet rehashes and impl_.table_ changes while incremental marking is in progress, is when the callback won't be called. So as preparing for HeapCompaction with IncrementalMarking, we change the key of the registration on HashMap from references(buffer address) to slots. Bug: 864425 Change-Id: I5af93f1c56d0a76952e3347c4f3f1ba4f271047b Reviewed-on: https://chromium-review.googlesource.com/1164881 Commit-Queue: Haruka Matsumura <harukamt@google.com> Reviewed-by:
-
David 'Digit' Turner authored
This CL improves a few functions related to symbol search and relocation. This prepares for a major change that will considerably change the way symbols are resolved during relocations and dlsym(), to better match default ELF semantics and help fix the component build as well. - Use a SearchResult result when looking for symbols, in order to allow symbols with a null address to be supported (this can happen for weak symbol exports). See SystemLinker::SearchResult and the related LibraryView::SearchResult struct definitions. - Ensure that SharedLibraryResolver properly releases its global scope handle on destruction. Since these correspond to a reference-counted global object, that will never be destroyed by the system linker, this was not a real resource leak, but is still the correct way to deal with this. - Add a comment to SharedLibraryResolver::Lookup() explaining why the code is written and will need to be refactored in a future CL. - Make LibraryView::LookupSymbol() const (finally!) - Use a few const references, instead of raw pointers when calling SharedLibrary::Relocate(). BUG=843987,802068 R=pasko@chromium.org, rmcilroy@chromium.org, agrieve@chromium.org android: crazy_linker: Minor cleanups. Minor cleanups to the code base. Preparing for future changes. BUG=NONE R=agrieve@chromium.org, pasko@chromium.org, rmcilroy@chromium.org Change-Id: I91c955c7be24e3738b118832c9ae8775934bc572 Reviewed-on: https://chromium-review.googlesource.com/1169603 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#582103}
-
Haruka Matsumura authored
This CL modifies collected traced_slot_ in HeapCompaction. In atomic pause GC world, slots that has nullptr references and only has an inline buffer are not collected by traced_slot_ because such HeapCollections are ealy returned in Trace method. However, In incremental GC, we want to collect such slots because they might have references to OutOfLineBuffer after tracing. So, we modified to collect all slots. Bug: 864425 Change-Id: I08d94ae86eb33973addcd2f535a003d29c9eeb3b Reviewed-on: https://chromium-review.googlesource.com/1156112 Commit-Queue: Haruka Matsumura <harukamt@google.com> Reviewed-by:
-
Greg Thompson authored
BUG=none Change-Id: I175181a2cdcfc0e2a04e40e7901343cd003e1ae7 Reviewed-on: https://chromium-review.googlesource.com/1164948Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#582101}
-
Trent Apted authored
The current approach to externs in file_manager js code requires js_type_check in various modules to re-list all the externs used by their dependencies, even if none of them are used in that module. This CL kills the js_library("closure_compile_externs") in the Gallery image_editor and puts externs named there where they belong. To help audit this, the js_unit_tests() template is modified to generate a js_type_check target for each unit test. This ensures that each unit test has a complete dependency chain, including externs attached properly to any of its dependencies. The changes do not attempt to do full IWYU: if an extern is picked up transitively in a js_type_check target, it is not listed more than once. Eventually, breaking out more unit tests will ensure we have dependencies better described, since each unit test has its own js_type_check. Bug: 867700 Change-Id: I06fc0359627728046408493088a5bc407e54484b Reviewed-on: https://chromium-review.googlesource.com/1166610Reviewed-by:Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#582100}
-
Alexander Hendrich authored
This CL updates the ONC Validator to not only log detailed errors/warning messages, but also collect them for later use (e.g., reporting to policy server or displaying in chrome://policy). DesignDoc: go/chromeos-robust-onc-policy Bug: 794848, 855057 Change-Id: Ie22ed887b3b298a8b7e92b175376f98d5f492dc3 Reviewed-on: https://chromium-review.googlesource.com/1116787 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582099}
-
Gauthier Ambard authored
When the LabelLink is displaying a text containing an unbreakable space, the unbreakable space is preventing two words from being broken at the end of a line. However, the ManualTextFramer used to get the position of the link isn't respecting the unbreakable spaces. So the displayed text isn't breaking the words at the end of the line but the link is positioned as if the words were broken. So the position of the link is wrong. Bug: 872290 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9b2bae32a47e19b14c397e230aade87b3cb88157 Reviewed-on: https://chromium-review.googlesource.com/1169014 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#582098}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 836ab12f. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22581 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams mkwst@chromium.org: external/wpt/secure-contexts NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9b98ffb1a68c9d79a96ce45414872cb43d7e0ccb Reviewed-on: https://chromium-review.googlesource.com/1170563 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582097}
-
Sheng-Hao Tsao authored
This CL relands "Don't show camera icon in guest mode", which was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1165962 Original description: This CL hides camera icon of internal camera app in guest mode. Since extensions are not allowed in guest mode, users can't perform any actions after clicking on the camera icon. TBR=stevenjb@chromium.org,melandory@chromium.org Bug: 866412 Test: Tested on eve that there's no camera icon in guest mode. Change-Id: Ia033c0899c5d23005c1c4779d20aff72f9a91501 Reviewed-on: https://chromium-review.googlesource.com/1167147 Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#582096}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/aba1649cfb98..3e655b0ac271 git log aba1649cfb98..3e655b0ac271 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 saklein@chromium.org Update expected users/groups to reflect freon values. Created with: gclient setdep -r src/third_party/chromite@3e655b0ac271 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I74de16d64ff43b28da7921d5446cf4d133166724 Reviewed-on: https://chromium-review.googlesource.com/1170287Reviewed-by:
-
vitaliii authored
TracingControllerTest.DoubleStopTracing TracingControllerTest.EnableAndStopTracingWithEmptyFile TBR=oysteine@chromium.org Bug: 873073 Change-Id: I1455984cf656abb30f700cdf30c5a9f770971b16 Reviewed-on: https://chromium-review.googlesource.com/1170683Reviewed-by:
-
Kush Sinha authored
Move the functions to translate back and forth between the account id used by the OAuth service chain and the account representation used by Chrome OS Account Manager, to a util class. This function was previously being performed internally in |ChromeOSOAuth2TokenServiceDelegate|. Move it to a common util class because other usages (ARC++) have cropped up that should not depend on |ChromeOSOAuth2TokenServiceDelegate| for this use case. Bug: 820046, 871690 Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Change-Id: Ie5d9fe672c521c0ddf3d6e376649d3a3fb9d33cb Reviewed-on: https://chromium-review.googlesource.com/1165352 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#582093}
-
