GitLab

This reverts commit b44653f9.

Reason for revert: Broke the tree due to a typo :(

Original change's description:
> viz: DCHECK that clients don't send empty frames
> 
> The service rejects a CompostiorFrame if it has an empty render pass
> list, or an empty output rect.  Add a DCHECK to ensure that clients
> don't send these.
> 
> Change-Id: I2a1a25fab8b2e01f5355eaf0378c98d730490863
> Reviewed-on: https://chromium-review.googlesource.com/c/1335268
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608087}

TBR=dcheng@chromium.org,fsamuel@chromium.org,sunnyps@chromium.org

Change-Id: I95c5f1a54a39f5ae482aa311caaf0c5fdc8df094
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1336207Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608099}

Change-Id: Ic64d8059a0cad7b831044151d822a912d71718de
Reviewed-on: https://chromium-review.googlesource.com/c/1334551
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608098}

https://pdfium.googlesource.com/pdfium.git/+log/a89ef2b38df0..e3b7b56f6bc3


git log a89ef2b38df0..e3b7b56f6bc3 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 thestig@chromium.org Break up ASSERT statements with ands.


Created with:
  gclient setdep -r src/third_party/pdfium@e3b7b56f6bc3

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I5612bcb9520da5db3f12f908b398c4c950d2bc6d
Reviewed-on: https://chromium-review.googlesource.com/c/1335839Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608097}

--enable-features overwrites eg_tests.json's own set of overrides, which
breaks ios_chrome_manual_fill_egtests.  Instead, directly import and
expand eg_tests.json and set --enable-features directly.

Change-Id: Ia3e03bad59c6d3e9745037666a0b16cfe3da90e7
Reviewed-on: https://chromium-review.googlesource.com/c/1335873Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608096}

https://skia.googlesource.com/skia.git/+log/d7157b2ccf53..bb9844ef69e7


git log d7157b2ccf53..bb9844ef69e7 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 benjaminwagner@google.com Add client code search to docs.
2018-11-14 reed@google.com impl SkFont::getPath
2018-11-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 02ce5830e7db..d5f1489286b8 (7 commits)
2018-11-14 halcanary@google.com SkPDF: store indirect references in object


Created with:
  gclient setdep -r src/third_party/skia@bb9844ef69e7

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@chromium.org

Change-Id: Ic3dd7bbc8234810035ec1ef12c6c3c66e0e8503e
Reviewed-on: https://chromium-review.googlesource.com/c/1335778Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608095}

Hide password icon when no passwords are available and show it again
if passwords become available.

Updates SavePasswordsConsumer to post empty results and adds an early
return where this was expected to keep the same behavior.

Bug: 878388
Change-Id: Ie4948d3b68e1ce00fa34f37f9207d64fca174ceb
Reviewed-on: https://chromium-review.googlesource.com/c/1333427
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608094}

Bug: 866281
Change-Id: Idedb310b57b39c532b31b8755eb61886742639c6
Reviewed-on: https://chromium-review.googlesource.com/c/1334857
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608093}

Using an explicit string in about_flags to avoid static initializer.

Bug: boringssl:226
Change-Id: I095c5060e903eb610576705acd760a535e55325e
Reviewed-on: https://chromium-review.googlesource.com/c/1335872
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608092}

https://chromium.googlesource.com/angle/angle.git/+log/d1a55e393e65..fca8fd620190


git log d1a55e393e65..fca8fd620190 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 syoussefi@chromium.org Vulkan: Refix cleanup race condition on Context destroy
2018-11-14 syoussefi@chromium.org Vulkan: prepare for ES3


Created with:
  gclient setdep -r src/third_party/angle@fca8fd620190

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:904846
TBR=cwallez@chromium.org

Change-Id: I53bef44de36347ad8e04b502c461208a7c35e581
Reviewed-on: https://chromium-review.googlesource.com/c/1335777Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608091}

Bug: 648337
TBR: kbr@chromium.org
Change-Id: I3389e93cbbe0c6361311d6bd6673bddbcea8f834
Reviewed-on: https://chromium-review.googlesource.com/c/1334510Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608090}

This patch changes FrameSelection::SelectWordAroundCaret to use
VisiblePosition-free versions of word boundary algorithms to reduce
usage of VisiblePosition.

Bug: 657237
Change-Id: I1605f77a86332fa20caa7966454fbf1307c10cea
Reviewed-on: https://chromium-review.googlesource.com/c/1330752
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608089}

This is a temporary change until we support managed
sessions properly and can show the UI based on
whether we run public session or managed session.

Bug: 905317
Change-Id: I03c15f2d0bc59ed9a86d4da86aa62590721366eb
Reviewed-on: https://chromium-review.googlesource.com/c/1335584Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Commit-Queue: Zakhar Voit <voit@google.com>
Cr-Commit-Position: refs/heads/master@{#608088}

The service rejects a CompostiorFrame if it has an empty render pass
list, or an empty output rect.  Add a DCHECK to ensure that clients
don't send these.

Change-Id: I2a1a25fab8b2e01f5355eaf0378c98d730490863
Reviewed-on: https://chromium-review.googlesource.com/c/1335268Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608087}

The content-security policy meta tag must be read before preloads can
be dispatched. This change allows the foreground HTML parser to use a
single HTMLPreloadScanner to read when this tag's been consumed.
It can then dispatch preloads at the correct time.

Bug: 901056

Change-Id: I70d0c75132b4203992f3b9d16db5c4442037ab13
Reviewed-on: https://chromium-review.googlesource.com/c/1320853
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608086}

Using wpt-import in Chromium 2dba2177.
With Chromium commits locally applied on WPT:
39c398ad "Worklet: Modernize service worker interception tests for worklets using async/await"
f482e77e "Add report-only mode to Feature Policy"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: I4fa4ae9132e88c9ff3252692d06958168b5d6e5d
Reviewed-on: https://chromium-review.googlesource.com/c/1336031
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608085}

This also moves json_parser into a parsers subdir. More parsers that
run in the same sandbox will be added in followups.

R=csharp

Bug: 830892
Change-Id: I8c73d7a88d03f62dd817bd9c834bd9a61783eb5b
Reviewed-on: https://chromium-review.googlesource.com/c/1329893
Commit-Queue: Joe Mason <joenotcharles@google.com>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608084}

There do not need to be destroyed. So switch over to NoDestructor.

Change-Id: Ie4ffb45a9b38188716a2bc3f1290bbbb3b64e939
Reviewed-on: https://chromium-review.googlesource.com/c/1330915Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608083}

Bug: 895233
Change-Id: I4beea124124a9f773d5d32db2957be1a2c5dfdd0
Reviewed-on: https://chromium-review.googlesource.com/c/1334933Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608082}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d5fa47311da1..88c15c341d97


git log d5fa47311da1..88c15c341d97 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 dgarrett@google.com chromeos_config: All firmwarebranch builds on 30 day schedule.


Created with:
  gclient setdep -r src/third_party/chromite@88c15c341d97

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ieac55be458a1ff24cb9291fbb7681d0929d7d661
Reviewed-on: https://chromium-review.googlesource.com/c/1335838Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608081}

TBR=zakerinasab@chromium.org

Bug: 903101,840371
Change-Id: I855ea360aefab4aae00b991f1000fa55e3f49935
Reviewed-on: https://chromium-review.googlesource.com/c/1336079
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608080}

Preparing to handle non-address results in HostResolver and HostCache.
First step is to switch HostCache::Key from AddressFamily to the more
general DnsQueryType and remove assumptions in HostCache and
HostResolverImpl that the only requestable types are A and AAAA.

No support yet for parsing and returning the non-address results. That
will be added in a later CL.

TBR=bbudge@chromium.org,tsepez@chromium.org

Bug: 846423
Change-Id: Ie921de57bd744e1796321c7d5706057c0db074d2
Reviewed-on: https://chromium-review.googlesource.com/c/1327232
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608079}

It is expected that initialization will fail when it is not supported by
the hardware, so lower these from DLOG(WARN) to DVLOG(1).

Failure to create a software decode session is still DLOG(WARN) because
this should work on all hardware.

Bug: 903656
Change-Id: I7bd62051c4c1d9082731b393d44166971f1aa0f6
Reviewed-on: https://chromium-review.googlesource.com/c/1334849Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608078}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8eae8558004a..93345bb86e3d


Created with:
  gclient setdep -r src-internal@93345bb86e3d

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I2101e2d29186d18cfc7a23e1909138fc833cfef5
Reviewed-on: https://chromium-review.googlesource.com/c/1335835Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608077}

Bug: 897086
Change-Id: Idfd8e9a68c663ba3e560a6f2443b2a468cdd3c65
Reviewed-on: https://chromium-review.googlesource.com/c/1331617
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608076}

875528, 875528, 750185, 850814

Bug: 894099, 766951, 836808, 740987, 765146, 826369, 730461, 869176,
Change-Id: I07b3ab43cff3d4d4f17349fe5eff9070fef5d437
Reviewed-on: https://chromium-review.googlesource.com/c/1335207
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608075}

This reverts commit 1a055a9b.

Reason for revert: broken tree:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/4386

Original change's description:
> Reland "Android: Allow proguard to strip unused native methods."
> 
> Reland of dc8f3c0a.
> 
> chrome_public_test_apk is now merged with chrome_public_apk_for_test
> which should fix the proguard issue.
> 
> TBR: agrieve@chromium.org
> Bug: 688465
> Change-Id: Ie43eae7f945e5ae444f1cb0adc0703b334402f3c
> Reviewed-on: https://chromium-review.googlesource.com/c/1333988
> Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608038}

TBR=estevenson@chromium.org

Change-Id: Ia718741dad550c0a4c861bd634a21232518dd161
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 688465
Reviewed-on: https://chromium-review.googlesource.com/c/1336064Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608074}

Bug: 884059
Change-Id: Iaee6daa6003c4956e6dba6d5351621b10bc0b5e1
Reviewed-on: https://chromium-review.googlesource.com/c/1332254Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608073}

This updates the code to use MarkAXObjectDirty() where we were using a
hack to fire value changes for generic tree changes. However, tree
change serialization/deserialization did not handle bundles where
there were only changed objects, and no events were provided.

Bug: 902324
Change-Id: I93f6a1ae1f2e7d835621af8f8deb6c62043454fe
Reviewed-on: https://chromium-review.googlesource.com/c/1318361Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608072}

Use smoother transition when the MV tiles are updated. This removes the
'white flash' that is currently present.

Screencast: https://screencast.googleplex.com/cast/NTM0NjkzNjMyNDM1ODE0NHxhZWM4ZWEyOS04MA

Bug: 905119
Change-Id: Ic1a7ea35b2e05bbcbcd583b2ca792a6b7c8f2dc0
Reviewed-on: https://chromium-review.googlesource.com/c/1334938Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608071}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5beeee15c175..a6150a3fe778


git log 5beeee15c175..a6150a3fe778 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 stevenperron@google.com Don't assert on void function parameters. (#2047)
2018-11-14 stevenperron@google.com Instruction::GetBaseAddress to handle OpPtrAccessChain (#2050)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@a6150a3fe778

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Idea0961f43f7a415cc7f644c295ff39c735c4e75
Reviewed-on: https://chromium-review.googlesource.com/c/1335834Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608070}

As part of the permission dialog work, I want to make sure that the
icon displayed in the dialog matches that of the Chrome app and other
clients (instead of the older icon which had two blue rectangles).

The concern is that the outdated icon may make the dialog look less
trustworthy and users might dismiss it outright instead of reading it.

Bug: 902041, 757618
Change-Id: Ia69ea7dab6d7d246302b75b199831c4048935888
Reviewed-on: https://chromium-review.googlesource.com/c/1336058
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608069}

- Do not start reordering if a modifier key is also held down (e.g.
  ctrl, shift, etc.)
- Fix reorder CSS if a theme or custom background is applied.
  - With theme: https://screenshot.googleplex.com/eVSKahPM34w.png
  - With custom bg: https://screenshot.googleplex.com/mQ0hPUJ9XLs.png
  - With theme and custom bg: https://screenshot.googleplex.com/XkSBSEtpxV1.png
- For themes/custom backgrounds, keep the edit menu icon white when
  focused using keyboard navigation. This makes it slightly easier to
  see on multicolored backgrounds.
  - Before: https://screenshot.googleplex.com/Agf1nZaxwwP.png
  - After: https://screenshot.googleplex.com/fPZmseG3LyN.png

Bug: 851335
Change-Id: Ic7fb6d5522dbc5b5395fadf5766ac643613a8bfd
Reviewed-on: https://chromium-review.googlesource.com/c/1335027Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608068}

The current threshold is LOW which corresponds to any non-zero score. This will cause any site with a non-zero engagement score to be ignored from lookalike suggestions.

The effect of this change is:
- The navigated site will be more likely to be considered for a lookalike suggestion
- The navigated site will be compared to fewer engaged sites

Bug: 878153
Change-Id: I19928398b207d36981736ed22e6a026263f93751
Reviewed-on: https://chromium-review.googlesource.com/c/1334851Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608067}

This patch changes the function to use VisiblePosition-free versions
of Start/EndOfWord, and hoists the creation of VisiblePosition to
callers to reduce the usage of VisiblePosition.

Bug: 657237
Change-Id: I8565ab3fa839b79c3e464c8622fc7a75161cc621
Reviewed-on: https://chromium-review.googlesource.com/c/1330755
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608066}

Change-Id: Ibbdd75e179458b401f2e5ff3a61a415865769351
Bug: 905095
Reviewed-on: https://chromium-review.googlesource.com/c/1335274Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608065}

To prevent permissions being accepted accidentally, permission prompts should
not be accepted as the default action. This CL changes default selection to
cancel button to reflect that.

Bug: 326740
Change-Id: I29d3e5c61c6a56546c7d9ada0824d3fccb91bc4f
Reviewed-on: https://chromium-review.googlesource.com/c/1334856Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Qiang Chen <qiangchen@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608064}

There are several public headers in pdf/ now. Better restrict which ones
should be used where.

Change-Id: I1cb4d746391bfbd6b41d98785c30a6d4309751b8
Reviewed-on: https://chromium-review.googlesource.com/c/1330991
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608063}

Bug: 879030
Change-Id: I4483a426013086588b0801485a241424d2c426b8
Reviewed-on: https://chromium-review.googlesource.com/c/1334270Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608062}

This CL was created automatically with tools/perf/update_wpr script

There are a couple of failing requests to https://yandex.ru/clck/safeclick/

R=perezju@chromium.org

Bug: 878390
Change-Id: Ifcc0cddbb43496c50abdc6ebbc3f5aabc52c3f10
Reviewed-on: https://chromium-review.googlesource.com/c/1329749
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608061}

This is a step towards introducing a UIThreadScheduler which will
have a SequenceManager rather than a MessageLoop on the UI thread.

We also remove the SequenceManager from base::Thread since we no longer
considering having anything other than a FIFO scheduler there.

TBR=marq@chromium.org

Bug: 863341, 891670
Change-Id: If1603e623688a5bb4d0ca71b2b55bc50ffb9c506
Reviewed-on: https://chromium-review.googlesource.com/c/1320329
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608060}