- 25 Sep, 2018 40 commits
-
-
Christian Biesinger authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4396b5dbaad5486719a3a3230858ced6cfdb3642 Reviewed-on: https://chromium-review.googlesource.com/1244096Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#594078}
-
yiyix authored
Enabling FrameMetrics caused 5-20% regression on rendering. (ref: https://bugs.chromium.org/p/chromium/issues/detail?id=876709). One of many reasons is that square root calculation took too long. In this cl, I implemented Newton's method to approximate the square root value. I ran perftest on a Nexus 4 device and got the following result: average of running square_root using std::sqrt: 1601-01-01 00:00:23.160 UTC average of running square_root using fastsqrt: 1601-01-01 00:00:10.629 UTC Conclusion: It's 2.3x faster with newton's approximation instead of standard library. I also ran perftests on linux desktop and got 3%-5% improvements. (perftests ref: https://chromium-review.googlesource.com/c/chromium/src/+/1222676) Bug: 881863 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5feebc32053650f338a92a2e1db6f4f67b20f995 Reviewed-on: https://chromium-review.googlesource.com/1225105 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#594077}
-
rbpotter authored
Make pages a dropdown, and only show the custom input if "Custom" page range is selected Bug: None Change-Id: If29a941ca2ff9d75f08bc1e103ac3d0a836e540c Reviewed-on: https://chromium-review.googlesource.com/1237241 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594076}
-
Ben Pastene authored
Tast is a new suite of tests. It's invoked via "local_test_runner" in the VM. You pass it a set of test names and it'll exercise some test cases. We shouldn't use much more than the browser flavored ones. Bug: 876587 Change-Id: I1d6ae9b6b5a929daadb6c12751cb0cd632a24d95 Reviewed-on: https://chromium-review.googlesource.com/1237673 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#594075}
-
Ian Clelland authored
This CL moves the functionality that previously existed in Frame::IsFeatureEnabled to SecurityContext, and from LocalFrame::ReportFeaturePolicyViolation to Document. The existing Deprecated* methods are changed to defer to these new locations. Bug: 888668 Change-Id: I2b926a88e9ac5c8428d4dc3cd4b3764b11f6d90d Reviewed-on: https://chromium-review.googlesource.com/1241194 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594074}
-
Nico Weber authored
Bug: 832676 Change-Id: Iac4e3e7c9e959f65a5f113653af8122b1a212519 Reviewed-on: https://chromium-review.googlesource.com/1244020Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594073}
-
Ryan Hansberry authored
Tether originally initiated host scans from the lock screen, in order to provide a list of hosts once the user unlocked the device. This was changed when it was discovered that Bluetooth issues meant Tether and SmartLock could not scan simultaneously. It was assumed that this restriction would no longer apply one the new MultiDevice APIs were available, but we now never want to allow host scans on the lock screen; this CL implements that logic. Bug: 888815 Change-Id: I392e61e8ad404372df42cf2240c65cac81651608 Reviewed-on: https://chromium-review.googlesource.com/1242214Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#594072}
-
Nico Weber authored
Also removes a layering violation between components/ and chrome/. Bug: 832676 Change-Id: Id894be95a9ac589da59b7a8f5587a3f4a09307cf Reviewed-on: https://chromium-review.googlesource.com/1244017 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
-
Robert Ogden authored
Anything less than 1/4 second and I was getting flakes locally. Bug: 885252 Change-Id: Ia61a99abb4ef57686af01a34264b252096e10b36 Reviewed-on: https://chromium-review.googlesource.com/1242683Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#594070}
-
Ahmed Fakhry authored
TBR=sky@chromium.org, bokan@chromium.org BUG=867063 Change-Id: I3f05f571b2d45e0f4cb4b04c401ae83cc63bd214 Reviewed-on: https://chromium-review.googlesource.com/1243574Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#594069}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d37570b325e2..8d6aa1a2a00d git log d37570b325e2..8d6aa1a2a00d --date=short --no-merges --format='%ad %ae %s' 2018-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9a20cc9744b3..1aae88c1e046 (1 commits) 2018-09-25 egdaniel@google.com Add support for RGB config to Vulkan. Created with: gclient setdep -r src/third_party/skia@8d6aa1a2a00d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: Id2e130af165aad7d787f88a3eb0abfec68306988 Reviewed-on: https://chromium-review.googlesource.com/1244376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594068}
-
Luna Lu authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I196ed40d3d9d452373a2ad7217b1c2ab75147d2b Reviewed-on: https://chromium-review.googlesource.com/1244357Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e64369342f2..c4a7356a469b git log 8e64369342f2..c4a7356a469b --date=short --no-merges --format='%ad %ae %s' 2018-09-25 tandrii@chromium.org git cl: cache also LABELS data on a change. Created with: gclient setdep -r src/third_party/depot_tools@c4a7356a469b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I9b1c545a29a53356bd55613935296c253d6bd0bd Reviewed-on: https://chromium-review.googlesource.com/1244117Reviewed-by:
-
Aaron Leventhal authored
Fix: Plumb through IME state change use to notify of caret change Bug: 887534 Change-Id: If472661b199afcbc8b30b7cb99e6d83b15114942 Reviewed-on: https://chromium-review.googlesource.com/1236735Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#594065}
-
Lan Wei authored
blink::EventHandler::ScheduleCursorUpdate crashes because we schedule the cursor update on the current frame not the local frame root. The mouse cursor update should be scheduled based on the timer of the page not each frame, because we only have one mouse cursor. Bug: 888905 Change-Id: Ia764985f489f68ab91eda38f5aae3d8014e55632 Reviewed-on: https://chromium-review.googlesource.com/1243568Reviewed-by:
-
Dmitry Gozman authored
These are generic containers which make sense in WTF. Bug: none Change-Id: I7966ba923871fab7481c832eae5a16ecfa03c13c Reviewed-on: https://chromium-review.googlesource.com/1237383Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594063}
-
Eric Seckler authored
Change-Id: I57817c7790153d3838f4d9039f62f04261b48390 Reviewed-on: https://chromium-review.googlesource.com/1243289 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#594062}
-
Theresa authored
BUG=827658 Change-Id: Id7981b607b150f8b471c0c67a581c9c2f6c1003c Reviewed-on: https://chromium-review.googlesource.com/1243047Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#594061}
-
Ken MacKay authored
Bug: internal b/116252835 Change-Id: I33854f87c93df1be26c4d61adaf8d894ac680af0 Reviewed-on: https://chromium-review.googlesource.com/1237408Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#594060}
-
sebsg authored
This is a pre-requisite for the USS migration of Wallet data/metadata. This CL adds a struct that allows manipulation of the metadata independently from the data. Change-Id: Iad50c7f659fc1bda13a3eab47b746194fd316eb4 Reviewed-on: https://chromium-review.googlesource.com/1241754 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#594059}
-
danakj authored
The SetBackgroundColor IPC has been recently moved from RenderView to RenderWidget, but the RenderWidget still delegates handling of it back to the RenderView. The RenderView then sets the background color on its |frame_widget_| which is a WebFrameWidget attached to it in RenderViewImpl::Initialize() via RenderFrameImpl::CreateMainFrame(). All RenderViewImpls do have a frame_widget_, since RenderViewImpl ends up setting that. So RenderWidget::GetWebWidget() will always return that frame_widget_ once RenderViewImpl::Initialize() has completed. There is a space of time after RenderWidget::Init() but inside RenderViewImpl::Initialize() where it would return a different WebWidget (the WebWidget on the WebViewImpl directly), but SetBackgroundOpaque IPC will not be received and handled during that time. So it is safe to use the frame_widget_ from the RenderViewImpl via RenderWidget::GetWebWidget() directly. And thus RenderWidget can set the background opaque on its WebFrameWidget without going through RenderViewImpl (other than to get the WebWidget). R=avi@chromium.org Bug: 419087 Change-Id: I65bf680a24a6312f1c1d569d2023666cbc53e8f6 Reviewed-on: https://chromium-review.googlesource.com/1239169Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#594058}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: I446d7008c0cd560457d977842c4c155ce6ca9a4b Reviewed-on: https://chromium-review.googlesource.com/1236264Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#594057}
-
Eric Karl authored
The previous patch delayed all frame sink manager set up while we are backgrounded. This left us with a null |host_frame_sink_manager| after a disconnect. This could lead to crashes. Instead, we now just delay the actual connection to the GPU process, other set up, such as BindAndSetManager which ensures a non-null |host_frame_sink_manager|, is called immediately. Bug: 888790, 866631 Change-Id: I5ad93df4b9aa7e7048faf8f51197ff1cf779c452 Reviewed-on: https://chromium-review.googlesource.com/1243603Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#594056}
-
edchin authored
This CL creates a codepath that utilizes the WKWebView snapshotting API when IsWKWebViewSnapshotsEnabled() is true. This CL intentionally keeps the original codepath intact so as to minimize the risk of refactoring errors. Bug: 739840, 869256, 711455 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I80324e82573851b1a62cda75242679cf59008c3e Reviewed-on: https://chromium-review.googlesource.com/1235714 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594055}
-
Peter Boström authored
This reverts commit f52ee5d6. Reason for revert: FindIt likely root cause for paint/invalidation/svg/image-animation-with-zoom.html flakes. Original change's description: > bitmap.getColor can be expensive (unmpremul, etc.), so don't call if not needed > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Id97f574f12deffbfe28e943a7735823be1533db9 > Reviewed-on: https://chromium-review.googlesource.com/1233941 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Mike Reed <reed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592508} TBR=fmalita@chromium.org,reed@chromium.org,mtklein@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Bug: chromium:887076 Change-Id: I0aacc1a0d27bc2de676da2cfe7214ebb7cb5ba8c Reviewed-on: https://chromium-review.googlesource.com/1243575Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#594054}
-
Ted Meyer authored
Since the CommandBufferStub is passed as a raw pointer, we need to make sure that if the underlying object is deleted, we are informed and do not segfault when destroying D3D11VideoDecoderImpl afterwards. Bug: 887822 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8ef13084d1d860ecf48aa580546808017e6590b9 Reviewed-on: https://chromium-review.googlesource.com/1239357Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594053}
-
Reilly Grant authored
This change adds the beginnings of the Serial API[1] to Blink. The functions on navigator.serial and SerialPort are unimplemented. [1]: https://wicg.github.io/serial Bug: 884928 Change-Id: I76b26337570b07ecf9b265c2876c516058e90ee8 Reviewed-on: https://chromium-review.googlesource.com/1238486Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594052}
-
Fredrik Söderquist authored
The LayoutSVGResourceFilter and LayoutSVGResourceMasker versions was taking const LayoutObject* while the one on LayoutSVGResourceClipper took a const FloatRect&. Align the two former with the later - thus eliminating unnecessary dependencies on the client. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I26dcfb5ba9d164e4c5f97b9063cac8b6281cd6e6 Reviewed-on: https://chromium-review.googlesource.com/1243193 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#594051}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f3119ef66d5c..a7af0218826c git log f3119ef66d5c..a7af0218826c --date=short --no-merges --format='%ad %ae %s' 2018-09-25 emircan@webrtc.org Disable ulpfec when field trial flag is present 2018-09-25 Peter) Slatala Add video support to media transport interface. 2018-09-25 buildbot@webrtc.org Roll chromium_revision 06f028f7..5198eaca (593823:593926) 2018-09-25 yvesg@webrtc.org Support e.g. --workers=2x to use two workers per core. 2018-09-25 sakal@webrtc.org Also disable AudioDeviceTest constructor for TSAN. 2018-09-25 henrika@webrtc.org Fixes issue where WebRTC.Audio.RecordSampleRateOffsetInPercent can report 100% (part II) Created with: gclient setdep -r src/third_party/webrtc@a7af0218826c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:b/113648245 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I931208280ee598eaedfce87380f3b433195b9930 Reviewed-on: https://chromium-review.googlesource.com/1243605Reviewed-by:
-
Hongchan Choi authored
Currently OfflineAudioContext does not do the clean up when rendering is finished. This CL adds the clean up process when `oncomplete` event is fired. with --repeat-each=50 option. Bug: 856317 Test: webaudio/Analyser/realtimeanalyser-float-data.html passes Change-Id: Ia0556f666bc49ddb92666beab4171cfcf5c385ba Reviewed-on: https://chromium-review.googlesource.com/1237384 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#594049}
-
Yang Guo authored
R=jochen@chromium.org Bug: v8:7281 Change-Id: Icacc1c60f4b0c9c3646f1ea310435ee2f90f0a05 Reviewed-on: https://chromium-review.googlesource.com/1238534 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594048}
-
Xianda Sun authored
This CL merges the two metrics because of their similarity. Apart from that, MainThreadScrollingReason does not collect metrics when a scroller is composited but still blocked on main thread due to event handlers. We really care about the reasons that make scrolling slow, so we should also collect composited but blocking cases and the two similar metrics can be merged. Bug: 861754 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I295d94f7ca3892dbfde34e4c61db0d95af92b1fe Reviewed-on: https://chromium-review.googlesource.com/1226828Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#594047}
-
Xiyuan Xia authored
After crrev.com/c/1233174, failures/time outs in the associated bugs are gone. Enable more tests in single process mash. Bug: 877496, 884389, 884393 Change-Id: I35a96699fbee450e0522ff84267842e96fb7c29c Reviewed-on: https://chromium-review.googlesource.com/1243194Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594046}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/90a12b3d4d1d..903514f95445 git log 90a12b3d4d1d..903514f95445 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 dj2@everburning.com Roll DEPS for spirv-headers (#1920) 2018-09-25 stevenperron@google.com Get KillNameAndDecorates to handle group decorations. (#1919) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@903514f95445 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie14884f18ca4f72d143854865b69dc49dbf71426 Reviewed-on: https://chromium-review.googlesource.com/1243608Reviewed-by:
-
Robert Sesek authored
Bug: 832676 Change-Id: I3d5d3db47c3a1e1ba3f8604ac6ab4ca7857887cf Reviewed-on: https://chromium-review.googlesource.com/1243728 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594044}
-
Chris Palmer authored
Bug: 705605 Change-Id: I7a056679917692e3ce326ac1553b2be110c9fdc5 Reviewed-on: https://chromium-review.googlesource.com/1239159Reviewed-by:
-
Xianzhu Wang authored
We didn't set output clip for some effect nodes because the effect may interleave with the current clip. This causes PaintChunksToCcLayer and PaintPropertyManager go through the complex code path to deal with interleaving effects and clips even if they don't interleave. Now set output clip except when there are non-contained fixed-position descendants which may escape the current clip. The benefits are: 1. PaintChunksToCcLayer and PaintPropertyManager will go through the more optimized path if they see output clip for an effect, and will generate more efficient paint operations and cc paint property tree and layers. 2. In BGPT, this avoids bugs of PaintPropertyManager in the code path handling interleaving effects and clips in cases that clips and effect don't actually interleave. Thus the scope of the bugs will be much smaller, and we will just focus on the real cases of the bugs. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4a767b78ccb13a3672dfb6397d888208f3c3b960 Reviewed-on: https://chromium-review.googlesource.com/1239418 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594042}
-
Fredrik Söderquist authored
This method is never called for a LayoutObject which has a "linked" resource (<pattern>), so remove the handling of |linked_resource_|. Change-Id: I8c57804ecb58f4b7e286e427f0b7de84909286b8 Reviewed-on: https://chromium-review.googlesource.com/1243807Reviewed-by:
-
Fredrik Söderquist authored
This uninlines MaskUnits() and MaskContentUnits() in LayoutSVGResourceMasker as well as ClipPathUnits() in LayoutSVGResourceClipper - reducing unnecessary includes/dependencies. Also streamline LayoutSVGResourceFilter::ResourceBoundingBox a bit by using the FilterUnits() accessor, and remove the redundant null-check on the element. Change-Id: I658b7626627ac38fc8b43bfd54630adb778233e8 Reviewed-on: https://chromium-review.googlesource.com/1243117Reviewed-by:
-
Daniel Rubery authored
The opt-in on DownloadFeedbackDialogView is very low, so remove it. At the same time, refactor logic for reporting. The safe browsing preferences are now checked within the DownloadProtectionService. Bug: 827567 Change-Id: I1bed2d912b53504246f21a803f0095cd15ead125 Reviewed-on: https://chromium-review.googlesource.com/1238563Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#594039}
-
