GitLab

Revert of [Android] Temporarily suppress RTL start&end check error. (patchset #1 id:1 of https://codereview.chromium.org/445753002/)

Reason for revert:
Android SDK fixed the issue, so we can convert back from warning to error.

Original issue's description:
> [Android] Temporarily suppress RTL start&end check error.
>
> The newest Android SDK had start&end attributes in non -v17 resources.
> Temporarily change the checking script from error to warning so that
> people can continue to work before it is fixed. This should be
> reverted once the issue is addressed
>
> BUG=None
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287711

TBR=newt@chromium.org,tedchoc@chromium.org,dfalcantara@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/555253004

Cr-Commit-Position: refs/heads/master@{#294038}

Known types occur very frequently. As it happens, we don't need to know
how prevalent unknown ones are in relation to known types.

BUG=412045
R=robertshield@chromium.org

Review URL: https://codereview.chromium.org/559633002

Cr-Commit-Position: refs/heads/master@{#294037}

This fixes most, but not all, errors identified by "gn check"

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/551103002

Cr-Commit-Position: refs/heads/master@{#294036}

Make the DataCompressionProxyDevRollout trial be able to override both the primary host and the fallback host of the data reduction proxy.

Related Chrome Android CL:
https://chrome-internal-review.googlesource.com/#/c/175697/

BUG=410961

Review URL: https://codereview.chromium.org/549153003

Cr-Commit-Position: refs/heads/master@{#294035}

BUG=412242
TEST=manual, see bug.

Review URL: https://codereview.chromium.org/549313003

Cr-Commit-Position: refs/heads/master@{#294034}

https://skia.googlesource.com/skia/+log/f5b6bf775c331784964bfcc9b9ac707dc6a7c62b..ef53f158de34ffaebd6537f1afd4adf38717987d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/555303002

Cr-Commit-Position: refs/heads/master@{#294033}

This changes the "test" template to create a shared_library (instead of
an executable) on Android. After this, we can actually run
base_unittests with
`build/android/test_runner.py gtest -s base_unnittests`
as normal (though may need to CHROMIUM_OUT_DIR and BUILDTYPE as
appropriate).

This requires adding the following targets:

//testing/android:native_test_native_code
//testing/android:native_test_util
//testing/android:native_test_jni_headers
//tools/android/md5sum:md5sum
//tools/android/md5sum:md5sum_bin
//tools/android/md5sum:md5sum_prepare_dist
//tools/android/md5sum:md5sum_copy_host

Also, makes it so that native executables are stripped (just like shared
libraries). Adds a simple create_native_execuatable_dist template that
sets up a dist directory for the executable (see
build/android/gyp/native_app_dependencies.gyp).

BUG=359249
TBR=rlarocque

Review URL: https://codereview.chromium.org/557463002

Cr-Commit-Position: refs/heads/master@{#294032}

BUG=388893

Review URL: https://codereview.chromium.org/555633003

Cr-Commit-Position: refs/heads/master@{#294031}

Update ash gyp files. There were some obsolete 'sources!' entries and a non-test file accidentally in the ash unittests sources.

workspace_backdrop_delegate.cc was duplicated in both ash and the unit tests target. Apparetcly this was done to make the component build work because it didn't have the export designation. The GN build detected this because it uses source_set instead of static_library which caught the duplicate symbol. This adds the export designation, removes the duplicate, and also adds ash_export.h to the sources list.

There were some warnings about superfluous const usage that surfaced. I assume this file isn't being compiled with chromium_code in the GYP build.

Review URL: https://codereview.chromium.org/551373005

Cr-Commit-Position: refs/heads/master@{#294030}

This finally replaces the time-updating-callback inside of AudioRenderer
and VideoRenderer with a model where clients can query the time. As a
result, many other bits of cleanup are now possible:
  - Renderers no longer need to be aware of the media duration
  - TimeDeltaInterpolator can be replaced with WallClockTimeSource
  - We can separate time values used for syncing video vs. informational

BUG=370634

Review URL: https://codereview.chromium.org/534073002

Cr-Commit-Position: refs/heads/master@{#294029}

Moves meta info helper functions into a new class EnhancedBookmarkModel,
that writes the version field whenever other fields are modified.
BUG=404227

Review URL: https://codereview.chromium.org/476573004

Cr-Commit-Position: refs/heads/master@{#294028}

Remove http://aws1.mdw.la/piatek/bypass-demo, which is not bypassed by the server now.

BUG=412497

Review URL: https://codereview.chromium.org/553543004

Cr-Commit-Position: refs/heads/master@{#294027}

After discussions, lock will be always available if the flag dictates,
and online auth will be required for the first unlock.

This is subequent to https://codereview.chromium.org/497783002/.

BUG=335086

Review URL: https://codereview.chromium.org/548393002

Cr-Commit-Position: refs/heads/master@{#294026}

"common" is used for the code that is common better renderer and browser. Rename to "util" instead.

BUG=None
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/558483003

Cr-Commit-Position: refs/heads/master@{#294025}

https://chromium.googlesource.com/chromium/blink/+log/f03316e4e9a81f26dcfe261fb27f54a71b00310c..396df151b75a49950fcb0a1184f3520cf4627fbc
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/556023002

Cr-Commit-Position: refs/heads/master@{#294024}

Review URL: https://codereview.chromium.org/543693003

Cr-Commit-Position: refs/heads/master@{#294023}

This was changed in the normal chromium print_preview_web_helper.cc in
02cfd5cc, but I missed the need to change it
in android's print_preview_web_helper.cc. This will allow isLoading() to live
solely on WebLocalFrame, as it doesn't make sense in a remote frame.

BUG=

Review URL: https://codereview.chromium.org/556923002

Cr-Commit-Position: refs/heads/master@{#294022}

BUG=412398

Review URL: https://codereview.chromium.org/552393002

Cr-Commit-Position: refs/heads/master@{#294021}

The new Chart JSON handling code in the buildbot will use the file chart.json
instead of standard out, so that Buildbot will not have to do any parsing of
logging output at all. This CL brings the Chart JSON handling code in line with
this approach.

R=sullivan,nednguyen
CC=nduca

Review URL: https://codereview.chromium.org/551973002

Cr-Commit-Position: refs/heads/master@{#294020}

Add an options_ui field to allows extension developers to configure how
their options pages are displayed. Example:

"options_ui": {
  "page": "options.html",
  "chrome_style": false,
  "open_in_tab": false
}

"page" is equivalent to using the "options_page" field.
"chrome_styles" enables the WebUI user agent stylesheet for the
  options page.
"open_in_tab" opens the options page in a tab instead of embedding it in
  chrome://extensions.

"page" is a required field. "chrome_style" and "open_in_tab" default to
false.

Both "options_ui" and "options_page" can specify the URL of an extension
options page. If both are present in the manifest, "options_ui.page"
will be used instead of "options_page".

Additionally, both entries "options_ui" and "options_page" are now
managed by the same ManifestHandler and stored in the same ManifestData
object (OptionsPageManifestHandler and OptionsPageInfo respectively).

BUG=408256

Review URL: https://codereview.chromium.org/518653002

Cr-Commit-Position: refs/heads/master@{#294019}

I misinterpreted the docs as meaning that read() and write() should
always return the number of bytes requested.

What it actually says is that the functions should always return the
number of bytes requested _unless_ the EOF is reached or there is an
error.

BUG=411557
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/549353003

Cr-Commit-Position: refs/heads/master@{#294018}

Old processing order for each command:
  scheduler.PutChanged() -> parser::ParseCommand() -> decoder::DoCommand()

This patch runs commands in batches (default of 20):
  scheduler.PutChanged() -> CmdParser::ParseCommands(20) -> dec::DoCommands(..)

Performance improvement is an average 0.2ms/frame on N5 on GPU rasterized pages.

BUG=394570

Review URL: https://codereview.chromium.org/558513003

Cr-Commit-Position: refs/heads/master@{#294017}

Add 3px of internal padding for textfield/combobox content.
Remove corresponding unused padding from FocusableBorder.
This better accommodates excessively tall fallback font text.
Update Omnibox, Find Bar, App List, and CookieInfoView.

See before/after pics at http://crbug.com/404999#c51

BUG=404999
TEST=Bookmark bubble/dialog, find bar, etc. don't clip most tall fallback text.
R=sky@chromium.org,pkasting@chromium.org

Review URL: https://codereview.chromium.org/516943003

Cr-Commit-Position: refs/heads/master@{#294016}

https://chromium.googlesource.com/angle/angle/+log/ab56c6aeff8ea52a8927a947ec20d19eb4564fc9..eeb7b0e9038b0fc57ead6a491541548159855dc2?pretty=full

BUG=
TEST=tree
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/554763004

Cr-Commit-Position: refs/heads/master@{#294015}

Reland 189a2ed4d209231d517b0e64a722722dead3f17a Fixes HasEventListener check in ExtensionKeybindingR

TBR=dtseng@chromium.org

Review URL: https://codereview.chromium.org/554073002

Cr-Commit-Position: refs/heads/master@{#294014}

The APIs that need forward declarations were actually introduced in
OS X 10.7 SDK instead of 10.9 SDK, forward declare them in the wrong
place will cause build issue when using older SDKs like 10.7 or 10.8.

BUG=390212

Review URL: https://codereview.chromium.org/555163002

Cr-Commit-Position: refs/heads/master@{#294013}

When use the Pepper MapTexSubImage2DCHROMIUM() and the Compositor API together, it may cause memory leak, and then run out of memory. The problem is because the Compositor API uses sync point to sync texture producer and the Chrome compositor, it does not need any IPC, so the PpapiCommandBufferProxy::last_state_[1] will not get updated, so the client does not known when the GPU process finishes accessing the memory, and then the memory can not be reused forever. This change add a shared state in PpapiCommandBufferProxy. It allows PpapiCommandBufferProxy updating state from a shared memory without an IPC. It fix this issue.

BUG=411004

Review URL: https://codereview.chromium.org/547733002

Cr-Commit-Position: refs/heads/master@{#294012}

The AppModelBuilder does not rely on content so much, rather
it's highly related to the extension system. Therefore, it's
better to be in athena/extensions, and its name should be
ExtensionAppModelBuilder instead.

This will simplifies DEPS rules of athena/content.

BUG=None
R=oshima@chromium.org
TBR=yoz@chromium.org, xiyuan@chromium.org, tony@chromium.org
TEST=build

Review URL: https://codereview.chromium.org/543263002

Cr-Commit-Position: refs/heads/master@{#294011}

event.

Occasionally we synthesize scroll or tap cancel events when a touch
sequence has been canceled or terminated, we want to make sure that
ET_GESTURE_END always happens after them.

BUG=379772

Review URL: https://codereview.chromium.org/549333002

Cr-Commit-Position: refs/heads/master@{#294010}

Implement postMessageEvent(), which is nearly identical to
RenderFrameImpl::willCheckAndDispatchMessageEvent(). The most notable difference
is the void return value, as remote frames know that the MessageEvent must
be delievered cross-process.

This is step 2 of 3 in getting WebRemoteFrameClient up and running.

BUG=411066

Review URL: https://codereview.chromium.org/545653002

Cr-Commit-Position: refs/heads/master@{#294009}

This has debugging statements in case it turns out not to be. Fingers crossed, though.

BUG=407376
TEST=no crashing, we hope

Review URL: https://codereview.chromium.org/549243002

Cr-Commit-Position: refs/heads/master@{#294008}

This uses the code from GYP to compute the maximum number of concurrent links
to use in the link pool, and sets this value in the toolchains.

Review URL: https://codereview.chromium.org/548633004

Cr-Commit-Position: refs/heads/master@{#294007}

https://skia.googlesource.com/skia/+log/32673b99a4fb5d798206eb7665b730ed0b4597a0..f5b6bf775c331784964bfcc9b9ac707dc6a7c62b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/555973003

Cr-Commit-Position: refs/heads/master@{#294006}

BUG=None
R=mmenke@chromium.org

Review URL: https://codereview.chromium.org/537403003

Cr-Commit-Position: refs/heads/master@{#294005}

This fixes a mistake in an earlier CL.

BUG=412393

Review URL: https://codereview.chromium.org/557833002

Cr-Commit-Position: refs/heads/master@{#294004}

Added all the plumbing to make Blink aware of the top controls position
and how its viewport has been resized as a result. This CL adds all the
machinery and plumbing but does not yet connect main-thread scrolls to
the top controls. This is needed to support scrolling the top controls
during slow-scrolls as well as correct viewport behavior in the virtual
viewport pinch-to-zoom.

The machinery for top controls now includes two values:

top_controls_layout_height: The amount that the viewport was shrunk to
accommodate the top controls. This is updated only during a layout that
causes a viewport resize (i.e. RenderWidget::OnResize). The compositor
needs this to know how much the viewport layer has already been resized
by Blink.

top_controls_content_offset: The amount that the top controls are showing.
This will be the same as top_controls_layout_height right after a viewport
resize, but will diverge since the top controls will move without
immediately causing a RenderWidget resize.

Blink now keeps track of the top controls "content offset", which is the
distance the content is offset from the top of the screen due to top
controls. It receives updates to this value from the Impl thread during
a commit and echos them back to the compositor.

On the compositor side, the top controls layout height is moved into the
LayerTreeImpl. This is necessary since a commit will change the viewport
layer's size on the pending tree. Keeping it in LayerTreeHostImpl meant
that, until the pending tree was activated, the top controls layout height
corresponded to the viewport bounds in the pending tree. This was causing
flickering as the viewport container was the incorrect size for a short
time. The compositor also keeps track of the top controls content offset
value. The top controls offset uses the same model as page scale, keeping
an offset (the value as known by the main thread), a delta from the main
thread's value, and a sent_delta to keep track of what has been sent to
the main thread.

See https://codereview.chromium.org/513053003 for Blink-side patch.

BUG=333143

Review URL: https://codereview.chromium.org/511253003

Cr-Commit-Position: refs/heads/master@{#294003}

Also shifts mechanism for minimizing interference with top-level traffic
from delaying dispatch to using the IDLE request priority.

BUG=387890
BUG=383404
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/495523003

Cr-Commit-Position: refs/heads/master@{#294002}

Revert of Revert "net: enable SSL_MODE_CBC_RECORD_SPLITTING with OpenSSL." (patchset #1 id:1 of https://codereview.chromium.org/547843002/)

Reason for revert:
Doesn't look like this helped with the perf regression, so undoing the original revert.

Original issue's description:
> Revert "net: enable SSL_MODE_CBC_RECORD_SPLITTING with OpenSSL."
>
> This reverts commit e06bd133.
>
> This is a preemptive revert to see whether a pagecycler regression can
> be attributed to this change. (Even if it can, we still probably want to
> make the change, but it's good to know.)
>
> BUG=409214
> TBR=davidben@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5fee53e7fe9a5a0f6aeb568446d8cdee5e3a96b7

TBR=davidben@chromium.org,agl@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409214

Review URL: https://codereview.chromium.org/559663003

Cr-Commit-Position: refs/heads/master@{#294001}

The root of all filesystems should be a directory node
except in the special case of blob URL where we maintain
the legacy behavior of having the mount point be a file
containing the blob content.

Also, fix the Access() call for http filesystem so that
it honors the access bits of the node itself.

This fixes an issue in naclports where a mount() of
an http filsystem followed by a chdir(http_root) would
always fail with ENOTDIR.

TEST=nacl_io_test

Review URL: https://codereview.chromium.org/547713002

Cr-Commit-Position: refs/heads/master@{#294000}

Fixes NULL pointer dereference when the RenderThreadImpl is
destructed but outstanding HTMLMediaElement objects have not
yet been garbage collected.

Reordering will keep audio streams alive slightly longer, but
that should be of no consequence since they would still respond
to graceful shutdown attempts by any living AudioRendererImpls.

BUG=408345
TEST=none

Review URL: https://codereview.chromium.org/517793003

Cr-Commit-Position: refs/heads/master@{#293999}