- 26 Sep, 2018 40 commits
-
-
Tibor Goldschwendt authored
Bug: 862689 Change-Id: If9713d4a079965047df35a8f5a4e93adf7e390bf Reviewed-on: https://chromium-review.googlesource.com/1246299Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594398}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8498332d304e..3cf15a9b47a0 git log 8498332d304e..3cf15a9b47a0 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 benjhayden@chromium.org Fix links in tracing/docs/ Created with: gclient setdep -r src/third_party/catapult@3cf15a9b47a0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9c56697c0f15c753c72ee9b24fe760effc873a8d Reviewed-on: https://chromium-review.googlesource.com/1246226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594397}
-
Jacob Dufault authored
Focus would move from the bubble dialog to lock contents view, which would then try to focus the auth user, which was a stale pointer that had been deleted. Bug: 884402 Change-Id: I72d729642f819d4ab2aa23c1e71edc6e851ae5ff Reviewed-on: https://chromium-review.googlesource.com/1239512 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594396}
-
Koji Ishii authored
This patch fixes: 1. ::first-line style is not applied when there are other anonymous inline boxes. 2. Inspector getPlatformFonts protocol collects fonts from two levels deep. Changed the logic not to include anonymous boxes to the depth limit. Also the incorrect expectation was fixed; legacy counts glyphs in ::first-letter twice. Bug: 636993, 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia028710b728e8e9172b540a46b42d804c9f57699 Reviewed-on: https://chromium-review.googlesource.com/1245078Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#594395}
-
Torne (Richard Coles) authored
This defines basic build targets for a Trichrome build using the upstream package names/configuration. The shared library APK contains the 32-bit version of libmonochrome.so and a few autogenerated Java pieces only at this stage, which means the total size of the three APKs is significantly larger than Monochrome at present. Bug: 887078 Change-Id: I3fcdfd6d7f717665a15c05dbb53602deda526b73 Reviewed-on: https://chromium-review.googlesource.com/1135546Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#594394}
-
Dale Curtis authored
DecryptingDemuxerStream had no traces and the DecyrptingVideoDecoder had some old-style, incomplete traces. This adds traces to the former and expands the latter. Specifically we now have: - DecryptingDemuxerStream::DecryptPendingBuffer [async] - DecryptingDemuxerStream::WaitingForDecryptionKey [async] - DecryptingVideoDecoder::DecodePendingBuffer [async] - DecryptingVideoDecoder::WaitingForDecryptionKey [async] The DVD traces used to use a trace_id and provide a buffer size, but this isn't really necessary since the start trace is tagged correctly just by using |this| and providing the timestamp. BUG=879970 TEST=passes cq Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If21288e6c47414ec038f034bba381fcebf5ca99b Reviewed-on: https://chromium-review.googlesource.com/1244164Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594393}
-
Thoren Paulson authored
The generated serial is stored in SharedPreferences in order to keep it consistent between reboots. Bug: internal b/111077464 Test: look at logs Change-Id: If988936bedd4fe9a9946ef2671a747dfc622ecf7 Reviewed-on: https://chromium-review.googlesource.com/1237524 Commit-Queue: Thoren Paulson <thoren@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594392}
-
Brandon Wylie authored
Implementing a cached_image_fetcher to interact with the existing cache/network classes. Bug: 882970 Change-Id: Ibf95b561a069b94785c5a10a66b39399af8acf68 Reviewed-on: https://chromium-review.googlesource.com/1239251Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#594391}
-
Ian Clelland authored
Change-Id: I03c0eeb61bd02f3c095a72b455de2d7ad3262569 Reviewed-on: https://chromium-review.googlesource.com/1246150Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#594390}
-
Tom Anderson authored
This reverts commit 239e5b82. > The old sizes.py perf test used to check for a whole set of performance > regressions. This is now handled elsewhere with the exception of the SI > check. The SI check is fairly simple, however, and doesn't require all > of the the perf_expectations infrastructure which is now obsolete. > > This CL removes the obsolete perf_expectations, hard codes the expected > number of SIs in the script, and removes the windows and android code > as it doesn't actually do anything. > > Bug: 572393 CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng TBR=dpranke Bug: 572393 Change-Id: Iad25e02aba593632f167bb534be95ba6a5691446 Reviewed-on: https://chromium-review.googlesource.com/1241935Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#594389}
-
Simeon Anfinrud authored
This allows users of Observable.not() to avoid importing org.chromium.chromecast.base.Unit, while communicating the same intent that there is nothing special about the data. This is also in anticipation of rewriting how not() works if Observables that can have multiple activations at once are made. For such Observables, a fold() or reduce() operator would be a natural way to implement not(), and forcing the type signature of the result of reduce() to agree with not() is an unnecessary constraint, when all that matters for not() is the lifetime of the activation, not the data type. Bug: None Test: cast_base_junit_tests, cast_shell_junit_tests Change-Id: I89f6f40695f443d9c946abaad4d00a9faa463046 Reviewed-on: https://chromium-review.googlesource.com/1241849Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594388}
-
Nate Fischer authored
Some apps declare a permission-guarded yet exported="true" Activity. Starting an intent to such an Activity will triggers a SecurityException. Instead of crashing, we should just ignore these intents. Chrome already handles this case, so this CL changes WebView shell and the default WebViewClient to behave similarly. This change will have no impact for apps which set their own WebViewClient, which should represent the vast majority of apps. R=torne@chromium.org Bug: 889300 Test: Manual - built a test app as described in http://b/115868439. Change-Id: Ia9ff8113d4796033661366c06e186d7bb6eb288d Reviewed-on: https://chromium-review.googlesource.com/1244547Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594387}
-
Zhongyi Shi authored
Add finch config param for cronet and Chrome to retry QUIC connection on the alternate network before handshake. The feature will be controlled by "retry_on_alternate_network_before_handshake". Bug: 790547 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: I5812083fe317f996313adce49f9bbd1d14b22f37 Reviewed-on: https://chromium-review.googlesource.com/1242038Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#594386}
-
Joanmarie Diggs authored
* Implement support for Event::LOAD_COMPLETE, firing AtkDocument load- complete and AtkObject state-change events. * Create Event::LOAD_START, and fire AtkObject state-change events. * Try to filter out load changes we don't want to fire an event for, e.g. pages which lack size. This saves each AT from having to filter these (presumed) irrelevant events out. TBR=slan@chromium.org Bug: 866331, 866333 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2f97563b5c2160793a09588481bd2bacf0f0eae1 Reviewed-on: https://chromium-review.googlesource.com/1234228 Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#594385}
-
Doug Arnett authored
Checks experiment_name field on Optimization defined at PageHint level and only whitelists if that experiment name is enabled for the client. Bug: 888666 Change-Id: I42425aaf9403a023d684c94ce94860cba27513f2 Reviewed-on: https://chromium-review.googlesource.com/1241214Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#594384}
-
erikchen authored
By default, webkit_layout_test failurse are retried 3 times. But when '--test-list' is passed, the retry count defaults to 0. To simplify the logic, this CL makes it so that webkit_layout_test failures are always retried 3 times. Bug: 888734 Change-Id: I46d15d71c979e5f12f334f5dcff41637f3f3aef4 Reviewed-on: https://chromium-review.googlesource.com/1244018 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#594383}
-
Ahmed Fakhry authored
Despite the fact that the docked magnifier feature is enabled by default, some users may explicitly disable it, which will cause crashes if the docked magnifier controller is accessed without checking that it exists. BUG=880428 Change-Id: I551edf47184e7c2fa79c4ebf72843758e5ef948c Reviewed-on: https://chromium-review.googlesource.com/1245731 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#594382}
-
Evan Stade authored
Disabling due to flake: NavigationControllerBrowserTest.UtilizationOfSpareRenderProcessHost TBR=xiyuan@chromium.org Bug: 888156 Change-Id: Ice1001691d141c2ffb2cec2399dffe8855acdf3a Reviewed-on: https://chromium-review.googlesource.com/1246145Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#594381}
-
Saman Sami authored
Updating the fallback lowerbound is not necessary anymore and will just waste time by causing an unnecessary commit and draw. Bug: 870456 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Icd553c179c5a2eb98c1608524d9c1caf42a27835 Reviewed-on: https://chromium-review.googlesource.com/1226366 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#594380}
-
Evan Stade authored
TBR=dpapad@chromium.org Bug: 887721,711256 Change-Id: I57a9bac7415bf0a3439c6b85e8f1228ceca7d41b Reviewed-on: https://chromium-review.googlesource.com/1246142Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#594379}
-
Morten Stenshorne authored
We want to test this with LayoutNG. Skip failing tests on NG (there are two). Bug: 889449 Change-Id: I3b80eb07d9dc359d24ab63417c3ca2ac228c1496 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1245793Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a602f9064b3e..c84510f4a313 git log a602f9064b3e..c84510f4a313 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 estevenson@chromium.org Angle: Remove obsolete requires_sdk_api_level_23 from BUILD.gn. Created with: gclient setdep -r src/third_party/angle@c84510f4a313 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:688465 TBR=syoussefi@chromium.org Change-Id: I5b9c1211a44f0edb8f7ff124c7def44604595ff2 Reviewed-on: https://chromium-review.googlesource.com/1246261Reviewed-by:
-
Fredrik Söderquist authored
Markers don't actually have any per-client caches, so all this code does is trigger a call to SetNeedsBoundariesUpdate - but if a marker was changed this flag would already be set. Hence worst case we may end up updating more than need (update the shape when only the transform changed for instance.) Not generally a huge deal, but also not good. Bug: 225808, 534817 Change-Id: I4d958cbc700c101a471c4ced1d79591cd1f2ebc9 Reviewed-on: https://chromium-review.googlesource.com/1245709Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#594376}
-
Nico Weber authored
Bug: 832676 Change-Id: I9b56c47523765af4b33a997b65fe2a48a9da7f29 Reviewed-on: https://chromium-review.googlesource.com/1246324Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594375}
-
Theresa authored
BUG=889285 Change-Id: If0210b1b934a2651e664af3d18268f453872d591 Reviewed-on: https://chromium-review.googlesource.com/1246143Reviewed-by:
-
Olivier Robin authored
This feature will still be controlled by frame messaging. Bug: 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibdf1c1c6ed616475a1d6d2c45929831a2c5fe5e9 Reviewed-on: https://chromium-review.googlesource.com/1245728Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594373}
-
Moe Ahmadi authored
This reverts commit dfd34b91. Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64%20Cast%20Audio/37042 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64%20Cast%20Audio/36915 Original change's description: > [fuchsia] Generate BUILD.gn from SDK metadata, migrate FIDL targets. > > This script uses the metadata JSON files in the SDK to generate a > BUILD.gn in //third_party/fuchsia-sdk/sdk. The build file is > regenerated whenever a new SDK is downloaded using "gclient sync". > > Only FIDL libraries are migrated for now. Additional metadata types can > be migrated in followup CLs. > > > Bug: 888753 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: If87010006cd23e90d970da4cb84e6de35804b7dd > Reviewed-on: https://chromium-review.googlesource.com/1241842 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594360} TBR=sky@chromium.org,kmarshall@chromium.org,sergeyu@chromium.org,scottmg@chromium.org Change-Id: If818310da713c18990fbed0f6c006bb90d41100d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888753 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1246296Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ad59bc2906ca..09a2951f46c3 git log ad59bc2906ca..09a2951f46c3 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 lalitm@google.com Merge "trace_processor: make schema more explicit in tables" Created with: gclient setdep -r src/third_party/perfetto@09a2951f46c3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id385b0e45ea5343f1175dc47f6272355ae3b47a8 Reviewed-on: https://chromium-review.googlesource.com/1246223Reviewed-by:
-
Evan Stade authored
on single process mash browser tests. TBR=lethalantidote@chromium.org Bug: 887175 Change-Id: I9c9963dfafff46e082fd6a4748e66549b7094dd4 Reviewed-on: https://chromium-review.googlesource.com/1246288 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/29447ec5203f..4977a156c2fc Created with: gclient setdep -r src-internal@4977a156c2fc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I48c3a068aee52785070e8c865b82bda327055511 Reviewed-on: https://chromium-review.googlesource.com/1246121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594369}
-
Steven Valdez authored
Change-Id: I9618c48fbdaa277070e67f3f1371eba341df00e8 Reviewed-on: https://chromium-review.googlesource.com/1244556Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#594368}
-
Eugene But authored
This will allow to offer more extensions in Open In... dialog. F.e. after this change Contacts extension will be offered for VCF files. Uniform type identifiers (UTIs) provide a unified way to identify data handled within the system, such as documents, pasteboard data, and bundles: https://developer.apple.com/library/archive/documentation/FileManagement/Conceptual/understanding_utis/understand_utis_conc/understand_utis_conc.html Bug: 604533 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I75a0864633023a1cd844582f08b5034bc447a65b Reviewed-on: https://chromium-review.googlesource.com/1244606 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#594367}
-
Kevin Marshall authored
Now that the SDK has all of the necessary dependencies to run Chromium WebRunner, the install procedure is now reasonable and can be documented. Change-Id: I009a74d48673c3ea4126cc593db177ba23ede715 Reviewed-on: https://chromium-review.googlesource.com/1226461 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#594366}
-
Leonard Grey authored
macOS 10.14 changed the method signature of a block parameter to application:continueUserActivity:restorationHandler: by introducing a lightweight generic. Since the parameter is unused and the protocol specified by the new generic is 10.14+, this change ignores the mismatched parameter. Bug: 887214 Change-Id: I4a111cdb69ac4fcc22a78448b3efb5bc7c0536e9 Reviewed-on: https://chromium-review.googlesource.com/1246322Reviewed-by:
-
Torne (Richard Coles) authored
Remove the old variable names now that downstream is using the new, consistent-with-Chrome names. Change-Id: I55a3e80c25b30b505504ff5268ec86da39a0e2c5 Reviewed-on: https://chromium-review.googlesource.com/1241015Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#594364}
-
Hans Wennborg authored
The builds were failing like: ERROR at //third_party/crashpad/crashpad/util/BUILD.gn:657:20: Item not found sources -= [ "stdlib/string_number_conversion_test.cc" ] ^---------------------------------------- You were trying to remove "stdlib/string_number_conversion_test.cc" from the list but it wasn't there. See //chrome/installer/setup/BUILD.gn:114:7: which caused the file to be included. "//third_party/crashpad/crashpad/util", ^------------------------------------- GN gen failed: 1 thakis excluded this file in https://chromium-review.googlesource.com/1113664 jperaza then upstreamed that in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1195567 but put it outside the crashpad_is_win clause When the upstream change was rolled into chromium in https://chromium-review.googlesource.com/c/chromium/src/+/1195670 we ended up with the file exclusion *both* in the crashpad_is_win_clause and outside it, causing this gn error. Bug: 856174 Change-Id: I5b812567e6a9be54ce622b9a221b61dc6a27f1b6 Reviewed-on: https://chromium-review.googlesource.com/1245463Reviewed-by:Scott Graham <scottmg@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#594363}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bdf1431686c2..90b47106a6e1 git log bdf1431686c2..90b47106a6e1 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6aad6a769d20..d73b871379e0 (1 commits) 2018-09-26 jvanverth@google.com Make line distance more robust Created with: gclient setdep -r src/third_party/skia@90b47106a6e1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I1e5ef576cbe8fd2299e449f717a2a2b50832cf7b Reviewed-on: https://chromium-review.googlesource.com/1246262Reviewed-by:
-
Peter E Conn authored
Bug: 871266 Change-Id: I142b570be0a17df00d9b43cf96fddc8c09c21a0d Reviewed-on: https://chromium-review.googlesource.com/1238463 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#594361}
-
Kevin Marshall authored
This script uses the metadata JSON files in the SDK to generate a BUILD.gn in //third_party/fuchsia-sdk/sdk. The build file is regenerated whenever a new SDK is downloaded using "gclient sync". Only FIDL libraries are migrated for now. Additional metadata types can be migrated in followup CLs. Bug: 888753 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If87010006cd23e90d970da4cb84e6de35804b7dd Reviewed-on: https://chromium-review.googlesource.com/1241842Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
Android instrumentation tests detect folder by the absence of the url field in the produced JSON for debugging. Therefore, the produce specifics from BookmarkNode shouldn't have url set at all instead of assigning an empty url. Bug: 516866 Change-Id: Ia61ebf6d67c04c2b2accad5f8ffc73c9125f0355 Reviewed-on: https://chromium-review.googlesource.com/1243810 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#594359}
-
