- 03 Jan, 2018 40 commits
-
-
Parastoo Geranmayeh authored
Change some of the autofill constructors to use std::unique_ptrs instead of the raw pointers. Bug: 794647 Change-Id: I364b59e867952dc48a66baf605a4dc23f33e7110 Reviewed-on: https://chromium-review.googlesource.com/843130 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526813}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/77863be41ffd..19e11600d3a9 $ git log 77863be41..19e11600d --date=short --no-merges --format='%ad %ae %s' 2018-01-03 perezju [Telemetry] Re-read DevTools config if agent is not ready Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia6b1764040817913819a45e473f915ac70f613b5 Reviewed-on: https://chromium-review.googlesource.com/848500 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526812}
-
Xida Chen authored
Please refer to the build here: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/29239 TBR=hiroshige@chromium.org NOTRY=true Bug: 788110 Change-Id: I2827e9b668467a814a2f4a667ab3d3f0fed7f344 Reviewed-on: https://chromium-review.googlesource.com/849077Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526811}
-
Benjamin Pastene authored
Bug: 794686 Change-Id: Ifefd2313c87b52fbb11057813ffbaba33e63b5a6 Reviewed-on: https://chromium-review.googlesource.com/848494Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#526810}
-
Wez authored
These test binaries have no failures reported on the FYI bot over the past 30 days. Bug: 707031 Change-Id: I915575b4a1a31a2f1370f357140243487fe8118a Reviewed-on: https://chromium-review.googlesource.com/848373Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#526809}
-
liberato@chromium.org authored
Switched D3D11VideoDecoder to use VideoFrame::ReleaseMailboxCB. Also added some random small cleanups (error checking, mostly). Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia4492de5c2506678bcdabc16de4c19dde92e4186 Reviewed-on: https://chromium-review.googlesource.com/847679 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#526808}
-
Dave Tapuska authored
This will count the number of pages we encounter with mouseup/down listeners in the event path on disable form controls. BUG=696686 Change-Id: I73102564444348c150714a8189bcab8738c9fa15 Reviewed-on: https://chromium-review.googlesource.com/847424Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#526807}
-
Philip Jägenstedt authored
The remaining failures are due to font/anti-aliasing differences. Bug: 509025 Change-Id: Ic2e568937228dfaf7f0cd138727131cf629ca40b Reviewed-on: https://chromium-review.googlesource.com/847556Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#526806}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/93b059db4a5a..8b5e8fdb3c35 $ git log 93b059db4..8b5e8fdb3 --date=short --no-merges --format='%ad %ae %s' 2017-12-15 oetuaho Replace remaining usage of TName with TSymbol Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I72de1742e1dec4dc6b17064b427c9e59807668f6 Reviewed-on: https://chromium-review.googlesource.com/849257Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526805}
-
Mounir Lamouri authored
This is also adding unit tests that check that the default ctor is not called. Bug: 798708 Change-Id: Ib8efb330d10517cb539fa4617e3f4fb3723d1dc0 Reviewed-on: https://chromium-review.googlesource.com/848715 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#526804}
-
Vladimir Levin authored
This is a refactor patch that does the following: - Introduces SoftwareImageDecodeCacheUtils as a helper class to SoftwareImageDecodeCache (referred to as Utils). - Renames ImageDecodeCacheKey to CacheKey and moves it to Utils. - Renames ImageDecodeCacheKeyHash to CacheKeyHash and moves it to Utils. - Moves CacheEntry to Utils. - Adds aliases for CacheKey/CacheEntry to SoftwareImageDecodeCache with corresponding renames. - Moves DoDecode and GenerateCandidate functions to Utils and makes them static. - To accomplish this, adds a color_type parameter that was previously read from SoftwareImageDecodeCache member. - Moves any helper anonymous variables/functions that are now used in Utils to Utils. - Cleans up unnecessary includes in the SoftwareImageDecodeCache. - Updates unittests/perftests with the new names for CacheKey. Other than renames/moves, there are no functionality changes. R=enne@chromium.org, chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I69dbf236c91bd12469941dacc0cc95424bab8116 Reviewed-on: https://chromium-review.googlesource.com/848497Reviewed-by:enne <enne@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#526803}
-
Xianzhu Wang authored
Bug: 798054 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I90888e88e6d3487a754967eebf89c2fffcadf3eb Reviewed-on: https://chromium-review.googlesource.com/847693Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526802}
-
danakj authored
It is rebaselined now. R=piman@chromium.org Bug: 146070 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I21978ecfc2b987512662fc308cb3c066befc210f Reviewed-on: https://chromium-review.googlesource.com/848172 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526801}
-
Will Chen authored
This test is occasionally timing out because it doesn't have enough time to finish. Many of its successful runs are right below 6s (the threshold for timeout). This reduces the test data for IndexedDB by over 100x so it should finish much faster (~2x faster locally). It also cleans the usage value because it's platform-dependent. Bug: 735245 Change-Id: I2ed003becdc60bf4a35368403e91fa4f952fb2c3 Reviewed-on: https://chromium-review.googlesource.com/847912 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#526800}
-
Yuri Wiitala authored
Ensures the ref-counted VideoCaptureImpl::ClientBuffer object has its ref-count adjusted with non-racy timing as the object is passed between threads. This prevents a DCHECK() in VideoCaptuerImpl::OnBufferDestroyed() from false-alarming on what it thinks is a "free while in-use" situation. More-complete discussion on this in the crbug. Testing: Confirmed fix by running reliable repro case for 5 days straight without it tripping the DCHECK(). Bug: 797851 Change-Id: Ia9f031493bec32f978c03f64d25d42611d6518b5 Reviewed-on: https://chromium-review.googlesource.com/848323Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526799}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 89a75d27. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/9561 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/selectors TBR=foolip No-Export: true Change-Id: I8c2621a098413a402fb10a8ff83d94ce02890c9e Reviewed-on: https://chromium-review.googlesource.com/848534 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526798}
-
Peter Beverloo authored
Bug: Change-Id: I3a744960522eab0e5ed6323aac06d7c8db91f847 Reviewed-on: https://chromium-review.googlesource.com/848899Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#526797}
-
Darren Shen authored
This patch implements transform value serialization. Also fixes CSSRotation and CSSSKew serialization. Spec: https://drafts.css-houdini.org/css-typed-om-1/#transformvalue-serialization Bug: 782103 Change-Id: I4d714ab245073fd2ffd236a308836ad8575b56e4 Reviewed-on: https://chromium-review.googlesource.com/844435 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#526796}
-
Navid Zolghadr authored
Add submetric TimeToHandled and also whether the whole scrolling event happened on main vs impl to the scrolling UKM events. Bug: 783874 Change-Id: I34b6832d779f9f5212e3fef23bf219cacc191e57 Reviewed-on: https://chromium-review.googlesource.com/840824 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#526795}
-
George Burgess IV authored
Scrubbed Chrome OS profiles (well, one at the moment) live in chrome/android/profiles. Hopefully we won't need to scrub them soon. In order to do AFDO on Chromium, we need to pull them locally. size wins are observed as with unscrubbed profiles on Chrome.apk (assuming the profile actually gets turned on, which is moved to another patch). Bug: 794750 Test: ChromePublic.apk builds after `gclient sync`. Similar perf/binary Change-Id: I9cc034ca21e948b372944b6bcdc8c5055fd71ca8 Reviewed-on: https://chromium-review.googlesource.com/843774Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#526794}
-
chengx authored
Bug: 734095 Change-Id: Id8d1a51014187c0b49726810985b38c67caa9c5f Reviewed-on: https://chromium-review.googlesource.com/847681 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#526793}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/05dcbc931eac..cbd4410908e2 $ git log 05dcbc931..cbd441090 --date=short --no-merges --format='%ad %ae %s' 2018-01-03 dsinclair Fold CXFA_MarginData into CXFA_Margin 2018-01-03 dsinclair Fold CXFA_CalculateData into CXFA_Calculate Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie9829258472bbfca1bdaf4a0f149ff8a7d511dbc Reviewed-on: https://chromium-review.googlesource.com/848243 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526792}
-
Aaron Gable authored
R=tandrii Bug: 793347 Change-Id: I348a5e568066b7304cdacd71c79ed203de3fd217 Reviewed-on: https://chromium-review.googlesource.com/849272Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#526791}
-
Dave Tapuska authored
Pepper can destroy a fullscreen object and a dangling ptr to a a lock target can be left. If an IPC is received after it is destroyed the dangling pointer could be called. BUG=759542 Change-Id: I746ef83dac8120559ef82ed772bd8861ab9e79bf Reviewed-on: https://chromium-review.googlesource.com/848057Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#526790}
-
Will Chen authored
I inadvertently broke some Windows bots when I landed: https://chromium-review.googlesource.com/c/chromium/src/+/848322 This sync'd the devtools-node-modules repo for all platforms, which caused an issue on Windows because some of the node modules were deeply nested (npm v2 and earlier installs it in a deeply nested manner). I restructured the repo by installing it with npm v5 which flattens the node modules directory which should solve these bot issues. Bug: 798765 Change-Id: I09056dbf6db3e4101918910f9c23d1cab260cc85 Reviewed-on: https://chromium-review.googlesource.com/848510Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#526789}
-
Matt Menke authored
It's a struct, and there are no subclasses. Bug: none Change-Id: Ie3078977c9b59315869752d092f0e2382327fca2 Reviewed-on: https://chromium-review.googlesource.com/848640Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#526788}
-
Trent Apted authored
There's an existing pixel test, LayerWithRealCompositorTest's CanvasDrawFadedString. However, - Nothing calls Canvas::DrawFadedText() except this test - The test is only enabled on Windows ("pixel tests are hard") - The test's reference image is too big.. - ..which means it doesn't actually need to elide/fade the string. - It requires a lot of plumbing (DrawFadedStringLayerDelegate) - Is uses cc::FuzzyPixelComparator with some magic numbers. http://crrev.com/c/828220 would delete Canvas::DrawFadedText() since nothing uses it, along with the existing pixel test. However, faded text still exists and is used in views::Label. This CL moves the pixel test to views::Label and "seeds" a pixel testing framework under ui/views for testing UI. Native UI often, intentionally differs across platforms and OS versions. The approach for the pixel testing framework attempts to cater for that without creating a maintenance burden. Bug: 791391 Change-Id: I6c71f2c98cf7feca07e2a4a10cf37926710b9d9f Reviewed-on: https://chromium-review.googlesource.com/805516Reviewed-by:danakj <danakj@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#526787}
-
Scott Violet authored
Also renames mojo_chromiumos_gtests to mojo_chromiumos_fyi_gtests to make it clear this only applies to the FYI waterfall. BUG=776514 TEST=test only changes Change-Id: I5ae831753a81e1f8eac54c01272c7cdd16017bab Reviewed-on: https://chromium-review.googlesource.com/848272 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#526786}
-
Reilly Grant authored
This temporary hack to get an implicit copy constructor is no longer needed. Change-Id: I06d45124f4d629e03be1bbefaa8479ad2060aac7 Reviewed-on: https://chromium-review.googlesource.com/847957Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526785}
-
Sahel Sharify authored
To fix the flakiness the tests are using mock time increment. Bug: 795617 Change-Id: I58ac018638ae33e4cd691bf1ea15a47f3b74d80f Reviewed-on: https://chromium-review.googlesource.com/847461Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#526784}
-
Dmitry Gozman authored
Bug: 772697 Change-Id: Ic8f75ef3970aeaa0c7f968957873898fd12c7137 Reviewed-on: https://chromium-review.googlesource.com/846341 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526783}
-
Matt Reynolds authored
The WifiPollingPolicy controls how frequently the network location provider will initiate Wi-Fi scans. Previously, the policy was attached to the WifiDataProvider, which is destroyed when there are no active geolocation API calls. Destruction of the provider causes us to lose track of our polling policy. The policy allows the first scan to be performed immediately and schedules subsequent scans at regular intervals. When the provider is destroyed and recreated rapidly it considers each scan to be "first", which allows many Wi-Fi scans to be performed in a short window. This change moves the policy state to a global instance so it can be saved when the provider is destroyed and recreated. The new policy allows the first-ever scan to be performed immediately, and subsequent scans may also be performed immediately if enough time has lapsed since the previous scan. In all other situations, the configured polling interval is enforced. BUG=764954 Change-Id: I00649dde2a707127e53e0330511172fef4a43471 Reviewed-on: https://chromium-review.googlesource.com/834988 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526782}
-
Miguel Casas-Sanchez authored
This CL rewrites two parts of VideoResourceUpdater::CreateForSoftwarePlanes() to take advantage of the faster libyuv library functions: - libyuv::Convert16To8Plane() was landed as part of libyuv:751 and is way faster than the C counterpart [1] - libyuv::CopyPlane() existed already and is also faster than the C counterpart. This CL is purely refactoring, functionality is covered by unit and browser tests. [1] https://bugs.chromium.org/p/libyuv/issues/detail?id=751#c11 Bug: 798485 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iead82969b13917aabdaacee47799f6816a164171 Reviewed-on: https://chromium-review.googlesource.com/848055Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#526781}
-
Dave Schuyler authored
This CL fixes some typos in comments. There are no logic changes or user visible changes. TBR=tommycli@chromium.org (code health) Bug: None Change-Id: I7772f14fa473d93e773179bfb5a66352da5aaeef Reviewed-on: https://chromium-review.googlesource.com/848374 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#526780}
-
Pavol Marko authored
This CL fixes sign-in behind an authenticated proxy. Two actual changes were necessary in this context: - SigninPartitionManager: copy auth data from the system request context into new StoragePartitions This makes SigninPartitionManager::StartSigninSession async, which made small changes necessary in GaiaScreenHandler and EnrollmentScreenHandler - SigninScreenHandler: Don't reload gaia immediately when auth details have been supplied. This was unnecessary (the URL Request will continue) and actually harmful, as now that we're using a new StoragePartition for each sign-in attempt, this discards auth data before we can copy them. To support the browsertest, testserver.py gets an argument to redirect CONNECT requests to localhost when proxying (in sign-in browsertests without proxy, we use RuleBasedHostResolverProc::AddRule to achieve this effect). Bug: 793524 Test: browser_tests --gtest_filter=WebviewProxyAuthLoginTest.* && unit_tests --gtest_filter=SigninPartitionManagerTest* Manual test: Setup: Setup an proxy server with Basic authentication Configure the device to use the proxy server. Make sure the user adding screen is shown. Test 1: Expect proxy auth dialog. Enter correct proxy auth data. Expect that sign-in screen is shown and sign-in works. Test 2: Expect proxy auth dialog. Enter incorrect proxy auth data. Expect that proxy-auth dialog is shown again. Test 3: Expect proxy auth dialog. Press Cancel. Expect that a network error dialog is shown. Press "try to sign in again". Expect proxy auth dialog. Enter correct proxy auth data. Expect that sign-in screen is shown and sign-in works. Change-Id: I78b5988b5ca4c6eaaf4e6f9443e299499d6f0f08 Reviewed-on: https://chromium-review.googlesource.com/837920Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#526779}
-
Xida Chen authored
This reverts commit 0346a3a1. Reason for revert: <INSERT REASONING HERE> Causing compilation failure here: https://ci.chromium.org/buildbot/chromium.win/WinMSVC64%20(dbg)/1592 Original change's description: > Adds predictable multimatch support in PreviewsOptimizationGuide > > Supports multiple hint matches with precendence given to the match > that occurs first in the configuration. Also, allows matches > without whitelisted optimization to be able to turn off whitelisting > for a host pattern (that otherwise would be whitelisted for another > matching pattern that occurs later in config). > > Bug: 783237 > Change-Id: I9239b74b170a1d5a19b13caccecc732f9715de90 > Reviewed-on: https://chromium-review.googlesource.com/847816 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Doug Arnett <dougarnett@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526763} TBR=dougarnett@chromium.org,ryansturm@chromium.org Change-Id: I92772c5873d06af184449ae6347bb2ebacb5100f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783237 Reviewed-on: https://chromium-review.googlesource.com/848535Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526778}
-
Thomas Anderson authored
This reverts commit 0346a3a1. Reason for revert: Causing build failure on WinMSVC64 (dbg): https://ci.chromium.org/buildbot/chromium.win/WinMSVC64%20(dbg)/1592 Original change's description: > Adds predictable multimatch support in PreviewsOptimizationGuide > > Supports multiple hint matches with precendence given to the match > that occurs first in the configuration. Also, allows matches > without whitelisted optimization to be able to turn off whitelisting > for a host pattern (that otherwise would be whitelisted for another > matching pattern that occurs later in config). > > Bug: 783237 > Change-Id: I9239b74b170a1d5a19b13caccecc732f9715de90 > Reviewed-on: https://chromium-review.googlesource.com/847816 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Doug Arnett <dougarnett@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526763} TBR=dougarnett@chromium.org,ryansturm@chromium.org Change-Id: If54e402cac060422cbff45a11ead41ca6c31d542 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783237 Reviewed-on: https://chromium-review.googlesource.com/849281Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526777}
-
Sergey Ulanov authored
--dry-run was broken after https://crrev.com/525224 because binary_name was no longer defined in _GetSymbolsMapping(), while still being used for dry-run. Change-Id: I76566e3e22007401a5c5d80daa5e7dc30af2c91f Reviewed-on: https://chromium-review.googlesource.com/848431Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#526776}
-
Eugene But authored
Make mutableCopy of http_request_headers_ to avoid crashes in AddHttpRequestHeaders and RemoveHttpRequestHeaderForKey. Bug: 798070 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaca5eb950f79b5936a75523392322036a37158a5 Reviewed-on: https://chromium-review.googlesource.com/846433 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#526775}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/aebad197dcaf..d9852cd27a76 $ git log aebad197d..d9852cd27 --date=short --no-merges --format='%ad %ae %s' 2018-01-03 brianosman Remove obsolete comment 2018-01-03 brianosman Remove unused color from all distance field GPs and GrAtlasTextOp 2018-01-03 reed partial revert of https://skia-review.googlesource.com/c/skia/+/90026 for android 2018-01-03 reed update pipe for lattice and shadowrec 2018-01-03 caryclark refresh public includes 2018-01-03 caryclark support srgb flag in bookmaker 2018-01-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ d8724a947..93b059db4 (1 commit) 2018-01-03 rmistry Add Housekeeper-PerCommit-Bookmaker to cq.cfg with 100% experiment% Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ie824679dea9d0130e98f51792a0986501bd7aa06 Reviewed-on: https://chromium-review.googlesource.com/849154 Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526774}
-