- 18 Jul, 2019 16 commits
-
-
Natalie Chouinard authored
Typo was causing script to fail with: TypeError: __init__() got an unexpected keyword argument 'actino' Change-Id: I9ea784032a5a5a5e4fe7659804d797db799068f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707171 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#678517}
-
Drew Stonebraker authored
To indicate ownership. Bug: 983197 Test: Run browser_tests browser_tests Test: --gtest_filter=*.NoFindBarControllerOnBrowserCreate Change-Id: I9e028d89348114ac70be7a339b1b1cfb1ffc86d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706780 Commit-Queue: Drew Stonebraker <stonebraker@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#678516}
-
Marijn Kruisselbrink authored
If the user selects a sensitive directory, a parent of a sensitive directory, or anything in certain extra sensitive directories, prompt the user to pick something else. Bug: 968851 Change-Id: I5ad144f89c823f20e766f463383959bc2a595327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696183Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#678515}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/db2e9fb45392..34f3be0173a3 git log db2e9fb45392..34f3be0173a3 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 ntfschr@chromium.org Devil: delete ANDROID_SERIAL before running tests Created with: gclient setdep -r src/third_party/catapult@34f3be0173a3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:955155 TBR=sadrul@google.com Change-Id: I37ad9981328e635d1baddbd5f527ebf408a06f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678514}
-
Wez authored
This is a reland of ffa05b99 logging::LogMessage has a special-case to write LOG_ERROR messages to stderr, even if LOG_TO_STDERR is not enabled, to make ERROR and FATAL messages more visible, especially in tests. Restrict this behaviour to apply only when no log destinations are set, other than LOG_TO_FILE, so that binaries which only LOG_TO_SYSTEM_DEBUG_LOG will never emit logspam to stderr. Tested by adding a unit test for this case. Bug: 968387 Change-Id: Ibe3369eb2a47accdd17cd3cbb19c921de827ca70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704917Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#678513}
-
Miyoung Shin authored
This CL resets own mojo binding in the internal function of ManifestManager::ContextDestroyed because Blink's GC objects that own mojo bindings manually need to reset the bindings to prevent use after poison issue. Bug: 979621 Change-Id: I38c4c3b532111f9ff721ef75b98d9e33a3f96441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705580Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#678512}
-
Ian Kilpatrick authored
ComputeAbsoluteHorizontal & ComputeAbsoluteVertical were almost identical. This added with the many writing mode switches generated a lot of code. This collapses most of the functions within the utils file to work in the logical writing-mode of the candidate. Change-Id: Ic678d5b46858fea402eda9839d1eb580dc30f7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681180 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#678511}
-
Xida Chen authored
Right now the include rules for cc/paint is written in BUILD.gn, this CL write it in DEPS file to make it more clear. This CL should not cause any behavior change. Bug: None Change-Id: I6654d784fa135cc8e397f852388b6c2cbbd1cad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707251Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#678510}
-
Min Chen authored
Delete related finch experiments: https://critique.corp.google.com/#review/258627188 Bug: 982537 Change-Id: I913809629a0fd92860ff5bf2983ec00d90203eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707238Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#678509}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9dbb81f004b6..d6cc1fe099d4 git log 9dbb81f004b6..d6cc1fe099d4 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 cwallez@chromium.org Add an implementation of Result<const T*, E*> Created with: gclient setdep -r src/third_party/dawn@d6cc1fe099d4 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I30113a21546052fa5e5694ccef4ec5025c6f4ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707453Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678508}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/68fb145dca2b..9d03368411cc git log 68fb145dca2b..9d03368411cc --date=short --no-merges --format='%ad %ae %s' 2019-07-17 tsepez@chromium.org Replace UnownedPtr with RetainPtr to parser objects in fpdfdoc 2019-07-17 thestig@chromium.org Properly check for Windows path names in presubmit checks. 2019-07-17 thestig@chromium.org Properly run Python scripts on Windows in presubmit checks. 2019-07-17 thestig@chromium.org Add click_form.pdf test PDF. Created with: gclient setdep -r src/third_party/pdfium@9d03368411cc The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:983867 TBR=pdfium-deps-rolls@chromium.org Change-Id: I6369b8090009bbb886506af1eb5d50a9415ef683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707378Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678507}
-
Reilly Grant authored
This replaces the placeholder serial port icons with the "developer_board" icon from the Material Design icon set. Bug: 917204 Change-Id: Ic1b7e8f4a62aeb7b20e9e5152d1f708650500095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695846 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#678506}
-
Natalie Chouinard authored
Migrate the SingleCategoryPreferences and ChosenObjectPreferences from deprecated Framework preferences to Support Library preferences. This change also removes the complete fragment layout override used by Storage preferences in favor of simply appending the custom views to the bottom of the layout. Because this is the first fragment migrated which contains a ChromeImageViewPreference, it includes some duplication of code so that the compat and non-compat image view preferences can coexist. Once the remaining ChromeImageViewPreferences are migrated to support library, this duplicate code will be removed (https://crbug.com/967022). Bug: 968592, 929743 Change-Id: I3a0ed1ec24d2824d22cfecf50c2053bd62a45add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706540 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#678505}
-
Sophie Chang authored
Bug: 969558 Change-Id: Iff43356255c9e72dd85db61ce971c41851ada005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707130Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#678504}
-
Sergey Ulanov authored
The new test verifies that GpuMemoryBuffer implementations handle the case when buffer size doesn't match the underlying buffer. Bug: 957314 Change-Id: I7f1e0ead35d88390599d1edc2b719e5d81d48327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662830 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#678503}
-
Kelvin Jiang authored
Implement a new upgradeScheme action type for DNR rules. These rules are evaluated along with redirect rules as they are matched based on their specified priority. When an http or ftp request matches with an upgradeScheme rule, the request's scheme is changed to https. Bug: 974388 Change-Id: I0d9524e1c7d405a413868626da99e805c26ac601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674748 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#678502}
-
- 17 Jul, 2019 24 commits
-
-
Alexandre Courbot authored
As we add support for the request API and upstream H264 structures, two sets of V4L2 H264 controls/structures will have to coexist: - The ones we used so far for our own kernels and the config store, - The official upstream ones, relying on request API. Thus we will need two versions of the V4L2H264Accelerator, each of which will use a different set of kernel controls/structures. However these kernel members share the same name and cannot be both included in the same compilation unit: thus, we cannot have them included in any .h file that the decoder will include, or name collision will occurs. The CL takes care of this last point my moving all kernel-specific definitions and includes into a private structure inside v4l2_h264_accelerator.cc. That way, none of the kernel members are visible to files that include v4l2_h264_accelerator.h, and we won't have any name collision as we introduce the other accelerator class. Bug: 917279 Test: vdatest passes on veyron_minnie. Change-Id: I1601fccd37624244b3351e647c1c7e75f526f4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705928 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#678501}
-
Eric Karl authored
Finch looks good, launching this feature. Bug: 899399 Change-Id: I3310bfcb15bbe17d2e0f314aa1c27c580d4d4a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707330 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#678500}
-
Yi Gu authored
Input event on the padding / border of an iframe should be claimed by its parent frame. See example here: https://jsbin.com/xozuwil/quiet. However, clicking on the padding is considered as clicking the iframe according to blink hit test. When VizHitTesting asks blink for hit test target, it gets the iframe which is inconsistent with VizHitTesting result where the parent frame is considered as the target. This patch takes the padding and border into account when asking blink for the hit test result and only accepts iframe as the target if the hit test point is inside the content box of the iframe. Note that fixing the inconsistency between blink hit test and viz hite test is tracked via crbug.com/753124. Bug: 977180 Change-Id: Ia0c36b68ef0428a19f7ae94f2ae9bf575f55f0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699589 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#678499}
-
Findit authored
This reverts commit 578f4505. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 678372 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU3OGY0NTA1NDMwMTA1YjUwMDM3NmRmMTY4NjI0ZDU5YmE0OGFhNWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/54995 Sample Failed Step: unit_tests Original change's description: > Add full Profile report into enterprise report. > > Full profile reports are append into the report for all activated profiles. > Multiple requests are created if total report size exceeds the limitation. > > Bug: 956237 > Change-Id: Iee36c34857346ca2a6aa2dbbfe7c09301fd3d129 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702770 > Commit-Queue: Owen Min <zmin@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678372} Change-Id: Ic93aa2db887c88ebafac36a46f4fa8684eb6decb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 956237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706886 Cr-Commit-Position: refs/heads/master@{#678498}
-
David Maunder authored
There was a gap in the plumbing of Task IDs when we serialize/deserialize navigation entries. The Task IDs were not being re-set on a navigation entry when we deserialized a navigation entry. Bug: 983596 Change-Id: I817e1073beb16ed93b4289502ccb3e33a4094ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704518Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#678497}
-
Jun Mukai authored
Bug: 983308 Test: compositor_unittests Change-Id: If6841f492b4e37ba584c4edc3338e5a27b88ee6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699118Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#678496}
-
Josh Karlin authored
What: Record the number of third party origins that read or write cookies on a given page load. How: TabSpecificContentSettings already had this information. So I've rerouted the signal to to WebContents so that others can get it too. TabSpecificContentSettings was already a WebContentsObserver so this is a a small change for that class. I routed the cookie read/write signals to PageLoadMetricsObservers as well and created a new ThirdPartyMetricsObserver to host the new metrics. Bug: 976866 Change-Id: I5917187c8152084c470b2bfe0d22dc48ba563ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666303 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#678495}
-
Reid Kleckner authored
Locally I did a release+component build and this test failed 65 out of 100 local runs. TBR=msramek@chromium.org Bug: 985131 Change-Id: Iff5d243e6adeb198939bc8e7699879bcc85ab668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707571Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#678494}
-
Eric Willigers authored
Like other CSS keywords, pointer-events keywords serialize in lower case. https://svgwg.org/svg2-draft/interact.html#PointerEventsProperty Change-Id: Iae5aed5cb8280f6b6df84024d076252af59cff11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706214 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#678493}
-
inglorion authored
Change-Id: I30dc712af38410fb4b3187253a7441ce897a644f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707553Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#678492}
-
Eric Karl authored
These are throwing off our reporting metrics, and aren't interesting to record. Bug: 978225 Change-Id: I78882e53f32acd74e2cf8513b72774e8e7312b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674785 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#678491}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3d00d0c295f43493f59ed8f15f4ea0eeb96901e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706785Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678490}
-
Jeffrey Cohen authored
Bug: 901429 Change-Id: Ib604a303a34d32fd1061f69015567c45137f2ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656049 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#678489}
-
Mark Yacoub authored
Rename to NumberOfPlanesForLinearBufferFormat. The function should be only valid for formats with linear layout. BUG=979736 Change-Id: I8f4a29cab73ad4e10a91349453dd158a92af3e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682211Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#678488}
-
Reid Kleckner authored
LLVM r365162 added a lit tests that uses cut. The new package has cut.exe from UnxUtils.zip. R=hans@chromium.org, pcc@chromium.org, thakis@chromium.org Bug: 984065 Change-Id: I35c42c33cc3c621ad5881caffc50d80f2cf11ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707474 Commit-Queue: Reid Kleckner <rnk@chromium.org> Auto-Submit: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#678487}
-
Harry Cutts authored
See go/cros-gesture-properties-dbus-design (Google internal only, sorry) for more details about the full design. Bug: 952054 Test: call the `GetProperty` method with a command like this (substituting a valid device ID): dbus-send --print-reply --system \ --dest=org.chromium.GesturePropertiesService \ /org/chromium/GesturePropertiesService \ org.chromium.GesturePropertiesServiceInterface.SetProperty \ int32:"$DEVICE_ID" string:"Mouse CPI" array:double:500 Change-Id: Ib91995c3c1fadbf776e55f078a35c38ced984020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589450 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#678486}
-
Ahmed Fakhry authored
- Overview doesn't affect whether the frame header is painted or not. It is always clipped anyways. - The desks containers are always mirrored and the mirrors are forced visible, but not other windows. This simplifies the code, and makes the mirrored backdrop visibility sync with the source backdrop visibility. BUG=866622, 978917 Change-Id: Ifa714006297e73f05c7a1d0dcff4bbedce04c11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700644 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#678485}
-
Xiao Yang authored
1. set_audio_focus_state() is called together with set_audio_focus_type() in FinishAudioFocusRequest(). So combined these two functions into SetAudioFocusInfo function. Bug: b/136660854 Change-Id: I6972493b5a30c41fc3f7b4135f9169aa0452dabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703486 Commit-Queue: Xiao Yang <yanxiao@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#678484}
-
Alexander Alekseev authored
Bug: 974971 Change-Id: Id3181df224832e97fed4e39d83ab8f35fa576ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705112Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#678483}
-
Danan S authored
It's now part of the People section. Bug: 927957 Change-Id: I3ee88d4fce66896613806d74ad4787670e658eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702167Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#678482}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It moves to inherit from OAuth2AccessTokenManager::Delegate and |token_manager_| from O2TS to PO2TS. PO2TS creates |token_manager_| with adding itself as a OAuth2AccessTokenManager::Delegate. It also cleans up unused members and macros from O2TS. Bug: 967598 Change-Id: Id2f574a59b6e002513bdb4edf3041379477d6d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703324 Commit-Queue: Julie Jeongeun Kim(OoO til July 21) <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#678481}
-
Lin Sun authored
Update the expectations file of WebGL/WebGL2 conformance test: - Add driver tags to Intel-specific issues. - Put Intel-specific issues together. Change-Id: I2765d45153716377c9b773c8a234a6bbef9a1d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687387Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#678480}
-
Tim Song authored
BUG=980861 Change-Id: I1b9ac25070c20bcddda93f0c6c9e7f1fdebe1936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703280Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#678479}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/483d4365..faec9ebf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I75ef55df2b2bdf5804e8398f69fa01af2a18dfbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706725Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678478}
-