GitLab

BUG=428124

Review URL: https://codereview.chromium.org/717533003

Cr-Commit-Position: refs/heads/master@{#305076}

1/3 blink: https://codereview.chromium.org/732963003
 - Intorduce originalURLViaServiceWorker in ResourceResponse and WebURLResponse
 - Change CSP check to use originalURLViaServiceWorker if exists in ResourceFetcher::didReceiveResponse().
2/3 chromium: https://codereview.chromium.org/731983003 [THIS PATCH]
 - Stop updating the request's URL in ResourceDispatcher::OnReceivedResponse() and WebURLLoaderImpl::Context::OnReceivedResponse().
 - Set WebURLResponse's originalURLViaServiceWorker in WebURLLoaderImpl::PopulateURLResponse().
3/3 blink: https://codereview.chromium.org/732003002
 - Change CSP check to use originalURLViaServiceWorker.
 - Add LayoutTest for this bug.

BUG=433743

Review URL: https://codereview.chromium.org/731983003

Cr-Commit-Position: refs/heads/master@{#305075}

This still has one remaining issue in that there are some situation where MessagePortService in the browser process might unqueue these transferred message ports before the service worker has been started. That will be fixed in a separate CL.

https://codereview.chromium.org/730543005/ has a test for this fix.

BUG=432678

Review URL: https://codereview.chromium.org/733703002

Cr-Commit-Position: refs/heads/master@{#305074}

This also moves extensions/renderer/guest_view/mime_handler_view_container.h into its own folder.

Review URL: https://codereview.chromium.org/739733002

Cr-Commit-Position: refs/heads/master@{#305073}

BUG=

Review URL: https://codereview.chromium.org/747523002

Cr-Commit-Position: refs/heads/master@{#305072}

This CL adds ProfilerValue which holds the cloud url for the profiler files
and can be added using results.AddValue(ProfilerValue()).

When doing format output, ProfilerValue and TraceValue will put their
cloud url in the key named "cloud_url".

BUG=431904
TEST= see #8 at crbug.com/431904

Review URL: https://codereview.chromium.org/731233003

Cr-Commit-Position: refs/heads/master@{#305071}

** Presubmit Warnings **
Pylint (435 files) (35.97s) failed
************* Module telemetry.page.page_test_unittest
W: 17, 0: Unused import scalar (unused-import)
************* Module telemetry.unittest_util.run_tests_unittest
C: 44, 0: Exactly one space required before assignment
    host  = runner.host
          ^ (bad-whitespace)

BUG=

Review URL: https://codereview.chromium.org/744533004

Cr-Commit-Position: refs/heads/master@{#305070}

PolicyWatcher.OnPolicyError callback and implementation.
- This new callback enables HostProcess to react to policy errors by
  calling ShutdownHost.
- PolicyWatcher on Linux calls this callback when detecting malformed
  policy files (with retries mechanism to avoid firing this for
  transient file reading problems)

BUG=427512 410050

Review URL: https://codereview.chromium.org/722743003

Cr-Commit-Position: refs/heads/master@{#305069}

Then we will proceed to remove the ui_unittests target in the next CL.

BUG=331829, 373148, 299841, 103304
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/748453002

Cr-Commit-Position: refs/heads/master@{#305068}

TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/743243002

Cr-Commit-Position: refs/heads/master@{#305067}

- Alphabetises the switch statement in AcceleratorController::PerformAction()
- Removes "default" from switch statement in
  AcceleratorController::PerformAction()
- Makes several methods in AcceleratorController take AcceleratorAction instead
  of int as input
- Rearranges methods in accelerator_controller.cc to match order in .h file

BUG=404473
TEST=None
R=oshima
TBR=sky (For trivial addition of ifdef to chrome/browser/ui/views/accelerator_table.cc)

Review URL: https://codereview.chromium.org/729993002

Cr-Commit-Position: refs/heads/master@{#305066}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2c80aa8..2405347

TBR=timvolodine@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/744133002

Cr-Commit-Position: refs/heads/master@{#305065}

BUG=435174

Review URL: https://codereview.chromium.org/744893002

Cr-Commit-Position: refs/heads/master@{#305064}

Sometimes OnDisplayMetricsChanged() may be called before shelf_
is set properly.

BUG=389171
R=stevenjb@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/740133002

Cr-Commit-Position: refs/heads/master@{#305063}

New extension button should slide out from the right, instead of the left.
Adjust the button's initial frame accordingly.

BUG=429810

Review URL: https://codereview.chromium.org/738223002

Cr-Commit-Position: refs/heads/master@{#305062}

BUG=none

Review URL: https://codereview.chromium.org/741943003

Cr-Commit-Position: refs/heads/master@{#305061}

Unused.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/740863003

Cr-Commit-Position: refs/heads/master@{#305060}

SuggestionsServiceFactory::GetForProfile() returns nullptr if
Profile::IsOffTheRecord() is true. So when another factory or
client code use the helper method to get the service, it gets
a nullptr.

The SuggestionsServiceFactory::GetBrowserContextToUse() test
happens only in the GetServiceForBrowserContext() call, and
thus does not happens when client code use this helper method.

The only situation where GetBrowserContextToUse() could be
called is if code directly call GetServiceForBrowserContext
or if ServiceIsCreatedWithBrowserContext() were overridden
to returns true.

Since none of those two conditions are true, then the method
is never called with an off-the-record Profile and the default
implementation inherited from BrowserContextKeyedServiceFactory
does the right thing (i.e. returns nullptr, which in turn cause
GetServiceForBrowserContext to return nullptr).

BUG=None

Review URL: https://codereview.chromium.org/744033002

Cr-Commit-Position: refs/heads/master@{#305059}

Revert of Add chrome sync tests to the GN build. (patchset #3 id:40001 of https://codereview.chromium.org/717923006/)

Reason for revert:
This seems the most likely culprit behind sync_integration_test build and test errors that started in the patch that included this change.

Original issue's description:
> Add chrome sync tests to the GN build.
>
> This adds sync_integration_tests, sync_performance_tests, and the sync test support targets.
>
> I removed some files that were duplicated between the sync integration tests and the test support. In GYP the fact that test support was a static library hid the duplicate symbols.
>
> Add a dependency on sessions_core from sessions test support since it's required to link. Made test support target be a source set (linking source sets into static libraries will often duplicate symbols).
>
> Committed: https://crrev.com/d60468061789084ebd98458b9743726cc1541786
> Cr-Commit-Position: refs/heads/master@{#304904}

TBR=scottmg@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/746563002

Cr-Commit-Position: refs/heads/master@{#305058}

Gyp variable mips_fpu_mode is currenty used and needed by v8.

BUG=
TEST=call build/gyp_chromium with GYP_DEFINES="target_arch=mipsel mips_arch_variant=r2"

Review URL: https://codereview.chromium.org/742133002

Cr-Commit-Position: refs/heads/master@{#305057}

This is a small webview-specific workaround that affects all drivers.
Will need a better driver/version specific workaround later.

BUG=434570

Review URL: https://codereview.chromium.org/722683004

Cr-Commit-Position: refs/heads/master@{#305056}

This CL makes the WeakPtrFactory check allow more than 1 WeakPtrFactory at
the end of the class, but still ensures that no other data members appear after the WeakPtrFactory(s).

BUG=303818

Review URL: https://codereview.chromium.org/740083002

Cr-Commit-Position: refs/heads/master@{#305055}

The data reduction proxy retries a bypassed request by creating
a new URLRequestHttpJob for the request and starting it. This
change uses URLRequestJobManager::CreateJob() to create that job.
Previously, the URLRequestJobFactory chain was called to create
the job, an it only would for main frame requests.

BUG=434830

Review URL: https://codereview.chromium.org/740643003

Cr-Commit-Position: refs/heads/master@{#305054}

For guest sessions (profile->IsGuestSession), we do not use
profile->GetOriginalProfile() for browser windows, we use the off the
record profile instead.

This was triggering an assert at the top of Browser::Browser().

BUG=434491

Review URL: https://codereview.chromium.org/741883002

Cr-Commit-Position: refs/heads/master@{#305053}

Specifically, this adds tests for:
  TruncatedMean
  Variance
  StandardDeviation
  StandardError

which were not covered before. I also added a couple notes about things
we may want to change in the behavior of the math_utils functions.

Still not covered is PooledStandardError, unit test coverage can be added
for that function in separate CL.

BUG=

Review URL: https://codereview.chromium.org/736573002

Cr-Commit-Position: refs/heads/master@{#305052}

Add some syscall wrappers instead of calling syscall() inline.
This adds some type safety and will make it easier to switch the
underlying syscall implementation.

This fixes a few issues with SYS_CLONE being called with the wrong number of
parameters.

BUG=435194

Review URL: https://codereview.chromium.org/684993005

Cr-Commit-Position: refs/heads/master@{#305051}

BUG=435174

Review URL: https://codereview.chromium.org/745683002

Cr-Commit-Position: refs/heads/master@{#305050}

Prior instrumentations showed that most of the jank for this bug comes from these lines in AboutSigninInternals::NotifyObservers
  scoped_ptr<base::DictionaryValue> signin_status_value =
      signin_status_.ToValue(client_->GetProductVersion());

Note that at least in Windows Canary, there are always 0 observers, and the value that we are calculating using a janky call is not used.

I'm almost certain that the cause of jank is in VersionInfo::GetVersionStringModifier, but I'm adding this last instrumentation to be 100% sure.

Reviewers, please feel free to stop me and start fixing the jank if you already know what's happening.

This is a mechanical change that adds instrumentation required to locate the
source of jankiness (i.e. a long-running fragment of code executed as a part of
the task that causes jank) in the code. See the bug for details on what kind of
jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've
helped to find and fix janky code. The code of the instrumentation is highly
optimized and is not expected to affect performance. The code simply creates a
diagnostic task which is identical to ones created by PostTask or IPC message
handlers. The task gets created only in developer build and in Canary channel.

BUG=422460

Review URL: https://codereview.chromium.org/740783004

Cr-Commit-Position: refs/heads/master@{#305049}

BUG=427057

TBR=gab,isherman

Review URL: https://codereview.chromium.org/731663002

Cr-Commit-Position: refs/heads/master@{#305048}

BUG=318404
TBR=samuong@chromium.org

Review URL: https://codereview.chromium.org/744453002

Cr-Commit-Position: refs/heads/master@{#305047}

After the fix, jankiness disappeared from the task tracked by this bug.
Before the fix, jankiness of URLRequestSimpleJob::StartAsync was 18.1jph.

However, jankiness of URLRequest::Delegate::OnResponseStarted went up from 23.7 to 42 jph.
That task is tracked by another bug 423948.

This could mean the page fault exception that moved to another place.
I'm instrumenting the suspicious place mentioned in earlier conversations.

BUG=422489

Review URL: https://codereview.chromium.org/746483002

Cr-Commit-Position: refs/heads/master@{#305046}

This was removed in https://codereview.chromium.org/689463003 and then
accidentally reintroduced in https://codereview.chromium.org/668123003.

R=reveman@chromium.org

Review URL: https://codereview.chromium.org/737903003

Cr-Commit-Position: refs/heads/master@{#305045}

 * Add JSDoc.
 * Add EventType enum.
 * Create completeInit class to wait for initialization completion.
 * Add FileSelectionHandler#isAvailable.

BUG=267281
TEST=None

Review URL: https://codereview.chromium.org/736663002

Cr-Commit-Position: refs/heads/master@{#305044}

As of M39, Chrome is a 64-bit only binary. This changes the default build
configuration to 64-bit globally. After this CL, the 32-bit Mac build is no
longer supported.

BUG=405542,18323
R=mark@chromium.org

Review URL: https://codereview.chromium.org/730173002

Cr-Commit-Position: refs/heads/master@{#305043}

Requests for tabs permission for VirtualKeyboard. The URL of the current tab page is needed, and this permission grants it.

BUG=

Review URL: https://codereview.chromium.org/739323002

Cr-Commit-Position: refs/heads/master@{#305042}

Focus of this CL is on the PNaCl records that can appear in bitcode files.
A subsequent CL will add how the records are converted to bitcode sequences.

Replaces CL: https://codereview.chromium.org/364463002

BUG=None
NOTRY=True
(documentation only change).

Review URL: https://codereview.chromium.org/725333002

Cr-Commit-Position: refs/heads/master@{#305041}

This is a reland of https://codereview.chromium.org/715853002/

There are no changes, but the last attempt triggered some silent exit code
errors which have now been fixed by https://codereview.chromium.org/732473003/

This CL provides a more robust and efficient implementation of WriteFile,
also integrating the functionality of the (now removed) WriteTextFile.

BUG=267773

Review URL: https://codereview.chromium.org/744753002

Cr-Commit-Position: refs/heads/master@{#305040}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f84325cc..2c80aa8

TBR=timvolodine@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/740413002

Cr-Commit-Position: refs/heads/master@{#305039}

BUG=400619

Review URL: https://codereview.chromium.org/722703002

Cr-Commit-Position: refs/heads/master@{#305038}

After the fix, jankiness disappeared from this task.

BUG=422489
TBR=tony@chromium.org, danakj@chromium.org, thestig@chromium.org, finnur@chromium.org, michaeln@chromium.org, avi@chromium.org

Review URL: https://codereview.chromium.org/747443002

Cr-Commit-Position: refs/heads/master@{#305037}