- 28 May, 2020 40 commits
-
-
danakj authored
This puts the main frame and iframe into the same site so that the devtools inspector can watch its network requests. Also remove access-inspected-object.js from the not-site-per-process virtual test suite since it was fixed and enabled. The test will be run without site-isolation in the not_site_per_process_blink_web_tests bot step. R=yangguo@chromium.org Bug: 623268 Change-Id: I1ab5fd22ec988e2aa7de8cea52e207a6f6c4528c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218750 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772583}
-
Gauthier Ambard authored
The tests were marked as flaky but I can't repro. Re-enabling them. Fixed: 714303 Change-Id: If329171730bd10aa4a6ed9ed9c7458b10f3587e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213531Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#772582}
-
Koji Ishii authored
This patch fixes |NGLogicalLineItem::HasFragment| to return true for floating items. Logically speaking, it should return true, but the current code returns false. It looks like this does not seem to affect, but found in r771489 crrev.com/c/2212187 and it's better to fix before code starts to relying on the behavior. Bug: 982194 Change-Id: Ie4de3a7e68190d1db5589781abe2b913961d3213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217995Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772581}
-
danielng authored
Signalling to the user that they can't add a port that's already being stored in the port forwarding settings for Crostini. Also, touched up some of the browser tests. Tests: Added browser tests and tested changes locally Bug: 848127 Change-Id: Ia001380f6a08970f20f43029b6dc78acc47ccadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210339 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#772580}
-
Miriam Polzer authored
The update engine sends a flag for enterprise rollback. Instead of guessing whether the current update is an enterprise rollback using channels and versions, we use the rollback flag together with the powerwash flag to determine which kind of update is happening. Bug: 864672 Change-Id: Ia9a97b2bfe8abf5d795a2b530689321b9d585a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215058Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Miriam Polzer <mpolzer@google.com> Cr-Commit-Position: refs/heads/master@{#772579}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/192fcf03f956..dc8caee164ef 2020-05-28 fancl@chromium.org auto-bisect: Fix tags in auto-bisection request If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087228 Tbr: rmhasan@google.com Change-Id: I55ab6f99ecd2c9598e5ece589879128d0ff8c607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772578}
-
Alex Danilo authored
Implements behavior of a <select> element using a <div> so that it can be styled for files-ng. Creates an absolutely positioned <div> to hold the <option> elements that would normally get inserted as children of <select>. Adds the styles needed for the files-ng case to apply to the <div> and its descendants. Points the initialization code that populates the <select> to use the <div> if files-ng is enabled. Adds event handling logic to mimic the behavior of <select> in regard to activation, keyboard events, etc. Fires a 'change' event on the <div> whenever an <option> is selected, that is needed so that the browser can match CSS :checked selectors that are targeting the emulated select (div) element. Sets the width of the <div> acting as host to the width of the absolutely positioned <div> hosting the <option> elements during selection to stop the host <div> changing width when different sized options are selected. Bug: 1002410 Change-Id: I5d7b227b561d96aaf61e88d9e206ac7de80d468e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201336 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#772577}
-
Roman Sorokin authored
Also postpone focused pod hooks during screen locking until after the session state changes. Fixed: 914972 Change-Id: I8fc68a0f07be8a3eea9cde973eb0e203e47edd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215326Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Adam Rice authored
The quota-based WebSocket implementation would never fragment outgoing messages of 64KB or less as long as quota had time to be updated. Emulate this behaviour with the new datapipe-based implementation, to avoid the risk of breaking applications dependent on the old behaviour. The behaviour is controlled by the feature flag "WebSocketReassembleShortMessages" which defaults to enabled. This can be disabled for experiments to determine if the feature is really needed. No extra bytes are copied and no extra allocations are done. The main overhead of the feature is in extra code complexity. Add a web test, expect-unfragmented.html. This has been tested against the old quota-based implementation (passes) and with --disable-feature=WebSocketReassembleShortMessages (fails). BUG=1086273 Change-Id: I958dd5d99931e3023ee339481f101ffa56ed274e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215383 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#772575}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/22534f2098e7..a2f4f6793366 2020-05-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5749e77b to f752954c (450 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I433be2c2d66ca40f0ec207d34c8bb4c53a59e4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218585Reviewed-by:
-
Kent Tamura authored
Bug: crbug.com/1069817 Change-Id: Ie3b4bb52e9151939026df20e37459de596d78545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217714 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772573}
-
Yoshifumi Inoue authored
This patch changes "mathml-sanitizer-bypass.html" to check whether MathML enabled or not to choose valid expectation. As of May 2020, MathML is experimental feature and implemented on LayoutNG. When enabling EditingNG and pasting clipboard content into editable, MathML contents are rendered as MathML layout instead of non-MathML. For <math>B</math>, we have following layout tree: MathML enabled: LayoutNGMathMLBlock {math} at (0,0) size 0x0 LayoutText {#text} at (0,0) size 0x0 MathML disabled: LayoutInline {math} at (0,0) size 10x19 LayoutText {#text} at (0,0) size 10x19 text run at (0,0) width 10: "B" Bug: 707656 Change-Id: I722541655322cedda7ada53fa09e08d78fd2db5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217758 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: -
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590623692-442abbb1e080c04fab88844b2b8eca58e501203d.profdata to chrome-win64-master-1590637846-cf66cd399b4c48375ae2ad3d18827b7a5bc0b17a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifd8ef8edefcb20833f6d17749d1d465f95747ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219628Reviewed-by:
-
Abhijeet Kandalkar authored
RenderViewHostTest.SetBackgroundOpaque test just checks whether mojo channel can be bound to a fake widget host and not testing any core functionality of RenderViewHost. This CL removes that test code from render_view_host_unittest.cc Bug: 1047469 Change-Id: I8a7aea5de90fd1711a50e496abd20623571d00e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216130Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#772570}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/97a2e2dd..4feef9cc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib54cc521c90367dfe3ab747642b900b5398a41ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218379Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772569}
-
Mike Jackson (EDGE) authored
Converting this to a parameterized test, and enabling to run in BMO mode now that https://chromium-review.googlesource.com/c/chromium/src/+/2215078 has landed Bug: 1082854 Change-Id: Ifb8f22adef8b9878e81a80584e5dd61d71f6b5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219587 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#772568}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2b0eafb1de5b..e00d27c6d65b 2020-05-28 greg@lunarg.com Fix missing patch decoration for TessFactor PCF arg (#2249) 2020-05-28 greg@lunarg.com Update SPIRV-Tools to stable. Also SPIRV-Headers to TOT. (#2250) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I66b44bfee4e3b01d84f2686dd124e2edf4b0d743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218583Reviewed-by:
-
Moe Ahmadi authored
zero-prefix suggestions disabled search suggest chips. In order to better understand the impact of search suggest chips on realbox performance SearchSuggestChips feature will be used in the latest realbox experiments in M83. This feature has been tested on Canary as part of NtpRealboxZeroPrefixSuggestionsDesktop study Change-Id: Id8f2f0e69da06af5203dc842c66dd01d6d5bfb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218723Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772566}
-
Sadrul Habib Chowdhury authored
In some web-tests, the compositor may not have a scheduler, and this can cause a crash. To fix this cash, update the code to not depend on the scheduler, and instead directly pass in the appropriate BeginFrameArgs instance through the SchedulerClient API. BUG=1086387 Change-Id: I160484f2be311f3ae3dffc983c4d0448ca3bae5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219163 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#772565}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/55c85f66d2fd..a3636ed8883d 2020-05-28 jiawei.shao@intel.com Support multiple array layers in one texture-to-texture copy command 2020-05-28 jiawei.shao@intel.com Disallow using cube or cube array texture views as storage textures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4bd0a8b174b49d17e95662f362efd5a52cbbba3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219433Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f5dace0f1e57..6a184fe947ed 2020-05-28 ynovikov@chromium.org Fix use_libfuzzer build 2020-05-27 cnorthrop@google.com docs: Update ANGLE for Android documentation 2020-05-27 kbr@chromium.org Emulate unsized depth/stencil textures on ES 3.0 without OES_depth_texture. 2020-05-27 tobine@google.com Vulkan:Initial worker thread disabled by default If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I1336abcced0aa13693dc53f46af1a0b04369a478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218666Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590623692-0f578bc687b2561083fd54c973f9fd861443060a.profdata to chrome-mac-master-1590637846-f24e6c1a243316554d5b0c2334884adcb37c67bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I94fce3cfbf9c53587744a0f9683f56c2769c3d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219627Reviewed-by:
-
Sadrul Habib Chowdhury authored
The CL was reverted due to flake failures of the test enabled in this CL. The fix is to allow for some errors when comparing the scroll offsets, since it can be any fractional value. Original CL description: === Update API to set fractional wheel deltas on android, and remove the code that explicitly used to remove precision. TBR=yfriedman@ for content/public (already reviewed in original CL) BUG=1085890 Change-Id: Id59b1bd38c62a7724334eeb7b0e45c7ba2ecde40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217117 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772561}
-
Chris Harrelson authored
As of this commit [1], it was previously limited to positioned elements. [1] https://chromium.googlesource.com/chromium/src/+/0a7940331530fc647dbd37e6bcce20540271234a Bug: 1087177 Change-Id: Ief3013338d63b59a88a788fced0e185e293de850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219312Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#772560}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d3a01e5713dc..192fcf03f956 2020-05-28 dberris@chromium.org pinpoint: Add the "pin" field in bisection form 2020-05-28 fancl@chromium.org auto-bisect: Implementing Auto-Bisection 2020-05-28 dberris@chromium.org pinpoint: Fix 'try a patch' dialog If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:10791706,chromium:1079183,chromium:1087144 Tbr: rmhasan@google.com Change-Id: Ie68629bba66f4f7e61fc2752c2ec2ce840e43ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219547Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f58d7039ba44..d4771af96b5e 2020-05-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib8d740b1e599ed44ab85093bbde6c991221c9002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219549Reviewed-by:
-
Jinsuk Kim authored
ContentView was not being removed together with WebContents wrapped in ThinWebView. This CL makes sure to remove it from the view hierarchy. Bug: 1080552 Change-Id: I54c81d8c0b67b35340af0a875c671d4bdd119599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212240Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#772557}
-
Eric Willigers authored
Existing menu code such as RenderViewContextMenu assumes the icons are available synchronously. We cache the favicon for each web app. If no icon is cached, the menu item is shown with no visible icon. References to Bookmark Apps in RenderViewContextMenu are replaced with references to web apps. Bug: 1052707 Change-Id: Ib6dd23c448e01dfb36575008532fcce76b339ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216834 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Joey Scarr authored
This is a reland of ac81b31b Original change's description: > Move linux-blink-cors-rel from fyi to chromium.linux. > > This is to enable the bot to be sheriffed. > > Bug: 1086320 > Change-Id: I0e379f7b168ce3d13874a399d953c251bede8a9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215763 > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Joey Scarr <jsca@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772501} Bug: 1086320 Change-Id: Ia450854e7d76cf64f48178fc8054db4d02ef5b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217755Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> Cr-Commit-Position: refs/heads/master@{#772555}
-
Yoshifumi Inoue authored
This patch changes "doubleclick-beside-cr-span.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ibee76fe9911b05e394e750e9d4effece1a9941d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215871 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
nancylingwang@google.com authored
When system startup, windows restored can’t get the visible and activated status from OnWindowVisibilityChanged and OnWindowActivated. Also web apps are ready at the very late phase which delays the shelf id setting for windows. So check the top window's visible and activated status when we have the shelf id. Fix the instance state issue when drag the browser tabs. The top window could be changed when drag a tab to switch between browsers, so update the relation for tab windows and browser windows. Bug: 1085284 Change-Id: I47ccf5e8c14d8ce6632bf469903709ddbadfbf8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190075 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Kent Tamura authored
Only ListBoxSelectType uses them. Bug: 1052232 Change-Id: I760693d453bb56e0461b81fc500ae3c47a09e12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217757 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Wei Li authored
Instead of letting the desk mini view to directly own a preview view, the preview can be owned by the view hierarchy. This also makes the ownership on mini view's children consistent. BUG=1044687 Change-Id: Ibe7392daecd736d02a3d8d0be8c17e332fd46371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218852 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#772551}
-
Koji Ishii authored
This patch defers creating |NGFragmentItem| until |NGFragmentItemsBuilder::AddLine|. This patch also removes |NGLogicalLineItem::fragment_item|. It was needed because |NGInlineLayoutAlgorithm| must create |NGFragmentItem|, but with r771489 <crrev.com/c/2212187>, we can create |NGFragmentItem| even after |NGInlineItemResult| was destroyed. This is to reduce memory copy when changing the Vector of |scoped_refptr<NGFragmentItem>| to the Vector of |NGFragmentItem| (WIP <crrev.com/c/2208806>). Bug: 982194 Change-Id: I41a4e4339d09ef5020bc20abcfd3899ca30792e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216133Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772550}
-
Scott Violet authored
The controls shouldn't scroll if a11y is enabled. I plan to merge this to 84, so that I'm forking AccessibilityUtil. The plan it to move AccessibilityUtil to ui so that it can be shared. BUG=1085210 TEST=BrowserControlsTest.testAccessibility Change-Id: Icc04354639d3ae1b4f64773752705b37117e9f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219008 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#772549}
-
zhaoyangli authored
Previously this was only used for iOS 13+ device. This CL changes it for all on device GTests and remove the iOS version check method. This CL only prepares to run these in test runner scripts. Will send follow up CLs on GN configs to make device builders really build and run GTests with xctest. Bug: 1087078, 1001667 Change-Id: I03386ec0caa6f719640cb4d8140cb73ded0ef2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219108 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772548}
-
Nidhi Jaju authored
service worker registration for better estimation of the size of ServiceWorkerRegistrationInfo for an OOM crash investigation. Bug: 848194 Change-Id: I3d5af5405d64ab9629989d6287f474f61ec16436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217668Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#772547}
-
Koji Ishii authored
This patch changes |ComputeAnnotationOverflow| to not to use |fragment_item| to compute the block height of ruby runs. This is needed for crrev.com/c/2216133 to remove |NGLogicalLineItem::fragment_item|. Its replacement should be |inline_item|, but this patch doesn't add it because all ruby runs should have |layout_result| and shouldn't need |inline_item|. Bug: 982194, 1069817 Change-Id: I40a0670121499bd212ca95ba3e2680a9b0f292de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217672Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/47bf5f46..97a2e2dd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I553631475fcbb840b02f09e9ecabddb6984c4a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217858Reviewed-by:
-
Asami Doi authored
This CL adds a feature flag for the offline capability check that checks if a website is installable. Browser tests relating to the check are updated to use parameterized tests depending on the feature flag. Bug: 965802 Change-Id: I3678383d62c3fad084d7c7a804755bc97de9b40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203571 Auto-Submit: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772544}
-
