- 15 Oct, 2020 40 commits
-
-
David Dorwin authored
Change-Id: Ia8cde7c733b8a96ad5bdf3a8f0ef4af92575080d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466936 Auto-Submit: David Dorwin <ddorwin@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#817327}
-
David Bertoni authored
Some tests were not being run as a Service Worker-based extension for the related parameterized case. Bug: 1093066 Change-Id: Ic7771a8b272cba593da1680dc1218d770d600283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458884Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#817326}
-
Wenbin Zhang authored
The current estimate of dawn_perf_tests is inaccurate. Updating the value based on actual runtime. Bug: chromium:1130157 Change-Id: I5f2e4b22ae983d897062a7940e00250b15db743d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472465Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#817325}
-
Dale Curtis authored
These operations should continue in all cases since dismissing, requesting, or waiting on picture buffers should happen regardless of whatever the decoder is currently doing. R=liberato Bug: 1111273 Change-Id: I7dc76ca22cca3f5f16c085a9cd9648275aa3e0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473342 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#817324}
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: Ib2ef4b92369ac7eb61ad148254a4506c02467fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468941Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817323}
-
Alice Boxhall authored
Bug: 1075862 Change-Id: I5da5ee8984896e5c39baef36c06f46eb451524bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327363Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#817322}
-
Yuly Novikov authored
TBR=kbr Bug: 1004581 Change-Id: I027e384cea1233e7fcc948d7989c22b286d7b381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473160Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#817321}
-
Jesse Schettler authored
Add a new FileType enum and include it in ScanSettings. The file type will be used to save scanned images in the desired format. Tbr: dcheng@chromium.org Bug: 1059779 Change-Id: I114ee2e85582340c46b4ab2111411b0ba2c16813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460980 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#817320}
-
Prashant Nevase authored
This patch makes image operations thread-safe in dark mode filter. The data members used for image operations are made read-only. Bug: 1094005 Change-Id: Ib4d31d824e04d54b2d681c45012869f4a4d1a738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465886 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#817319}
-
Hirokazu Honda authored
Bug: 1029212, 1000988 Test: video_decode_accelerator_tests test-25fps.av1.ivf --use_vd Change-Id: I03c5989907a75f213f9cc77fcc1719b6a086b9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438076 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#817318}
-
George Burgess IV authored
The strings stored in `tokens` all have static storage duration, so there's no reason to put them in `std::string`s. AX-Relnotes: n/a. Bug: None Change-Id: I9b6bc9e847e5c27d68707a4f33d37b225ded34fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457589Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#817317}
-
Peter Kasting authored
Bug: 772945 Change-Id: I7b52c1c6712a99ddc9fb417374820f5d2d0c2f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469437 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#817316}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2f0cad0f053e..df97f4c2861e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC loyso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: loyso@google.com Change-Id: Iea01b6dee6bce50e93380f650c06f1f833645f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473819Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817315}
-
Evan Stade authored
The services will be foregrounded and the notifications will be visible when a cast session is ongoing. The service/notification ID design matches that of MediaSession. The notification IDs are defined in client xml, so //components/media_router code needs to ask the embedder for these values. Casting is still not functional in WebLayer even after this change as a CastOptionsProvider is required. Bug: 1057100 Change-Id: I4d6fa44d1073a0a26c618c501e58251f118379c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467197Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#817314}
-
Regan Hsu authored
This class enables the PhoneHub Multidevice feature state when the HostStatus (provided by the MultideviceSetupClient) of the phone is initially |kHostSetLocallyButWaitingForBackendConfirmation|, and becomes either 1) |kHostVerified|, or 2) becomes |kHostSetButNotYetVerified| first, and then later |kHostVerified|. This class also disables the PhoneHubNotification Multidevice feature state when Notification access has been revoked by the phone, provided via NotificationAccessManager. Bug: 1106938 Change-Id: I01435323b3a3b8ec886ab32de0ba324b9473d2a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468265 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#817313}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b901b8f9..28cb2dd6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibf29358eb3d1935504ab737e4aac596d7702599b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473738Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817312}
-
Andrey Kosyakov authored
headless_shell build with build/args/headless.gn should not depend on x11, and https://crrev.com/c/2368534 brought x11 via dawn to all linux builds. Bug: 976495 Change-Id: I65c0371f97e2c7eeda5381f890d52c8b06c60b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473444Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#817311}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0581509dc2dd..7411aeba4d3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia5eb48cd6b15e155445ae8b9952e6560c4f5fb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817310}
-
Lukasz Anforowicz authored
The "RelaxIsolatedWorldCorsInFileUrlLoaderFactory" feature was introduced in r740899 in Q1 2020 just in case more extensions encounter https://crbug.com/1049604 forcing us to revert to the old behavior. This never happened and the feature was never enabled (and we don't have any plans of using this feature in the future - quite the opposite, we want to keep the feature disabled). Based on the above this CL removes the feature (~reverting r740899). Bug: 1049604 Change-Id: I4e2c2b61965661e61c75fd8cf7878715da4882d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466511Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#817309}
-
Alexey Baskakov authored
This reverts commit 290037a8. Reason for revert: Breaks compilation on lacros https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-lacros-dbg/1132 Original change's description: > Set use_dawn=true on Linux > > This enables WebGPU on Linux behind --enable-unsafe-webgpu > and --enable-features=Vulkan. Shared image support requires > SkiaRenderer (default on Linux) and Vulkan to be enabled. > > Bug: 976495 > Change-Id: I97065f2ac6aadd110971254bfe3526d366318b83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368534 > Commit-Queue: Austin Eng <enga@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817266} TBR=kbr@chromium.org,cwallez@chromium.org,kainino@chromium.org,enga@chromium.org Change-Id: I050e90c36094f047d4e311d467c603b47d2abf82 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473858Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#817308}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: Ib72fae06192b4fea7f9e87bf6a4f55bd50c136b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459187Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#817307}
-
Joon Ahn authored
https://screenshot.googleplex.com/4Cu2NuqTLYKXMpM Bug: 1125150 Change-Id: I6211f47c2d05405bfad0e935325622caede41fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472202Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817306}
-
Clark DuVall authored
This change pulls weblayer out of the base module and into the chrome module. WebLayer supports being loaded from a "weblayer" split, so an empty split is created which depends on the "chrome" split (which has the weblayer implementation). WebLayer java was not added directly to the "weblayer" split, because it would end up pulling a bunch of code shared with chrome into the base module. Bug: 1126301 Change-Id: I78aaec57a9b970bec964c36421d759bbbf7039eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463963Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#817305}
-
Xiaohui Chen authored
Follow up on thread https://groups.google.com/a/chromium.org/g/security-dev/c/ul731DpnsR0 Bug: None Change-Id: Ic289e297865d6323e587a6b8d843b4293886101e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472702 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#817304}
-
Nancy Wang authored
When the ARC raw icon image rep has the correct size, it should be added to the imageskia as well, otherwise, the imageskia might miss the rep for one scale, which could cause the scale mismatching issue. BUG=1124679 Change-Id: Ib6332a0b0924afff590a72b3c4e3158522f254c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472718Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#817303}
-
Mustafa Emre Acer authored
Bug: 1077426 Change-Id: Ia2d5a44bf8ba63aaaec915ae93cdb4afd0bafea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466818Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#817302}
-
Karthika Pai authored
This is part of a migration that replaces the old <histogram-suffixes> syntax that was used to denote groups of histogram to the new patterned histogram syntax. Bug: 758782 Change-Id: I74e4f195782cd5e236d401d0bbeb8402c0f53143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472435Reviewed-by:
-
Kyle Williams authored
Removing the CfmServiceRegistry allows for more succinct APIs and a more clear design. * Replace |RequestBindService| with |BindRegistry| * Fix Tests and function definitions BUG=b:170679101 TEST='./out/Default/chromeos_unittests --dbus-stub --single-process-tests --gtest_filter=Cfm* && xvfb-run ./out/Default/unit_tests --single-process-tests --gtest_filter=Cfm*' Change-Id: I9e2a0abc0a1ad388db28d096d9e4080d80945b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467279Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fb3d4294864a..b7c1c3f1140b 2020-10-14 jeremya@chromium.org fix v8 sample processing in multiprocess context If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:731804 Tbr: wenbinzhang@google.com Change-Id: I01424de5929a653cee61c77eeb3ca524fe8ba114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472624Reviewed-by:
-
Kent Tamura authored
This CL has no behavior changes. No-Try: true Change-Id: Id12d1876e22f8c40c3998573fa8cef36b06ab012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467038Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#817298}
-
David Dorwin authored
Previously, the file was always written, even in the case of an exception. Change-Id: I0cee215b529f6864c8c14fc90934de2fc7f44974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466738Reviewed-by:
-
Thomas Lukaszewicz authored
Bug: 1130078 Change-Id: Ie2011526a9e9e75327895441af629758fa49b715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471879 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#817296}
-
Scott Violet authored
BUG=1133893 TEST=test only change Change-Id: Idcc6912a75b2e9919fd8391926ff771b323d887e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473340 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#817295}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3d6e2c46968d..2f0cad0f053e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msw@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1135660 Tbr: msw@google.com Change-Id: I5dae22b9131fe05ebd2f9417a56dc3e0e4c548ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473027Reviewed-by:
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //ios/chrome/browser. R=rohitrao@chromium.org Bug: 1113033 Change-Id: Iddc26c3a0adcdaaf0e9a9dfda5f3244e3e1b5ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472457 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#817293}
-
Keren Zhu authored
Bug: 772945 Change-Id: I972c061fcc008f3c37308c5186e6432d766de1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470237 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
-
Akihiro Ota authored
Fix two assertion errors: 1. The first error was firing because we were asserting things in the wrong order; to fix it, we just needed to move the assertion after the speech expectation. 2. The second error was firing because we were asserting the current range before it changed. To fix this, we add an extra speech expectation, which is spoken after the range has changed. Bug: N/A Change-Id: I06f9ead1815ce2e2e2c0ce77a6459d8cf3dc8f12 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461587Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#817291}
-
Alexey Baskakov authored
This reverts commit abedddf0. Reason for revert: Breaks compilation on lacros https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-lacros-dbg/1132 Original change's description: > Roll Dawn from 73b70229af3a to 84b70a6e4d93 (3 revisions) > > https://dawn.googlesource.com/dawn.git/+log/73b70229af3a..84b70a6e4d93 > > 2020-10-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from f2b8b6e87396 to ff267ca60e14 (2 revisions) > 2020-10-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 435916e544cc to f2b8b6e87396 (1 revision) > 2020-10-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 4311dd05c883 to 435916e544cc (1 revision) > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/dawn-chromium-autoroll > Please CC enga@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel > Bug: None > Tbr: enga@google.com > Change-Id: Ib445bb81fe3a552451171cf1b0d2626e307bfdae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473020 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#817270} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,enga@chromium.org,enga@google.com Change-Id: I0c0878b4b2640dae5f2bc496597d03e2876d31dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473777Reviewed-by:
-
Alex Newcomer authored
Just check for whether something can be rendered in HTML using the same criteria. Forgot to update this line when I changed the criteria on OnClipboardHistoryItemAdded. Bug: 1138665 Change-Id: Ic50fcec0bd78a1ab5d6090024fb54de79141bec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473165Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#817289}
-
Jamie Madill authored
This adds an is_unexpected tag, and handles multiple results (e.g. from retries) correctly. Bug: 931731 Bug: 1138507 Bug: angleproject:5124 Change-Id: I23054010db058eaa9d275c9b5de3052030210024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472338Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#817288}
-
