- 27 Mar, 2020 40 commits
-
-
Roman Sorokin authored
Also removed SigninScreenHandler::SetFocusPODCallbackForTesting Fixed: 602951 Bug: 987587 Change-Id: Id943fc5c0a82bdb45f44d69b02ccded83f5a0072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120358 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#754095}
-
Pavol Marko authored
Make sure that the policy-mapped-pref value is only used when the PrefService is fully initialized. Bug: 1047683 Test: Manual: Set the policy value to 2, reload policies, restart ui -> no variations in chrome://version. Set the policy value to 0, reload policies, restart ui -> variations in chrome://version. Change-Id: Id706bbc5be463f355b61cb1a553ab151be3a7dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107597 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#754094}
-
Randy Rossi authored
Make changes to build files to allow packaging chromevox from chromecast builds. Need to split out chromevox and common deps from deps that will only build for chromeos. Also add the ability to specify a manifest file using the FileUtil::LoadExtension method instead of assuming 'manifest.json' hard coded constant. Bug: None Test: Test case, Local chromecast build Change-Id: Id4e5ac0cbb80241536a2e7e3cf48a71dd5f1124a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112573Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#754093}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/ffed96d1528d..fa17e1bc3e84 git log ffed96d1528d..fa17e1bc3e84 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 dschuff@chromium.org Update ARM trusted toolchain tools to use Chrome's sysroot Created with: gclient setdep -r src/native_client@fa17e1bc3e84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: mseaborn@chromium.org Change-Id: I789b349a5b5e186843db8a4e79ad2455cd3e4486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124809Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754092}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/62e2d1bb6aa4..058444fabc78 git log 62e2d1bb6aa4..058444fabc78 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 jophba@chromium.org Hotfix for broken arm bot Created with: gclient setdep -r src/third_party/openscreen/src@058444fabc78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I8369e6c90897cd38ca80a657e62bccd719359db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124807Reviewed-by:
-
David Van Cleve authored
crbug.com/1062637 reported URLLoaderFactory VALIDATION_ERROR_DESERIALIZATION_FAILED crashes starting shortly after adding a new member to ResourceRequest. The new member, of type OptionalTrustTokenParams, is only used for functionality currently behind a flag (and not enabled anywhere in production). To help diagnose the cause of the crash (and, in particular, whether it has to do with the trust_token_params field) this change separates the deserialization of this field from the large "if (!Read(A) || !Read(B) || ...)" conditional in url_request_mojom_traits.cc and specifically dumps on failure to deserialize the field. R=yhirano Bug: 1062637 Change-Id: Icc199fe29bcf1179d762971fb383ffee95b31ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119764 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#754090}
-
Maksim Ivanov authored
This CL fixes the regression from https://crrev.com/c/2089684 that the back ("x") button in the Ash PIN request dialog wasn't clickable via mouse or touch screen. The underlying problem was that the button's view was overridden by another invisible view, so that one can see the button and even tab into it but not click it via mouse. The fix is to make sure that the button's view is on top of other views, i.e. it's added last into FillLayout. This CL also improves the existing unit tests to become a regression test for this bug. Now the tests will simulate mouse clicks in a way that is closer to the real-world flow (piping them through the whole views hierarchy, rather than directly firing the button press event). Bug: 1064368 Test: log into Chromebook using a smart card, lock screen, start unlock, click "x" in PIN dialog, check that dialog closes Change-Id: I9b20896a83f5fa251d3b05c5a8bc97ace9ebcd7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120295Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Daniel Nicoara authored
git log --oneline c5352e6b..bc4f023b 69bc430 drm/virtgpu: add header 1914f98 minigbm: mediatek: fix SCANOUT flag 8f708a1 minigbm: add synaptics gbm driver c2ad3d7 Add more scanout formats to meson driver 8d88474 minigbm: run presubmit.sh, modify OWNERs 827b8c2 minigbm: virtio: check caps version before disabling formats ddb56b5 mediatek: get prime fd with drv_bo_get_plane_fd 912c4c3 minigbm: dri: Set the plane sizes on bo creation. cfcea2f arc-cros-gralloc: amdgpu: Use DRI_PATH to load radeonsi 9b367b3 minigbm: dri,amdgpu: Modifier support. 44588bb minigbm: dri: Support 2+ planes query for modifiers. 26fe682 Reland "minigbm: introduce test allocation" 08d8dbf Revert "minigbm: introduce test allocation" Bug: b:152384632 Test: Compiled chrome Change-Id: Ib4f875d03be4545ad4f71c145c50a6627d1040cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124300Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#754088}
-
Daniel Cheng authored
services.cc controls access to objects across a privilege boundary, so it should also go through security review. Bug: 1012033 Change-Id: I4cc8a96ec56ac2eed05423bc508b5e7b5e58f843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122920Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#754087}
-
David Van Cleve authored
This is one of a series of CLs updating Trust Tokens key commitment state to use a singleton in-memory store owned by NetworkContext and updated via Mojo from the component updater. This involves [1, this CL]: Remove key commitment-related state from the on-disk trust token store - Remove key commitment setters/getters - Remove batch size from the store Note: This change is actually a no-op, since no functionality depended on being able to store these items over the course of more than one operation. 2: Mojoify TrustTokenKeyCommitmentResult and remove commitment fetching and parsing code. 3: Clean up the persistent storage schema, swapping in the Mojo commitment result struct for existing uses of TrustTokenKeyCommitment{Result}. 4: Add a centralized issuers-to-commitments store in the network service. 5: Add component updater logic to populate this store. Bug: 1063510 Preliminary: Remove key commitments from TrustTokenStore Change-Id: Ib794ba2095b4608ff68eca8ddb42481cd6d2591e Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116646Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#754086}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4b1be08ec993..3665d28e6e71 git log 4b1be08ec993..3665d28e6e71 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 yunchao.he@intel.com Add validation tests for resource usage tracking Created with: gclient setdep -r src/third_party/dawn@3665d28e6e71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8c0c96e577e0bcd5ad46b97f269cec3d7e0aeaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123884Reviewed-by:
-
Side Yilmaz authored
RevampedContextMenuHeader classes. Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates RevampedContextMenuHeader classes by passing the current profile from RevampedContextMenuCoordinator. The junit tests of RevampedContextMenuHeader classes are also updated by adding mock Profile object to mimic the regular profile. Bug: 1041781 Change-Id: Iab0f5d900fea3616b5fdcd688335f17d8b757b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108503 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#754084}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/2542cb728f11..1bcd0c3f96e1 $ git log 2542cb728..1bcd0c3f9 --date=short --no-merges --format='%ad %ae %s' 2020-03-26 wub gfe-relnote: (n/a) More http2 changes to compile with -Wunused-parameter and -Wsign-compare. No behavior change. 2020-03-26 dschinazi Fix one curly brace placement in test code 2020-03-26 renjietang Account for static streams when QuicSession constructs v99_streamid_manager. 2020-03-26 nharper Internal QUICHE change Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org Change-Id: I980077c210a8cff22152c2cdc3eb5f15f72dfc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124547Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754083}
-
Yue Li authored
Bug: b/130042061 Test: Run unit_tests --gtest_filter=DeviceActionsTest.* Change-Id: I7bb24e5682a26193385688919ef7ba6aaf8fb3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112414 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#754082}
-
zhaoyangli authored
iOS common tests are already running on this builder. This CL adds other unit tests and EG2 tests as designed to run on this builder. Bug: 943883 Change-Id: Idff82abb809642d814a87bd6d9dec281b84f7751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122847Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#754081}
-
Dana Fried authored
- ExtensionsToolbarContainer now uses a 1D flex rule. - A number of classes have GetClassName() methods for debugging. Change-Id: I5e0c11fd1a786422190d78808b05e118efe65a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123167Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#754080}
-
Robert Sesek authored
An internal class apparently overrides this method, and now is broken because it is marked @Override. Tbr: wychen@chromium.org No-Try: true Bug: 1065440, 832124 Change-Id: I0a8e1bf64c99c004dfa3a9a4cee91da71112bd37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124232 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Stephen Chenney authored
Apparently histpgram bucket layout is not consistewnt across runs, or some other behavior is not deterministic. To de-flake the test we need to relax the asserts a little, but we're stuill testing that data is appearing. Bug: 1065326 Change-Id: I1c3490bb11f676d10b16b5ef32a065d7627856d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123520 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#754078}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/14b1e3f3d10a..c8974b38bff1 git log 14b1e3f3d10a..c8974b38bff1 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 bclayton@google.com Kokoro: Test LLVM 10 backend for ubuntu 2020-03-27 bclayton@google.com Coverage: Add 'turbo-cov': a faster reimplementation of llvm-cov 2020-03-27 capn@google.com Don't download all submodules for Kokoro tests 2020-03-27 bclayton@google.com Reactor: Disable more warnings to get LLVM 10 building 2020-03-27 bclayton@google.com LLVM 10: Add configs/common and configs/darwin. 2020-03-27 bclayton@google.com LLVM 10: Add configs/common and configs/linux. Created with: gclient setdep -r src/third_party/swiftshader@c8974b38bff1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I69b285bc54d167bf17b5759d1fe531a3330276f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123883Reviewed-by:
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to justify-content_space-between-002.html. Bug: 1063749 Change-Id: Ib4c2a87c230e1e8865be868e7bfc7d5273bcc865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121639 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#754076}
-
Katie D authored
Per security advice, the distilled page should have the same favicon as the original. Checks whether it is a distilled page and then converts to the original URL before looking up the favicon. Bug: 1006661 Change-Id: I3c25a1dcbc361b13e733633112b76de5077d9749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075637Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#754075}
-
evliu authored
Bug: 1065135 Change-Id: Ibf92b54e6e9576928097d5e5de17905e43c3e98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123029Reviewed-by:
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to flex-minimum-size-002.html Bug: 1063749 Change-Id: I1bb8d941d41a61c984b6431808302eb3d051a50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123500 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
-
Daniel Cheng authored
Bug: 1061138 Change-Id: Ie4e452dd78b207dfd86fb8da2cc7f0575c907f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121470Reviewed-by:
-
edchin authored
The dependency on /extensions was solely due to the use of a list builder for testing. This CL removes this unnecessary dependency. Also, the dependency on /extensions prevented these tests from being run on Android, and would have prevented them from being run on iOS in the future. Bug: 1065187 Change-Id: Ida63651f4c67f08ba3981f5d277afcdbf438cb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122820 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754071}
-
sreejakshetty@chromium.org authored
This CL introduces RenderDocumentHostUserData(RDHUD) API through which we can associate data with the underlying document. This patch converts UsbTabHelper to use RenderDocumentHostUserData and replaces existing manual tracking of frame lifetime in a map. Currently a map from render_frame_host to the FrameUsbServices is maintained to get the associated FrameUsbServices object instead we use RDHUD to do the same set of operations. This document https://docs.google.com/document/d/138_67WkBaU35W_wlLUS7ux-ICM_5tosdyLOBiqvlWs8/edit?usp=sharing explains in more detail on how RenderDocumentHostUserData can be used and extended to different classes. BUG=1057611 Change-Id: I37894f2897f4f7b2c5bbd10d422a39daba9bd0c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055105 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#754070}
-
Tao Bai authored
Make bounds passed through mojo. Bug: 1064420 Change-Id: Ib54220a70907c4506acf46479d51a8a79416a7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118832Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#754069}
-
Katie D authored
The text in the page info bubble describes whether the initial article was retrieved over a secure or insecure connection. Bug: 840191 Change-Id: I6c36fbe35d741ad67766b362af46a8e68757afd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115930 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#754068}
-
Jinfeng Ma authored
We collect three types of the highest layers from subtree for the paint layer which has overlay overflow control that needs to be reparented. Since they are all updated individually, the order in which they appear in the paint layer tree may not be fixed. The update order should be recorded to ensure that we access them in the proper z-order. Bug: 1006173 Change-Id: I11aed015a5b14f8a62938274cf7b7c7b58ddf2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120841 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#754067}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a27ec02e9e1e..60f529d224f9 git log a27ec02e9e1e..60f529d224f9 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 jacktfranklin@chromium.org Expand event listener e2e tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@60f529d224f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I79f35a52df12c05a5042efae2eafd91a763bda00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123878Reviewed-by:
-
Gauthier Ambard authored
The minimal content height of the NTP shouldn't take into account the toolbar on landscape. Fixed: 1062997 Change-Id: I5b4e9ef65a6de67863ce7f5ab05f57390e6c7f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124707 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#754065}
-
Wei-Yin Chen (陳威尹) authored
This CL only mechanically reorders tests. Should be no-op. Bug: None Change-Id: Iabd38fe1b4ce6ab8dbfc8717724fce2f7bb5f614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123637 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#754064}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5851deb6..276eb74c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2b5630c1166f17dde5b59712064a10b6f0d1a21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124075Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754063}
-
Wez authored
Fuchsia has been running tests with retries disallowed via an explicit --test-launcher-retry-limit of zero. Remove this explicit limit so that the TestLauncher can retry tests, potentially providing a better signal regarding their flakiness. Change-Id: I246235108f95cef90a43de4f43ff4493aebf01b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120400 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#754062}
-
Becca Hughes authored
Remove URLs from Media History when we remove that URL from Chrome History. BUG=1024352 Change-Id: Ib4bd8da2ba318d187eab092aff19ae714a134630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123188Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#754061}
-
prashant.n authored
Having separate role |kListSymbol| for list item markers will help classify list symbols separately against being considered as text. This patch uses text color classifier only as of now and can be changed if needed. Bug: 1030457 Change-Id: I82a1bbe1842bee4e79214c99eec3ed914086dbaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108416Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#754060}
-
Peng Huang authored
This CL refactors VulkanImage::InitializeFromGpuMemoryBufferHandle() to platform specified files (vulkan_image_{android, linux, win, etc}.cc. And implements InitializeFromGpuMemoryBufferHandle() for Linux. Bug: 848385 Change-Id: I7081d338cfc194185e5cda049fb7eab03fbf9b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124295Reviewed-by:Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754059}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/385de38b272f..9a3ee1913acb git log 385de38b272f..9a3ee1913acb --date=short --first-parent --format='%ad %ae %s' 2020-03-27 brianosman@google.com Remove arbitrary limit on number of composed color filters 2020-03-27 brianosman@google.com Remove GrSRGBEffect 2020-03-27 brianosman@google.com Disable BinPackParameters in .clang-format 2020-03-27 bungeman@google.com Add back deprecated warnings. 2020-03-27 phanm@google.com Add experimental support for svg text tag. 2020-03-27 robertphillips@google.com Have GrFillRRectOp make use of the GrSimpleMeshDrawOpHelper Created with: gclient setdep -r src/third_party/skia@9a3ee1913acb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Idd0f0578d18287401a2661d791afa409ff59f241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123882Reviewed-by:
-
Daniel Nicoara authored
HDCP updates are asynchronous. Do not pass display state pointers between async calls since display configuration may have changed. Instead query the display state and validate that the requested displays are valid. BUG=1058030 TEST=display_unittest with asan & msan Change-Id: I406bb80b31f017bd60b01188be132fec08c8da00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121091 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#754057}
-
Wei-Yin Chen (陳威尹) authored
With cached flags set by annotations (crbug/1056327), we no longer need to hard-code OverviewModeState. Also renames some tests for readability. Bug: 1065163 Change-Id: If5c27e22066ba062772bb3066b4b2fd9cda938f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122821Reviewed-by:
-
