- 03 Jun, 2019 40 commits
-
-
David Staessens authored
When using '--gtest_repeat' setup of the test environemt will be done multiple times on the same environment. This will result in crashes as e.g. initialization of the Vaapi should only be done once. TEST=ran new VDA perf tests on eve BUG=953114 Change-Id: Iacc837c114796d9c90b8cd9724719e7d13348680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610672 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665497}
-
Gabriel Charette authored
R=fdoray@chromium.org, skyostil@chromium.org Change-Id: I7210c5fc7a20cc2a2b367dd5d81d1551b2bd1f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636136 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#665496}
-
Koji Ishii authored
This patch hangs preserved trailing spaces when `text-align` is `start` (or `left` in LTR or `right` in RTL). The previous tests did not cover `start` case because it was thought not observable, but issue 966773 discovered that it is ovservable, and tests figured out that all impls hang in this case. This patch matches LayoutNG to legacy. The test is tentative until the CSS WG resolution. One test was failing before this patch but was accidentally passed. Now it really fails: Bug: 966773 Change-Id: I324b0c83e7aa9e5f3233b7bc56b262ddc5ee1fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640139 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#665495}
-
Yi Su authored
This CL extracts the content-type utility into //ios/web/web_view/content_type_util.* so that it can be shared between CRWWebController, WebStateImpl and CRWWKNavigationHandler. Bug: 956511 Change-Id: I0097d7b89c0f0f972beadf7753c34097a0c0847e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634730 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#665494}
-
Ramin Halavati authored
An old TODO is applied. Bug: 277296 Change-Id: I1272f8106b526ecb1f95a59db9c9e33a3568211e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634689Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#665493}
-
Etienne Pierre-doray authored
MessageLoopCurrent::task_runner() is depecated. This CL replaces it with with ThreadTaskRunnerHandle::Get(). A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1631693 Please CQ if LGTY! This CL was uploaded by git cl split. R=timvolodine@chromium.org Bug: 616447 Change-Id: I8336c678dfe4e0342003a89bd794e4c3715b9874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635628 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#665492}
-
Jeevan Shikaram authored
This is a reland of crrev.com/c/1605442. PS1 is the original landed CL. Add support to detect managed pinning and managed permissions and display badges next to the toggles. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=953580#c4 TBR: raymes@chromium.org Bug: 953580, 965910 Change-Id: Ie2ce836ffe6a4683ec5ba1437352ffb6ac846402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619587 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#665491}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3e719632482a..80180caaa9b2 Created with: gclient setdep -r src-internal@80180caaa9b2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I895213c6148d244ed7814f993e28fa548e4d3fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640252Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665490}
-
Mathias Carlen authored
Before this patch we reported the committed URL to our backend in the initial request. The committed URL can potentially contain PII and can therefore not be kept. This patch changes that and reports the data url from the intent as passed to chrome by a caller. There is approval for that piece of information to be logged. Bug: b/133732376 Change-Id: Idb98a727d37f2b9e7488f2f84b8fd273c2f4240f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632252 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#665489}
-
David Staessens authored
This CL adds additional metrics to the video_decode_accelerator_perf_tests. The average and 25/50/75 percentiles for both frame decode and frame delivery times are now calculated and output to the command line and the metrics json file. TEST=ran new VDA perf tests on eve BUG=953114 Change-Id: I25024d8baa2496014cedba0b706d862c8cc0711e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611076 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665488}
-
Leon Han authored
This CL aims to slim down ServiceWorkerGlobalScopeClient by moving its ServiceWorkerHostAssociatedPtr member into ServiceWorkerGlobalScope, to facilitate removing ServiceWorkerGlobalScopeClient completely in the future. Previously, CallerXXX --> ServiceWorkerGlobalScopeClient -Mojo calls-> Remote ServiceWorkerHost impl. Now, CallerXXX -GetServiceWorkerHost()-> ServiceWorkerGlobalScope then -Mojo calls-> Remote ServiceWorkerHost impl BUG=931142 Change-Id: I1f8250210faf4ef0f34ef81f06d1a79ba23c3a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636517Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#665487}
-
Ryo Hashimoto authored
WebContents::GetDelegate() can return nullptr. BUG=b:64863368 TEST=Browse a PDF with an ARC Custom Tab on a Chromebook and see no crash Change-Id: I15a25cb573581e3be932f02452dde396bab5eb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638303Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#665486}
-
Luciano Pacheco authored
Add retry for "right-click" to show the context menu for "remove folder shortcut" menu. The right-click is on directory-tree (LHS), there is an event listener p1[ for file selection (RHS), which races with this right-click and makes this flaky. I've added a local log for a retry and I could see it failing in the first run and succeeding in the second run, this is a stopgap fix, there is still a chance to race between the retry and the click after it, but the window is much smaller. As the TODO in [1], I'll try to remove the event listener to eliminate this race. [1] - https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/file_manager_commands.js?l=362-366&rcl=051250e22e8533ec28b9baa56ba945e9deda3166 Bug: 936429 Change-Id: Ibcb1cbfec9d22cb451d74f481bf4af4255e0f752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640817 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#665485}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ib73ee05dddfcd7b1e7d7dc3f73a2e057260762ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640898Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665484}
-
Maciej Pawlowski authored
First usages of StrongAlias in production code. Fewer bare strings. Bug: 954080 Change-Id: I1be4a54ac45f66ad21df4d0707b28f01fee01a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636199 Commit-Queue: Maciej Pawlowski <mpawlowski@opera.com> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#665483}
-
Richard Knoll authored
When switching to inline settings, we want to hide all views except the origin, not just the timestamp. This groups all views that need to be hidden together so it's easier to hide and show them again. The previous CL http://crrev.com/c/1565001 did not handle the summary text view that is shown for list and progress style notifications. Bug: 955410 Change-Id: I3190cf112ee926b6e8ca1edc0953e1a3cd494273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615467Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665482}
-
Hitoshi Yoshida authored
GLenum is typedefed in webgl_video_texture.idl and webgl_rendering_context_base.idl. We should avoid such duplicates in case of inconsistency. This CL removes one of them, which focuses on a narrow scope. Bug: 839389 Change-Id: I88f0d0cd52168480a2cf4f17a54ecd81d79c3fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640529Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#665481}
-
Christopher Lam authored
This CL cleans up kChromeUISyncResourcesHost which isn't used. In doing so, it removes a context menu check that makes the normal page options not appear on chrome://syncresources, as well as a default implementation that looks like it was intended to remove these options on all WebUIs. Bug: None Change-Id: Id7a8bce3ca68759d143178ebe50615d00dcaec13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634593 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#665480}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=henrika@chromium.org Change-Id: I78f63048cdfeb41f0d87aeaa4a1e9a9f837e095a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636202 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665479}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=henrika@chromium.org Change-Id: I69b6fbe7658dfe423b99079de5218ff94ac2ba7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635618 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665478}
-
Alex Oldemeier authored
For additional enterprise reporting, we need to retrieve the package id from the registration. This commit adds a getter and tests. Bug: 844468 Test: unit_tests --gtest_filter "CrostiniRegistryServiceTest.*" Change-Id: Icfea51476cf8e00068391a1953e5ab6ad0cc6e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634697 Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665477}
-
Gyuyoung Kim authored
Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/animation directory. [1] https://github.com/heycam/webidl/issues/365 Bug: 963267 Change-Id: Ied1032d67bcdaa52e7fa3265471fd53f4b5ddd8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640743Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#665476}
-
Rune Lillesveen authored
Use Scoped* helpers to reset flags back to the default value for other tests. Change-Id: Icb5bdcdb36f09051703f0fab129211b617c4efee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637568Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665475}
-
Sam McNally authored
For enum histograms ranging from 0 to N, 1 should be passed as the min, N as the max and N + 1 (or the number of values) as the bucket count. For files app histograms, N + 1 is passed for both max and bucket count. This causes the middle value to not have a bucket. Pass N as the max to avoid this problem. Bug: 969600 Change-Id: I1725fdf8d97a9932174a47aaebe8382b3010db0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640148Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#665474}
-
JunHo Seo authored
A huge(tested on downstream build - chromium68 with gcc 8.2, about 180MB) compile warning messages are printed during building chromium. One of major warning messages is about memory operation. Previously, I tried to fix the warning by fixing related code( https://chromium-review.googlesource.com/c/chromium/src/+/1637021), but it was not accepted. As a second option, this CL suppress the warning. And the build flag is added only for (!clang and !win and !nonacl) build. Below is a sample message: src/third_party/blink/renderer/platform/wtf/vector.h:193:13 warning: 'void* memcpy(void*, const void*, size_t)' writing to an object of type 'class blink::Member<blink::TreeScopeEventContext>' with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess] Bug: 819294 Change-Id: Ibfdc7bc278fc4f2a4640d770754de42ab5438e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638211Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Cr-Commit-Position: refs/heads/master@{#665473}
-
Alex Oldemeier authored
This adds fields for the Termina kernel version and a list of installed apps to the existing device management backend proto. Test: compile Bug: 844468 Change-Id: Iee48c736a67cf466beff91086374250f1cb22cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628617 Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#665472}
-
Darren Shen authored
Disable: SitePerProcessHitTestBrowserTest.SurfaceHitTestPointerEventsNoneChanged Flaky on all bots. TBR=clamy@chromium.org,sunxd@chromium.org BUG=968970 Change-Id: I1db969e3a610cc8e2af385d8bbf0b5d6d6185e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640251Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#665471}
-
Tomasz Moniuszko authored
Bug: 969015 Change-Id: I74bf788a0cabed4a78702a2fb9c6e033feaaf7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635684Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#665470}
-
David Staessens authored
To improve the readability of performance metrics printed on the command line when running the video_decode_accelerator_perf_tests, this CL makes change to use std::cout instead of VLOG(0). TEST=ran new VDA perf tests on eve BUG=953114 Change-Id: I13d2e246dc86af56461c488546a88053d4e56755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635121 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665469}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9f6a47f27cc..3e719632482a Created with: gclient setdep -r src-internal@3e719632482a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Ifca0642135a19040b2ef60dfef64d7777a5c374f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640246Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665468}
-
Koji Ishii authored
When an inline box has |IsInLayoutNGInlineFormattingContext|, its containing LayoutBlockFlow must have |NGPaintFragment|. The stack trace of the issue indicates that there maybe cases where it doesn't stand. This patch adds two guards against such case: 1. Same as crbug.com/963103, |InlineFragmentsFor()| pretends it's not LayoutNG if the LayoutBlockFlow is dirty. This may affect code that reads from dirty tree such as scroll anchoring, but protects from reading deleted objects. 2. If something still wrong, CHECK before returning possibly deleted objects. Usually, an inline formatting context isn't so deep that this check shouldn't be too expensive. Unfortunately, implementing these guards to |InlineFragmentsFor()| broke several accessibility and scroll anchoring tests, which seem to read inline positions of dirty tree. This patch makes the guards opt-in, and let |InlinePainter| to opt-in. Also makes sure to clear |IsInLayoutNGInlineFormattingContext| when inserting to the tree. This is a speculative fix. Bug: 969096 Change-Id: Ic29c5c77e6a27b395d6cd7bafc2bfbbd858c14fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638973 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#665467}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I76a0c2250e307c08730335d7f41003b90b626e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640248Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665466}
-
David Staessens authored
This CL adapts the video_decode_accelerator_perf_tests to write frame decode times to the metrics output json file. In addition frame delivery times will now be written to the same json file, instead of a separate one, so all performance metrics are contained a single file. TEST=ran new VDA perf tests on eve BUG=953114 Change-Id: I972b67b93119fc0f5157890edcd9ef5845bd970c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608968 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665465}
-
Takuto Ikuta authored
os of builder is updated to 10.14. https://chromium-swarm.appspot.com/bot?id=build213-m9 Let me drop version specification until we need to pin that. Bug: 969553 Change-Id: I09cf8b75766973113903c84a408a3baa0e178478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640366 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#665464}
-
Lei Zhang authored
ui::AXPlatformNodeAuraLinux::OnDescriptionChanged() calls g_value_set_string(), which internally duplicates a string into a GValue. The GValue needs to be cleared before destruction to avoid leaking the memory used for the string duplication. BUG=961907 Change-Id: I38086cd421667dc2a4edf2a9325c5b15cde5645a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638947Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#665463}
-
Gyuyoung Kim authored
Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/css directory. [1] https://github.com/heycam/webidl/issues/365 Bug: 963267 Change-Id: I667cab102b9b2cc7ea32ae60aa5de8545b56861d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640301Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#665462}
-
David Staessens authored
This CL adds the --output_folder parameter to the video_decode_accelerator_tests and video_decode_accelerator_perf_tests binaries, so the default output folder for video frames and metrics can be overwritten. This is required to run the tests from Tast. TEST=ran new VDA (perf) tests on eve BUG=953114 Change-Id: Id536f0bc441dbf23ea3ab39434e340ec4503924e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605324 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665461}
-
Darren Shen authored
Changed ui/keyboard to ash/keyboard. Removed ash/virtual_keyboard (doesn't exist). Removed blakeo@ (no longer working on VK). TBR=yhanada@chromium.org Bug: 961568 Change-Id: I2183d5d442689547c6e09dcd323168e8444903e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638936 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#665460}
-
dpapad authored
This is in preparation of removing the custom cr.EventTarget implementation in favor of native EventTarget. Bug: 854268,778674 Change-Id: I3dbf4b3ace86d0966d09a01d5d0fa86d6ca9ba19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639239 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#665459}
-
John Budorick authored
Most of our kvm-enabled ubuntu capacity in pool:Chrome has moved to xenial. Bug: 954450 No-Try: true Change-Id: I38121933f5f3533d427ed178792d4f909f929bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638899 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#665458}
-