GitLab

This CL converts DedicatedWorkerHostFactory mojom interface client
in content and blink to use BrowserInterfaceBroker.

Bug: 936482
Change-Id: I3991c213428888c94b1922aabeaa1ce807e832b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935775
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719856}

Because NDEFRecord#lang is supposed to be set to the document element's
lang attribute in the original web page that constructs/writes this
record, not in the current web page trying to construct an
NDEFReadingEvent instance.

This CL adds a wpt to guarantee that.

BUG=520391

Change-Id: If609455d6411ee886b74ab7557292c37da41eed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930451Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#719855}

Also some code style changes to make the code pass presubmit.

Bug: 937251
Change-Id: I259d54bda0e5183c30999c6698f06761a4183e40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939814Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719854}

When a desktop PWA is launched in a window, we now record the
display mode that was requested in the manifest.




Bug: 1939127
Change-Id: I98b77e5eebd355add3cb38a97924fbcd457b99fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939082
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719853}

Report whether a scroll-begin/update caused the browser top-controls to
move or not. Also report the end-to-end latency metrics separately for
these two cases, so that it is possible to measure the impact of
changing the height of the top-controls during scroll.

BUG=1027129

Change-Id: I5084a439aa83999809da3a8e9419f30cd3d1a8bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931922Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719852}

Previously web_engine_integration_tests were using default WebEngine
instance. This approach creates several issues. Particularly WebEngine
that is being tested may not be the latest verstion installed on the
test system. Updated the tests to use Launcher API to start a new
instance of WebEngine. This approach will also allow to pass custom
flags to WebEngine, which will be useful for some tests.

Also fixed initialization order in ContextProviderMain

Change-Id: Id6ffbd9a498fa42531193c5e9c6d01a932591ca7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938454
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719851}

This reverts commit b7edadd9.

Reason for revert: MSAN issue fixed

Original change's description:
> Revert "ozone: Build with xkbcommon by default on is_linux && !is_chromecast"
> 
> This reverts commit 713420fb.
> 
> Reason for revert: Causes MSAN failure
> More details in crbug/1027853
> 
> Original change's description:
> > ozone: Build with xkbcommon by default on is_linux && !is_chromecast
> > 
> > This is necessary on Linux targets unless you don't want keyboard
> > support or only need support for a hardcoded US layout.
> > 
> > Noticed because the CQ broke after building for ozone locally. This
> > reduces the number of flags needed to build as the Linux Ozone builder
> > does.
> > 
> > Bug: 1026476
> > 
> > Change-Id: I77352c133b1f7552301b6e1f252d40a4f2c72106
> > 
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925370
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
> > Commit-Queue: Michael Spang <spang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#718240}
> 
> TBR=sky@chromium.org,spang@chromium.org,kpschoedel@chromium.org
> 
> Change-Id: I4fa0de1881acbf1eaf7e70bfe4b24dbc84647f43
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1026476
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932436
> Reviewed-by: Tim Schumann <tschumann@chromium.org>
> Commit-Queue: Tim Schumann <tschumann@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718445}

TBR=sky@chromium.org,spang@chromium.org,kpschoedel@chromium.org,tschumann@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1026476, 1027853
Change-Id: I4f601a169bd5d18714a1a78ca8cacd0b43939afa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941277Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719850}

Previously Flush() was taking base::Closure, which is deprecated.
Replaced with base::OnceClosure.

Bug: 751838
Change-Id: Iccd5bb58b262cb67f87810613b180da9148fe145
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940300
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719849}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8b811565..81668204

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ieaad52ef4f15c85c862e2b817e9ba232f67aba29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941237Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#719848}

During import, such keywords are ignored.

Bug: 6867
Change-Id: I7f6955629bca92506c4be4dba398577a07483580
Fixed: 6867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937583Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719847}

This CL converts RemoterFactory mojom interface client in content
to use BrowserInterfaceBroker.

Bug: 936482
Change-Id: I2513a91b6b0a034c65cf22813d352e7e9a2929b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939067
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719846}

Use the color that is used for other auth methods, rather than the
result of applying the "AutoColorReadability" transformation to the
white color.

Bug: 1024254
Change-Id: I4c4c94f3db2b1dbf1f5d8a6ac81fcc247e8bacc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816468Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719845}

This API enables tast tests to set metrics consent, which is required
for us to integration test the crash reporting system.

BUG=1018456
TEST=`tast run platform.ServiceFailure` with this change.

Change-Id: I9bdd3d20a590224079716ef399967aae3929866b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929983
Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719844}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d60fe6b7daaf..5abf580ff877


Created with:
  gclient setdep -r src-internal@5abf580ff877

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1029095
Tbr: jbudorick@google.com
Change-Id: I9b3ce3fe6a206c067cf177eb0f9def601a680022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941290Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#719843}

The browser knows when the top-controls visible height changes. So
include that information from the browser, using a SwapPromise. Also,
extract that flag into the aggregated frame in SurfaceAggregator, and
pass it along to the OutputSurfaces in OutputSurfaceFrame.

BUG=1027129

Change-Id: I5b233be7da38e31138863a7da6ec06958288dfbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929584
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719842}

Polymer updates the template upon any property mutation, using
setProperties allows to batch property mutation and update the template
only once, use it for better overall performance.

AVG of 5 runs  | setProperties | without setProperties
onMetadataX()  | 4.273876953   | 5.588183594 (~23% faster)
clear()	       | 2.381201172   | 3.849414063 (~38% better)

Bug: 948605
Change-Id: I63005391e3cbc8ed53ad142d6d9211521ad72a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937949
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719841}

Extend the expiry milestone of assistant app support feature flag which
is still in use.

Bug: None
Test: Locally build and test
Change-Id: I3cfdba42aa1cc79b715575f583fe02bdfd2802e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939684Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719840}

Instead of reporting the height and shown_ratio for the browser-controls
separately, merge them into a single 'visible_height' field, since that
is the only information used (for the screencasting API).

In addition to that, make this an optional field, so that if top-controls
height do not change, then this field does not need to be set. This will
be used in follow-up CLs to report latency metrics separately for
scroll-begin/update events that change the visible height of the browser
top-controls.

BUG=1027129

Change-Id: I0fe55a5f214e69235e700985d6214c1096f77e2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931101Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719839}

https://swiftshader.googlesource.com/SwiftShader.git/+log/8a6dcf76315c..d6e903bdc9ef

git log 8a6dcf76315c..d6e903bdc9ef --date=short --first-parent --format='%ad %ae %s'
2019-11-28 sugoi@google.com Support multisampled Bresenham lines

Created with:
  gclient setdep -r src/third_party/swiftshader@d6e903bdc9ef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:b/142965928
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I80914116433fe994a6682b4cae9b38e9675fcf3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939679Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#719838}

AttributeDescendantSelector.html of linux-perf/blink_perf.css was
15% slower with -ftrivial-auto-var-init=pattern.

Before: https://pinpoint-dot-chromeperf.appspot.com/job/16672223220000
After: https://pinpoint-dot-chromeperf.appspot.com/job/157aebd3220000

Bug: 977230
Change-Id: Ibe020d9749caeaccdf5ca2d94abe9eeba756a454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938438Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719837}

This adds a reporting filter intended for Stylus' devices, which adds
metric recording.

Bug: 1009290
Change-Id: Ifed692f1bd6dcf6cea7891dc615d6887bb11d672
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923223
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Reviewed-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719836}

Bug: 1029038
Change-Id: Ib14ab97f409afdf6159daf8dfe35fcf91beeb934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939956
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719835}

This CL replaces mojo::BindingId with mojo::ReceiverId to use
new Mojo types from TCPBoundSocket, SocketFactory,
StoragePartitionImpl, and isolated_origin_browsertest.cc.

Bug: 955171
Change-Id: Ic4405662b852f90277a56f2b9b07874459a19a54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933842Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#719834}

https://chromium.googlesource.com/catapult.git/+log/c9d4943dc832..fa0def753f3e

git log c9d4943dc832..fa0def753f3e --date=short --first-parent --format='%ad %ae %s'
2019-11-28 jbudorick@chromium.org devil: ensure py_utils is on the path for device_utils_test.

Created with:
  gclient setdep -r src/third_party/catapult@fa0def753f3e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC rmhasan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1029009
Tbr: rmhasan@google.com
Change-Id: Ie30899dbb624bc039bd218f2bd6bb4f820d87625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940595Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#719833}

We previously added a new method to our private api
(setAreaToRemainOnScreen) which allows us to define an area within the keyboard window that cannot move off screen during a drag operation (see
https://chromium-review.googlesource.com/c/chromium/src/+/1896483).

This commit implements the logic to ensure the area set by
setAreaToRemainOnScreen does not move off screen during a drag operation.

If setAreaToRemainOnScreen is never called, and the
area_to_remain_on_screen is never set, then the whold keyboard window
will be kept on screen during a drag operation.

Bug: 1020461
Change-Id: I34a3271a29351beadef0487a84df1bc98e37881d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924181
Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719832}

Rebuild the libraries on a trusty host at d60812ca
("instrumented_libraries: Fix DebianBuilder clean build") so that
instrumented libxkbcommon0 is available, fixing bug 1027853.

Bug: 1027853

Change-Id: I20c4a48406cf5b25f0601f4af82b51e99142b6e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941267Reviewed-by: Evgenii Stepanov <eugenis@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719831}

This change ensures proper positioning of explicit margin always at the
front of the suggestion view, instead of artificially limiting suggestion
size. This ensures correct layout in RTL modes.

Bug: 1021263
Change-Id: I98c9e0e3ad181f0d4cb10d8ca53f4081f5749650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941114
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719830}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa16617226b7..d60fe6b7daaf


Created with:
  gclient setdep -r src-internal@d60fe6b7daaf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:None
Tbr: jbudorick@google.com
Change-Id: I00559ec5e1565a15bf04848b5327caec688cc90a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939678Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#719829}

7fd5226a97ea Give database settings kOwnerOnly permissions

Change-Id: Ie131569a1a1652f782c1008230efa4a949fe4e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940951Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719828}

Adds a metric for both all impressions and those that we actually
count as "impressions";

Bug: 1026649
Change-Id: Idfd781445f130f82f0d8a5ff4ead194afa37bd75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927731
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719827}

This CL connects powerd ambient color temperature reading
to the displays' CTMs.

The temperature coming from powerd is not applied directly
to the display but it's instead interpolated over time to
avoid sudden changes and visible noise.

Night light and ambient color temperature RGB scaling
factors are currently composed by multiplication.
In this way if one of the feature is off it won't affect
the other.


Bug: 1021193
Test: new unittests added
Change-Id: I47514b43b5d8a9ea0cf5f433e4c78fcb95b22f46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915021Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Auto-Submit: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719826}

With initial icon members files36:success and files36:failure used for
visual signals. The icon <svg> source comes from CL:1918902.

Not used just yet, so no change in behavior.

Bug: 1026943
Change-Id: I43aab4e34286ac04072c2e2c814cc514670a3553
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940313Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Auto-Submit: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719825}

https://ci.chromium.org/p/chromium/builders/ci/android-code-coverage-native
"//chrome/android:libchrome" causes linker issue when native coverage is on.
Getting rid of this library now until linker issue fixed.

Bug: 1026891
Change-Id: Ibf99d2fc154c38e637bf1758816c61cc6832492f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941168Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#719824}

This will make it easier in the future to add other methods to allow WebLayer to handle the download so that corner cases of downloading (e.g. depend on cookies/auth, POSTs) work. By adding a return value, we would know in future iterations of the API when WebLayer can handle the download.

Bug: 1025603
Change-Id: Id933a14a39793aa8f00346ae73557fba5163fa43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941117
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719823}

This is a reland of f8030cb2

Original change's description:
> viz: Remove unused bottom-controls data from compositor frame.
>
> The bottom_controls_height and bottom_controls_shown_ratio fields
> in CompositorFrameMetadata are currently unused. Their usage has been
> replaced by the same fields in RenderFrameMetadata. So remove these
> fields.
>
> BUG=none
>
> Change-Id: I96af75cc5f933821cfb486fdeb1e314daa2a7030
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927973
> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#717874}

Tbr: dcheng@ since re-land after trivial change.
Bug: 1028641
Change-Id: I16a869c42c74e294eef20f63886be592e4116ed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941194Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719822}

According to the spec, base URL and source text is calculated in
early steps in
https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script
and then used for creating inline classic scripts in Step 25.

However, ClassicPendingScript has been recalculating these values
by via ScriptElementBase.

This CL instead plumbs these values from PrepareScript() to
ClassicPendingScript, to align with the spec,
and also as a preparation for [1].

Multiple callers of ScriptElementBase::TextFromChildren() within
PrepareScript() should be still merged,
but this should be done later, to avoid rebase conflicts with [1].

This CL doesn't change the behavior.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1924523

Bug: 1026549, 686281
Change-Id: I437425a3a8918399364dbe84c898df57b46c252b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937369
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719821}

Current OpenXR implementation use some strcpy_s without size, replace
them with std strcpy_s with a size parameter.

Fixed: 1029100
Change-Id: I872f8fe3d97f7a5356d6135085b1f08e76cd8952
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940876
Commit-Queue: Zheng Qin <zheqi@microsoft.com>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719820}

Attach fetch time to elements in the cache and force re-fetch for old ones.

BUG=chromium:804691
Fixed: 804691

Change-Id: Ie43600b3c8c26a4f2e7b00deaa54c530a067222b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935768
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Auto-Submit: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719819}

This changes the known interception disclosure infobars to be triggered
on the CERT_STATUS_KNOWN_INTERCEPTION_DETECTED flag (instead of being
triggered on a test URL). This also updates the tests to set up a
CRLSet for the embedded test server and use real navigations rather
than triggering the disclosure infobars directly.

Bug: 1014711
Change-Id: Iaac4fd7eb11ad448921905d842f5b409d21952d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929847
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719818}

Bug: 1022827
Change-Id: Ie3ee8e5f3ced8c694cf964eb9b596cb30a19c36f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941195Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719817}