- 31 Aug, 2013 4 commits
-
-
tfarina@chromium.org authored
This will make it easier the next patch in this series. BUG=None TEST=None, no functional change, just refactoring. R=asanka@chromium.org, erg@chromium.org Review URL: https://codereview.chromium.org/23646006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220705 0039d316-1c4b-4281-b951-d872f2087c98
-
ccameron@chromium.org authored
BUG=281709 Review URL: https://chromiumcodereview.appspot.com/23483021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220704 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
BUG=282346 Review URL: https://chromiumcodereview.appspot.com/23455021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220703 0039d316-1c4b-4281-b951-d872f2087c98
-
ddorwin@chromium.org authored
BUG=224793 Review URL: https://chromiumcodereview.appspot.com/23708010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220702 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Aug, 2013 36 commits
-
-
eliben@chromium.org authored
BUG=None R=awatson@chromium.org Review URL: https://codereview.chromium.org/23456011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220700 0039d316-1c4b-4281-b951-d872f2087c98
-
mohsen@chromium.org authored
Re-enabled TouchEditableImplAuraTest.TouchSelectionOriginatingFromWebpageTest with two fixes: - Fixed calculations for selection rectangle after a touch selection handle is moved. - Added a wait between dragging the handle and getting the selection in the test to be sure that the selection is updated completely. Also, added some logs in the test so that if it failed again, more data is available for investigation. BUG=276870 Review URL: https://chromiumcodereview.appspot.com/23449013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220699 0039d316-1c4b-4281-b951-d872f2087c98
-
vmpstr@chromium.org authored
This is a very small change that adds about 1% performance. R=reveman@chromium.org Review URL: https://chromiumcodereview.appspot.com/23837002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220698 0039d316-1c4b-4281-b951-d872f2087c98
-
tburkard@chromium.org authored
R=isherman@chromium.org Review URL: https://codereview.chromium.org/23707014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220697 0039d316-1c4b-4281-b951-d872f2087c98
-
navabi@google.com authored
The provision check checks if setup wizard is disabled. If the device status check is run with no-provision-check, don't try to get read the status of the setup wizard from the device. The reason for the change is that checking the status of the setup wizard has caused problems in certain cases (see the discussion on the bug). While the particular issue can be fixed elsewhere, it is better to not check the status if we are not going to use it. BUG=255157 TBR=ilevy@chromium.org Review URL: https://chromiumcodereview.appspot.com/23503015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220696 0039d316-1c4b-4281-b951-d872f2087c98
-
ramankk@chromium.org authored
BUG=276002 Review URL: https://chromiumcodereview.appspot.com/23033016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220695 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
For Windows Ash (metro mode) we did not had timely access to the real window (aka 'core window') so to keep the compositor from CHECKIing we gave the shell desktop Window when it wanted a window here RootWindow::RootWindow(const CreateParams& params) { ... compositor_.reset(new ui::Compositor(this, host_->GetAcceleratedWidget())); ... } This was called from: ash::DisplayController::AddRootWindowForDisplay ash::DisplayController::InitPrimaryDisplay ash::Shell::Init Because ash was always created. Later on when the viewer process had started it sends an IPC back with the core window which set the real window with void ChromeMetroViewerProcessHost::OnSetTargetSurface(..) { scoped_refptr<AcceleratedPresenter> any_window = AcceleratedPresenter::GetForWindow(NULL); any_window->SetNewTargetWindow(hwnd); .... } All this hackery can go away because now Ash starts on demand once the aforementioned IPC arrives. BUG=none TEST=chromes starts in metro mode. Review URL: https://chromiumcodereview.appspot.com/22876030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220694 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
Addressing sadruls comments from the previous CL https://codereview.chromium.org/22865036/ which was already committed. Changes as below:- 1. We dispatch the GESTURE_BEGIN event before the TAP_DOWN in the repost code as some recipients may rely on that behavior. 2. A new test GestureRepostEventOrder has been added to validate that we receive reposted and subsequent events in the correct order. BUG=277018 R=sadrul@chromium.org Review URL: https://codereview.chromium.org/23202016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220693 0039d316-1c4b-4281-b951-d872f2087c98
-
lazyboy@chromium.org authored
NOTRY=true BUG=282674 Test=None Review URL: https://chromiumcodereview.appspot.com/23840002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220692 0039d316-1c4b-4281-b951-d872f2087c98
-
dewittj@chromium.org authored
A recent change in Views causes the mouse move trackers to be removed when visibility changes, causing the mouseexited event never to happen if a window is closed underneath the mouse. BUG=282117 R=mukai@chromium.org Review URL: https://codereview.chromium.org/23764003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220691 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=277773 Review URL: https://chromiumcodereview.appspot.com/23564004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220689 0039d316-1c4b-4281-b951-d872f2087c98
-
dewittj@chromium.org authored
This is a field displayed in an alternate font that adds an extra line of information about the notification. BUG=276004 Review URL: https://chromiumcodereview.appspot.com/23462005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220688 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220687 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=156996:157007&mode=html TBR= BUG= Review URL: https://chromiumcodereview.appspot.com/23621017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220686 0039d316-1c4b-4281-b951-d872f2087c98
-
sgurun@chromium.org authored
BUG=282636 Review URL: https://chromiumcodereview.appspot.com/23441023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220685 0039d316-1c4b-4281-b951-d872f2087c98
-
nduca@chromium.org authored
BUG=236763 TEST=base_unitttests SystemMetricsTest.* R=darin@chromium.org, nduca@chromium.org Review URL: https://codereview.chromium.org/22824008 Patch from Json Mak <jwmak@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220684 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
As is, OpaqueBrowserFrameView is untestable due to its dependencies. This patch separates out all the layout and sizing logic into a LayoutManager subclass, makes OpaqueBrowserFrameView use that, and then adds tests for the new LayoutManager. Note that I've deliberately made as few cleanups to the layout logic as possible. The point is to get this code under test before I start more radical changes. BUG=281788 Review URL: https://chromiumcodereview.appspot.com/23531006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220683 0039d316-1c4b-4281-b951-d872f2087c98
-
shadi@chromium.org authored
The loop action plays HTML5 media in loops and measures the avg time it takes to loop, i.e. time from end to start playback again. BUG=249435 Review URL: https://chromiumcodereview.appspot.com/21134002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220682 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
Slash is an invalid path character. Colon isn't used on Mac. In both cases, an underscore is subsisted. BUG=281701 Review URL: https://chromiumcodereview.appspot.com/23449015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220681 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
BUG=none Review URL: https://chromiumcodereview.appspot.com/23757011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220680 0039d316-1c4b-4281-b951-d872f2087c98
-
DHNishi@gmail.com authored
TBR=kalman@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/23707013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220678 0039d316-1c4b-4281-b951-d872f2087c98
-
karen@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220677 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
We don't actually use these resources, we link and load them into resources.pak. BUG=52609 Review URL: https://chromiumcodereview.appspot.com/23543010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220676 0039d316-1c4b-4281-b951-d872f2087c98
-
tburkard@chromium.org authored
R=jam@chromium.org Review URL: https://codereview.chromium.org/23622012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220674 0039d316-1c4b-4281-b951-d872f2087c98
-
rjkroege@chromium.org authored
BUG=281815 R=lazyboy@chromium.org Review URL: https://codereview.chromium.org/23788006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220673 0039d316-1c4b-4281-b951-d872f2087c98
-
eliben@chromium.org authored
This reflects the current state of master in https://github.com/eliben/nacl-docs-rst BUG=None R=binji@chromium.org Review URL: https://codereview.chromium.org/23835002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220672 0039d316-1c4b-4281-b951-d872f2087c98
-
bruening@google.com authored
TBR=nhiroki@chromium.org BUG=282646 Review URL: https://codereview.chromium.org/23572020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220671 0039d316-1c4b-4281-b951-d872f2087c98
-
benm@chromium.org authored
This achieves backwards compat with "Classic" Android WebView which would always set this level of font hinting and enable sub puxel positioning. BUG=281508 Review URL: https://chromiumcodereview.appspot.com/23461014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220668 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=272460 Review URL: https://chromiumcodereview.appspot.com/23496024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220667 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
All the options used by browser_backends need to be moved from finder_options to browser options. BUG=269131 TEST=trybot Review URL: https://chromiumcodereview.appspot.com/23664002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220665 0039d316-1c4b-4281-b951-d872f2087c98
-
ddorwin@chromium.org authored
Key systems are now explicitly added rather than loaded from arrays of structs. This is in preparation for moving knowledge of key systems and registration out of content/. BUG=224793 TEST=exsting content_unittests Review URL: https://chromiumcodereview.appspot.com/23464005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220664 0039d316-1c4b-4281-b951-d872f2087c98
-
antrim@chromium.org authored
BUG=281246 R=ygorshenin@chromium.org Review URL: https://chromiumcodereview.appspot.com/23757003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220661 0039d316-1c4b-4281-b951-d872f2087c98
-
jeremy@chromium.org authored
The afoermentioned bug causes some pages to wedge which causes profile generation in Telemetry to fail. Use tab.WaitForDocumentReadyStateToBeInteractiveOrBetter() instead to attempt to mitigate this. BUG=282100 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/23478017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220660 0039d316-1c4b-4281-b951-d872f2087c98
-
jackhou@chromium.org authored
This maintains a duplicate set of menus for standard items. This enables keyboard shortcuts to work as expected when the Chrome menus are hidden. This also adds tags to various items in MainMenu.xib using existing and new entries from chrome_command_ids.h. The tags are used to look up items in the main menu. BUG=168080, 276052 TEST=When an app window is focused, the main menu should change to a set of menus relevant to apps. I.e. Chrome specific menus/items should be hidden. The item in the menus should behave as expected for the app. Review URL: https://chromiumcodereview.appspot.com/23005021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220659 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=none NOTRY=true R=chrisgao@chromium.org, frankf@chromium.org Review URL: https://codereview.chromium.org/23800002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220657 0039d316-1c4b-4281-b951-d872f2087c98
-
bruening@google.com authored
TBR=bungeman@chromium.org BUG=266484 Review URL: https://codereview.chromium.org/23689005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220656 0039d316-1c4b-4281-b951-d872f2087c98
-