GitLab

This CL restricts the type of ActivationSequence to StrongAlias
instead of int, so that it cannot be used interchangeably with int
anymore. This CL also moves the definition to //extensions/common so
that renderer/ can use it.

This CL doesn't produce any behavior changes.

Bug: 1970854
Change-Id: I30a5acc19c87bb4d6d4ab8f3cb36f8b9af12c2ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986327Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729952}

But drop unused .SingleTab/.MultiTabs suffix.
Current histogram values kept for posterity @
https://docs.google.com/document/d/18uYnVwLly7C_ckGsDbqdNs-AgAAt3AmUmn7wYLkyBN0/edit#heading=h.yy3qczapsgy7

R=fdoray@chromium.org, rkaplow@chromium.org

Bug: 1037318
Change-Id: Ice8efe602d65c24d88d03bfb37882202e4c35881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990990
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729951}

Previous patch did not update GLTextureRepresentation's clear region
on begin access. This allowed it to get out of sync if other (non-GL)
components modified the clear rect.

This patch updates the cleared rect on each begin access.

Bug: 1039232
Change-Id: Iacc6e65b25d770e1d17e51a5f1c2c632dfad0101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990195Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729950}

Versions of vim with +python3 but -python currently display an error message
at startup if they use ninja-build.vim. We can support these versions along
with existing +python -python3 versions of vim by using pythonx instead.

Change-Id: I389486aa5b49b3466514e98fa57b5dce3115273a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994080Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729949}

In https://chromium-review.googlesource.com/c/chromium/src/+/1955823 the
code was updated to match the terminology in the readme (blob key vs blob
number), however in doing so accidentally the readme was also modified.

This reverts the changes to the readme, as it already used the correct
terminology for blob numbers and blob keys.

Bug: 1027737
Change-Id: Ie4012688901b9813248e99bce93ee6b454eba53e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993872
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729948}

These metrics were originally added in order to explore possible limits
on ad CPU usage before and after page interactive for the heavy ad
intervention.

These metrics are no longer used, and total CPU usage is instead used
as intervention criteria. The metrics are also somewhat difficult to
interpret due to the complexity of TTI.

Bug: 1013388
Change-Id: I944c3769514f8d4a03ac507796336aa55bcd5b4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992166Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729947}

Instead of

foo("bar") {
  deps = [ ":repack" ]
  data = [ "$root_out_dir/repack_output.pak" ]
}

use

foo("bar") {
  data_deps = [ ":repack" ]
}

This happens to remove `$root_out_dir/locales/` from data,
which is good for correct incremental builds (see bug).

I didn't touch android and iOS, since I don't know the
android_assets() / the copy_data_to_bundle approach used
in iOS well.

(For similar bundling reasons, most of the `data` lines were already in
!is_mac blocks.)

While comparing browser_tests.runtime_deps as described in comment 18
on the linked bug, I noticed that we include .pak.info files in the
isolate for repack()ed files. Since those are build-time things, remove
them from repack() outputs, so that data_deps doesn't add these to the
.runtime_deps files. (For the build, the removal is harmless since deps
are still tracked through the action stamp files.)

One side effect of this change is that most test binaries defined
in chrome/test now get all locales in their isolate, instead of just
en-US or en-US and fr previously.

The target that includes ui_tests.pak is //ui/resources:ui_test_pak_data,
switch to that in a few places -- the previous ui_test_pak target
pulled in ui/en-US.pak which apparently isn't needed anywhere.

TBR=torne,sergeyu

Bug: 912946
Change-Id: I0d9c6ff0d3b00cd5a876443b61b083a1aabf24d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989515
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729946}

The new build_hwasan_splits flag causes HWASAN splits to be created for
the Monochrome6432 and TrichromeChrome6432 bundles, as well as any of its
DFMs that contain native code. The intent is that this flag will eventually
default to true in official builds.

The library is deliberately installed in TrichromeChrome6432 rather than
TrichromeLibrary6432 (where the regular native library lives) because the
Android platform does not support splits for the library containing the
WebView implementation. This means that only Chrome will use the HWASANified
native library, and WebView will use the regular native library.

Bug: 916828
Change-Id: Ie92bb36e83df245ab431b0123a44b0f0a3182100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769731
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729945}

This enables clang-format-style autoformatting via YAPF.

Bug: 846432
Change-Id: I212c731c53a7cd2b8da839f30688c5c23d3b7c8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989232
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729944}

The activation of the keytype suppression was by mistake removed in
Chrome for all calls running the processing in the renderer process.
The CL that caused this was
https://chromium-review.googlesource.com/c/chromium/src/+/1495528

This CL re-enables keytype suppression.

Bug: chromium:1033455
Change-Id: Ieaeafc53f2d4b0d8e87400544e859fd0e0e68886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984305Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Per Åhgren <peah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729943}

The metric tracks whether the invalid DM token was stored successfully.

Bug: 1039399
Change-Id: I8e1cf72b65353e378841dfc1642d9176638a748a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988674Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729942}

I submitted https://chromium-review.googlesource.com/c/chromium/src/+/1992807
without adequate testing, and of course it didn't quite work:
https://chrome-swarming.appspot.com/user/task/49a3b1ea6bb41910
Traceback (most recent call last):
  File ../../testing/scripts/run_performance_tests.py, line 290, in execute_gtest_perf_test
    e)
TypeError: not enough arguments for format string

For this changelist, I fix the bugs and add a test case for it.

Note that lots of terrible unrelated git cl format changes were forced on this
change. I filed crbug.com/1040604 for this.

R=bsheedy@chromium.org, wenbinzhang@google.com

Bug: 1040300, 1039019
Change-Id: Ib1d22f655b58dc70790ca701cb028bbb6d599a64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993443Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729941}

Users with BrowserThread traits can just use the getter to get a new
pointer to the existing task runner each time (the BrowserThread API
will soon move to content::GetUIThreadTaskRunner() and this call will
make even more sense then the current one using "create" semantics).

This is necessary in order to rename LazyTaskRunner to
LazyThreadPoolTaskRunner and having it automatically call into the
upcoming base::ThreadPool:: APIs (destination as an API rather than as
a trait).

See Task Posting APIs v3 for details:
https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit

R=fdoray@chromium.org

Bug: 1026641
Change-Id: I03e84ad5f607c93c4e2d649820954f0a4b08df56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988682
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729940}

The deletion of obsolete clients after 2 minutes causes crashes if
chrome shutsdown before that time. Make sure shared db is not destroyed
while running the destroy task by holding a reference. Add a test to
verify crash is fixed.

BUG=1014088

Change-Id: Ia5ddf51f29254416a93ee7f3416b96d60794e473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925754
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729939}

Currently, the decision on whether a scroll should be animated or not
occurs in InputHandlerProxy. This makes the compositor scroll interface
more complicated than it needs to be and exposes details about scrolling
that should be encapsulated in the compositor.

This CL moves the |smooth_scroll_enabled| from an ad hoc bit in the
InputHandlerProxy into a real setting in LayerTreeSettings. We then
rearrange the public interface of the compositor input handler so that
we only have a ScrollUpdate method. This method now checks whether a
given scroll should be animated or not and delegates to the old ScrollBy
or ScrollAnimated methods, based on the answer. Finally, we remove some
of the divergence between animated and non-animated paths in
InputHandlerProxy so that both kinds of scrolls are handed in the same
way.

Bug: 1016229
Change-Id: I2143cf27aeb6aca905b59b817fe8e3f1b14b7858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981711
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729938}

This CL plumbs the power experiment state to the media players in the
renderer that they are / are not the only playing player.  This
lets the renderer decide whether to start measuring power usage.

Bug: 1017783
Change-Id: I17e9b453c63482b20bf2b9c4d802ff346f7bd44e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992686Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729937}

Screen width of some devices does not have enough space for the logo.
See screenshot here:
https://drive.google.com/drive/folders/1-ZYyD0KSYr2wLEzBHZ9UFIP-K7D79tDV?usp=sharing

This CL removes the logo if there is not enough space at the first layout.

Known issues:
If device is rotates, screen width may change.

Bug: 1025296, 1027324
Change-Id: Ib5e17a8b49bd70c304d8e38e95d5de4123cf4ea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976311Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Mia Glaese <glamia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729936}

Reverts CL:1903901, which was added as a workaround for an issue where
focusing web contents in Assistant UI would cause app list to revert
back from assistant to "apps" state. The issue was caused by calls to
OnHomeLauncherGainingFocusWithoutAnimation() whose logis was resetting
app list state - this logic has since been removed from the method
(in CL:1966374), which made this workaround unnecessary.

BUG=1026727, b:144056527

TEST=Open embedded Assistant UI, tap "What can you do", verify that
     Assistant UI remains open after tapping grid items (and shows the
     UI associated with the grid item)*
* Unless the grid item is expected to open a browser tab, in which case
the assistant UI is expected to be hidden.

Change-Id: Ibf91647ddceb40dcacf054c66aec6205eac097ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994121Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729935}

These are no longer recorded, and likely haven't been for some time.

Bug: 1037096
Change-Id: I2d3f6febc2a0fda20dea02dc6473c3dcca81d3c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993621Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729934}

This CL adds an axe accessibility test for the threads pane.

Bug: 963183
Change-Id: I35dc2738f7bd5fce2e4b24aaa6a86b51b671b982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707832Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#729933}

This reverts commit 514a76b7.

Reason for revert: This was removing the tests from the wrong location,
it was removing them from WPT folder instead of fast/css-grid-layout/.

Original change's description:
> [css-grid] Remove outdated css-grid-layout alignment tests
> 
> The alignment tests in question have been moved from WebKit to WPT
> with the following PR:
> * https://github.com/web-platform-tests/wpt/pull/19828
> * https://github.com/web-platform-tests/wpt/pull/20088
> * https://github.com/web-platform-tests/wpt/pull/19809
> * https://github.com/web-platform-tests/wpt/pull/19665
> * https://github.com/web-platform-tests/wpt/pull/20110
> 
> The removed tests that are now in WPT can be found under:
> third_party/blink/web_tests/external/wpt/css/css-grid/alignment/
> 
> This patch removes the outdated version of the tests from
> third_party/blink/web_tests/fast/css-grid-layout/
> 
> Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531
> Commit-Queue: Manuel Rego <rego@igalia.com>
> Reviewed-by: Manuel Rego <rego@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#729346}

TBR=jfernandez@igalia.com,rego@igalia.com,obrufau@igalia.com,rmonteriso@igalia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I18d98894d82e9800024d0fd23ee11c82432a0e64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993801Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#729932}

The existing OpenCoverageFile and SetCoverageFile implementation is
causing lots of timeouts when running fuzzing testcases. Either because
there is a hardcoded child_pool of size 4, or maybe because of the lock
mechanism being used.

This change allows not to use this logic when dumping code coverage in
a fuzzing build. The fuzzing coverage bots are using --disable-sandbox
anyway, so this just improves their stability and performance.

This change may be reverted in future if/when the underlying issue in
OpenCoverageFile/SetCoverageFile gets resolved. It does not affect non
fuzzing builds (e.g. blink layout tests), therefore is not a priority.

Bug: 1002058,957581
Change-Id: Ic847aaadf9dd2c4a8130f9736b15f9c2cb3171ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981022Reviewed-by: Sajjad Mirza <sajjadm@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729931}

InspectorTaskRunner queues itself for a V8 interrupt, but V8 doesn't
automatically increment the task runner's refcount. As a result,
InspectorTaskRunner needs to manually increment and decrement its
own refcount to ensure that it doesn't get deleted, which would
otherwise result in V8 hanging onto a dangling pointer.

Bug: 933128
Change-Id: I715734015bbf810ecbba5f4e509fcc924b3aa1b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993436Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#729930}

Whenever there is a MediaRoute update for an existing media notification
item, update the view if necessary.

Bug: 1040207
Change-Id: Ie8c28237fee56268f20dd57e08f9cf405fdb79cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992690Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729929}

https://pdfium.googlesource.com/pdfium.git/+log/f793e3abc4ec..3c04fb3a9464

git log f793e3abc4ec..3c04fb3a9464 --date=short --first-parent --format='%ad %ae %s'
2020-01-09 tsepez@chromium.org Cover FPDF_GetDefaultTTFMap() from embedder tests.
2020-01-09 tsepez@chromium.org Watch CFXA_FFWidgets across more On* methods.
2020-01-09 tsepez@chromium.org Ensure CFWL_Widget::m_pTextOut is initialized.

Created with:
  gclient setdep -r src/third_party/pdfium@3c04fb3a9464

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I18e4257ed9a16265973dfb124855b024adb0903c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993881Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729928}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/797d74a266bb..12f8d69f1288

git log 797d74a266bb..12f8d69f1288 --date=short --first-parent --format='%ad %ae %s'
2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@12f8d69f1288

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Id353d9adffbf9e54e2cee6cce71f410ea4f9a731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993571Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729927}

Ignore existing presubmit errors in preference_spinner_*.xml

NOPRESUBMIT=true

Bug: 1035928
Change-Id: I3c25864ff3e3e82ecc6bffbbd30a945df6539f42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992815Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729926}

See https://skia-review.googlesource.com/c/skia/+/263349

Change-Id: I04ee11072dd33ed5076a6b53ab580b4d5ed6b2f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993626Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729925}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac0b770408f5..141fae8b9f4d


Created with:
  gclient setdep -r src-internal@141fae8b9f4d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I490db605ecb95bfe91f611a94a04d6dbe6459b13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993880Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729924}

Getting rid of .Lukewarm suffix as it was only useful to diagnose what
happens when it's not warm/cold. The main histogram already gives that
and Startup.Temperature can be used for diagnosis.

This CL will add 25-30% more users to the "warm" bucket and drop 5-15%
from the "cold" bucket. .WarmStartup and .ColdStartup metrics are
expected to shift as a result.

Detailed analysis @ https://docs.google.com/document/d/1haXFN1cQ6XE-NfhKgww-rOP-Wi-gK6AczP3gT4M5_kI

R=chrisha@chromium.org

Bug: 969961, 1037318
Change-Id: I7c73806c0dc24d3c95d131bc1fa3098d8c57e5eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991941Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729923}

https://webrtc.googlesource.com/src.git/+log/5c35f2fb1bc2..3b19b2734385

git log 5c35f2fb1bc2..3b19b2734385 --date=short --first-parent --format='%ad %ae %s'
2020-01-09 jsphchn@google.com Make the sdk:audio_session_objc target public.
2020-01-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision efba8d29..b57c714b (729663:729764)
2020-01-09 aalaniz@twilio.com Update Android camera switch API to allow specifying a name
2020-01-09 phoglund@webrtc.org Extract plottable counter from perf results logger.
2020-01-09 henrika@webrtc.org Avoids crash in ADM for Android
2020-01-09 jonaso@webrtc.org Reland "Add field trial to base stable target rate on loss based target rate"

Created with:
  gclient setdep -r src/third_party/webrtc@3b19b2734385

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1029452
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I01b4a6f8f04f559e8c67572fddd292ebf9cae87b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993883Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729922}

When separating ssid from security type in a serialized network
identifier, we were previously using an underscore.  Since this is an
allowed character in SSIDs, it's safer to use something more unique.

Bug: 966270
Change-Id: I3aac88bd3fc0cfa6058b021892a697e09b271cfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992585Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729921}

Enables HEADLESS operation on screen-less devices, using a switch
published via the system's config store.

Reading/parsing logic is promoted to a common library,
"config_reader.h", and ContextProvider is modified to use it.

Bug: 1025045
Change-Id: Iad72297cf0e2a2d30e2650563c23d58204ad7eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989998
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729920}

Bug: 1011446
Change-Id: I35b19fa40c105738b286e5bf669049643b45681a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993900
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729919}

Bug: 1036489
Change-Id: I64bea0d19217483cb040a0bc0ba2697809a96ade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993800Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729918}

This feature has been enabled since M-76.

Bug: 889087
Change-Id: I54fbf2851fe7da7c442f6abb05010405f7f27fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992321Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729917}

This test, previously named
OmniboxViewTestWithoutSplitSettings.EditSearchEngines, was deleted at r727291.
The test seems relevant regardless  of whether the OS/Browser settings are split
though. Restoring it since it still seems useful, without the now obsolete
"WithoutSplitSettings" suffix.

Fixed: 994927
Change-Id: I87bbbdc312a1a22b21fd2391c8c8f112302a5ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993941Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729916}

This removes the cached find-in-page value for a profile when that
profile's history data is cleared. Like most data that is deleted along
with DATA_TYPE_HISTORY, the time range is ignored; any time range will
cause the last find-in-page value to be deleted.

The original motivation for this change was to delete some Chrome
dependencies from //chrome/browser/ui/find_bar/, in preparation for
componentization, because it's an alternate way of achieving the
behavior that is being deleted there (wrt clearing FIP for guest
profiles). However it is also a behavioral improvement in that it makes
Clear Browsing Data more comprehensive.

Bug: 1038415, 889642
Change-Id: I429470c4f215e6a2ace29e42c2e8795a2e70daa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986909Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729915}

Reland "Removed BrowserView::ViewHierarchChanged, moved most code to constructor and widget-specfic code to AddedToWidget."

This is a reland of f3616c26

Original change's description:
> Removed BrowserView::ViewHierarchChanged, moved most code to constructor and widget-specfic code to AddedToWidget.
> 
> Bug: 245409
> Change-Id: I1e606548df4361199862c561ad86f4d40cbaa7df
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979098
> Commit-Queue: Allen Bauer <kylixrd@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#728998}

Bug: 245409
Change-Id: Id5317849e130ec8715200f0947bc01f2bc932842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991945
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729914}

Uses the JNI generator to generate test methods for native java
unittests that simply call java test methods.

Bug: 783819
Change-Id: I2ff4d87a1aa053847077bd3f418123be49174375
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992247
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729913}