- 07 Feb, 2019 40 commits
-
-
Finnur Thorarinsson authored
Bug: 921425, 656015 Change-Id: Ia5f324ea9c6d3c66c52214af083f597ea55df8b2 Reviewed-on: https://chromium-review.googlesource.com/c/1455950 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#629972}
-
Daniel Bratell authored
Jumbo, as implemented as a gn template, will naturally hide the original files behind new files target_jumbo_1.cc, target_jumbo_2.cc, .... This breaks the gn analyze step which is used by cq to figure out if it needs to test compile or not. To give gn analyze a chance to see what is going on, put the original sources in the merge action's |input| list. The action won't use the files and it will serialize actions that don't need serializing but it might be a small price to pay. There might be unexpected and unwanted side effects from this. The cleanest solution would be to give gn native jumbo support which would also allow other changes like better IDE support and better error messages, but this is what we got. Bug: 893071 Change-Id: I36aa498795871a63cfcd4e2d27c29e2f59d5ccbb Reviewed-on: https://chromium-review.googlesource.com/c/1455943 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#629971}
-
Marc Treib authored
Callers can instead trigger a reconfigure by grabbing and immediately releasing a SyncSetupInProgressHandle instead. This resolves one of the last reasons for using ProfileSyncService rather than SyncService. Bug: 924508 Change-Id: I2ba2839356e32954d3c655356a60c6398d41adae Reviewed-on: https://chromium-review.googlesource.com/c/1456658Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#629970}
-
Etienne Pierre-doray authored
This CL removes redundant members in base::internal::Task: - delay: Redundant with PendingTask::delayed_run_time - sequenced_time: Redundant with PendingTask::queue_time (unused when sequenced_time is used). This clean up makes Task easier to read, and slightly more lightweight. Change-Id: I7ed16bd3458d61f98d717f2f3dd83124f9f0121f Reviewed-on: https://chromium-review.googlesource.com/c/1448977Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#629969}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I5fc899717a00db03daf0a4c5a94e267daa305c0d Reviewed-on: https://chromium-review.googlesource.com/c/1458601Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#629968}
-
Marc Treib authored
These were previously only exposed in *Profile*SyncService. Moving them up into the interface removes one of the last reasons to use ProfileSyncService directly. Bug: 924508 Change-Id: Ie7f44f4dc8adba814812b9fae9bf3e753c7890c5 Reviewed-on: https://chromium-review.googlesource.com/c/1458038Reviewed-by:
-
David Benjamin authored
Make it slightly easier to find the actual uses. Bug: 755368 Change-Id: I3b9929aba2440ad876e1500c279ea9fd9d63d29a Reviewed-on: https://chromium-review.googlesource.com/c/1456936Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#629966}
-
Benoît Lizé authored
Cleans up feature flags for string parking, making foreground and background compression mutually exclusive. Compression on memory pressure is kept in both cases. This does not remove background compression, as the foreground one is still experimental, whereas the background one has been validated by deb/beta/stable experiments. Bug: 877044, 924164 Change-Id: I79b65e6d0073b18a704055e0cfeb54ba451e20c2 Reviewed-on: https://chromium-review.googlesource.com/c/1458200Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#629965}
-
Friedrich Horschig authored
This change tries to use more of the Chrome stack for our integration tests. This might catch errors in the bridge that previously let compile failures slip. This *might* increase robustness because the calls of the native bridge are now correct and don't have to be replaced anymore. This caused some weird cases where the bridge would say: display nothing and the test quickly called *DO* display something. The overhead shouldn't increase much, since we don't actually load the test data from the render but instead fill the cache of the native part of the component. This allows the native side to behave naturally and even fill tapped suggestions as it normally would. A small clean-up that supported this change: the EmbeddedTestServer allows loading html pages which provides an IP as origin instead of a data url. Bug: 913888, 894428, 922131, 920901 Change-Id: Ib2c09ed386354965ccdaf2f44ca1aafd218fd018 Reviewed-on: https://chromium-review.googlesource.com/c/1448233 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#629964}
-
Caitlin Fischer authored
Bug: 850597 Change-Id: Ie295693b36e077086f3beb379a80dc87211e2323 Reviewed-on: https://chromium-review.googlesource.com/c/1455055 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Igor authored
This is a device policy that specifies whether and in which case the device must reboot on user sign out. By default the policy value is NEVER. Two other options are available, with possibility to add more in the future. The implementation of the effects of the policy, the reboot itself, will be done in a separate CL. Bug: b:77799573 Test: unit_tests --gtest_filter=DeviceSettingsProviderTest.DeviceRebootAfterUserSignout Change-Id: I2f8e847620f5b28d36d20d3e6912b99ec6e00497 Reviewed-on: https://chromium-review.googlesource.com/c/1455961 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Cr-Commit-Position: refs/heads/master@{#629962}
-
Christian Dullweber authored
Change-Id: I5e4b63cb0a7bf86b4978b4089ab5fe9086d48a90 Reviewed-on: https://chromium-review.googlesource.com/c/1446351Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#629961}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3043fbd9fc27..af5e7a520e64 git log 3043fbd9fc27..af5e7a520e64 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 lalitm@google.com Merge "trace_processor: improve test framework and add kernel LMK tests" 2019-02-07 lalitm@google.com Merge "trace_processor: fix crash with instants table when adding args" 2019-02-07 hjd@google.com perfetto-ui: Add process_scheduling track 2019-02-07 lalitm@google.com Merge "trace_processor: remove duration column on counters table" 2019-02-07 hjd@google.com Merge "Remove GOOGLE_CHECK" Created with: gclient setdep -r src/third_party/perfetto@af5e7a520e64 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8efe052759702ac4ca8b2fa6e761c9a55bf8f52b Reviewed-on: https://chromium-review.googlesource.com/c/1458416Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629960}
-
Thomas Tangl authored
When files in chrome/browser/resources are changed, the tryjob linux_chromium_dbg_ng is added to the commit queue. This is done to catch browser tests that fail because of missing dependencies/includes. These failures are often not caught by rel builds. Change-Id: I4a17e1e09e7a4ed450f5cc9efc2ce8831a9be525 Reviewed-on: https://chromium-review.googlesource.com/c/1437286 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#629959}
-
Koji Ishii authored
Following bot results are included. 14771 14772 14779 14790 14798 14801 14812 14817 2 lines were removed and 0 lines were deflaked by consecutive results since 14754. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I38d1d2800e92dcc6833a4206cb6d7f119c929800 Reviewed-on: https://chromium-review.googlesource.com/c/1456416Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#629958}
-
Sergio Villar Senin authored
ChildAccountService was observing changes the list of gaia accounts in the cookie jar in order to notify its observers. We can achieve the same behaviour by observing IdentityManager instead. Apart from that the call to GaiaCookieManagerService::ListAccounts() was successfully replaced by IdentityManager::GetAccountsInCookieJar(). This allows us to completely remove the dependency on GaiaCookieManagerService. Bug: 921007 Change-Id: I7acc064c65ae2d61eb9d807e08183f2ee30e5183 Reviewed-on: https://chromium-review.googlesource.com/c/1409010 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#629957}
-
Dominic Farolino authored
This reverts commit 66236c64. Reason for revert: Bad and unexpected performance regressions were introduced with this change. It is possible to incur an infinite loop of loading a <link> and firing the load event, if the onload function tampers with the `rel` attribute, as is sometimes done with preload links. This may prevent a window's load event from ever being fired. Mitigating problems like this needs to more looking into before this change can land apparently. Performance regression bugs: https://crbug.com/927427, https://crbug.com/928796, https://crbug.com/929153, https://crbug.com/929265. The original bug (https://crbug.com/922618) has been re-opened to track future work for this. Original change's description: > Link element events should be able to fire more than once > > As per spec https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet, > the <link> element can have its load and error events fire multiple times, > per resource it loads. > > Bug: 922618 > Change-Id: Ifc9ade076e119d5cf9f4eaf656c6ea7c1deb0ba9 > Reviewed-on: https://chromium-review.googlesource.com/c/1423601 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Dominic Farolino <domfarolino@gmail.com> > Cr-Commit-Position: refs/heads/master@{#628010} TBR=yhirano@chromium.org,kouhei@chromium.org,domfarolino@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 922618 Change-Id: I0affe5a242bf472743d11a4905a630da7895cfca Reviewed-on: https://chromium-review.googlesource.com/c/1457745Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#629956}
-
kylechar authored
Remove usage of deprecated base::Bind, base::Callback, base::Closure, base::CancelableCallback and base::CancelableClosure types from content/gpu/*, content/browser/gpu* and chrome/gpu/*. Where possible convert to the corresponding once type. Otherwise replace with the repeating type which is equivalent to the deprecated type. Bug: 714018 Change-Id: I8da148c51d9eb8b5d85a4a8f76b41f8a13ff295f Reviewed-on: https://chromium-review.googlesource.com/c/1456941Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#629955}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7ca375c8ca54..0041fe53dcfe git log 7ca375c8ca54..0041fe53dcfe --date=short --no-merges --format='%ad %ae %s' 2019-02-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1a597bc4..ee5dfb22 (629788:629907) 2019-02-07 oprypin@webrtc.org Roll chromium_revision c27b32b2..1a597bc4 (629510:629788) 2019-02-07 oprypin@webrtc.org Pause rolling buildtools 2019-02-06 steveanton@webrtc.org Reland: Remove dead code from stream_params.h 2019-02-06 solenberg@webrtc.org Remove HAVE_WEBRTC_VOICE. 2019-02-06 nisse@webrtc.org Move RtpSenderVideo tests to separate file. 2019-02-06 nisse@webrtc.org Delete MediaTransport method SetNetworkChangeCallback 2019-02-06 nisse@webrtc.org Allow more than one registered network change callback in MediaTransport 2019-02-06 oprypin@webrtc.org Roll chromium_revision 9d5d0c66..c27b32b2 (629245:629510) Created with: gclient setdep -r src/third_party/webrtc@0041fe53dcfe The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:927867,chromium:None,chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7a024246384477be0b56fa2bed7316f6983db105 Reviewed-on: https://chromium-review.googlesource.com/c/1457535Reviewed-by:
-
Erik Luo authored
Bug: 929561 Change-Id: I98ec6ea3cc6a6de1d82489a737cd5f51f9bc56f0 Reviewed-on: https://chromium-review.googlesource.com/c/1457919Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#629953}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a54660850c3..36651e4e3873 Created with: gclient setdep -r src-internal@36651e4e3873 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5117525c0b39eeb83fefda75be9240ba6904a656 Reviewed-on: https://chromium-review.googlesource.com/c/1458277Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629952}
-
Hans Wennborg authored
TBR=thakis Bug: 929645 Change-Id: Ie38f68f99b82e8193afbf367a7894f70cb9e18ec Reviewed-on: https://chromium-review.googlesource.com/c/1458182Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#629951}
-
Erik Luo authored
EagerEval's preview is breaking onto a new line. We should be making the entire preview 'nowrap'. Bug: 929535 Change-Id: Ib26f3bb26b06991e0a32320ec9f6744efa23e4a8 Reviewed-on: https://chromium-review.googlesource.com/c/1455349Reviewed-by:
-
Michael Lippautz authored
In the case a dedicated worker is terminated before the backing thread has been created the message proxy would never be cleaned up. With unified heap this means that any wrappers may keep on to old window objects. Bug: 928781, 843903 Change-Id: Ic0f1968609d259a2eea9a4c90d47f95729b4ce79 Reviewed-on: https://chromium-review.googlesource.com/c/1458217Reviewed-by:
-
jdoerrie authored
This change adds a base::as_u16cstr() utility function for platforms where wchar_t is UTF16. Furthermore, it also provides a as_writable_u16str() function, renames base::wdata() to base::as_wcstr() and base::as_writable_wcstr() respectively, and removes the no longer needed CastToStringPiece16 and CastToWStringPiece. Bug: 911896 Change-Id: I192da78b9d2d4ddca8a642242d0c65dc7fc361f4 Reviewed-on: https://chromium-review.googlesource.com/c/1452185Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#629948}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/69a830d3..d6d7c729 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5455056689e8b5b3aeb0da03c2bd2edb254f9ec4 Reviewed-on: https://chromium-review.googlesource.com/c/1457926Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629947}
-
François Beaufort authored
This CL removes the SkipAd media switch feature as the Picture-in-Picture window will receive events only from blink/. Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/l6sW0G4jzhE Bug: 910436 Change-Id: I4c41b476691f43d76a8811f8990873c222341e7c Reviewed-on: https://chromium-review.googlesource.com/c/1452186 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#629946}
-
Nicolas authored
This CL adds BrowserSwitcherServiceWin, which extends BrowserSwitcherService and contains the Windows-specific code. This avoids too many #ifdefs in that file. Change-Id: Icbf49f82e605710c273c8795805c4ad962b67ea7 Reviewed-on: https://chromium-review.googlesource.com/c/1457221Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#629945}
-
Carlos Caballero authored
Add a new task trait to tell the future BrowserUIThreadScheduler which tasks are critical for startup and allow it to prioritize them accordingly. Design doc: https://docs.google.com/document/d/1z1BDq9vzcEpkhN9LSPF5XMnZ0kLJ8mWWkNAi4OI7cos/edit# Bug: 863341, 872372 Change-Id: Ifb082762726fbda951325802faf82f1dacf219cc Reviewed-on: https://chromium-review.googlesource.com/c/1454632 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#629944}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/382b122e45dc..c19d81acc096 git log 382b122e45dc..c19d81acc096 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src c27b32b2..635f1120 (414 commits) Created with: gclient setdep -r src/third_party/skia@c19d81acc096 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ide6b3951f697b7c6cfda248adff46d06564e11f6 Reviewed-on: https://chromium-review.googlesource.com/c/1458276Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/29ecb64560ae..3043fbd9fc27 git log 29ecb64560ae..3043fbd9fc27 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 lalitm@google.com trace_processor: fix MSAN failure due to off-by-one Created with: gclient setdep -r src/third_party/perfetto@3043fbd9fc27 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I61c047f0de6d35296dcd08b783cb3b8d7a664be4 Reviewed-on: https://chromium-review.googlesource.com/c/1457533Reviewed-by:
-
Yutaka Hirano authored
As part of WebDataConsumerHandle deprecation, this CL removes WebDataConsumerHandle references from core/. - Remove WebDataConsumerHandle parameter from - Resource::ResponseReceived - RawResourceClient::ResponseReceived - ThreadableLoaderClient::DidReceiveResponse. - Add RawResourceClient::ResponseBodyReceived. - Add ThreadableLoaderClient::DidReceiveResponseBody. - Remove BufferingDataPipeWriter and start using BufferingBytesConsumer instead. - Stop dispatching data chunks from WebURLLoaderImpl to ResourceLoader when |use_stream_on_response_| is set. Bug: 894819 Change-Id: Id85d8f377fd073378ac5bfde6e2571dc1ad9e4b5 Reviewed-on: https://chromium-review.googlesource.com/c/1447999Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#629941}
-
Kush Sinha authored
Bug: 816954 Change-Id: I4ee640075af0948cbb8b5bfcc127123348cad98b Reviewed-on: https://chromium-review.googlesource.com/c/1426779 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629940}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f0a00cd7f17b..93c01741f610 git log f0a00cd7f17b..93c01741f610 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 evanhernandez@chromium.org cros branch: Support custom repo root. 2019-02-07 zwisler@google.com portage_util: unit test for always_live GetSourceInfo() call 2019-02-07 ahassani@chromium.org cros_generate_update_payload: Use new paygen library 2019-02-07 saklein@chromium.org build_api: Implement ImageService/Test Created with: gclient setdep -r src/third_party/chromite@93c01741f610 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib85a3a46d1f4e977ca010f8e02f20abe9c8a9506 Reviewed-on: https://chromium-review.googlesource.com/c/1457534Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b68e715cb291..2a54660850c3 Created with: gclient setdep -r src-internal@2a54660850c3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2787fc634d12614c6d848d39dca3eb200480eb44 Reviewed-on: https://chromium-review.googlesource.com/c/1457530Reviewed-by:
-
Nikita Podguzov authored
Bug: 848942 Change-Id: I5e98582e5d1a949c8db25846068655ed2c551068 Reviewed-on: https://chromium-review.googlesource.com/c/1454897 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#629937}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/859db6b5a03c..382b122e45dc git log 859db6b5a03c..382b122e45dc --date=short --no-merges --format='%ad %ae %s' 2019-02-07 csmartdalton@google.com Revert "Add a GpuGM class for GPU-only tests" Created with: gclient setdep -r src/third_party/skia@382b122e45dc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I024bed8810e3f1f7a9149e673fb4770e68357be9 Reviewed-on: https://chromium-review.googlesource.com/c/1457531Reviewed-by:
-
Alan Cutter authored
This CL ensures we do not spam the user's Application directory on Mac when syncing down installed PWAs. This makes Mac behave the same as Windows and Linux. Bug: 929559 Change-Id: I31df57e7d8228b2a47cc362f258afeee2dc840ef Reviewed-on: https://chromium-review.googlesource.com/c/1457698 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#629935}
-
Kush Sinha authored
AccountManagerMigrator used |AccountReconcilor::Initialize| as a way of starting account reconciliation because |AccountReconcilor::Start| is a private method. Make |AccountReconcilor::EnableReconcile| call |AccountReconcilor::StartReconcile| in its implementation and call |EnableReconcile| from AccountManagerMigrator. Bug: 904128 Test: components_unittests --gtest_filter="*AccountReconcilorTest*" Change-Id: I7899fb261080c10bb62ebdefe31c45d3a9a4754c Reviewed-on: https://chromium-review.googlesource.com/c/1424299 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#629934}
-
Kush Sinha authored
Th test assumed that Mirror account consistency will only be available if the logged in account is a child account. This assumption is no longer true. Bug: 915628 Test: browser_tests --gtest_filter="*ChromeOsMirrorAccountConsistencyTest*" Change-Id: I99a1f672949e76c22db159c0d69384f50727670d Reviewed-on: https://chromium-review.googlesource.com/c/1437285 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
