- 21 Sep, 2020 40 commits
-
-
Irina Fedorova authored
This CL adds a sort of weak credentials to GetWeakCredentials(). It uses the same comparator as used to display the list of saved passwords in the UI. Bug: 1119752 Change-Id: Iac597b71a55321f1a72a2d0f378f506976c8d21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418815 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#808900}
-
Dominik Röttsches authored
Measure latency on the Blink side for IPC roundtrips retrieving fonts from Android downloadable fonts. Bug: 1115064 Change-Id: I0bb3f2f53470858de5c7803a1f6ec096be28f4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416291Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#808899}
-
Andrew Grieve authored
* Fixes an issue with an unrecognized compiler flag. * Could not get -flto to work and no good error message from the failure. Left a TODO to re-enable it. Bug: None Change-Id: I683119e43e767ff5b228706bc6b6f68c2282f7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418993Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808898}
-
nancylingwang authored
This CL adds unit tests to verify: 1. Loading compressed icons. 2. Loading icons from the resource. 3. Loading icons from the compressed data. BUG=1083331 Change-Id: I35d0ff87e7f8a1f5099408f194572b3c527b3213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418692Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808897}
-
Etienne Pierre-doray authored
org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest#testCloseTabViaCloseButton is flaky. TBR=meiliang@chromium.org Bug: 1130212 Change-Id: I2f1f44879c9f849db98ded90f53568971d77ef2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421610Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#808896}
-
Yuanyao Zhong authored
The valuables scroll_extent_min and scroll_extent_max are only meaningful when the node is scrollable and min is smaller than the max. On non-x86 the value is 0, so it was working previously. However on x86 the value is "8000 0000" Test: build on device and x86 version to test the functionality. Bug: None Change-Id: Ie065617712722f2250067293836221e57f7a0a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419599Reviewed-by:
Randy Rossi <rmrossi@chromium.org> Commit-Queue: Yuanyao Zhong <yyzhong@google.com> Cr-Commit-Position: refs/heads/master@{#808895}
-
Henrique Nakashima authored
Output now looks like this (removed some lines for brevity): Printing class dependencies for .c.b.app.flags.ChromeCachedFlags: 2 inbound dependency(ies) into .c.b.app.flags.ChromeCachedFlags: [chrome_java] <- .c.b.app.ChromeActivity <- .c.b.init.ChromeBrowserInitializer 6 outbound dependency(ies) from .c.b.app.flags.ChromeCachedFlags: [chrome_java] -> .c.b.app.appmenu.AppMenuPropertiesDelegateImpl -> .c.b.tasks.ReturnToChromeExperimentsUtil -> .c.b.tasks.tab_management.TabUiFeatureUtilities -> .chrome.features.start_surface.StartSurfaceConfiguration [//c/b/flags:java] -> .c.b.flags.BooleanCachedFieldTrialParameter -> .c.b.flags.CachedFeatureFlags was before: Printing class dependencies for org.chromium.chrome.browser.app.flags.ChromeCachedFlags: 2 inbound dependency(ies) into org.chromium.chrome.browser.app.flags.ChromeCachedFlags: [//chrome/android:chrome_java] org.chromium.chrome.browser.app.ChromeActivity org.chromium.chrome.browser.init.ChromeBrowserInitializer 6 outbound dependency(ies) from org.chromium.chrome.browser.app.flags.ChromeCachedFlags: [//chrome/android:chrome_java] org.chromium.chrome.browser.app.appmenu.AppMenuPropertiesDelegateImpl org.chromium.chrome.browser.tasks.ReturnToChromeExperimentsUtil org.chromium.chrome.browser.tasks.tab_management.TabUiFeatureUtilities org.chromium.chrome.features.start_surface.StartSurfaceConfiguration [//chrome/browser/flags:java] org.chromium.chrome.browser.flags.BooleanCachedFieldTrialParameter org.chromium.chrome.browser.flags.CachedFeatureFlags Change-Id: If9535c19ab5121a6a057e5c6d1dedea657e453ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392942Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#808894}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d970d657aa56..4559368cc4a1 2020-09-21 robertphillips@google.com Add MRU to GrThreadSafeUniquelyKeyedProxyViewCache If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: csmartdalton@google.com Change-Id: I7e3303255f103ec31b28878f1b1c0a535bb48e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421544Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808893}
-
David Jean authored
The collapsed state is shared silently by the ListModel (by saving to NSUserDefaults). So if more than one window use the same collapse key, they become unsync if one changes without telling the others. Bug: 1125093 Change-Id: I987f98c590f743fd12f7d8aab3ac2782554a9a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409908 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#808892}
-
Anqing Zhao authored
Considering this case was disabled 3 years ago, but it runs successfully in local test. Let's re-enable it and monitor its current status. Bug: 766169 Change-Id: I3518ef855e4cd319ca0e2045fe764751d0c54923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420608 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#808891}
-
Manuel Rego Casasnovas authored
We can avoid the Unite() operation in AdjustScrollableOverflowForPropagation() when we're processing a kFragmentBox, because ScrollableOverflow() already returns the element's size for that type of elements if TextHeightType is kNormalHeight. BUG=1128984,1130140,1130141 Change-Id: I828b7098e1a40b975bd257f99525e7cc9f4956fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420611Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#808890}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fcd0fd47bdba..a53556930038 2020-09-21 adithyas@chromium.org Portals: Add support for highlighting in ConsoleContextSelector 2020-09-21 sigurds@chromium.org Show report-only mode setting for COOP/COEP in frame tree 2020-09-21 jacktfranklin@chromium.org Fix ElementsBreadcrumbs mutation bugs. 2020-09-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-09-21 tvanderlippe@chromium.org Upgrade TypeScript to 4.1.0-beta 2020-09-21 changhaohan@chromium.org Skip idle state e2e test for now 2020-09-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-21 tvanderlippe@chromium.org Fix more issues for TypeScript 4.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1005916,chromium:1011811,chromium:1051466,chromium:1129881,chromium:1130513 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I03f82624125a4224eff1dae62cd8447ffa051a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421546Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808889}
-
Sebastien Lalancette authored
Updated EG tests and also had to disable drag-drop functionality in Reading List, Bookmarks and History tables when EG tests are running. This is because of an EG framework issue (which hangs the tests) that is being worked on: crbug.com/1129058 Bug: 1110944 Change-Id: I378d86e76cff6aa6e2389f5fc008a8e5805d7061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368497Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#808888}
-
Michele Mancina authored
Bug: b/169042549 Change-Id: Ie69d4306bc055278c344fc4de8decf46d8a287c5 Change-Id: Ie69d4306bc055278c344fc4de8decf46d8a287c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421451 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#808887}
-
Nicolas Ouellet-Payeur authored
This CL removes Nearby Share code from the Linux/Windows builds: https://crrev.com/c/2416726 This wasn't caught by the traffic_annotation_auditor buildbot, because the CL only modified BUILD files. So we need to fix annotations.xml separately. TBR=rhalavati@chromium.org Change-Id: I75241d848dacf798665be0f86d62530bac6b4406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422239Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#808886}
-
Fredrik Söderqvist authored
Reorder the function to check for a paintserver resource first and then return any color. This structure should be more conducive to future paintserver handling. Change so that we don't resolve a color if there is no color value to resolve. Also apply the same restriction to the visited paint/color, such that only a color can "replace" a color. Bug: 109212 Change-Id: I81a0c47b694406c931663804df6705f7bf651572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418372Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#808885}
-
Peter Kotwicz authored
This CL adds a strict mode violation exemption for DexPathList#toString() for Android P in addition to the existing suppression for Android O. The fix to not call File#isDirectory() in DexPathList#toString() landed in Android Q. BUG=1109678 TBR=agrieve Change-Id: I5d028a4584c2e2de7acfe2cdd2631260d3f61cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417494 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808884}
-
arthursonzogni authored
We want to display "issues" in the Devtool panel when an access is made in between two windows from different virtual browsing context group. Checking the access was previously gated behind having at least one reporting endpoint defined. This patch removes it. We are still gating emitting ReportingObserver events behind having a reporting endpoint defined. This might be something we might want to remove in the future as well. Bug: 1124251 Change-Id: I0e77ed9530d55ec50a011caedd765c07612b407b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418711Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808883}
-
Robert Ma authored
While working on https://crrev.com/c/2419575, I found that errors in PRESUBMIT_test.py were not informative. This CL would produce more error details when e.g. `wpt lint` fails to run. Change-Id: I87cd4a98bdf3eb7ca49313d30e799bd440d4ee2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418990Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#808882}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/22d5e3c0712d..f343742a8c9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC etiennep@google.com,elklm@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: etiennep@google.com,elklm@google.com Change-Id: I39eeb72e54303a71d4b9b1710567d2826631d23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421541Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808881}
-
Tanmoy Mollik authored
Scale ic_person_add_24dp to 40dp as discussed on this cl: https://crrev.com/c/2390906 Bug: 1107423 Change-Id: Iac64338e50c072380d53f1aab1ca07f492c1ca30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410387 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808880}
-
Pavol Marko authored
Historically, multi sign-in was disallowed when either the primary Profile or the Profile being added used / had used policy-pushed CA certificates. The reason for limiting this was that the certificate verifier used at that time (NSS) had process-wide caches, so certificate verification results could leak across Profiles. Now that we use the built-in certificate verifier, this risk does not exist, so allow multi sign-in regardless of the policy-pushed certificate state of the primary / secondary Profiles. Also move clearing of the local_state pref that tracks policy-pushed certificate usage for a Profile into UserSessionManagerImpl because MultiProfileUserController does not have a dependency on the policy-pushed certs infrastructure anymore. In a follow-up the pref can likely be migrated to be a user Profile pref now instead of a local_state pref. Bug: 718002 Test: unit tests, browser tests Change-Id: I1006e0cb1cb4c9fdd68f5373e18acb27f5c3eaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297566 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#808879}
-
Tim Volodine authored
This test is failing on L bots and android-bfcache-rel. BUG=1130564 TBR=tedchoc@chromium.org,wenyufu@chromium.org Change-Id: Ib35afbc97a288a79efa686c0011a403267ae00ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421514Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#808878}
-
Sylvain Defresne authored
Test TranslateInfobarModalOverlayMediatorTest.UpdateLanguageInfo fails if system locale is not "en-US". This prevents running the test on a developer device if they want to use the device in their language. Bug: 1102968 Change-Id: Icdc61da3c1015388c89a8ecc90aeb45e5e93a88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421457 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808877}
-
Swapnil authored
We have many extensions stuck in CREATED stage which is reported in ExtensionManagement::UpdateForcedExtensions when extension list is fetched from kInstallForceList pref. Some of the intermediate stages were added to investigate CREATED stage. This CL moves these intermediate stages to a new enum and introduces a few new stages for investigation. Following histograms are added: Extensions.ForceInstalledCreationStage Extensions.ForceInstalledStage2 Following histogram is deprecated: Extensions.ForceInstalledStage Bug: 989526 Change-Id: I17a1bd7d49c31b6363a0512a424017775098042f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390222Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#808876}
-
Andrew Grieve authored
Use autoninja from PATH so that it matches the version used when building explicitly (allows for devs that are using a custom-built version of ninja). Allow omitting -C when script is run from within the output directory. This matches ninja's behavior. Bug: None Change-Id: I55763f178e2cf85892efbb4397a7ec81ed054aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419608 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#808875}
-
Raphael Kubo da Costa authored
testdriver.js' documentation says "presently, testdriver.js only works in the top-level test browsing context (and not therefore in any frame or window opened from it". If we do not restrict the set_permission() call here, the call to initialize_generic_sensor_tests() in generic-sensor/resources/iframe_sensor_handler.html will time out waiting for it to complete when running the iframe tests outside the Chromium CI (i.e. in wpt.fyi or with "wpt run"). Change-Id: I522a5ebacb7da9e35bbe2ea3564d3288a34c653b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421671 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#808874}
-
Norge Vizcay authored
[Autofill assistant] Extend AutofillAssistantPasswordManagerIntegrationTest.java to cover saving password The test was extended to cover presaving and saving password steps. It checks if the new generated password has been saved properly in the password store. Bug: 1130453 Change-Id: I6c05fbc9d3db13acc4724c9437e6e2d29cdd41bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421808Reviewed-by:
Milica Selakovic <selakovic@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Norge Vizcay <vizcay@google.com> Cr-Commit-Position: refs/heads/master@{#808873}
-
Viktor Semeniuk authored
Change-Id: I89c6a46f6c10c322096ecbdb41870bd87fa80995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421889Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#808872}
-
Alice Wang authored
This CL uses monogram for account avatar when user is signed in and no profile photo is uploaded. Prior to this CL, the placeholder image was used in this case. Bug: 1127886 Change-Id: I7790911e338d8b3f7d4ab4ec9fe3e25e9dcce4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416373 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#808871}
-
George Burgess IV authored
It seems that this constructor call was intended to be used as a scope guard. In order for that to happen, there has to be a variable name here. Bug: 1130379 Change-Id: I37569794b4526ab0c90e82b0a133ca1d85bb14b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420917Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#808870}
-
Rohit Rao authored
Disables the feature by default. BUG=1102794 Change-Id: Ia8132e8d959cc5017f18b5fd31618ae996de8b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417654Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#808869}
-
Etienne Pierre-doray authored
org.chromium.chrome.browser.NavigateTest#testRendererInitiatedIntentNavigate TBR=qinmin@chromium.org Bug: 1130419 Change-Id: I72a257cce875efb96124f3167d48a41489898f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421629Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#808868}
-
Sylvain Defresne authored
This reverts commit c793bf0d. Reason for revert: suspected of causing consistent failures of MobileSessionShutdownMetricsProviderTest.ProvideHasPossibleExplanationMetric on iphone-device bot. Original change's description: > [ios] Add previous session info to synthetic crash report > > The data is retrieved from PreviousSessionInfo singleton and > includes the following fields: > - free_disk_in_kb > - memory_warning_in_progress > > Bug: 1103752 > Change-Id: I10e6fe758bfde8ad753cbbd363ab34afc1a52e44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414784 > Commit-Queue: Olivier Robin <olivierrobin@chromium.org> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Auto-Submit: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808397} TBR=eugenebut@chromium.org,olivierrobin@chromium.org Bug: 1103752, 1130551 Change-Id: I372e3efa5e68d3375c9af044ac8bbe2f78125acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421594Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#808867}
-
Tanmoy Mollik authored
Rename Google services entry from "Other google services" to "Google services". Bug: 1130017 Change-Id: I3d979502eb78bc9b50667b65a8124c8274c0c5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420612Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#808866}
-
Amr Aboelkher authored
Extend the expiry date by half a year for the following accessibility shortcuts: - CrosHighContrast - CrosScreenMagnifier - CrosSpokenFeedback BUG=chromium:1081294 Change-Id: If04d8b6de386dcec14c8581d7f52450c9e74cbee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418953Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#808865}
-
Gyuyoung Kim authored
To reduce including a heavy web_preferences.h only when we need to use AutoplayPolicy enum, this CL moves AutoplayPolicy enum to autoplay_policy.h file. Bug: 919392 Change-Id: I0775d15052d679a06fd49c3586c9c789fa4e7894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418757Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#808864}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5721bfd7a5e6..f2db91bc8aed 2020-09-21 treehugger-gerrit@google.com Merge "Background mode for busy_threads" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If408a96d3ee60f800d68196e556f0d54e5917200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421540Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808863}
-
Mike Dougherty authored
The page has multiple results for headers with the text "Bookmarks". Replace the matcher with a new NavigationBarTitle helper. Bug: 1129588 Change-Id: I6c829ccc467e1df48bacd5af6e53c7bf92879206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419239Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#808862}
-
Yuki Shiino authored
On Android, malloc, free, etc. are intercepted by using the linker option -Wl,-wrap,FUNC , which means we're intercepting only the symbols undefined at link time. Non-undefined symbols like a call to malloc inside libc are not intercepted. strdup and strndup are such functions that internally call to malloc. However, the return values of strdup/strndup are deallocated with free (= our own free), so we should intercept strdup/strndup to have them use our own malloc. This patch implements wrapper functions for strdup/strndup just like one for malloc. Bug: 1111332 Change-Id: I5747a2c32f19bb63c0380f10f589b9a8f6dd3b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418513Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#808861}
-