- 09 Nov, 2020 40 commits
-
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/33ece0a9f897..5fa7c4e22c1b $ git log 33ece0a9f..5fa7c4e22 --date=short --no-merges --format='%ad %ae %s' 2020-11-06 wtc Quiet the find_package(libyuv) call 2020-11-06 wtc Miscellaneous cleanup 2020-11-06 wtc Fix miscellaneous comment nits 2020-11-06 wtc Remove disableGridImages from avifDecoder 2020-11-06 sorairolake apps: Add version option 2020-11-06 wtc Move assignment of header->av1C.chromaSamplePosition 2020-11-06 wtc Add #error if AVIF_CODEC_AOM_DECODE/ENCODE undefined 2020-11-06 wtc Cosmetic: Move code to be with related code 2020-11-06 wtc Change avifDecoderReadItem to take avifIO as input 2020-11-06 jdrago Add BEST_QUALITY and FASTEST upsampling filters for easier high-level control over libyuv and filters (...) 2020-10-22 jdrago Fix accidental stomp of AVIF_PLATFORM_LIBRARIES CMake variable 2020-10-22 jdrago Fix various macOS/clang build issues 2020-10-22 jdrago Expose libyuv availability to API and cmdline tools 2020-10-22 jdrago Basic libyuv support, first pass 2020-10-22 wtc Fix a crash in avifJPEGRead() on fopen() failure 2020-10-19 wtc Link with {ZLIB_LIBRARY} after ${PNG_LIBRARY} 2020-10-16 wtc Remove unneeded libs and includes for svt and aom 2020-10-15 wtc Add size_t casts to fix MSVC x86 compiler warnings 2020-10-15 jdrago Various fixes to SVT-AV1 PR #369 2020-10-15 jon add SVT-AV1 encoder Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Bug: 1136922 Change-Id: I5f6478281b769124d8f1b975b3d3dc27a70bc7f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524292 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825522}
-
Antonio Gomes authored
Dependency/include graph: - frame_header.h is included by default_frame_header.h - browser_non_client_frame_view_ash.cc includes default_frame_header.h. So, in order to free browser_non_client_frame_view_ash.cc|h from including //ash/ headers the items above will migrate step by step to //chromeos/ui. BUG=1113900 R=jamescook@chromium.org TBR=oshima@chromium.org Change-Id: I9a174c9daa9674380605805649496039d543a0d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521706Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#825521}
-
Roman Arora authored
- Change search field font to inherited one - Move shortcut text to a side in a div Bug: 1145608 Change-Id: I6e6926c9d7a6a843072950e2fd0f31eaaf0df747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521097 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#825520}
-
Mark Pearson authored
This reverts commit 96a972a1. Reason for revert: PrivateNetworkRequestBrowserTest.RecordsAddressSpaceFeatureForFetch is flaky on https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64 It failed 4 out of the last 25 builds. https://screenshot.googleplex.com/8bGbnEgxTnyrXk9 When I say failed, I mean it failed on both the original run and the re-run (i.e. failed twice in a row), which turns the bot read. The failures look like [ RUN ] PrivateNetworkRequestBrowserTest.RecordsAddressSpaceFeatureForFetch [20276:19520:1109/002722.827:ERROR:device_event_log_impl.cc(211)] [00:27:22.827] Bluetooth: bluetooth_adapter_winrt.cc:1073 Getting Default Adapter failed. ../../chrome/browser/net/private_network_request_browsertest.cc(171): error: Value of: GetAddressSpaceFeatureBucketCounts(histogram_tester) Expected: has 1 element that has a first field that is equal to WebFeature::kAddressSpaceLocalEmbeddedInPublicSecureContext, and has a second field that is equal to 1 Actual: {} Stack trace: Backtrace: `anonymous namespace'::PrivateNetworkRequestBrowserTest_RecordsAddressSpaceFeatureForFetch_Test::RunTestOnMainThread [0x00007FF66FF0A4D5+1211] (o:\chrome\browser\net\private_network_request_browsertest.cc:168) content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF673CD884D+683] (o:\content\public\test\browser_test_base.cc:770) ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00007FF673B2F126+4442] (o:\chrome\browser\chrome_browser_main.cc:1664) ChromeBrowserMainParts::PreMainMessageLoopRun [0x00007FF673B2DF05+65] (o:\chrome\browser\chrome_browser_main.cc:1033) content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF672089943+73] (o:\content\browser\browser_main_loop.cc:991) content::StartupTaskRunner::RunAllTasksNow [0x00007FF67242BE1F+61] (o:\content\browser\startup_task_runner.cc:41) content::BrowserMainLoop::CreateStartupTasks [0x00007FF6720886AC+594] (o:\content\browser\browser_main_loop.cc:905) content::BrowserMainRunnerImpl::Initialize [0x00007FF67208B38A+126] (o:\content\browser\browser_main_runner_impl.cc:130) content::BrowserMain [0x00007FF672086E9D+161] (o:\content\browser\browser_main.cc:43) content::RunBrowserProcessMain [0x00007FF6729DADC5+89] (o:\content\app\content_main_runner_impl.cc:521) content::ContentMainRunnerImpl::RunServiceManager [0x00007FF6729DBA61+849] (o:\content\app\content_main_runner_impl.cc:1008) content::ContentMainRunnerImpl::Run [0x00007FF6729DB6E2+330] (o:\content\app\content_main_runner_impl.cc:886) content::RunContentProcess [0x00007FF6729DA561+805] (o:\content\app\content_main.cc:372) content::ContentMain [0x00007FF6729DA8DE+61] (o:\content\app\content_main.cc:398) content::BrowserTestBase::SetUp [0x00007FF673CD8452+1772] (o:\content\public\test\browser_test_base.cc:605) InProcessBrowserTest::SetUp [0x00007FF673A1EFA6+398] (o:\chrome\test\base\in_process_browser_test.cc:347) [20276:19520:1109/002727.767:WARNING:pref_notifier_impl.cc(40)] Pref observer for media_router.cast_allow_all_ips found at shutdown. [ FAILED ] PrivateNetworkRequestBrowserTest.RecordsAddressSpaceFeatureForFetch, where TypeParam = and GetParam() = (5267 ms) Original change's description: > [CORS-RFC1918] Selectively re-enable broken test. > > This change enables the test except when a conflicting feature is > enabled. It improves on the status quo (test disabled everywhere) until > the underlying failure can be fixed, letting the test run on all CI bots > except for the offending Network Service bot. > > Bug: chromium:1142865 > Change-Id: I4bb870d04c6b35961c1c32d9d3549d03afeaa3f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519693 > Auto-Submit: Titouan Rigoudy <titouan@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Titouan Rigoudy <titouan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824400} TBR=mmenke@chromium.org,titouan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1142865 Change-Id: I65320686b457fcbe21211c0091abf9218a728b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528123Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#825519}
-
Daniel Cheng authored
This eliminates the need to cast the scoped enumeration to an integral type, and updates the enum to use the kMaxValue convention which allows: - clang to enforce kMaxValue correctness - autodeduction of the max value by UMA_HISTOGRAM_ENUMERATION() Bug: 742517, 1047547 Change-Id: I35c9d7cc03d15bcec530b599b459a94e4f975672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524932Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825518}
-
yjliu authored
Bug: 1147099 Change-Id: Ib8c822644ee3f12b75c585cfa07a255594974b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527842 Commit-Queue: Jun Liu <yjliu@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#825517}
-
Brian Malcolm authored
BUG=chromium:1095910 Change-Id: Ib7079bb2c2c32e3923366e95a48345745e243623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525859 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825516}
-
Cathy Li authored
Change-Id: Iff1cbc45639609b911cb3b56d72504988c5791bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526930Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#825515}
-
Bruce Dawson authored
The linux archive for bisecting of builds has not been added to since March of 2016. This leads to cryptic error messages and confusion, as seen here, when trying to debug builds since then: https://groups.google.com/a/chromium.org/g/chromium-dev/c/IHfbPh0iYwE This change adds range checking so that if the reason for a lack of sufficient builds to bisect is specifying out-of-range revision numbers there will be a helpful error message. It also adds a special-case check for linux and suggests linux64 as an alternative. Another bit of confusion in that same thread was the specifying of branch numbers instead of revision numbers. Since the ranges for these numbers do not overlap (and will not overlap in the next century) this change prints a message about revision versus branch numbers if the max_rev is less than the available bisect range. There are still an infinite number of ways of misusing bisect-builds.py but this should clean up a few of the ones which have been hit. Change-Id: I774e912fe131ae6fce360301fc053d0a3d0f9852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524293Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#825514}
-
Etienne Bergeron authored
This CL is fixing a corner case detected by the render_text_api_fuzzer. The eliding of an invalid email address is triggering a DCHECK to tail. const size_t split_index = email.find_last_of('@'); DCHECK_NE(split_index, base::string16::npos); The RenderText API is assuming a well formatted email when eliding with ELIDE_EMAIL. There is no guarantee that the user input will be formatted correctly and this can leads to strange crashes. This CL is 1) Adding support for invalid email 2) Adding unittests to cover basic cases of ELIDE_EMAIL 3) Replace the use of GetStringWidthF by GetStringWidthForText which ensures the styles/fonts (and glyph_width_for_test) are propagated R=msw@chromium.org,gab@chromium.org Bug: 1085014, 1146455 Change-Id: I669b7388b5ffa561d4585e7fbea9212c95671a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523411 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#825513}
-
Sergey Ulanov authored
1. Increased size used for input buffer collections used in decryptor and video decoder from 512kB to 1MB (see linked bug). 2. Reduced input buffer size used in the audio decryptor from 512kB to 128kB 3. Removed code that sets min_buffer_count_for_camping for input buffer collections in video decoder and decryptor. min_buffer_count is set to 2 instead. 4. Removed code that sets packet_count_for_(server|client) in the buffer constraints passed to StreamProcessor. These values are currently ignored in decoder and decryptor. Overall these changes reduce total amount of memory allocated for contiguous buffers during video playback, while allowing for larger video packets. Bug: b/172081397 Change-Id: Ieaa550fa86f8c276cc4dcb945249a364a0a2c74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519150 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825512}
-
Kenneth Russell authored
kbr leads the WebGL and khushalsagar the OOP-raster portions of this interface and should be able to approve changes to it. Bug: 1063437 Change-Id: I003cd3ab137d2768ab65cf7c0aa56b91e95d3733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524122Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#825511}
-
Alex Moshchuk authored
Previously, when LockProcessIfNeeded() was called for SiteInstances without a site, it only ensured that the resulting process has an allow-any-site lock. However, when LockProcessIfNeeded() is called on the same process more than once, such as when it gets reused by different BrowsingInstances with blank SiteInstances, this is insufficient. We also need to call IncludeIsolationContext() to inform ChildProcessSecurityPolicy of new BrowsingInstances. This is required for relanding https://crrev.com/c/2446370, where ChildProcessSecurityPolicy will start keeping track of a list of BrowsingInstances for each process, and not doing this would lead to mismatched process locks and crashes. Bug: 1135539 Change-Id: Ie7b5320cb5a2101d9685169cf6eba254178165fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523732 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825510}
-
Ionel Popescu authored
This CL updates the default background-color of the popup to transparent instead of white. Doing this we avoid having a white flash on popup open when dark color-scheme is used, as the default background color of the popup is white. For more details: http://crrev.com/c/2517730. Bug: 1114272 Change-Id: Ia9676bba7c343bd0b18f9be4ea38d94dcacc3899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525601Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Toni Barzic authored
BUG=None Change-Id: I8618a3cd47732d94ed7e43ab64cceaf6108e9c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524061Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
This CL adds an argument option to modularization LOC stat generator script so it can output the result to a specified file in json format. Also relocated the script under //tools/android. Bug: 1146478 Change-Id: I6d24b467e7ac64116461aec7780f6fb9a20da03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521982Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#825507}
-
Akihiro Ota authored
This change: 1. Adds logic to localize the practice area 2. Adds tutorial strings to chromevox_strings.grdp 3. Removes unused strings, such as those spoken after a key sequence is pressed. 4. Removes the text fields lesson, which was initially added as a proof-of-concept. 5. Removes practice area state announcements, which was also initially added as proof-of-concept. Bug: 1075752, 1143480 Change-Id: Ia564736023530b87a604d1e12164eda1ad96528a AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520168 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825506}
-
Nate Chapin authored
Merge NavigatorPresentation and Presentation, so that Presentation is the Supplement<Navigator> Simplify eager initialization from ModulesInitializer. Currently, ModulesInitializer calls PresentationReceiver::From(), which calls NavigationPresenation::presentation() to initialize the NavigatorPresentation, Presention, and PresentationReceiver. It then reads the PresentationReceiver off the Presentation and returns it, even though the return value is unused. After this CL, ModulesInitializer calls Presention::presentation(), which initializes both Presention and PresentationReceiver, and still ignores the return result. This also makes Presention explicitly aware of the conditional initialization of PresentationReceiver based on Settings. Change-Id: I4ee01f0b501eb1cb8a2c49de0ed62cfab75bd895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518761Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#825505}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I690e9976244794f766c60bd9c7ba28461cbbce9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523730 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#825504}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=bashi@chromium.org Change-Id: Id51f8577aaf6248d49a8378cbf14e97d7e69f1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526904 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825503}
-
Ali Juma authored
This deletes the SafeBrowsingAvailableOnIOS feature flag since the feature has been enabled by default and shipped to 100% of Stable. This also deletes code related to detecting WebKit-provided Safe Browsing warnings, since WebKit-provided Safe Browsing is disabled unconditionally. Bug: 1028755 Change-Id: Idae751f84aa274ffdd8b17a5660a752fa19de8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522907Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#825502}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b674f8a27725..934ac6ebdf6b 2020-11-09 gavinmak@google.com [depot_tools] Add --fork-point when computing merge-base 2020-11-09 sokcevic@google.com Set default branch in fake_repos 2020-11-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-11-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1111269,chromium:1144918 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I52c22bb41b43627128dad628dd3dec4b977af9b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825501}
-
Eric Orth authored
Another case of the apparently poor job I did adding in the malformed vairant of HttpsRecordRdata. ServiceFormHttpsRecordRdata::IsEqual() did not check if the input was malformed before casting to service form. Fix is to check before casting, and also to use the AsServiceForm() helper instead of a raw cast, as the helper has the CHECKs designed to make bugs like this obvious. Fixed: 1146873 Change-Id: I5222a09c9c032bc163ca1beebf4bf1e0504ccad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526931 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#825500}
-
My Nguyen authored
Amharic, Bengali and Burmese are still under discussion Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/8yAKy4aHVk8hLSp Bug: 889763 Change-Id: If1256942d3f57cef5c6fa563937605bf374179b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524804Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825499}
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/Bn9YsR6A6SNXmC6 Bug: 889763 Change-Id: I73c8962a041ced655bcb711f78326d2db0652c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524805Reviewed-by:
-
Fletcher Woodruff authored
OnGetNextImageResponse was deserializing the response as StartScanResponse instead of GetNextImageResponse. Somehow, this was still working, but it should be fixed. Bug: None Change-Id: I2202b34103232659ebe0157fa7578fdff5e029bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526910 Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#825497}
-
cfredric authored
The first time I was notified about ICU not being initialized, it was for the first_party_sets_parser_json_fuzzer target, which makes sense because that target did not depend on net_fuzzer_test_support, so ICU didn't get initialized for it. But when I added the manual initialization to both fuzzers, now the first_party_set_parser_fuzzer had ICU initialized twice. This could also be fixed by calling AllowMultipleInitializeCallsForTesting, but it's neater to just remove the manual initializations for both fuzzers and add the dependency to the JSON fuzzer. Bug: 1146783 Change-Id: I4f3c81ca0cf662010db3e159e226b13e09a55b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526907 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
-
Mark Pearson authored
This reverts commit e15311e1. Reason for revert: causes consistent compile failures on win64-chrome bot, starting here: Failure looks like: [3375/20246] CXX obj/chrome/installer/setup/lib/google_chrome_behaviors.obj FAILED: obj/chrome/installer/setup/lib/google_chrome_behaviors.obj c:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../chrome/installer/setup/google_chrome_behaviors.cc(27,10): fatal error: 'chrome/installer/setup/uninstall_metrics.h' file not found #include "chrome/installer/setup/uninstall_metrics.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Deprecate uninstall_metrics. > > Remove the tracking/persisting of these metrics in prefs. Removed > uploading in uninstaller. > > Bug: 1107516 > Change-Id: I84499820cea86b5f785949d9274e8b2205714aae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308133 > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825461} TBR=rkaplow@chromium.org,tommycli@chromium.org,ntfschr@chromium.org,grt@chromium.org Change-Id: I9873f0a1da27389ca4066b23e312fd3e4cefbf67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1107516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527847Reviewed-by:
-
Stephen Roe authored
Bug: 1126177 Change-Id: I081553be89d56a872b4bb6e8c08f32c1fbb3544b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422889 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#825494}
-
Thanh Nguyen authored
This CL adds Index mojom and its implementation. It also adds LinearMapSearch functions that are inherited from new Index interface. Design doc: go/lss-sandboxing Implementation plan: go/lss-sandboxing-impl Bug: 1137560 Change-Id: Ic12d6d5d93a3dddf7f34adf69041262608abeab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515422Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825493}
-
Jérôme Lebel authored
Adding WaitUntilCacheIsPopulated() before calls: * ChromeIdentityService::GetIdentityWithGaiaID() * ChromeIdentityService::HasIdentities() * ChromeIdentityService::GetAllIdentities() * ChromeIdentityService::GetAllIdentitiesSortedForDisplay() * AuthenticationService::GetAuthenticatedIdentity() * AuthenticationService::IsAuthenticated() This patch also adds the following method as an helper: AuthenticationService::WaitUntilCacheIsPopulated() This method should be temporary, and should be replace by ChromeIdentityService::RunAfterCacheIsPopulated() (or a AuthenticationService version). Design doc: http://go/async-identityservice-api crrev.com/c/2489915 Adding methods in ChromeIdentityService crrev.com/i/3353161 Implementing in ChromeIdentityServiceImpl crrev.com/c/2490110 Adding metrics crrev.com/i/3353162 Implementing the metrics => crrev.com/c/2490010 Adding WaitUntilCacheIsPopulated calls crrev.com/i/3354983 Adding DCHECK for cache state Bug: 897470 Change-Id: Iced6e7e50d704091abfe7d5b705157fe71c50ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490010 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#825492}
-
Javier Ernesto Flores Robles authored
Bug: 1138702 Change-Id: Ic2ba09f4e6eab748f93ca9aee4fc2cbd0bf70532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517993 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Daniel Cheng authored
This metric has expired. Fixed: 1072662 Change-Id: Iad422fcd3ba65a8e43da385961aaac406c5e2d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524921Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/095896a516a7..b6999d94c051 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mpearson@google.com,bcwhite@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1142577 Tbr: mpearson@google.com,bcwhite@google.com Change-Id: I21d7079ecd4bb13b64ff305957e266085f081620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525754Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Yu Han authored
Prior to this CL, the text selection color on Mac/dark mode is too dark. It doesn't provide enough of a contrast between the selected text and its background highlight color. The reason is that Chrome blends the Mac specific highlight color with white, Color::BlendWithWhite(). It adds a .6 alpha channel which results the color being too dark. The fix is to mimic Safari's logic[1] and apply a greater alpha value, making the alpha channel more transparent. Thus, the selection background color is lighter. [1] https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/rendering/RenderThemeMac.mm#L385 Bug: 1146379 Change-Id: Ib4d54f0b3dbe5c32038e10af65c644db2f4e8dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525368 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#825488}
-
Rainhard Findling authored
This CL prevents the safety check Chrome cleaner child from sending additional SC parent completion events to the UI when the Chrome cleaner status changes in the backend. Bug: 1087263 Change-Id: I80c8c2549053460e20fadd03d91deab97f4cda6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527381Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#825487}
-
Shakti Sahu authored
This CL adds 1- Handle reading list bookmark type in BookmarkId string serialization. Serialized string ids will have 'r' prefix, similar to 'p' prefix in partner bookmarks. 2- Added missing reading list type to BookmarkBridge::DoesBookmarkExist 3- Added missing reading list type to BookmarkBridge::DeleteBookmark. Bug: 1139070 Change-Id: If34fc167ad5d92f22e13f941f55a04f9bea2bd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524704 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825486}
-
Vincent Boisselle authored
This is experimental code gated behind a feature flag. We may decide to not proceed with the experimentation but we at least want the code in M88 just in case. Change-Id: Icb2263a48ac35f071f2bd857aaa2e6bc0a38d7bb Bug: 1146458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522914Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#825485}
-
Brian Sheedy authored
Fixes Skia Gold triage links and test failures being associated with all tests in a batch, instead only associating them with the result for the particular test that produced the bad image. This is handled by including the full test name in the JSON that gets pulled from the device, then using that in the test runner to look for matching results to modify. Bug: 1146498 Change-Id: I5cad7333aa69332f3e46165a6a73c25a0aa6266f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521249Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825484}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202011090600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/pWeqsIGRIui0WPD3a7xaKASeJ10P8A3jGHGdlGXx0loC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159960286 Tbr: help-app@grotations.appspotmail.com Change-Id: I17b68f955d7ffceae60e8173e9c00fc16a67a732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525864Reviewed-by:
-
