- 07 Nov, 2019 40 commits
-
-
Ahmed Mehfooz authored
Bug: 1021639 Change-Id: If65812f8a2d961f88fc66c9b060671e7b7d8e8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900293Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#713291}
-
Theresa Wellington authored
Move android_chrome_strings.grd to its own separate build target and merge ui widget strings back into android_chrome_strings.grd. BUG=1002534 Change-Id: I179e2d74ba8dc169574fd2596915067ebb357787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895971Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#713290}
-
Chris Lu authored
The banner should not be dismissed if the Infobar's action has not finished. This is because Infobars that have a non-instantaneous action will persist the banner until completion. Bug: 1014959 Change-Id: I3b9a442c60163a29ef37ec6a1e39ae66734e74d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900136 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#713289}
-
Junbo Ke authored
Bug: b/143499157 Test: CQ Merge-With: eureka-internal/332932 Change-Id: I98b2331231a85c84dda4f894bf5336fae37a16af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894298Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#713288}
-
Zhongyi Shi authored
The QuicChromiumPacketReader upon finishing the socket read, will dereference the socket to get local and peer addresses and report packet back to the visitor unconditionally even if the connection is closed. The patch landed in crrev.com/c/1900569 nulls out the socket upon connection close, leading to null dereference when fetching local and peer addresses. Bug: 1014092, 1021938 Change-Id: I9af79f03b3e2ffbe1ed036af8980efa6b6d1478c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901946 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#713287}
-
Marina Sakai authored
Remove a macro-generated function for a private property of MessageEvent and all the macros in v8_private_property.h This CL removes a macro-generated function for a private property of MessageEvent, and replaces it with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol. Now we can remove all the macros in v8_private_property.h. Bug: 715418 Change-Id: Id4ce8e9cc45deea7e9e8bf2064bc44b8559cc0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899227Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Marina Sakai <marinasakai@google.com> Cr-Commit-Position: refs/heads/master@{#713286}
-
Anupam Snigdha authored
Display attributes may not be available for all compositions so added a null check to avoid crashes in ui::TSFTextStore::GetDisplayAttribute while querying for attribute info using ITfDisplayAttributeInfo object. Bug: 1017313 Change-Id: Icac383a03729ba62cca0b45a67c324eb359e2283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902111Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#713285}
-
Alan Cutter authored
This text used to be for a model dialog but is now used by a bubble. Bubble dialogs don't use title text on any platform. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=419504&signed_aid=U0mvxY1dLrVi4TEDJKYtrA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=419505&signed_aid=_YtJNSAFtjqMsLVgd1Foqg==&inline=1 Fixed: 1020310 Change-Id: Ia613fe934041fec7326550d8a438a4ab07f0d4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898905 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#713284}
-
Rahul Arakeri authored
This CL deletes this VirtualTestSuite because it is not a configuration that is shipped on Windows or Linux. This config is run only on Mac which already has coverage. Bug: 1022096 Change-Id: Ia54bbd71c458c51fdbbe058c7564801f62b28afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901640Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#713283}
-
Sajjad Mirza authored
This fixes link-time undefined symbol errors that occur because the Clang profiling runtime uses symbols from the C runtime. Bug: 1020445 Change-Id: Ic7b1f9cb970ff26592a934675ee5bc204249f4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896238Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#713282}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6072d056a7cb..322220a0b205 git log 6072d056a7cb..322220a0b205 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 timvp@google.com Vulkan: Ignore VK_INCOMPLETE from vkGetPipelineCacheData Created with: gclient setdep -r src/third_party/angle@322220a0b205 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Ia934d70c5748bc80c845e831afde719855b76709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902082Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713281}
-
Michael Spang authored
This shouldn't be necessary any longer; it was fixing small errors introduces by computing rotations using trig functions. Bug: 1019015 Change-Id: Ia6c273454f96c556f34d0adca391eb0e121a98b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885635 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#713280}
-
Erik Chen authored
We only need to run these checks once. We run them on android_compile_dbg because that's the fastest cycling builder. Bug: 1020704 Change-Id: I0a088dbf23c23fd56ce82b457ed70c73297ae1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900921 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#713279}
-
Oksana Zhuravlova authored
This change removes the DocumentInterfaceBroker mojom interface and all related plumbing. No functional changes since the interface was not used by anything (clients migrated to BrowserInterfaceBroker). TBR=tommycli@chromium.org,rbpotter@chromium.org,arthursonzogni@chromium.org,kenrb@chromium.org,alexmos@chromium.org,rdevlin.cronin@chromium.org,haraken@chromium.org Bug: 985120 Change-Id: I893f940bc2c5d237aac5fb6b3962c06bfa98e938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881394Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#713278}
-
Natalie Chouinard authored
Move Download Location feature-specific methods from PrefServiceBridge to the dedicated DownloadLocationDialogBridge as static methods. Bug: 1016957 Change-Id: I513fe4a6919754305fc19568b8149d01069bbd4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898508 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713277}
-
Etienne Pierre-doray authored
This extract parts of CFIBacktraceAndroid into a dedicated utility class for parsing Chrome CFI tables. This is meant for direct use by ChromeUnwinderAndroid to eventually replace CFIBacktraceAndroid. CFIBacktraceAndroid originally implements caching of recent entries. This was ditched in this CL for simplicity and might be re-introduced in a follow-up if performance/memory is an issue. This CL does not attempt to reuse the extracted reader implementation in CFIBacktraceAndroid, in order to avoid introducing bugs in StackUnwinderAndroid due to the differing implementations. Bug: 989103 Change-Id: I3a34d55c7b61d336dd998ac8d863af9f041dab59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872838Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#713276}
-
Kai Ninomiya authored
Prepares us to roll the vertex state CTS changes along with the vertex state changes in Dawn and Chrome. TBR: enga@chromium.org Change-Id: I5ed5eebdff7d8e7559b0044686caacea9defd850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902131Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#713275}
-
Clark DuVall authored
The classes were renamed in http://crrev.com/c/1898536, this just cleans up the variable names and references in comments. Also removes NewBrowserCallbackProxy.java which was replaced by NewTabCallbackProxy.java. Change-Id: Id84989f5fb603fe521ff22f959156c8993236abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902530Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#713274}
-
Steven Bennetts authored
Bug: 965089 Change-Id: I659a95d604806bf7cf0305206e1239010253521b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875384 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713273}
-
Natalie Chouinard authored
Migrate some simple feature-specific getters/setters to use the generic feature-agnostic methods instead. Bug: 1016957 Change-Id: Ia37263b9e66c99bab8ebce3385d71d4308a9b0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898390Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#713272}
-
Ana Salazar authored
This change will allow users to use the mousewheel to scroll over the contents of the scrollable shelf. Bug: 1018016 Change-Id: I949eb241a74be365b0a366f56c59cba04ce6099b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901354Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#713271}
-
Avery Musbach authored
The present CL is a new way to serve the same purpose as [1]. As SplitViewDragIndicators::WindowDraggingState has values called kFromOverview and kFromTop, I think it is most intuitive to add one called kFromShelf, with the caveat that the difference between kNoDrag and kFromShelf is all about animations. Compared to [1], I think it is nice to avoid adding a whole extra member variable. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1894754 Test: ash_unittests DragWindowFromShelfControllerTest.SplitViewDragIndicatorsWindowDraggingStates Test: ash_unittests SplitViewDragIndicatorsTest.SplitViewDragIndicatorsVisibility Fixed: 1020349 Change-Id: I69aefae3a68579d2f0d0c61a8d8f5588689d0b13 Bug: 1020349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898771 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#713270}
-
Luum Habtemariam authored
The new CupsProxyService adds more libCUPS dependent code to Chrome, but it doesn't look like any of the trybots currently run them. This change combines the new tests into a new target set to run in the ChromeOS VM trybot (chromeos-amd64-generic-rel). Bug: chromium:945409 Test: trybot runs and passes Change-Id: I4ef5724a3d4b0923fba3abcd7fde8bb744209c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797002Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#713269}
-
Miguel Casas authored
This CL continues crrev.com/c/1897358 by substituting LOG_ASSERT()s in test code with ASSERT_TRUE()s, avoiding crashing the test binary. m/g/t/video_frame_validator.cc is an easy one-to-one substitution, whereas video_frame_helpers.cc need to add a macro to return an invalid value when the predicate doesn't hold up. Bug: 1020776 Change-Id: I8e0671dce792b479c91c722c652bd387f4cd5faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900559Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#713268}
-
Yuchen Liu authored
This reverts commit 3fe28bd3. Reason for revert: Break Android. Revert to unblock internal CQ. Original change's description: > [chromecast] Enable new QueryableData bindings on Linux > > Set the new QueryableData JS bindings feature on. > > Bug: internal b/138623432 > Test: E2E manually test > Change-Id: Ia1a3e4f650aeabee3aae90f9e764a63c2d9213b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891738 > Auto-Submit: Jiawei Li <lijiawei@chromium.org> > Reviewed-by: Yuchen Liu <yucliu@chromium.org> > Commit-Queue: Jiawei Li <lijiawei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711043} TBR=yucliu@chromium.org,lijiawei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: internal b/138623432 Change-Id: I798ac7fbf55e16597347748ba7f2c4af4156761c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902710Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713267}
-
John Abd-El-Malek authored
The script to generate Java versions handles both cases. Change-Id: I6ae9373da9658a6c509ad1dd473cd8e4cfc1f3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902517 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713266}
-
Akihiro Ota authored
This change refactors Output.format_ to take a parameters object. This helps maintain code readability in instances where optional parameters need to be passed in. Change-Id: I3e24f9d809b745aaef1bef16d376a16c35742a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820044 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#713265}
-
Marc Treib authored
Bug: 1021147 Change-Id: Iaa557f133ba9f4d517bac952ba2d7807915b31d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900987 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#713264}
-
Anand K. Mistry authored
Bug: 1007813 Change-Id: I0fbb86cd6d2fae4e9a8d2ead2079a706c8e57ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898157Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#713263}
-
Ahmed Fakhry authored
This CL makes the following changes: - Tab scrubbing will always use 3-finger gestures. - 4-finger horizontal swipes will switch desks only if the flag "--enable-virtual-desks-gestures" is enabled. - 3-finger horizontal swipes while in Overview will always move the highlighter. This CL is meant to be merged back to M-79. A follow-up CL will remove the "--enable-virtual-desks-gestures" flag entirely on M-80, so that virtual desks gestures will always be enabled going forward. BUG=1005340 TEST=Tested manually on device, updated existing tests. Change-Id: I1316e150556a4f2ede79b41dab8ddc3402d39370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902232 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#713262}
-
Patrick Monette authored
Bug: 1021600 Change-Id: I8501d63d719194685281e27d85342e807e3794cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895897 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#713261}
-
Rob Schonberger authored
Adds a configuration into model configuration to allow a model to have the radius transformed. Intention is that a model is customized per device depending on the characteristics of the device being executed on. Updates unit test appropriately, and also remove the former approximate for radius conversion. Bug: 1009290 Change-Id: I80e0160302a98ad8564ac73b0bb07f1ab8327467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900516 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713260}
-
Manas Verma authored
Previously, the verify pending dialog would only be shown if Unmask Details did not return on time. This CL ensures that it is always shown for an opted-in user. Bug: 949269 Change-Id: Ieb5d63be16e163d95c0be3de1141180eb6b9b3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902073Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#713259}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b54d7ad71425..762f11932e24 git log b54d7ad71425..762f11932e24 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 tsepez@chromium.org Fix 64-bit arithmetic in sha2 variants. 2019-11-06 thestig@chromium.org Avoid crashes in FPDFText_GetCharBox(). 2019-11-06 tsepez@chromium.org Document obsolete FPDF render flags. Created with: gclient setdep -r src/third_party/pdfium@762f11932e24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: If547184b0b0992e505455a72b921e2e72499741c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902238Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713258}
-
Gary Kacmarcik authored
This adds a command line switch to the NativeMessagingHost to have it query for the OS permissions required for the Host to work. Currently, this option simply queries the current permissions and returns true/false, but follow on cls will replace this with a proper Wizard UI to walk the user through the process of granting these permissions. Change-Id: Id805f072b9bba1721728ed2ba848fd9ba51e9a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900132 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#713257}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iff6bc40b6dd230254d4fd8be16e1e137660419b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902606Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713256}
-
Torne (Richard Coles) authored
Load the implementation of WebLayer using WebViewFactory by default. This requires that the currently selected WebView implementation is the WebLayer implementation you want to use. If the client APK specifies a package name in the metadata tag, it will be used as the implementation instead, but this is only intended for testing and does not use the exact same loading mechanisms. Change-Id: Id12d13a1b49f718bb7c6bc6dbedb848a37f74355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869296 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#713255}
-
Peter Boström authored
This roughly halves(!) the number of active layers (per Compositing.Browser.NumActiveLayers) on platforms where FocusRings are enabled (Mac). This is due to FocusRing previously always painting on layers regardless of there being anything to draw or not (e.g. it was always an early return in ::OnPaint rather than preventing the layer paint). Bug: chromium:924232 Change-Id: If7b9fcfa2f24b42f2c9b2e86b1b2f1543908b7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902066 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#713254}
-
Caroline Rising authored
Change-Id: If7e4fbbdd337fffd110065b530a2e5d7d0c00eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900394Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#713253}
-
Alexey Baskakov authored
Add follow up tests for this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1797824 (Init, GetData, Identities). In next CL: Add more WebAppSyncBridge unit tests. Bug: 860583 Change-Id: Ifb7f0a66b78867ba7618a911de2847c4cc75752a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900523 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#713252}
-