- 17 Aug, 2018 40 commits
-
-
Tibor Goldschwendt authored
Bug: 862694 Change-Id: I4ab7cb60c8e397964f88449c31ff4fd0d6f4e253 Reviewed-on: https://chromium-review.googlesource.com/1173252Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584070}
-
Robert Ma authored
In https://crrev.com/c/833751 we stopped to create new baselines for testharness.js tests without existing baselines. This behaviour is in fact undesired: if a testharness.js test used to pass (and hence didn't have a baseline), we'd like to be able to create a new baseline for it using --reset-results if it starts to fail. The comment is improved so hopefully that is clear enough. Bug: 864410 Change-Id: I9b21a6e8d909585f8eb44e53dd90b488f383ea1a Reviewed-on: https://chromium-review.googlesource.com/1179363 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584069}
-
Friedrich Horschig authored
The test that used to be disabled on Win only is now disabled on Mac as well. Recent flake: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14961 Flakiness dashboard confirming the flakiness: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=components_unittests&tests=SslCastSocketTest.TestConnectEndToEndWithRealSSL TBR=wjmaclean@chromium.org Bug: 874491 Change-Id: Ida63c17fc4618d1944f947c3fcf0a0247bc04d57 Reviewed-on: https://chromium-review.googlesource.com/1179882Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584068}
-
Fredrik Söderquist authored
The 'params.name == HTMLNames::classAttr' condition will never be true, because the if-block just above it will catch that case. The |class_name_| SVGAnimatedProperty object is registered in the attribute map. Retain and update the comment about the somewhat special handling of the 'class' attribute. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9928fb6f9c29d5db961b7f937fe4b1c0fb3fde82 Reviewed-on: https://chromium-review.googlesource.com/1179749Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#584067}
-
Fabio Tirelo authored
This DCHECK is sometimes hit for the password popup on DCHECK enabled windows canary asan builds, and it shouldn't exist. Returning a default value instead. Bug: 874062 Change-Id: Ib5be385fb9108aadd8cba09bf587a61ff097cea5 Reviewed-on: https://chromium-review.googlesource.com/1174896Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#584066}
-
Justin Donnelly authored
Note that I'm omitting the URL elision experiment (OmniboxUIExperimentHideSteadyStateUrlSchemeAndSubdomains). That seems to have broken a few browser tests, so tommycli is going to fix them and add it to the testing config in a later CL. Bug: 854714, 806995, 824893 Change-Id: I99b79d22ee5f1a3df0ec780a4283c7211f107a12 Reviewed-on: https://chromium-review.googlesource.com/1176391Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#584065}
-
Domenic Denicola authored
This CL updates the implementation and tests to be adapted versions of https://github.com/domenic/async-local-storage/tree/73580d0151f04849ca9e691807907e95c4d17d12/prototype. Change-Id: I9071883a6fef8ef97c405a9a749bf9c2d3cfb58a Reviewed-on: https://chromium-review.googlesource.com/1171573Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584064}
-
Friedrich Horschig authored
Another recent flake was in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/1633 TBR=sahel@chromium.org Bug: 869726 Change-Id: I8822f4fb53a2c762ddbb46f66ba307b3803b765d Reviewed-on: https://chromium-review.googlesource.com/1179836Reviewed-by:
-
Jeffrey Cohen authored
Bug: 864612 Change-Id: I353668033e7144714fdfc8327f9cd46962e0b22c Reviewed-on: https://chromium-review.googlesource.com/1176737Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
It's not used. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If6630b2e404108044833ea5512151facdfe7e59d Reviewed-on: https://chromium-review.googlesource.com/1179760Reviewed-by:
-
Tonko Sabolčec authored
This CL includes: - Add a util class which sets the preference on the main thread. - Use utility class in LoginDatabase to set the date on successul deletion of undecryptable passwords. - Expand DB tests to make sure that the pref is stored. Bug: 791541 Change-Id: I32c2afc70c6091175cae09a7120de7622b568448 Reviewed-on: https://chromium-review.googlesource.com/1178052 Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#584060}
-
Jerry Lin authored
This fuzzer passes fuzzed message |PasswordRequirementsSpec| to function |GeneratePassword|. The random choices inside the function are still random and not replaced by the fuzzed input. R=vabr@chromium.org Bug: 847200 Change-Id: I221fe286328d5818bd50282046799e8930079298 Reviewed-on: https://chromium-review.googlesource.com/1120088Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584059}
-
Robert Ma authored
No-Try because the test hasn't been imported. TBR to unblock the importer. TBR=foolip No-Try: True Bug: 875249 Change-Id: I3a799b9aa326f59422ef60218e53c6cbdb932792 Reviewed-on: https://chromium-review.googlesource.com/1179811Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#584058}
-
Leonard Ge authored
This CL is a follow up CL of CL: 1174721. So we don't add field trial flag when the new compatibility mode flag is set. Bug: chromium:866881 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I5dae5a130445b9c61ad40cb13744a6272947424b Reviewed-on: https://chromium-review.googlesource.com/1175127Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Leonard Ge <wangge@google.com> Cr-Commit-Position: refs/heads/master@{#584057}
-
Tommy C. Li authored
Currently, if the user has unelided the URL, the URL won't reset on navigation. Instead, we should only only preserve the URL if the user has actually made modifications, rather than merely uneliding the URL. Bug: 875002 Change-Id: Ie138ee9a0b4cf7d7d903d600a739deb2378de29c Reviewed-on: https://chromium-review.googlesource.com/1178631Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#584056}
-
Friedrich Horschig authored
Adding another test to the pile of flaky test in this file. See bugs for recent failures. TBR=sahel@chromium.org,dtapuska@chromium.org Bug: 836996, 875186 Change-Id: Ie8b3565a9f785304f60ca2e2dac1c6ff77f30fb4 Reviewed-on: https://chromium-review.googlesource.com/1179827Reviewed-by:
-
Friedrich Horschig authored
This is a known issue but the expectation was (as assumed) missing in this file: https://crrev.com/c/1074907 TBR=caseq@chromium.org Bug: 847114 Change-Id: I94ea44f67d95b0aee83745980a3b221dec79b677 Reviewed-on: https://chromium-review.googlesource.com/1179759Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/aea32f9d6ad3..adc48799090c git log aea32f9d6ad3..adc48799090c --date=short --no-merges --format='%ad %ae %s' 2018-08-17 phoglund@webrtc.org Make sure video_capture_tests run sequentially. Created with: gclient setdep -r src/third_party/webrtc@adc48799090c The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I97703dc019c4117946fb76f53e6c0bab863686e9 Reviewed-on: https://chromium-review.googlesource.com/1179330Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584053}
-
Antonio Gomes authored
BUG=714018 Change-Id: I59944400286435c71ed605ba019cd7f2680e5532 Reviewed-on: https://chromium-review.googlesource.com/1174656Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#584052}
-
Valeriya Sinevich authored
Change-Id: I7ad08f099b3d1901575b465fbd9bcfe46911ca7e Reviewed-on: https://chromium-review.googlesource.com/1170690 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#584051}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3d85a23b6c18..c7e7bd382c39 git log 3d85a23b6c18..c7e7bd382c39 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 anthonyalridge@google.com Create a bar chart for data grouped by story. Created with: gclient setdep -r src/third_party/catapult@c7e7bd382c39 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I91249ff753976f235acabbc1869206a2b6c9afc1 Reviewed-on: https://chromium-review.googlesource.com/1179333Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584050}
-
Peter Wen authored
This is a bug that is already fixed in upstream apkanalyzer but not yet released and rolled in the various downstream projects and ultimately into Android SDK Tools (eventually). Bug: 874994 Change-Id: I9c83b6ee35c5691f687e174b3213ca7e71a9ea2c Reviewed-on: https://chromium-review.googlesource.com/1178687 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#584049}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates WebRtcEventLogUploaderImpl et al away from URLFetcher. Note that this CL slightly changes the flow of the WebRtcEventLogUploader code. Previously, an URLRequestContextGetter instance was acquired on UI thread, passed to the IO-capable task runner, used there, and ultimately deleted either on the UI thread or on the IO-capable task runner thread, depending on the termination circumstance (eg BrowserProcessImpl shutdown or upload completion, respectively). However, URLLoaderFactory and SimpleURLLoader have stricter threading restrictions than URLFetcher and URLRequestContextGetter. For instance, a SharedURLLoaderFactory instance needs to be created, used and deleted on the same thread. Given this scenario, a natural approach to tackle this migration would be the use of CrossThreadSharedURLLoaderFactory{Info} classes. However, as mentioned earlier, the fact that WebRtcEventLogUploader instances are constructed the aforementioned IO-capable task runner thread and the deletion thread varies, make the use of CrossThreadSharedURLLoaderFactory{Info} less straightforward. This CL makes use of the thread agnostic network::mojom::URLLoaderFactoryPtrInfo class instead: from the IO-capable task runner it posts a message to the UI thread to bind a network::mojom::URLLoaderFactory object. As per the mojo documentation [1]: "Once the LoggerPtr is bound we can immediately begin calling Logger interface methods on it, which will immediately write messages into the pipe. These messages will stay queued on the receiving end of the pipe until someone binds to it and starts reading them." [1] https://chromium.googlesource.com/chromium/src/+/master/mojo/public/cpp/bindings/README.md#Binding-an-Interface-Request BUG=773295,873187 Change-Id: Ic29222ea63e90dcb26f3124bdea1c627570dc04d Reviewed-on: https://chromium-review.googlesource.com/1171622 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:Elad Alon <eladalon@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#584048}
-
Julie Jeongeun Kim authored
It moves the code to read the data from FD to 'ReadDataFromFD' in WaylandDataDevice to reuse it for drag-and-drop, as WaylandDataDevice is the class to handle not only copy-and-paste but drag-and-drop and drag-and-drop needs to read the data from FD as well. It doesn't bring behavioral changes. Bug: 578890, 875164 Change-Id: I460ab9df2b4d32bbdb0e71c753cb19c572df12ab Reviewed-on: https://chromium-review.googlesource.com/1179505Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#584047}
-
Greg Thompson authored
Google Update and Chrome use Chrome's ClientState key as a bucket for holding data and to communicate with one another. In general, HKLM is used for system-level installs and HKCU is used for per-user installs. GoogleUpdateSettings was looking in both hives for values, which can lead to incorrect values being used. This CL tightens up accesses so that only the correct hive is used for each value. This CL also updates some of the implementation to use install_static instead of BrowserDistribution, which is deprecated. Finally, some dead code has been removed. BUG=none R=rogerta@chromium.org Change-Id: I0d70042e2d70d9d33e9eb8c2f5e846e35d5d0634 Reviewed-on: https://chromium-review.googlesource.com/1179743Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#584046}
-
Tonko Sabolčec authored
Bug: 791541 Change-Id: Ibf11c698d40b29299510f73e8a6b308c618d506b Reviewed-on: https://chromium-review.googlesource.com/1178284Reviewed-by:
-
Valeriya Sinevich authored
Now CookieManagerService inherits from TokenServoice::consumer and can fetch access tokens. Change-Id: I0329257b9cb5908576beb7dae7b938c0d39cd487 Reviewed-on: https://chromium-review.googlesource.com/1169816 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/92f1422f..4e86b694 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I515b7c2224ec22db8d24f9cb2fecdaefce6b22ae Reviewed-on: https://chromium-review.googlesource.com/1179802Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584043}
-
Christopher Grant authored
Use of the material design controller in VR is generating crashes. Its use was likely unintentional. BUG=874552 R=jdonelly Change-Id: Id10449ebe736c3217fd4559c1b941d6e45404214 Reviewed-on: https://chromium-review.googlesource.com/1178963Reviewed-by:
-
Balazs Engedy authored
This CL also delays creating the AuthenticatorRequestDialogModel and showing the dialog until after ChromeAuthenticatorRequestDelegate's OnTransportAvailabilityEnumerated is called, plus renames Step::kInitial to ::kWelcome. Bug: 847985 Change-Id: I3b46781ccea0309e1efc7c3fec45cbe4c43e9017 Reviewed-on: https://chromium-review.googlesource.com/1175120 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584041}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2ae6f8e569a3..c6b2cf82b09b git log 2ae6f8e569a3..c6b2cf82b09b --date=short --no-merges --format='%ad %ae %s' 2018-08-16 bridgwater@google.com Update URL for GN quick start guide. Created with: gclient setdep -r src/third_party/perfetto@c6b2cf82b09b The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I2a826cebe51ae015928e18c3e51462136ab5d4f2 Reviewed-on: https://chromium-review.googlesource.com/1179331Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584040}
-
Hans Wennborg authored
These were created following the instructions from https://chromium.googlesource.com/chromium/src/+/master/docs/win_order_files.md using Chromium #584022. Bug: none Change-Id: I01b4fc550f237091c2486194edf6c0dc7ea1387b Reviewed-on: https://chromium-review.googlesource.com/1179755Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#584039}
-
Maja Kabus authored
Created new dictionary TrustedTypePolicyOptions with callbacks and adjusted TrustedTypePolicyFactory and TrustedTypePolicy to accept the dictionary. Added createURL() and createScriptURL, and adjusted createHTML() in TrustedTypePolicyOptions. Bug: 739170 Change-Id: Ie63fdf90b5aac53188fcd8141c95d287c3e726fd Reviewed-on: https://chromium-review.googlesource.com/1167282Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Maja Kabus <kabusm@google.com> Cr-Commit-Position: refs/heads/master@{#584038}
-
vitaliii authored
Delete .cc files of UserEventService and ConsentAuditor interfaces. Change-Id: Ic5f19f38b65359365dde91441e95426c0fafcd08 Reviewed-on: https://chromium-review.googlesource.com/1135310Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#584037}
-
Oriol Brufau authored
They should be allowed like the physical border colors. Spec: https://drafts.csswg.org/css-logical/#border-color Spec: https://drafts.csswg.org/selectors/#visited-pseudo BUG=860313 TEST=fast/css/css/logical-box-border-color-visited-001.html TEST=fast/css/css/logical-box-border-color-visited-002.html TEST=fast/css/css/logical-box-border-color-visited-003.html Change-Id: I20967bf4b00716e5c4ec2bac2e3781c81cdaa688 Reviewed-on: https://chromium-review.googlesource.com/1178043 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#584036}
-
Peter E Conn authored
State was getting slightly out of sync with the following sequence of events: 1. Open a TWA to a non-verified origin. 2. Navigation finishes, we notice and disable TWA UI. 3. finishNativeInitialization occurs, which is where we initially try to show the Disclosure Snackbar. Bug: 871266 Change-Id: Iaf152b49de18cf22eca90b61df570e582dd2a435 Reviewed-on: https://chromium-review.googlesource.com/1179680Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#584035}
-
Rakina Zata Amni authored
Currently scoping (searching for all find matches) is done in 100ms chunks and uses timers. We want to make it use idle tasks instead to ensure this doesn't block important tasks. Bug: 868227 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iaa9f40580fe5c69af398ae43a339d06305767503 Reviewed-on: https://chromium-review.googlesource.com/1152710 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584034}
-
Friedrich Horschig authored
Marking some idlharness tests flaky as they have been the main point of failure on a significant amount of Linux tests. Tbr: mgiuca@chromium.org Bug: 873045 Change-Id: I798aeeadde74b34b458b8d05862dde5535a37d41 Reviewed-on: https://chromium-review.googlesource.com/1179750Reviewed-by:
-
Leszek Swirski authored
Posted blocking ScriptStreamer tasks can end up in a queue, and have their Resource complete loading before the task even starts. When this happens, these tasks will no longer block on network input, but they will still be posted to the blocking task runner, which does not spin up new threads if the running task is not blocked. When there are a lot of small functions posted for streaming, this results in a slightly paradoxical starvation, where the blocking task runner is processing lots of no-longer-blocking tasks all in one thread, as it has no reason to spin up new threads. To avoid this, if a streaming task isn't started before the resource finishes loading, we can cancel this posted task, and instead post a new non-blocking task to the non-blocking thread pool. This frees up the blocking task runner to process only blocking tasks (and thus allows it to spin up new threads for them). TBR=kouhei@chromium.org Bug: chromium:865098 Bug: chromium:866868 Change-Id: I930b10d23fd538b3529ab3a31f6caba13a8661fb Reviewed-on: https://chromium-review.googlesource.com/1179744Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#584032}
-
Hans Wennborg authored
Clang and the macOS SDK are starting to drop support for targeting versions before 10.6. Bug: 874997 Change-Id: Id3ac6b42f49e0cdb28f85f127fb41305ba1af4cb Reviewed-on: https://chromium-review.googlesource.com/1179748Reviewed-by:
-
