GitLab

Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/418333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285591 0039d316-1c4b-4281-b951-d872f2087c98

This was something that was missed as part of this review:
https://codereview.chromium.org/352173005/

BUG=
TBR=mad
NOTRY=true

Review URL: https://codereview.chromium.org/420713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285590 0039d316-1c4b-4281-b951-d872f2087c98

Partially reverts crrev.com/284112 by moving the verifier test from unit_tests target back to browser_tests, because of trust information leaking between test cases.

BUG=396497

Review URL: https://codereview.chromium.org/419213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285589 0039d316-1c4b-4281-b951-d872f2087c98

This CL turns const by value return values into const by ref.

Replacing const value by a const ref when a member variable is returned is safe, because the member variable will live at least as long as the temporary object returned now. It can also be more efficient, because returning a ref can spare copying.

BUG=393155

Review URL: https://codereview.chromium.org/416373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285588 0039d316-1c4b-4281-b951-d872f2087c98

LabelButton's GetPreferredSize() gets called a lot, and it's pretty
expensive (creates a temporary label every time). To make it less sucky, we
should cache its last computed size and reuse that, just like Label does.

BUG=373906

Review URL: https://codereview.chromium.org/371633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285587 0039d316-1c4b-4281-b951-d872f2087c98

The CT verifier is needed in the off-the-record profile to
do SCT validation. Currently the CT verifier is stateless
so it is safe to share it with the OTR profile.

BUG=395648

Review URL: https://codereview.chromium.org/411333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285584 0039d316-1c4b-4281-b951-d872f2087c98

The password entry field in user pods should always have a white
background color, even if it is disabled.

BUG=396008
TEST=Manual

Review URL: https://codereview.chromium.org/409093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285583 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285582 0039d316-1c4b-4281-b951-d872f2087c98

This change makes the CLD2 header files ok to use regardless of whether or not
the CLD2_DYNAMIC_MODE define is set when including them. No-op implementations
have been added to the C++ code in CLD2 for the cases where client code
incorrectly calls dynamic-mode methods with a non-dynamic build of the library.
This allows including projects (such as Chromium) to opt for runtime checks
instead of compile-time checks when dealing with CLD2, which in turn greatly
simplifies the build logic for code that depends on CLD2.

BUG=367239
TBR=toyoshim

Review URL: https://codereview.chromium.org/422493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285581 0039d316-1c4b-4281-b951-d872f2087c98

Currently, destroying a ui::TouchEvent removes its tracking id from the slot mapping. Because MenuEventDispatcher::DispatchEvent was creating
(and destroying) a touch event, the tracking id was being
removed too early.

This patch refcounts the tracking ids, so the tracking id won't be removed until it should be.

BUG=394437

Review URL: https://codereview.chromium.org/400213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285580 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100538
TBR=yurys@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/419813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162783

Review URL: https://codereview.chromium.org/400873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285578 0039d316-1c4b-4281-b951-d872f2087c98

Disable WindowAnimationsTest.LockAnimationDuration and WindowAnimationsTest.HideShowBrightnessGrayscaleAnimation under Dr.Memory

BUG=397478
TBR=earthdok@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/416993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285577 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285576 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

BUG=N/A
R=xians@chromium.org

Review URL: https://codereview.chromium.org/417943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285575 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285574 0039d316-1c4b-4281-b951-d872f2087c98

Leave a note about suppressing data races in TSan v2.

BUG=351259
TBR=bruening@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/416363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285573 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178912:178923&mode=html
TBR=haraken@chromium.org,jchaffraix@chromium.org
BUG=

Review URL: https://codereview.chromium.org/423463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285572 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350377

Review URL: https://codereview.chromium.org/404353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285571 0039d316-1c4b-4281-b951-d872f2087c98

Three-sided patch:
[1] Blink: https://codereview.chromium.org/409403002
[2] Chromium: reuse a ServiceWorkerHandle
[3] Blink: https://codereview.chromium.org/411863003

BUG=395928

Review URL: https://codereview.chromium.org/412833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285570 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285569 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/0925a5784c8424e3f9d75dbf4612ada12dc37131..75770afff8cdcd77ddb594a68de71f2b6f5cd393

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/423433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285568 0039d316-1c4b-4281-b951-d872f2087c98

Shows the enroll button when the device is not enrolled, and shows the unenroll
button when the device is enrolled.

When the enroll button is clicked, sets a variable in the local state and
reboots.

TEST=maunally test the settings page.
BUG=chromium:353050
R=bartfab@chromium.org

Review URL: https://codereview.chromium.org/405383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285567 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through source and header files.
2) Rename data member variables to use unix_hacker_ style.
3) Rename methods to use CamelCase style.
4) Rename file name to mock_spell_check.

BUG=331299

Review URL: https://codereview.chromium.org/410283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285566 0039d316-1c4b-4281-b951-d872f2087c98

Instead, app_list::OmniboxProvider is responsible to set true to SearchTermsArgs::from_app_list.

BUG=388515

Review URL: https://codereview.chromium.org/399063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285565 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [WebSocket] Send a close frame when the renderer process is gone. (https://codereview.chromium.org/390773002/)

Reason for revert:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/5350

Original issue's description:
> [WebSocket] Send a close frame when the renderer process is gone.
> 
> Renderer processes may die without clearing its |WebSocketBridge|s.
> It is helpful to send a close frame with code = 1001 in such a case.
> 
> BUG=392534
> R=ricea@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285557

TBR=ricea@chromium.org,jgraettinger@chromium.org,eroman@chromium.org,mmenke@chromium.org,yhirano@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392534

Review URL: https://codereview.chromium.org/416333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285564 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=jianli@chromium.org (for notifications_api.cc)

Review URL: https://codereview.chromium.org/415143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285562 0039d316-1c4b-4281-b951-d872f2087c98

During StartAnimation first it does a search for all animations which are
running and starting. After that it again searches the entire animation
list for animations waiting for target availability.

This patch reduces this search (for loops) by keeping track of the
animations waiting for target availability in the first search itself.


BUG=396562

Review URL: https://codereview.chromium.org/408833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285561 0039d316-1c4b-4281-b951-d872f2087c98

Having a RequestAnimationFrame API on CommandBuffer makes no sense - the
context itself has nothing to do with scheduling and may not even be
swapping onscreen.  The spinning cube app was using this API as a way to
get delayed tasks without depending on base - basically
posttask-via-mojo-message. This adds basic delayed task support to the
public RunLoop and uses that instead. This only supports posting tasks
from the thread that owns the runloop. We can expand as needed. The mojo
RunLoop attempts to interleave delayed tasks with handle handlers, like
base's MessageLoop.

Review URL: https://codereview.chromium.org/384513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285560 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285559 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178842:178911&mode=html

TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/418223006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285558 0039d316-1c4b-4281-b951-d872f2087c98

Renderer processes may die without clearing its |WebSocketBridge|s.
It is helpful to send a close frame with code = 1001 in such a case.

BUG=392534
R=ricea@chromium.org

Review URL: https://codereview.chromium.org/390773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=336558
TEST=NO_TVCM=1 tools/telemetry/run_tests browser finder path

Review URL: https://codereview.chromium.org/412553006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285556 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384861
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/410993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285555 0039d316-1c4b-4281-b951-d872f2087c98

Revert of skia/ext: Early out from analysis when we have more than 1 draw op. (https://codereview.chromium.org/418093003/)

Reason for revert:
This change broke some tests in Blink
Additionally, it renders DevTools shortcuts screen unusable (Open devTools -> F1 -> Shortcuts tab)

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=virtual%2Fandroid%2Ffullscreen%2Ffull-screen-fixed-pos-parent.html%2Cvirtual%2Fandroid%2Ffullscreen%2Ffull-screen-iframe-zIndex.html%2Cvirtual%2Fandroid%2Ffullscreen%2Ffull-screen-zIndex.html

Original issue's description:
> skia/ext: Early out from analysis when we have more than 1 draw op.
> 
> This patch puts in a heuristic that earlies out from analysis when
> we have more than one draw op. The intent here is that in most cases,
> if we see more than one draw operation, then analysis is likely not
> to be solid.
> 
> It also removes HasText from analysis canvas, since the only
> remaining use for this was a previous early out heuristic.
> 
> BUG=397198
> R=enne
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285499

TBR=enne@chromium.org,senorblanco@google.com,junov@chromium.org,vmpstr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=397198

Review URL: https://codereview.chromium.org/416333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285554 0039d316-1c4b-4281-b951-d872f2087c98

Windows: Fix a corner case where we still think Adobe Reader is up to date after it has been uninstalled.

BUG=370746
TEST=Manual, see https://code.google.com/p/chromium/issues/detail?id=370746#c43

Review URL: https://codereview.chromium.org/419163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285553 0039d316-1c4b-4281-b951-d872f2087c98

We'll need this for the new and improved WaitMany.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/419613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285552 0039d316-1c4b-4281-b951-d872f2087c98

The NSSCertDatabase singleton for Linux is now maintained by nss_context_linux.cc .

BUG=329735

Review URL: https://codereview.chromium.org/405973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Test=None, internal cleanup.

Review URL: https://codereview.chromium.org/411253009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285550 0039d316-1c4b-4281-b951-d872f2087c98

One more clean up before getting 397391 done.

HasGDocFileExtension is a very thin wrapper of the latter
function, and what all the callers need is the former interface.
This CL merges those two functions into one to make it more
easily searchable where in our code is relying on the extensions.

BUG=397391

Review URL: https://codereview.chromium.org/416223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285549 0039d316-1c4b-4281-b951-d872f2087c98