GitLab

The changes in LinkHighlight code in http://crrev.com/541913002 causes
the link-highlights to disappear in many cases (see the bug). Eight
changes have been committed to the same code afterwards, making it
impossible to fully revert the target CL. The partial revert here fixes
the problem.

BUG=430244

Review URL: https://codereview.chromium.org/719053004

git-svn-id: svn://svn.chromium.org/blink/trunk@185245 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, there are several parts of the touch pipeline that need to
know whether a touch event may cause scrolling. In particular, touchmove
events within a platform-specific slop region will not induce
scrolling, and such events are suppressed by the TouchEventQueue when
the touchstart is not prevented. The TouchEventQueue uses a slop region
constant to perform this suppression.

However, there are no guarantees that this constant is the same as that
used in gesture detection. With devtools touch emulation, it should be
possible to vary the slop region when emulating different devices, but
the duplicated slop region code in the TouchEventQueue makes this
difficult.

This solution tags each touch event with a bit indicating whether
the event may cause scrolling, allowing any listener or consumer of the
touch stream to better reason about the touch event's default action.
This tagging will be wired up in the corresponding Chromium change:
https://codereview.chromium.org/718153002

Also remove the IsLastInputEventForCurrentVSync flag as it's no
longer used.

BUG=425586

Review URL: https://codereview.chromium.org/702883004

git-svn-id: svn://svn.chromium.org/blink/trunk@185244 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Clean up virtual functions in css/ by:
- Making classes final when possible
- Using 'override' when appropriate
- Making isXXX() virtual functions private on XXX classes

I also added a few nullptr usages.

Based on:
http://trac.webkit.org/changeset/175391

Review URL: https://codereview.chromium.org/719833002

git-svn-id: svn://svn.chromium.org/blink/trunk@185243 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Remove the parameter;
- Move RenderObject::addChildFocusRingRects into RenderLayerModelObject
  so that the layerQuads can be mapped by 'this' without the help of
  paintContainer;
- Don't check paintInvalidationContainer in
  RenderInline::addFocusRingRects. The original check and comment
  don't make sense. The element having outline:auto invalidates and
  paints the whole focus ring. The area of the whole focus ring is
  included in the visual overflow of the element.

TEST=existing focus-ring and outline:auto tests

Review URL: https://codereview.chromium.org/711493004

git-svn-id: svn://svn.chromium.org/blink/trunk@185242 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412088

Review URL: https://codereview.chromium.org/714303003

git-svn-id: svn://svn.chromium.org/blink/trunk@185241 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turn SVGPropertyBase into a non-refcounted, GCed object
and move all its derived objects to the heap.

R=kouhei,haraken
BUG=340522

Review URL: https://codereview.chromium.org/678163002

git-svn-id: svn://svn.chromium.org/blink/trunk@185240 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While one of the values of background-size is auto we have to use the
appropriate scale to maintain our aspect ratio. In this step we might
end up getting new image width or height as zero. In this case we should
clamp to minimum value as 1.

BUG=424048

Review URL: https://codereview.chromium.org/659913003

git-svn-id: svn://svn.chromium.org/blink/trunk@185238 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because render thread IPCs don't currently go through the Blink Scheduler,
it's possible for the order of execution between blink tasks and IPC tasks
to change. Most of the time this is harmless, but it exposes a race
condition between the MessagePort::dispatchMessages task posted by
MessagePort::start and WebMessagePortChannelImpl::OnMessage.  Normally
the initial dispatchMessages would execute first and do nothing, but if
OnMessage gets in first then a message will delivered even if the channel
has been closed.

This patch fixes that by adding a check in dispatchMessages to see if the
channel has been closed.

BUG=432129

Review URL: https://codereview.chromium.org/720543005

git-svn-id: svn://svn.chromium.org/blink/trunk@185237 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185224

TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/715303003

git-svn-id: svn://svn.chromium.org/blink/trunk@185236 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185226

BUG=428324
TBR=fs@opera.com

Review URL: https://codereview.chromium.org/720913003

git-svn-id: svn://svn.chromium.org/blink/trunk@185235 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/717923002

git-svn-id: svn://svn.chromium.org/blink/trunk@185234 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was set but never used. Probably a relic from CSS regions support.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/716213002

git-svn-id: svn://svn.chromium.org/blink/trunk@185233 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik

Review URL: https://codereview.chromium.org/719053003

git-svn-id: svn://svn.chromium.org/blink/trunk@185232 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test started failing after codereview.chromium.org/716963002. The
change to transitions/cross-fade-border-image.html in the linked patch
is similar. Since the tryservers don't have numbers in their paths we
didn't notice this test needed updating.

BUG=432566

Review URL: https://codereview.chromium.org/722753002

git-svn-id: svn://svn.chromium.org/blink/trunk@185231 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The specification has a "if Callable(V) is true, ..." case for (among
other things) callback function types, which is implemented here, only
for callback function types.

BUG=293561

Review URL: https://codereview.chromium.org/715353002

git-svn-id: svn://svn.chromium.org/blink/trunk@185230 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=431761

Review URL: https://codereview.chromium.org/713053002

git-svn-id: svn://svn.chromium.org/blink/trunk@185229 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Depends on https://codereview.chromium.org/720443002/

BUG=304341,350378

Review URL: https://codereview.chromium.org/687933002

git-svn-id: svn://svn.chromium.org/blink/trunk@185228 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman

Review URL: https://codereview.chromium.org/720793003

git-svn-id: svn://svn.chromium.org/blink/trunk@185227 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When referencing an SVG image from <svg:image> with pAR set to 'none', and
said image had no intrinsic size, but a 'viewBox', the use of the intrinsic
size (which would be computed as 300x150) as the container size would
incorrect. The 'viewBox' would resolve against 300x150, so if it defined
a different aspect ratio than that, the image would not appear correctly
scaled.

For pAR=none there're a number of cases to consider:
  1) The referenced image has a 'viewBox'.
  2) The referenced image has intrinsic dimensions.
  3) The referenced image has none of the above.
For cases (1) and (2), we should use the 'viewBox' and intrinsic dimensions
(respectively) to define the container size (~= the image's viewport maps
to the viewport defined by <svg:image>). In case (3) we try to use whatever
is left to use (300x150). (In practice cases (2) and (3) should be
equivalent.)

This also recognizes that the TC
svg/custom/svg-image-par-none-zero-intrinsic-size.html
is incorrect, and modifies it. Gecko seem to agree with this change.

The TC from the bug also made it obvious that there was a repaint bug at
play, which resulted in the updated return value from
RenderSVGImage::updateImageViewport. This is covered by the existing TC
svg/custom/svg-image-par-resize.html, which now seem to issue more correct
repaint rectangles.

BUG=428324

Review URL: https://codereview.chromium.org/713263002

git-svn-id: svn://svn.chromium.org/blink/trunk@185226 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=yosin

Review URL: https://codereview.chromium.org/719873002

git-svn-id: svn://svn.chromium.org/blink/trunk@185225 bbb929c8-8fbe-4397-9dbb-9b2b20218538

XP bot seems to have been asleep when the rebaseline ran.

TBR=fmalita,yosin
BUG=

Review URL: https://codereview.chromium.org/719863002

git-svn-id: svn://svn.chromium.org/blink/trunk@185224 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=timloh@chromium.org,yosin
BUG=432566

Review URL: https://codereview.chromium.org/718093003

git-svn-id: svn://svn.chromium.org/blink/trunk@185223 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=brettw@chromium.org
TBR=haraken@chromium.org
BUG=431177

Review URL: https://codereview.chromium.org/701043002

git-svn-id: svn://svn.chromium.org/blink/trunk@185222 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185200

BUG=331251
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/719753004

git-svn-id: svn://svn.chromium.org/blink/trunk@185221 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit c67fa612fedd3cf79f999ad61f2022dec85ff032, aka r185205.

Speculative revert to green up browser_tests:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=PrerenderBrowserTest.PrerenderClickNewBackgroundTab

TBR=jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/721793002

git-svn-id: svn://svn.chromium.org/blink/trunk@185220 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Convert fast/css/css-properties-position-relative-as-parent-fixed.html
in a ref-test test avoiding the need to rebaseline the expected results
if we do any modification.

BUG=31286,425991
TEST=fast/css/css-properties-position-relative-as-parent-fixed.html

Review URL: https://codereview.chromium.org/669143002

git-svn-id: svn://svn.chromium.org/blink/trunk@185219 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Derive from GarbageCollected<> instead whenever possible.

R=haraken
BUG=340522

Review URL: https://codereview.chromium.org/697893003

git-svn-id: svn://svn.chromium.org/blink/trunk@185218 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instant events are now considered as having duration 1us rather than 10us which makes overlapping much less likely.

BUG=398783

Review URL: https://codereview.chromium.org/721703002

git-svn-id: svn://svn.chromium.org/blink/trunk@185217 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They are included as "common definitions" in WebIDL and can thus be used
by other specifications without definition.

Review URL: https://codereview.chromium.org/715233003

git-svn-id: svn://svn.chromium.org/blink/trunk@185216 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=432104

Review URL: https://codereview.chromium.org/711383002

git-svn-id: svn://svn.chromium.org/blink/trunk@185215 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the spec, "A grid item establishes a new formatting context
for its contents." Hence, margins should not collapse even when they may
be adjoining to its content's margins. It also prevents any 'float' protruding
content on the adjoining grid items.

BUG=430100

Review URL: https://codereview.chromium.org/697653004

git-svn-id: svn://svn.chromium.org/blink/trunk@185214 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In an attempt to modularize accessibility, we are breaking dependencies and moving files to Source/modules/. Some dependencies were simply dead code (such as RenderMenuList depending on AXMenuList). Others were changed to from #include statements to forward references (such as AXObject in AXObjectCache.h). This last change had some unfortunate side effects, because some unrelated files were depending on non-accessibility-related things like PositionWithAffinity, which is included from AXObject.h and relied on by files that only include AXObjectCache.h. Since this CL breaks that include chain, seemingly unrelated files (such as RenderText.cpp) needed additional #includes in order not to break the compile.

BUG=428285
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/713933002

git-svn-id: svn://svn.chromium.org/blink/trunk@185213 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit c80133d17fe11102619db29cfe9dc4cdda4603ce.

Speculative revert to try to un-crashify WinXP bots:

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/15182

TBR=hiroshige
BUG=

Review URL: https://codereview.chromium.org/718083002

git-svn-id: svn://svn.chromium.org/blink/trunk@185212 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/723533002

git-svn-id: svn://svn.chromium.org/blink/trunk@185211 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently the ServiceWorker backend does not support register() and
getRegistration() calls on non-HTTP(s) page (eg, "file://"). Such calls
trigger a renderer crash because SWProviderHost does not have a valid
document URL and treats a request as a bad message.

This patch makes SWContainer abort such calls before sending an IPC message.


BUG=432048
TEST=run-webkit-tests fast/serviceworker/access-container-on-local-file.html

Review URL: https://codereview.chromium.org/722583002

git-svn-id: svn://svn.chromium.org/blink/trunk@185210 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/714423005

git-svn-id: svn://svn.chromium.org/blink/trunk@185209 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=432502
NOTRY=true

Review URL: https://codereview.chromium.org/717163002

git-svn-id: svn://svn.chromium.org/blink/trunk@185207 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/712403002

git-svn-id: svn://svn.chromium.org/blink/trunk@185206 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a page takes clickjacks a regular click, don't allow opening
background tabs from anchor elements.

BUG=431335
TEST=none, content_shell doesn't do tabs...
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/717133002

git-svn-id: svn://svn.chromium.org/blink/trunk@185205 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/MuxvaXiyBxU

BUG=339919

Review URL: https://codereview.chromium.org/719013002

git-svn-id: svn://svn.chromium.org/blink/trunk@185204 bbb929c8-8fbe-4397-9dbb-9b2b20218538