GitLab

Even if GL_CHROMIUM_framebuffer_multisample isn't available (such as on Qualcomm), this allows
glBindFramebuffer(GL_{DRAW,READ}_FRAMEBUFFER, ...) on ES3 command buffer
without throwing GL_INVALID_ENUM.

BUG=674357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2576273002
Cr-Commit-Position: refs/heads/master@{#438881}

BUG=665969

Review-Url: https://codereview.chromium.org/2571383002
Cr-Commit-Position: refs/heads/master@{#438880}

Replace it by GetValueFontColorForRow()

BUG=666189
TEST=existing

Review-Url: https://codereview.chromium.org/2563863003
Cr-Commit-Position: refs/heads/master@{#438879}

Thie crrev.com/2570783006 introduced a non-icon-mask class for
toolbarButtonGlyphs, which clashed with masked images. This patch
eliminates the clash.

BUG=674418, 674425
TBR=dgozman
NOTRY=true

Review-Url: https://codereview.chromium.org/2581753002
Cr-Commit-Position: refs/heads/master@{#438878}

They should be strings. They were not strings.

This fixes https://codereview.chromium.org/2572233003/

BUG=668202
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2579103002
Cr-Commit-Position: refs/heads/master@{#438877}

All incidence of flake that dropped it out of the CQ has been absent
for a good few days now. I think it's time to add it back.

TBR=tandrii@chromium.org
BUG=672382

Review-Url: https://codereview.chromium.org/2583553002
Cr-Commit-Position: refs/heads/master@{#438876}

ScrollingCoordinator::updateTouchEventTargetRectsIfNeeded() currently doesn't
update the touch rects when TouchEvent feature detection is disabled. This
could be bad when scrolling with a touch-action:none region. Since we are
always firing touch events, we can remove all refs to
touchEventFeatureDetection in ScrollingCoordinator.

BUG=671232

Review-Url: https://codereview.chromium.org/2582473003
Cr-Commit-Position: refs/heads/master@{#438875}

API use on the ThreadedWorkletGlobalScope is recorded in parent Document's
UseCounter.

Note that ThreadedWorkletGlobalScope hasn't been shipped yet and this
should not affect use counts in the real world.

BUG=667357
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2582483002
Cr-Commit-Position: refs/heads/master@{#438874}

This path has been removed, so there's no need for the exception now.

Related CL: http://crrev.com/606563004

Review-Url: https://codereview.chromium.org/2577553004
Cr-Commit-Position: refs/heads/master@{#438873}

Startup.FirstCommitNavigationTime2

BUG=668726

Review-Url: https://codereview.chromium.org/2559823004
Cr-Commit-Position: refs/heads/master@{#438872}

Caused by caller switching to anonymous functions for deferred startup.

BUG=672201

Review-Url: https://codereview.chromium.org/2576213005
Cr-Commit-Position: refs/heads/master@{#438871}

I originally added the WeakPtrs all over the place so that we could post to the device provider from the GL thread. This CL moves the calls to the UI thread, and removes the WeakPtrs with it.

BUG=671302

Review-Url: https://codereview.chromium.org/2570553004
Cr-Commit-Position: refs/heads/master@{#438870}

BUG=662005

Review-Url: https://codereview.chromium.org/2574303002
Cr-Commit-Position: refs/heads/master@{#438869}

BUG=619345

Review-Url: https://codereview.chromium.org/2583493003
Cr-Commit-Position: refs/heads/master@{#438868}

As per Microsoft's recommendation for LoadLibraryEx on MSDN.
https://msdn.microsoft.com/en-us/library/windows/desktop/ms684179(v=vs.85).aspx
"Use this flag when you want to load a DLL only to extract messages or
resources from it."

Review-Url: https://codereview.chromium.org/2570563002
Cr-Commit-Position: refs/heads/master@{#438867}

BUG= internal b/27450476
TEST= cast_multizone_backend_unittests

Review-Url: https://codereview.chromium.org/2557513002
Cr-Commit-Position: refs/heads/master@{#438866}

remove already fixed items.
and change the order as same as specification.

spec list:
https://drafts.fxtf.org/geometry/#DOMMatrix

BUG=388780

Review-Url: https://codereview.chromium.org/2530273003
Cr-Commit-Position: refs/heads/master@{#438865}

Fixes a crash that could happens when closing the Win10 welcome page while
the utility process is running.

BUG=

Review-Url: https://codereview.chromium.org/2581473002
Cr-Commit-Position: refs/heads/master@{#438864}

This CL fixes a number of race conditions on request cancellation
and completion. In particular:

 - Multiple cancellation calls on a request would DCHECK/crash.

 - A request could be cancelled concurrent to completion,
   resulting in a DCHECK/crash.

 - There was an ineffective lock internal to each request. Most
   of the critical code was already protected (though sometimes
   not properly) by the managers internal lock and the request
   lock wasn't adding any value.

BUG=672823

Review-Url: https://codereview.chromium.org/2571923002
Cr-Commit-Position: refs/heads/master@{#438863}

This CL adds a new script that automates building and uploading new
sysroot images.  Previously, you had to run UpdatePackageListsAll,
BuildSysrootAll, and UploadSysrootAll for each of the 4
sysroot-creators.  Then, you had to manually update the revision and
sha1sum in install_sysroot.py.  Now, simply run build_and_upload.py
and your CL should be ready to go.  In addition, the script
concurrently updates each sysroot image (there are currently 11 of
them), greatly reducing the time it took to update the sysroots.

In addition to adding the script, this CL also rolls all sysroots.

R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2567123002
Cr-Commit-Position: refs/heads/master@{#438862}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2568843002
Cr-Commit-Position: refs/heads/master@{#438861}

BUG=674432

Review-Url: https://codereview.chromium.org/2579643003
Cr-Commit-Position: refs/heads/master@{#438860}

This suite currently occasionally is timed out (its usual runtime is 20 minutes total), causing flaky failure

BUG=661434

Review-Url: https://codereview.chromium.org/2579793002
Cr-Commit-Position: refs/heads/master@{#438859}

Protocols, hosts, and suborigins are guaranteed to be canonicalized to
ASCII. Using WebString::ascii DCHECKs this fact, whereas WebString::utf8
branches on it. Using ascii() prevents a scan-through of each part of
the origin.

BUG=672877

Review-Url: https://codereview.chromium.org/2573113002
Cr-Commit-Position: refs/heads/master@{#438858}

Note this patch, while useful in it's own right, needs base messageloop
cancellation support for full effect.  Until that patch lands there may be
some pointless wakeups for canceled DoWorks. This is of particular concern
for using the scheduler on the compositor thread.

Includes fix for telemetry and tsan issues.

BUG=578176, 674238, 674157
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
Review-Url: https://codereview.chromium.org/2546423002
Cr-Original-Commit-Position: refs/heads/master@{#438173}
Cr-Commit-Position: refs/heads/master@{#438857}

This is flaking, as many other tests in that environment.

BUG=674497,357329
TBR=skuhne@chromium.org

Review-Url: https://codereview.chromium.org/2580883002
Cr-Commit-Position: refs/heads/master@{#438856}

The test failures all are because on Android ChromeContentBrowserClient::CreateThrottlesForNavigation returns a throttle that defers a request. The test harness assumed they're always synchronous. Fix by waiting on the callback to be run asynchronously.

The other minor fix is to Android specific NetErrorTabHelperTest tests. The RenderFrameHost test harness fakes navigations but doesn't handle multiple loads per RenderFrameHost very well (specifically, if a pending or speculative RFH is used). Fixing this would necessitate moving a bunch of methods from RenderFrameHostTester to WebContentsTester and updating all the tests. Additionally, the specific test harness code in NetErrorTabHelperTest has issues in that it doesn't use the pending/speculative RFH. The easiest solution here is to split the one unit test into three.

This fixes the 225 failing unit_tests on Android.

BUG=673806

Review-Url: https://codereview.chromium.org/2574953002
Cr-Commit-Position: refs/heads/master@{#438855}

BUG=668714, 673771

Review-Url: https://codereview.chromium.org/2576443002
Cr-Commit-Position: refs/heads/master@{#438854}

This CL uses an auto-resizeble WebUI constrained dialog to ensure that
it is loaded with the right height.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbTkVxc0twaDJhWjQ/view?usp=sharing
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbZmVFVXY1TnZmalU/view?usp=sharing

BUG=670238

Review-Url: https://codereview.chromium.org/2580663003
Cr-Commit-Position: refs/heads/master@{#438853}

BUG=674497
TBR=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2579073002
Cr-Commit-Position: refs/heads/master@{#438852}

Revert of Fixed dragging a folder from bookmark manager to open all elements in new tabs (patchset #7 id:120001 of https://codereview.chromium.org/2502483002/ )

Reason for revert:
Reverting because this introduces a bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=672805

Original issue's description:
> Fixed dragging a folder from bookmark manager to open all elements in new tabs
>
> Dropping a bookmark folder on Omnibox or Tab strip will open all of the urls in
> separate tabs.
>
> Note that this does not include urls within nested folders, because
> BookmarkNodeData.WriteToClipboard (bookmark_node_data.cc:190) does not put urls
> from nested folders into clipboard.
>
> I have two questions from reviewers:
>
> 1) Do we have to record metrics in ToolbarController like what we have in
> TabStripController.OpenUrl()?
>
> 2) I could not find any unit test for testing DropUrls of tab_strip_controller.mm
> and toolbar_controller.mm, am I right?
>
> BUG=661765
>
> Committed: https://crrev.com/d2e643efc4cceed77e046658a588f1559f1b1e88
> Cr-Commit-Position: refs/heads/master@{#434124}

TBR=avi@chromium.org,shrike@chromium.org,shahriar.rostami@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=661765

Review-Url: https://codereview.chromium.org/2572363002
Cr-Commit-Position: refs/heads/master@{#438851}

https://skia.googlesource.com/skia.git/+log/ebccb82680fc..625cd9e0c937

$ git log ebccb8268..625cd9e0c --date=short --no-merges --format='%ad %ae %s'
2016-12-15 bsalomon Workaround freeze on Mac Chrome when checking read pixel config support.
2016-12-15 bsalomon Rename NVPR batch->op and sk_sp'ify
2016-12-14 raftias Added optimized sRGB/2.2 gamma stages into A2B color xform
2016-12-15 robertphillips Add a deferred copy surface (take 3)
2016-12-15 caryclark speculative pointer to member fix
2016-12-14 bsalomon Even more batch->op and sk_sp'ification.

BUG=662802,674047

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2583513002
Cr-Commit-Position: refs/heads/master@{#438850}

BUG=669956

Review-Url: https://codereview.chromium.org/2578713002
Cr-Commit-Position: refs/heads/master@{#438849}

Sometimes the render process goes away (tab closed, crashes, etc.)
before the MediaGalleries GetMetadata call completes.

This CL adds a nullptr check to gracefully handle that case.

BUG=673459

Review-Url: https://codereview.chromium.org/2570903002
Cr-Commit-Position: refs/heads/master@{#438848}

This makes multi-line labels left align with themselves instead of wrap underneath the checkbox.

BUG=667389

Review-Url: https://codereview.chromium.org/2566983005
Cr-Commit-Position: refs/heads/master@{#438847}

Review-Url: https://codereview.chromium.org/2579803002
Cr-Commit-Position: refs/heads/master@{#438846}

Date of the last visit to any bookmarked page is stored to
BookmarkModel. Previously, this happens in off-the-record profiles as
well. This CL fixes the issue.

BUG=662382

Review-Url: https://codereview.chromium.org/2572433002
Cr-Commit-Position: refs/heads/master@{#438845}

Compatible with lazy initialisation, no memtrack_init() required.
Also fixed buffer overflow.

BUG=672780

Review-Url: https://codereview.chromium.org/2576713002
Cr-Commit-Position: refs/heads/master@{#438844}

BUG=671302

Review-Url: https://codereview.chromium.org/2574313002
Cr-Commit-Position: refs/heads/master@{#438843}

This CL adds a GN arg so that the PartitionAlloc sources
can be included or excluded. Since PartitionAlloc is still under
development and not used by all components that depend on base/, this
will give an option to binary size sensitive projects(e.g. Cronet) to
not bear the size increase in the meanwhile.

BUG=674570

Review-Url: https://codereview.chromium.org/2575973002
Cr-Commit-Position: refs/heads/master@{#438842}