- 23 Jul, 2014 40 commits
-
-
vmpstr@chromium.org authored
This patch adds const versions of operator* for layer iterators, so that we can use them for sorting/heapifying the iterators. R=reveman Review URL: https://codereview.chromium.org/413603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285038 0039d316-1c4b-4281-b951-d872f2087c98
-
adamk@chromium.org authored
This method is never called from Blink ("web components" are always enabled). Review URL: https://codereview.chromium.org/408053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285037 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=none TEST=none R=keybuk@chromium.org TBR=keybuk@chromium.org Review URL: https://codereview.chromium.org/401953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285036 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285031 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
R=nick@chromium.org TBR=brettw@chromium.org,nick@chromium.org BUG=none Review URL: https://codereview.chromium.org/371313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285030 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
In addition to a developer-readable string for inline install failures, include a stable error code. This isn't perfect, since a) the function prototype of function(error, errorCode) isn't great, and b) we kind of lose track of what went wrong after a certain point in the install process. Unfortunately, to fix a) requires either a breaking change or a revamp to our whole error reporting, and fixing b) requires stable error values at every point in our install process (which we don't have, and won't anytime soon). BUG=331887 TBR=benwells@chromium.org (app_list) TBR=yoshiki@chromium.org (file_manager) TBRs for trivial, no-functionality changes. Review URL: https://codereview.chromium.org/384823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285029 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
This change puts nexe information in the parameters for starting a NaCl plugin instead of sending that information over SRPC. This may remove the need for that IPC round trip entirely; perhaps we could report load failure as part of the RPCs for starting sel_ldr or performing StartModule(). nacl_defines.gypi as added as a dependency in components/components_tests.gyp because nacl_process_host.h now includes "native_client/src/public/nacl_file_info.h", which requires nacl_defines. BUG=333950 R=bbudge@chromium.org, brettw@chromium.org, hidehiko@chromium.org, jschuh@chromium.org, mseaborn@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/332463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285028 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Fix libxml clang warnings. Add ppapi_unittest_shared target. Rename ipc:test_support_ipc to ipc:test_support and use this target when needed (the places that wanted this incorrectly specified only "ipc". R=hclam@chromium.org Review URL: https://codereview.chromium.org/418453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285027 0039d316-1c4b-4281-b951-d872f2087c98
-
bajones@chromium.org authored
BUG=396385 R=kbr@chromium.org Review URL: https://codereview.chromium.org/406143003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285025 0039d316-1c4b-4281-b951-d872f2087c98
-
alexst@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/409793007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285024 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
BUG=328119 Review URL: https://codereview.chromium.org/401723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285023 0039d316-1c4b-4281-b951-d872f2087c98
-
skyostil@chromium.org authored
Check in perf-to-tracing conversion script. This lets the --perf command line switch actually produce trace files that can be loaded by Trace Viewer. The conversion script was originally written by Victor Miura <vmiura@chromium.org> in https://codereview.chromium.org/296623002/. TEST=PerfControllerTest BUG=375754 Review URL: https://codereview.chromium.org/404543003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285022 0039d316-1c4b-4281-b951-d872f2087c98
-
courage@chromium.org authored
In a previous change, an improved test subclass of GetAuthTokenFunction was created for multi-login tests. All chrome.identity.getAuthToken browser tests now use this class, and the original test class has been removed. The new class does not have any mock methods since the originals were not testing anything interesting anyway, and does not need to be a friend of its base class. This change also adds some coverage for error cases in getAuthToken, for requests specifying a non-primary account ID. BUG=364203 Review URL: https://codereview.chromium.org/410553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285020 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
Getting the value is fine and fast, but returning a reference has the advantage of allowing you to pass &handle.value() to anything taking a |const MojoHandle*| (without needing to save to a temporary variable). R=sky@chromium.org Review URL: https://codereview.chromium.org/417583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285019 0039d316-1c4b-4281-b951-d872f2087c98
-
grt@chromium.org authored
This is a rare codepath used only by Chrome Frame uninstalls. It's rare that it will be hit now, but leave correct code in place until the great installer GCF cleanup rather than remove this one small piece now. BUG=NONE R=gab@chromium.org Review URL: https://codereview.chromium.org/410923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285017 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285016 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
broke win64 build: FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper environment.x64 aot_target_build_newlib_x86_32_nonsfi_nlib__via_pnacl__363af64d0619df24e45ee3bc5549531a..rsp ..\..\ppapi\native_client\src\untrusted\pnacl_irt_shim error: unable to open output file '../../../../../out/Debug_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi.o---irt_shim_ppapi.c---.po': 'Error opening output file '../../../../../out/Debug_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi.o---irt_shim_ppapi.c---.po': The system cannot find the path specified' 1 error generated. ..\..\..\..\..\out\Debug_x64\gen\sdk\win_x86\pnacl_newlib\bin\pnacl-clang -c irt_shim_ppapi.c -o ../../../../../out/Debug_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi.o -MD -MF ../../../../../out/Debug_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi.o.d --target=i686-unknown-nacl --pnacl-allow-native --pnacl-allow-translate -arch x86-32-nonsfi -O2 -g -Wall -fdiagnostics-show-option -Werror -DPNACL_SHIM_AOT -Wno-unused-function -Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args -Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts -Wno-unused-function -D__linux__ -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_BSD_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -DNOMINMAX -DPSAPI_VERSION=1 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_ATL_NO_OPENGL -D_SECURE_ATL -DCHROMIUM_BUILD -DTOOLKIT_VIEWS=1 -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DNO_TCMALLOC -DENABLE_EGLIMAGE=1 -D__STD_C -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -DNTDDI_VERSION=0x06020000 -D_USING_V110_SDK71_ -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DCLD_DATA_FROM_STATIC -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DWIN_PDF_METAFILE_FOR_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -DNACL_WINDOWS=0 -DNACL_OSX=0 -DNACL_LINUX=0 -DNACL_ANDROID=0 -I../../../../../out/Debug_x64/gen/tc_pnacl_newlib/include -I../../../../.. -I../../../../../out/Debug_x64/gen -I../../../../../third_party/wtl/include -std=gnu99 FAILED: Command '..\..\..\..\..\out\Debug_x64\gen\sdk\win_x86\pnacl_newlib\bin\pnacl-clang -c irt_shim_ppapi.c -o ../../../../../out/Debug_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi.o -MD -MF ../../../../../out/Debug_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi.o.d --target=i686-unknown-nacl --pnacl-allow-native --pnacl-allow-translate -arch x86-32-nonsfi -O2 -g -Wall -fdiagnostics-show-option -Werror -DPNACL_SHIM_AOT -Wno-unused-function -Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args -Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts -Wno-unused-function -D__linux__ -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_BSD_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -DNOMINMAX -DPSAPI_VERSION=1 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_ATL_NO_OPENGL -D_SECURE_ATL -DCHROMIUM_BUILD -DTOOLKIT_VIEWS=1 -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DNO_TCMALLOC -DENABLE_EGLIMAGE=1 -D__STD_C -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -DNTDDI_VERSION=0x06020000 -D_USING_V110_SDK71_ -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DCLD_DATA_FROM_STATIC -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DWIN_PDF_METAFILE_FOR_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -DNACL_WINDOWS=0 -DNACL_OSX=0 -DNACL_LINUX=0 -DNACL_ANDROID=0 -I../../../../../out/Debug_x64/gen/tc_pnacl_newlib/include -I../../../../.. -I../../../../../out/Debug_x64/gen -I../../../../../third_party/wtl/include -std=gnu99' returned non-zero exit status 1 ninja: build stopped: subcommand failed. http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/1055/steps/compile/logs/stdio > NaCl: Update revision in DEPS, r13506 -> r13511 > > This pulls in the following Native Client changes: > > r13507: (noelallen) Reapply patch which was reverted due to conflict. > r13508: (dschuff) PNaCl Driver: do not generate temp file names beyond Windows' MAX_PATH limit > r13509: (jvoung) Add a flag to pnacl-finalize that allows users to keep function names. > r13510: (dschuff) Disable flaky sandboxed translator tests on mac > r13511: (dschuff) Update revision for PNaCl r13466->r13509 > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_nacl_sdk_build > (linux_rel_precise32,linux_arm_cross_compile omitted because they are currently broken) > > R=jvoung@chromium.org > > Review URL: https://codereview.chromium.org/409113009 TBR=dschuff@chromium.org Review URL: https://codereview.chromium.org/418583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285015 0039d316-1c4b-4281-b951-d872f2087c98
-
hjd@chromium.org authored
BUG=395244 Review URL: https://codereview.chromium.org/410083003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285014 0039d316-1c4b-4281-b951-d872f2087c98
-
zeeshanq@chromium.org authored
Compositor touch hit testing was re-enabled on Android webview back in February (https://codereview.chromium.org/183943002) and we haven't had any complaints since. It's probably safe to remove the flag and related code now. This is part 1 of 2, will be followed by: https://codereview.chromium.org/406053002 BUG=304518 Review URL: https://codereview.chromium.org/399953004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285013 0039d316-1c4b-4281-b951-d872f2087c98
-
japhet@chromium.org authored
This adds a link_followed parameter to CustomContextMenuContext. This object is sent back to the renderer process when a context menu is closed, allowing us to provide sufficient information to send pings if appropriate. BUG=257281 Review URL: https://codereview.chromium.org/384243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285011 0039d316-1c4b-4281-b951-d872f2087c98
-
weiliangc@chromium.org authored
Set up a counter in LayerTreeImpl to indicate whether a recent frame has been pushed from main thread. Since missing and incomplete tiles are compositor side concept, only track those numbers on compositor side. BUG=381695 Review URL: https://codereview.chromium.org/411693004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285010 0039d316-1c4b-4281-b951-d872f2087c98
-
anton@chromium.org authored
If the chrome library is loaded directly from inside the APK the android stack trace will give the on device name of the APK in the stack trace. Try to find the symbols in this case by mapping to the appropriate library name. BUG=390618 Review URL: https://codereview.chromium.org/401003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285009 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
If EnableAdbRoot fails, then we can't wipe the data because then we're not able to restore the adb_keys and the device never reappears. BUG=396120 Review URL: https://codereview.chromium.org/413523006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285008 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
This reverts r284650. There is one test that is flaky 34% of the time, but that is the exception and not the norm. We don't need 12 retries to make browser_tests or other test suites not flaky. If there are very flaky tests, we should disable them instead. I've disabled all the tests that flake more than 5% of the time. BUG=395189 R=brettw@chromium.org, sergeyberezin@chromium.org Review URL: https://codereview.chromium.org/413733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285006 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
The monsoon provides power for the device, so for devices with no real battery, we need a chance to turn them on after the monsoon enables voltage output to the device. BUG= Review URL: https://codereview.chromium.org/400863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285005 0039d316-1c4b-4281-b951-d872f2087c98
-
mlamouri@chromium.org authored
BUG=162827 Review URL: https://codereview.chromium.org/410173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285004 0039d316-1c4b-4281-b951-d872f2087c98
-
stgao@chromium.org authored
It breaks http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/5252 > Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread. > > BUG=393149 > > Review URL: https://codereview.chromium.org/387923002 TBR=bauerb@chromium.org Review URL: https://codereview.chromium.org/416543006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285002 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
BUG=396729 R=stgao@chromium.org TBR=tbarzic@chromium.org Review URL: https://codereview.chromium.org/411043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285001 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
This CL adds support for moving files which are on the same provided file system. Note, that moving between file system instances will be done using FileStreamWriter. TEST=unit_tests, browser_tests: *FileSystemProvider*Move* BUG=391362 Review URL: https://codereview.chromium.org/389973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285000 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
This was used as part of the PNaCl rollout but is no longer necessary. I came across this while investigating what code in chrome needs to be updated once the file for the trusted plugin library is gone. Usage statistics say that this flag has been used 1850 times in the past 7 days by 197 users. TBR=ncbray BUG=354867 Review URL: https://codereview.chromium.org/392023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284997 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284996 0039d316-1c4b-4281-b951-d872f2087c98
-
dschuff@chromium.org authored
This pulls in the following Native Client changes: r13507: (noelallen) Reapply patch which was reverted due to conflict. r13508: (dschuff) PNaCl Driver: do not generate temp file names beyond Windows' MAX_PATH limit r13509: (jvoung) Add a flag to pnacl-finalize that allows users to keep function names. r13510: (dschuff) Disable flaky sandboxed translator tests on mac r13511: (dschuff) Update revision for PNaCl r13466->r13509 BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_nacl_sdk_build (linux_rel_precise32,linux_arm_cross_compile omitted because they are currently broken) R=jvoung@chromium.org Review URL: https://codereview.chromium.org/409113009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284995 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
Revert of Remove ash_unittests to see if it's affecting bot stability (https://codereview.chromium.org/411673002/) Reason for revert: Was not the cause of flakiness. Original issue's description: > Remove ash_unittests to see if it's affecting bot stability > > Bot has been completely failing intermittently. ash_unittests > is the Win8-specific part that runs here, so temporarily remove > it to see if it's related to the back-and-forth to Metro > switches. > > BUG=340422 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284820 TBR=sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=340422 Review URL: https://codereview.chromium.org/414783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284993 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
We have lots of test APKs that don't need application icons. And I think we'd notice if Chrome itself was missing an icon even without this warning ;) BUG=393235 NOTRY=true Review URL: https://codereview.chromium.org/410683007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284992 0039d316-1c4b-4281-b951-d872f2087c98
-
prasadv@chromium.org authored
BUG=385327 NOTRY=true Review URL: https://codereview.chromium.org/413633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284991 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
With this patch, both Windows and Ozone implementations use PlatformWindow for interacting with the native windowing system. Eventually, the X11 implementations will also use this, and WindowTreeHost will have a single implementation on all platforms. BUG=none R=ben@chromium.org Previously landed in r284850, but reverted in r284905 because it broke a multi- window ash unit-test on Windows. The test is now disabled (r284931). Review URL: https://codereview.chromium.org/400413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284986 0039d316-1c4b-4281-b951-d872f2087c98
-
pmeenan@chromium.org authored
This fixes an issue introduced by https://codereview.chromium.org/135723003/ where the navigation messages are no longer associated with the RenderView and as a result the resource loader was not resetting state for new navigations. BUG=391741 Review URL: https://codereview.chromium.org/368953006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284985 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
BUG=395823 R=rsleevi@chromium.org Review URL: https://codereview.chromium.org/410743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284984 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
This CL adds language and keyboard pickers to public session pods. The CL focuses on the necessary changes to the login UI. Follow-up CLs will: - wire up the pickers so that they actually influence the language and keyboard layout in the public session, and - customize the contents of the language picker based on policy (languages recommended by policy go first; the top recommended language is pre-selected) BUG=214904,241790 TEST=Manual, including RTL Review URL: https://codereview.chromium.org/398543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284983 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Fixes this warning: In file included from ..\..\media/video/capture/win/pin_base_win.h:15: ..\..\base/memory/ref_counted.h(131,7) : warning(clang): delete called on 'const media::TypeEnumerator' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] delete static_cast<const T*>(this); ^ ..\..\media\video\capture\win\pin_base_win.cc(40,39) : note(clang): in instantiation of member function 'base::RefCounted<media::TypeEnumerator>::Release' requested here base::RefCounted<TypeEnumerator>::Release(); ^ 1 warning generated. BUG=82385 NOTRY=true Review URL: https://codereview.chromium.org/410833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284982 0039d316-1c4b-4281-b951-d872f2087c98
-