1. 05 Feb, 2010 36 commits
    • kov@webkit.org's avatar
      2010-02-05 Sebastian Dröge <sebastian.droege@collabora.co.uk> · 99d92be4
      kov@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
              https://bugs.webkit.org/show_bug.cgi?id=34317
      
              * GNUmakefile.am:
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::mediaPlayerPrivateSourceChangedCallback):
              (WebCore::doGstInit):
              * platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
              * platform/graphics/gtk/WebKitWebSourceGStreamer.h:
              Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure.
              This makes sure that referer, cookies, authentication information
              and all kinds of other context are passed to GStreamer for websites
              like Vimeo or YouTube.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54427 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      99d92be4
    • vestbo@webkit.org's avatar
      [Qt] Fix build on Windows · 8c030dbf
      vestbo@webkit.org authored
      Reviewed by Kenneth Rohde Christiansen.
      
      DerivedSources for our API headers failed on Windows,
      due to Windows not accepting ; as a command separator,
      not needing quotes for echo, and needing < and > escaped.
      
      We now detect Windows and set these quote markers and
      escape markers accordingly, as well as use && for separating
      individual commands.
      
      * Api/DerivedSources.pro:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54426 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8c030dbf
    • japhet@chromium.org's avatar
      2010-02-05 Nate Chapin <japhet@chromium.org> · 8cd356e7
      japhet@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [V8] Clean up code for getting a v8::FunctionTemplate.
              
              https://bugs.webkit.org/show_bug.cgi?id=34606
      
              * bindings/scripts/CodeGeneratorV8.pm: Making GetTemplate() public
              * bindings/v8/V8Binding.cpp:
              (WebCore::configureTemplate):
              * bindings/v8/V8DOMWrapper.cpp: Remove getTemplate(), use V8ClassIndex::getTemplate() instead.
              (WebCore::V8DOMWrapper::getConstructor):
              (WebCore::V8DOMWrapper::instantiateV8Object):
              * bindings/v8/V8DOMWrapper.h:
              (WebCore::V8DOMWrapper::lookupDOMWrapper):
              * bindings/v8/V8Index.cpp: Remove duplicate caching of FunctionTemplates.
              (WebCore::V8ClassIndex::getTemplate):
              * bindings/v8/V8Index.h:
              * bindings/v8/WorkerContextExecutionProxy.cpp:
              (WebCore::WorkerContextExecutionProxy::toV8):
              * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
              (WebCore::v8HTMLAudioElementConstructorCallback):
              (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
              * bindings/v8/custom/V8HTMLAudioElementConstructor.h:
              * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
              (WebCore::v8HTMLImageElementConstructorCallback):
              (WebCore::V8HTMLImageElementConstructor::GetTemplate):
              * bindings/v8/custom/V8HTMLImageElementConstructor.h:
              * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
              (WebCore::v8HTMLOptionElementConstructorCallback):
              (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
              * bindings/v8/custom/V8HTMLOptionElementConstructor.h:
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::createInjectedScriptHostV8Wrapper):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54425 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8cd356e7
    • ossy@webkit.org's avatar
      Rubber-stamped by Tor Arne Vestbø. · b055355d
      ossy@webkit.org authored
      [Qt] fast/css/dashboard-regions-attr-crash.html skipped,
      because ENABLE_DASHBOARD_SUPPORT=0 is the default option.
      
      * platform/qt/Skipped:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54424 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b055355d
    • eric@webkit.org's avatar
      2010-02-05 Simon Hausmann <simon.hausmann@nokia.com> · 9227eb2e
      eric@webkit.org authored
              Reviewed by Tor Arne Vestbø.
      
              Add .gitattributes file to tell git about files with Windows linefeeds
              https://bugs.webkit.org/show_bug.cgi?id=34645
      
              On Windows git defaults to "true" for core.autocrlf, meaning all text
              files in the working directory are converted from CRLF to LF on checkin
              time. Some files present in the repository have been checked in with
              CRLF linefeeds and git should not try to convert them. The added
              .gitattributes file tells git to not do any CRLF conversion.
      
              * .gitattributes: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54423 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9227eb2e
    • hausmann@webkit.org's avatar
      [Qt] Build break in QtWebkit on Symbian · 9d799ed9
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34597
      
      Patch by Siddharth Mathur <siddharth.mathur@nokia.com> on 2010-02-05
      Reviewed by Ariya Hidayat.
      
      * plugins/PluginView.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54422 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9d799ed9
    • yurys@chromium.org's avatar
      2010-02-05 Yury Semikhatsky <yurys@chromium.org> · 995e481f
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              - Use SerializedScriptValue for passing data between injected script and
              inspector frontend.
              - Remove custom JSON implementation from the instpector utility script.
              - Make sure that only objects created in the same ScriptState can be values
              of ScriptObject/Array properties and arguments to ScriptFunctionCall. We don't
              want ScriptObjects to leak between contexts.
              - Use ScriptState of the 'this' object in ScriptFunctionCall instead of passing
              it as additional parameter.
      
              https://bugs.webkit.org/show_bug.cgi?id=33592
      
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::JSInjectedScriptHost::reportDidDispatchOnInjectedScript):
              * bindings/js/ScriptArray.cpp:
              (WebCore::ScriptArray::set):
              * bindings/js/ScriptFunctionCall.cpp:
              (WebCore::ScriptFunctionCall::ScriptFunctionCall):
              (WebCore::ScriptFunctionCall::appendArgument):
              * bindings/js/ScriptFunctionCall.h:
              * bindings/js/ScriptObject.cpp:
              (WebCore::ScriptObject::set):
              * bindings/js/ScriptValue.cpp:
              (WebCore::ScriptValue::serialize):
              (WebCore::ScriptValue::deserialize):
              * bindings/js/ScriptValue.h:
              * bindings/v8/ScriptArray.cpp:
              (WebCore::ScriptArray::set):
              * bindings/v8/ScriptFunctionCall.cpp:
              (WebCore::ScriptFunctionCall::ScriptFunctionCall):
              (WebCore::ScriptFunctionCall::appendArgument):
              * bindings/v8/ScriptFunctionCall.h:
              * bindings/v8/ScriptObject.cpp:
              (WebCore::ScriptObject::set):
              * bindings/v8/ScriptState.h:
              * bindings/v8/ScriptValue.cpp:
              (WebCore::ScriptValue::serialize):
              (WebCore::deserialize):
              * bindings/v8/ScriptValue.h:
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::V8InjectedScriptHost::reportDidDispatchOnInjectedScriptCallback):
              * inspector/InjectedScript.cpp:
              (WebCore::InjectedScript::dispatch):
              (WebCore::InjectedScript::callFrames):
              (WebCore::InjectedScript::wrapForConsole):
              (WebCore::InjectedScript::releaseWrapperObjectGroup):
              * inspector/InjectedScript.h:
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
              * inspector/InjectedScriptHost.h:
              * inspector/InjectedScriptHost.idl:
              * inspector/InspectorBackend.cpp:
              (WebCore::InspectorBackend::dispatchOnInjectedScript):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::setFrontendProxyObject):
              (WebCore::InspectorController::didPause):
              (WebCore::InspectorController::didEvaluateForTestInFrontend):
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::InspectorFrontend):
              (WebCore::InspectorFrontend::newScriptArray):
              (WebCore::InspectorFrontend::newScriptObject):
              (WebCore::InspectorFrontend::populateFrontendSettings):
              (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount):
              (WebCore::InspectorFrontend::addConsoleMessage):
              (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount):
              (WebCore::InspectorFrontend::updateResource):
              (WebCore::InspectorFrontend::removeResource):
              (WebCore::InspectorFrontend::didGetResourceContent):
              (WebCore::InspectorFrontend::updateFocusedNode):
              (WebCore::InspectorFrontend::setAttachedWindow):
              (WebCore::InspectorFrontend::addRecordToTimeline):
              (WebCore::InspectorFrontend::parsedScriptSource):
              (WebCore::InspectorFrontend::failedToParseScriptSource):
              (WebCore::InspectorFrontend::addProfileHeader):
              (WebCore::InspectorFrontend::setRecordingProfile):
              (WebCore::InspectorFrontend::didGetProfileHeaders):
              (WebCore::InspectorFrontend::didGetProfile):
              (WebCore::InspectorFrontend::pausedScript):
              (WebCore::InspectorFrontend::setDocument):
              (WebCore::InspectorFrontend::setDetachedRoot):
              (WebCore::InspectorFrontend::setChildNodes):
              (WebCore::InspectorFrontend::childNodeCountUpdated):
              (WebCore::InspectorFrontend::childNodeInserted):
              (WebCore::InspectorFrontend::childNodeRemoved):
              (WebCore::InspectorFrontend::attributesUpdated):
              (WebCore::InspectorFrontend::didRemoveNode):
              (WebCore::InspectorFrontend::didGetChildNodes):
              (WebCore::InspectorFrontend::didApplyDomChange):
              (WebCore::InspectorFrontend::didGetEventListenersForNode):
              (WebCore::InspectorFrontend::didGetCookies):
              (WebCore::InspectorFrontend::didDispatchOnInjectedScript):
              (WebCore::InspectorFrontend::addDatabase):
              (WebCore::InspectorFrontend::selectDatabase):
              (WebCore::InspectorFrontend::didGetDatabaseTableNames):
              (WebCore::InspectorFrontend::addDOMStorage):
              (WebCore::InspectorFrontend::selectDOMStorage):
              (WebCore::InspectorFrontend::didGetDOMStorageEntries):
              (WebCore::InspectorFrontend::didSetDOMStorageItem):
              (WebCore::InspectorFrontend::didRemoveDOMStorageItem):
              (WebCore::InspectorFrontend::updateDOMStorage):
              (WebCore::InspectorFrontend::addNodesToSearchResult):
              (WebCore::InspectorFrontend::contextMenuItemSelected):
              (WebCore::InspectorFrontend::evaluateForTestInFrontend):
              (WebCore::InspectorFrontend::callSimpleFunction):
              * inspector/InspectorFrontend.h:
              (WebCore::InspectorFrontend::scriptState):
              * inspector/front-end/InjectedScript.js:
              (injectedScriptConstructor):
              (injectedScriptConstructor.):
              * inspector/front-end/InjectedScriptAccess.js:
              (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName.myCallback):
              (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName):
              (InjectedScriptAccess._installHandler):
              * inspector/front-end/inspector.js:
              (WebInspector.pausedScript):
              (WebInspector.addConsoleMessage):
      
      2010-02-05  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Remove unused inmport of ScriptFunctionCall.h
      
              https://bugs.webkit.org/show_bug.cgi?id=33592
      
              * Api/qwebelement.cpp:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54421 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      995e481f
    • vestbo@webkit.org's avatar
      [Qt] Generate convenience headers (QWebView, etc) using qmake · 28786fe1
      vestbo@webkit.org authored
      Reviewed by Simon Hausmann.
      
      In Qt this is done using syncqt, but we use a pro-file instead
      that generates makefile-rules for each of the extra headers.
      
      These extra headers are installed alongside the normal headers.
      
      WebCore:
      
      * WebCore.pro: Use headers.pri based on DerivedSources instead
      of the one previously checked in in the source tree.
      
      WebKit/qt:
      
      * Api/DerivedSources.pro: Added. List of headers + pro file magic
      * Api/headers.pri: Removed, list of headers is now in the above file
      
      WebKitTools:
      
      * Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54420 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      28786fe1
    • zoltan@webkit.org's avatar
      Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0 · 4fb1c034
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34569
      
      Patch by Kwang Yul Seo <skyul@company100.net> on 2010-02-05
      Reviewed by Alexey Proskuryakov.
      
      With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
      if the return value of malloc and calloc is 0.
              
      However, these functions can return 0 when the request size is 0.
      Libc manual says, "If size is 0, then malloc() returns either NULL,
      or a unique pointer value that can later be successfully passed to free()."
      Though malloc returns a unique pointer in most systems,
      0 can be returned in some systems. For instance, BREW's MALLOC returns 0
      when size is 0.
      
      If malloc or calloc returns 0 due to allocation size, increase the size
      to 1 and try again.
      
      * wtf/FastMalloc.cpp:
      (WTF::fastMalloc):
      (WTF::fastCalloc):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54419 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4fb1c034
    • abecsi@webkit.org's avatar
      2010-02-05 Andras Becsi <abecsi@webkit.org> · 9c85e808
      abecsi@webkit.org authored
              Unreviewed typo fix.
      
              Fix wrong whitespace alignment introduced in r54342.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54418 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9c85e808
    • eric@webkit.org's avatar
      2010-02-05 Mikhail Naganov <mnaganov@chromium.org> · bb17ae4c
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Enable JAVASCRIPT_DEBUGGER in chromium port.
      
              https://bugs.webkit.org/show_bug.cgi?id=34638
      
              * page/Console.cpp:
              * page/Console.h:
              * page/Console.idl:
      2010-02-05  Mikhail Naganov  <mnaganov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Enable JAVASCRIPT_DEBUGGER in chromium port.
      
              https://bugs.webkit.org/show_bug.cgi?id=34638
      
              * features.gypi:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54417 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bb17ae4c
    • kenneth@webkit.org's avatar
      Rubberstamped by Oliver Hunt. · c696ef82
      kenneth@webkit.org authored
      [Qt] Make it possible to choose whether the launcher should
      use the traditional QWidget based QWebView or the newer
      QGraphics based QGraphicsWebView on a QGraphicsView.
      
      * QtLauncher/main.cpp:
      (LauncherWindow::LauncherWindow):
      (LauncherWindow::eventFilter):
      (LauncherWindow::loadStarted):
      (LauncherWindow::print):
      (LauncherWindow::screenshot):
      (LauncherWindow::setEditable):
      (LauncherWindow::setupUI):
      (main):
      * QtLauncher/webview.cpp:
      (WebViewGraphicsBased::WebViewGraphicsBased):
      (WebViewGraphicsBased::resizeEvent):
      (GraphicsWebView::mousePressEvent):
      (GraphicsWebView::contextMenuEvent):
      * QtLauncher/webview.h:
      (WebViewTraditional::WebViewTraditional):
      (GraphicsWebView::GraphicsWebView):
      (WebViewGraphicsBased::setPage):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54416 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c696ef82
    • eric@webkit.org's avatar
      2010-02-05 Pavel Feldman <pfeldman@chromium.org> · 90e6d0c7
      eric@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Tab width for javascript source is 8, should be 4
      
              https://bugs.webkit.org/show_bug.cgi?id=31248
      
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame):
              * inspector/front-end/TextEditorModel.js:
              (WebInspector.TextEditorModel.prototype.set replaceTabsWithSpaces):
              (WebInspector.TextEditorModel.prototype._innerSetText):
              (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54415 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      90e6d0c7
    • ukai@chromium.org's avatar
      2010-02-05 Fumitoshi Ukai <ukai@chromium.org> · e543d4f2
      ukai@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              send() should return false, after frame that opened a WebSokcet is detached
              https://bugs.webkit.org/show_bug.cgi?id=34630
      
              * websocket/tests/send-after-close-on-unload-expected.txt: Added.
              * websocket/tests/send-after-close-on-unload.html: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54414 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e543d4f2
    • tony@chromium.org's avatar
      2010-02-05 Tony Chang <tony@chromium.org> · e387c2e0
      tony@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=24872
              Add a test to make sure copying from a list and pasting into a list
              keeps the list at the same indention level rather than nesting.
      
              * editing/pasteboard/paste-list-002-expected.txt: Added.
              * editing/pasteboard/paste-list-002.html: Added.
      2010-02-05  Tony Chang  <tony@chromium.org>
      
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=24872
              When pasting a list into another list should not indent another level.
              If the cursor is at the beginning of the line, it should insert the
              list items before the current list item.  If the cursor is at the end
              of the line, it should insert the list items after the current list item.
      
              This matches Firefox and IE and makes the common activity of reordering a list
              work as expected.
      
              This also adds a small helper method (isListItem) to htmlediting.h.
      
              Test: editing/pasteboard/paste-list-002.html
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              (WebCore::ReplaceSelectionCommand::insertAsListItems):
              * editing/ReplaceSelectionCommand.h:
              * editing/htmlediting.cpp:
              (WebCore::isListItem):
              (WebCore::appendedSublist):
              * editing/htmlediting.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54413 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e387c2e0
    • vestbo@webkit.org's avatar
      [Qt] Make 'make -f Makefile.DerivedSources qmake' work · 8387aafd
      vestbo@webkit.org authored
      Reviewed by Lars Knoll.
      
      Previously this target ended up generating a file named
      Makefile.DerivedSources.DerivedSources, and so on.
      
      * DerivedSources.pro:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54412 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8387aafd
    • mrowe@apple.com's avatar
      Rubber-stamped by Dan Bernstein. · e878da75
      mrowe@apple.com authored
      Fix the ability to #include <WebKit/DOMFile.h>.
      
      * MigrateHeaders.make: Mark DOMBlob.h as a public header since the already-public DOMFile.h depends on it.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54411 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e878da75
    • eric@webkit.org's avatar
      2010-02-04 Yaar Schnitman <yaar@chromium.org> · 8175ae86
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin
              https://bugs.webkit.org/show_bug.cgi?id=34509
      
              Resubmit: The previous commit (r54333) was rolled back.
      
              * WebKit.gyp:
              * tests/TransparencyWinTest.cpp: Added.
              (WebCore::RECTToFloatRect):
              (WebCore::drawNativeRect):
              (WebCore::getPixelAt):
              (WebCore::clearTopLayerAlphaChannel):
              (WebCore::clearTopLayerAlphaPixel):
              (WebCore::operator<<):
              (WebCore::TEST):
              * tests/UniscribeHelperTest.cpp: Added.
              (WebCore::UniscribeTest::UniscribeTest):
              (WebCore::UniscribeTest::MakeFont):
              (WebCore::UniscribeTest::SetUp):
              (WebCore::UniscribeTest::TearDown):
              (TEST_F):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54410 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8175ae86
    • ukai@chromium.org's avatar
      2010-02-04 Fumitoshi Ukai <ukai@chromium.org> · fb886a72
      ukai@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              should not crash when document opened websocket is unloaded
              https://bugs.webkit.org/show_bug.cgi?id=34562
      
              * websocket/tests/close-on-unload-and-force-gc-expected.txt: Added.
              * websocket/tests/close-on-unload-and-force-gc.html: Added.
              * websocket/tests/close-on-unload-reference-in-parent-expected.txt: Added.
              * websocket/tests/close-on-unload-reference-in-parent.html: Added.
              * websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54406 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fb886a72
    • mrowe@apple.com's avatar
      Build fix. Remove a symbol corresponding to an inline function from the linker export · ec71130b
      mrowe@apple.com authored
      file to prevent a weak external failure.
      
      Reviewed by Timothy Hatcher.
      
      JavaScriptCore:
      
      * JavaScriptCore.xcodeproj/project.pbxproj: Accommodate rename of script.
      
      JavaScriptGlue:
      
      * JavaScriptGlue.xcodeproj/project.pbxproj: Accommodate rename of script.
      
      WebCore:
      
      * WebCore.base.exp: Remove symbol.
      * WebCore.xcodeproj/project.pbxproj: Accommodate rename of script.
      
      WebKit:
      
      * WebKit.xcodeproj/project.pbxproj: Accommodate rename of script.
      
      WebKitTools:
      
      * Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.
      Teach the script how to detect weak external symbols so that these errors can be caught immediately
      in the future.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54405 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ec71130b
    • ukai@chromium.org's avatar
      2010-02-04 Fumitoshi Ukai <ukai@chromium.org> · c3effddd
      ukai@chromium.org authored
              Reviewed by Shinichiro Hamaji.
      
              websocket/tests/close-on-unload.html failed on Mac Tiger
              https://bugs.webkit.org/show_bug.cgi?id=34563
      
              * platform/mac-tiger/Skipped: remove websocket/tests/close-on-unload*.html
              * websocket/tests/close-on-unload_wsh.py: use dict instead of set.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54404 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c3effddd
    • dbates@webkit.org's avatar
      2010-02-04 Daniel Bates <dbates@webkit.org> · 36673b08
      dbates@webkit.org authored
              [Qt] Unreviewed, build fix for Qt bot.
      
              * runtime/JSStringBuilder.h: Changed #include <X.h> notation #include "X.h".
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54403 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      36673b08
    • ggaren@apple.com's avatar
      Build fix: export a header. · 16328d08
      ggaren@apple.com authored
      * JavaScriptCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54402 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      16328d08
    • ggaren@apple.com's avatar
      Build fix: Added a forwarding header. · fe976783
      ggaren@apple.com authored
      * ForwardingHeaders/runtime/WeakGCPtr.h: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54401 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fe976783
    • ggaren@apple.com's avatar
      WebCore: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383) · af04b33e
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=33383
      <rdar://problem/7559449>
              
      Reviewed by Alexey Proskuryakov and Darin Adler.
      
      There were two bugs here:
              
      1. A stale wrapper would invalidate a node's event listeners, even if
      the node had a fresh wrapper keeping it alive.
              
      The fix for this is for an event listener to keep a WeakGCPtr back-pointer
      to the wrapper it expects to mark it. The wrapper destructor checks this
      back-pointer, and only invalidates the event listener in the case of a match.
      
      2. Conversely, a stale wrapper would not invalidate a node's event
      listeners soon enough, if its destructor didn't have a chance to run
      before an event fired on the node. (This can only happen in cases where
      we've made some other error and failed to mark a wrapper that was circuitously
      observable in the DOM. But we know we have edge case bugs like this, and
      we don't want them to be crashes.)
              
      The fix for this is to check the wrapper back-pointer before firing the
      event listener. As long as the the wrapper back-pointer is not null,
      it's safe to fire the listener. 
      
      * ForwardingHeaders/runtime/WeakGCPtr.h: Added. Appease build gods.
      
      * bindings/js/JSAbstractWorkerCustom.cpp:
      (WebCore::JSAbstractWorker::addEventListener):
      (WebCore::JSAbstractWorker::removeEventListener):
      * bindings/js/JSDOMApplicationCacheCustom.cpp:
      (WebCore::JSDOMApplicationCache::addEventListener):
      (WebCore::JSDOMApplicationCache::removeEventListener):
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::markChildren):
      (WebCore::JSDOMWindow::addEventListener):
      (WebCore::JSDOMWindow::removeEventListener): Updated to pass a wrapper
      to the JSEventListener constructor.
      
      * bindings/js/JSEventListener.cpp:
      (WebCore::JSEventListener::JSEventListener):
      (WebCore::JSEventListener::initializeJSFunction):
      (WebCore::JSEventListener::invalidateJSFunction):
      * bindings/js/JSEventListener.h:
      (WebCore::JSEventListener::create):
      (WebCore::JSEventListener::isolatedWorld):
      (WebCore::JSEventListener::wrapper):
      (WebCore::JSEventListener::setWrapper):
      (WebCore::JSEventListener::jsFunction):
      (WebCore::createJSAttributeEventListener): Implemented the back-pointer
      described above. Refactored the jsFunction() accessor to return 0 if
      the wrapper back-pointer is 0.
      
      * bindings/js/JSEventSourceCustom.cpp:
      (WebCore::JSEventSource::addEventListener):
      (WebCore::JSEventSource::removeEventListener):
      * bindings/js/JSLazyEventListener.cpp:
      (WebCore::JSLazyEventListener::JSLazyEventListener):
      (WebCore::JSLazyEventListener::initializeJSFunction):
      * bindings/js/JSLazyEventListener.h:
      (WebCore::JSLazyEventListener::create):
      * bindings/js/JSMessagePortCustom.cpp:
      (WebCore::JSMessagePort::markChildren):
      (WebCore::JSMessagePort::addEventListener):
      (WebCore::JSMessagePort::removeEventListener):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::JSNode::addEventListener):
      (WebCore::JSNode::removeEventListener):
      (WebCore::JSNode::markChildren):
      * bindings/js/JSSVGElementInstanceCustom.cpp:
      (WebCore::JSSVGElementInstance::addEventListener):
      (WebCore::JSSVGElementInstance::removeEventListener):
      * bindings/js/JSWebSocketCustom.cpp:
      (WebCore::JSWebSocket::addEventListener):
      (WebCore::JSWebSocket::removeEventListener):
      * bindings/js/JSWorkerContextCustom.cpp:
      (WebCore::JSWorkerContext::markChildren):
      (WebCore::JSWorkerContext::addEventListener):
      (WebCore::JSWorkerContext::removeEventListener):
      * bindings/js/JSXMLHttpRequestCustom.cpp:
      (WebCore::JSXMLHttpRequest::markChildren):
      (WebCore::JSXMLHttpRequest::addEventListener):
      (WebCore::JSXMLHttpRequest::removeEventListener):
      * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
      (WebCore::JSXMLHttpRequestUpload::markChildren):
      (WebCore::JSXMLHttpRequestUpload::addEventListener):
      (WebCore::JSXMLHttpRequestUpload::removeEventListener): Updated to pass a wrapper
      to the JSEventListener constructor.
      
      
      * bindings/js/ScriptEventListener.cpp:
      (WebCore::createAttributeEventListener): Updated to pass a wrapper
      to the JSEventListener constructor.
      (WebCore::getEventListenerHandlerBody): Updated for the fact that jsFunction()
      is no longer a virtual accessor on the EventHandler base class.
      
      * bindings/scripts/CodeGeneratorJS.pm: Updated for the fact that jsFunction()
      is no longer a virtual accessor on the EventHandler base class. Added a "JS"
      to invalidateEventListeners and markEventListeners to clarify that these
      actions are for JS event listeners only. Added a wrapper parameter to
      invalidateEventListeners for the back-pointer check explained above.
      
      * dom/EventListener.h:
      (WebCore::EventListener::invalidateJSFunction): ditto
      
      * dom/EventTarget.h:
      (WebCore::EventTarget::markJSEventListeners):
      (WebCore::EventTarget::invalidateJSEventListeners): ditto
      
      LayoutTests: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
      https://bugs.webkit.org/show_bug.cgi?id=33383
      <rdar://problem/7559449>
      
      Reviewed by Alexey Proskuryakov and Darin Adler.
      
      * fast/events/bogus-event-listener-invalidation-expected.txt: Added.
      * fast/events/bogus-event-listener-invalidation.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54400 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      af04b33e
    • mrowe@apple.com's avatar
      Versioning. · 12930538
      mrowe@apple.com authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@54398 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      12930538
    • mrowe@apple.com's avatar
      Versioning. · 2cfce27c
      mrowe@apple.com authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@54397 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2cfce27c
    • eric@webkit.org's avatar
      2010-02-04 Tony Chang <tony@chromium.org> · e012e807
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=25002
              When inserting a new paragraph, avoid nesting empty divs.  When
              pasting near the end of a paragraph, this prevents each paste
              command for getting nested one level deeper.
      
              Three paste tests have been rebaselined since this causes the pasted
              content to be outside the last div instead of inside.  E.g.,
              <div>foo<div>bar</div>[pasted content]</div> is now
              <div>foo<div>bar</div></div><div>[pasted content]</div>
      
              The new test verifies this behavior.
      
              * editing/inserting/paragraph-outside-nested-divs-expected.txt: Added.
              * editing/inserting/paragraph-outside-nested-divs.html: Added.
              * platform/mac/editing/pasteboard/paste-text-012-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-013-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-017-expected.txt:
      2010-02-04  Tony Chang  <tony@chromium.org>
      
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=25002
              When inserting a new paragraph, avoid nesting empty divs.  When
              pasting near the end of a paragraph, this prevents each paste
              command for getting nested one level deeper.
      
              Test: editing/inserting/paragraph-outside-nested-divs.html
      
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::highestVisuallyEquivalentDiv):
              (WebCore::InsertParagraphSeparatorCommand::doApply):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54395 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e012e807
    • barraclough@apple.com's avatar
      Add a JSStringBuilder class (similar-to, and derived-from StringBuilder) to · d40d1172
      barraclough@apple.com authored
      construct JSStrings, throwing a JS exception should we run out of memory whilst
      allocating storage for the string.
      
      Reviewed by Oliver Hunt.
      
      Similarly, add jsMakeNontrivialString methods to use in cases where previously
      we were calling makeString & passing the result to jsNontrivialString.  Again,
      these new methods throw if we hit an out of memory condition.
      
      Move throwOutOfMemoryError into ExceptionHelpers, to make it more widely available.
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * runtime/ArrayPrototype.cpp:
      (JSC::arrayProtoFuncToString):
      (JSC::arrayProtoFuncToLocaleString):
      (JSC::arrayProtoFuncJoin):
      * runtime/DateConstructor.cpp:
      (JSC::callDate):
      * runtime/DatePrototype.cpp:
      (JSC::dateProtoFuncToString):
      (JSC::dateProtoFuncToUTCString):
      (JSC::dateProtoFuncToGMTString):
      * runtime/ErrorPrototype.cpp:
      (JSC::errorProtoFuncToString):
      * runtime/ExceptionHelpers.cpp:
      (JSC::throwOutOfMemoryError):
      * runtime/ExceptionHelpers.h:
      * runtime/JSStringBuilder.h: Added.
      (JSC::JSStringBuilder::releaseJSString):
      (JSC::jsMakeNontrivialString):
      * runtime/NumberPrototype.cpp:
      (JSC::numberProtoFuncToPrecision):
      * runtime/ObjectPrototype.cpp:
      (JSC::objectProtoFuncToString):
      * runtime/Operations.cpp:
      * runtime/Operations.h:
      * runtime/RegExpPrototype.cpp:
      (JSC::regExpProtoFuncToString):
      * runtime/StringBuilder.h:
      (JSC::StringBuilder::append):
      * runtime/StringPrototype.cpp:
      (JSC::stringProtoFuncBig):
      (JSC::stringProtoFuncSmall):
      (JSC::stringProtoFuncBlink):
      (JSC::stringProtoFuncBold):
      (JSC::stringProtoFuncFixed):
      (JSC::stringProtoFuncItalics):
      (JSC::stringProtoFuncStrike):
      (JSC::stringProtoFuncSub):
      (JSC::stringProtoFuncSup):
      (JSC::stringProtoFuncFontcolor):
      (JSC::stringProtoFuncFontsize):
      (JSC::stringProtoFuncAnchor):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54394 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d40d1172
    • dumi@chromium.org's avatar
      WebCore: 1. Fix a bug in SQLiteTransaction: do not assume that COMMIT always · 71fb8a94
      dumi@chromium.org authored
      succeeds.
      2. Jump straight to the transaction error callback when a
      statement fails in a way that makes sqlite automatically rollback
      the transaction.
      3. Fix the code that handles the "quota reached" failure, as it is
      one of the failures that lead to an automatic transaction
      rollback.
      
      Reviewed by Eric Seidel.
      
      https://bugs.webkit.org/show_bug.cgi?id=34280
      
      * platform/sql/SQLiteDatabase.cpp:
      (WebCore::SQLiteDatabase::isAutoCommitOn):
      * platform/sql/SQLiteDatabase.h:
      * platform/sql/SQLiteTransaction.cpp:
      (WebCore::SQLiteTransaction::begin):
      (WebCore::SQLiteTransaction::commit):
      (WebCore::SQLiteTransaction::rollback):
      (WebCore::SQLiteTransaction::transactionWasRolledBackBySqlite):
      * platform/sql/SQLiteTransaction.h:
      * storage/SQLTransaction.cpp:
      (WebCore::SQLTransaction::SQLTransaction):
      (WebCore::SQLTransaction::runStatements):
      (WebCore::SQLTransaction::runCurrentStatement):
      (WebCore::SQLTransaction::handleCurrentStatementError):
      (WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
      
      LayoutTests: 1. Enhance quota-tracking.html: if sqlite automatically rolls back
      a transaction because of a statement failure, make sure the rest
      of the statements in the transaction are not executed.
      2. Fix the expectations for quota-tracking.html. Sqlite cannot
      recover from reaching a DB's max size.
      
      Reviewed by Eric Seidel.
      
      * storage/quota-tracking-expected.txt:
      * storage/quota-tracking.html:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54393 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      71fb8a94
    • pkasting@chromium.org's avatar
      Not reviewed, rollback. · 1b20de7f
      pkasting@chromium.org authored
      Rollback r54387, it doesn't fix builds and Chromium doesn't want this behavior.
      
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54392 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1b20de7f
    • sfalken@apple.com's avatar
      Windows build fix. · 42246ae6
      sfalken@apple.com authored
      * wtf/MathExtras.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54391 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      42246ae6
    • darin@apple.com's avatar
      2010-02-04 Darin Adler <darin@apple.com> · 7391ffae
      darin@apple.com authored
              Reviewed by David Levin.
      
              Make MathExtras.h compatible with <cmath>
              https://bugs.webkit.org/show_bug.cgi?id=34618
      
              * wtf/MathExtras.h: Include <cmath> instead of <math.h>.
              Use "using" as we do elsewhere in WTF for the four functions from <cmath>
              we want to use without the prefix. Later we could consider making the std
              explicit at call sites instead.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54388 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7391ffae
    • senorblanco@chromium.org's avatar
      2010-02-04 Stephen White <senorblanco@chromium.org> · 8d116c80
      senorblanco@chromium.org authored
              Unreviewed, build fix.
      
              Fix for Chromium/Mac after palindromic scrollbar change (54345).
      
              Covered by many layout tests.
      
              * platform/chromium/ScrollbarThemeChromiumMac.h:
              (WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54387 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8d116c80
    • eric@webkit.org's avatar
      2010-02-04 Clemmitt Sigler <cmsigler@gmail.com> · 395d39fd
      eric@webkit.org authored
              Reviewed by David Levin.
      
              WebKitGTK doesn't build GtkLauncher when --enable-mathml is specified.
              Updated WebCore/GNUmakefile.am to include needed files in build.
      
              https://bugs.webkit.org/show_bug.cgi?id=34387
      
              No new tests.
      
              * GNUmakefile.am:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54386 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      395d39fd
    • eric@webkit.org's avatar
      2010-02-04 Stephan Aßmus <superstippi@gmx.de> · 65e047e5
      eric@webkit.org authored
              Reviewed by David Levin.
      
              Misc coding style fixes in Haiku port code.
              https://bugs.webkit.org/show_bug.cgi?id=34527
      
              No tests needed.
      
              * platform/haiku/ContextMenuItemHaiku.cpp: Trailing white space, NULL -> 0
              * platform/haiku/DragImageHaiku.cpp: Trailing white space.
              * platform/haiku/FileChooserHaiku.cpp: Sorted headers.
              * platform/haiku/LocalizedStringsHaiku.cpp: Needed to include NotImplemented.h
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54383 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      65e047e5
  2. 04 Feb, 2010 4 commits