GitLab

Previously, ShellUtil::RemoveShortcuts() simply wipes out the entire directory if |location| is SHORTCUT_LOCATION_START_MENU or SHORTCUT_LOCATION_APP_SHORTCUTS, for efficiency. But we're now writing code to migrate shortcuts on the self-destruct flow. In this case, wiping out the directory would destroy our results. Therefore the new logic for deletion of these directories are:
- Use same code to remove Chrome-specific shortcuts (this is what's done for other diretories, e.g., Start Menu).
- If the directory becomes empty, then remove it; otherwise do nothing.

The side effect is that if user creates any non-Chrome shortcuts in these directories, then these shortcuts (and the containing directory) will persist after Chrome uninstall. I think this is a pretty normal behavior.

BUG=235857

Review URL: https://chromiumcodereview.appspot.com/22870004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217130 0039d316-1c4b-4281-b951-d872f2087c98

NULL check all access to RenderWidgetHost in ImeAdapterAndroid since RWH
can be null after destruction.

BUG=internal b/10143869

Review URL: https://chromiumcodereview.appspot.com/22764006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217129 0039d316-1c4b-4281-b951-d872f2087c98

[InstantExtended] Update chromeactions.txt to correspond with the added actions for detecting a SRP on nav entry committed. See https://codereview.chromium.org/21395002/ for the CL which adds the actions.

Note: this also includes any other updates to actions since the last time chromeactions.txt was updated.

BUG=263644

Review URL: https://chromiumcodereview.appspot.com/22493016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217128 0039d316-1c4b-4281-b951-d872f2087c98

This adds the client plumbing needed to get an arbitrary JSON message from client to host, or vice versa. This will allow us to extend the protocol at short notice, without needing to wait for client plugin changes to be promoted to Stable.

BUG=

Review URL: https://chromiumcodereview.appspot.com/22477006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217127 0039d316-1c4b-4281-b951-d872f2087c98

This shares most of its code with the startup_warm measurement. You
must now specify either --warm or --cold to run the new startup
measurement.

Due to splitting up the original patch for this into many pieces, some
of the earlier changes didn't all work together. There are also a
couple of fixes for those in here.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22300013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217126 0039d316-1c4b-4281-b951-d872f2087c98

BUG=263951
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22940002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217125 0039d316-1c4b-4281-b951-d872f2087c98

Previously, a separate constant (kNumPainters) was used.
This constant was incorrect (there were only two elements in the array).

As described in http://www.viva64.com/en/b/0205/.

BUG=271533

Review URL: https://chromiumcodereview.appspot.com/22920003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217124 0039d316-1c4b-4281-b951-d872f2087c98

I had a copy-paste error in some of the recently-implemented parts of
the extension activity log.  This fixes that.

I believe the bug is harmless because update_statement isn't used again
before it goes out of scope (so it's fine that it was clobbered) and
SQLite defaults to a null value for unbound parameters (so it's fine
that insert_statement wasn't initialized).

Still, I should get the code right and this fixes it.

Review URL: https://chromiumcodereview.appspot.com/22901002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217123 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217121 0039d316-1c4b-4281-b951-d872f2087c98

R=ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/22817004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217120 0039d316-1c4b-4281-b951-d872f2087c98

This is the relanding of crrev.com/216611.

BUG=266714
TEST=manual
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22405006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217119 0039d316-1c4b-4281-b951-d872f2087c98

Provides the ability to generate error messages within schema-compiled code for ease of debugging. 
Error messages may be disabled by adding a 'generate_error_messages' property to json schema, e.g. "generate_error_messages": false

Error generation mostly written by Aaron Jacobs (https://codereview.chromium.org/16462004/).

BUG=234834

Review URL: https://chromiumcodereview.appspot.com/22228002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217118 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164084

Review URL: https://chromiumcodereview.appspot.com/21271002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217117 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22867002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217116 0039d316-1c4b-4281-b951-d872f2087c98

BUG=270192

Review URL: https://chromiumcodereview.appspot.com/22702003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217115 0039d316-1c4b-4281-b951-d872f2087c98

When we don't switch the process, the renderer takes care of updating
the policy. However, when we switch the process, the redirect is handled
in the browser, and we need to update the policy there.

BUG=262860
R=simonjam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22904002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217113 0039d316-1c4b-4281-b951-d872f2087c98

Add another extension to the whitelist for Shared Modules on stable and
supporting Pepper interfaces

BUG=234789

Review URL: https://chromiumcodereview.appspot.com/22407017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217112 0039d316-1c4b-4281-b951-d872f2087c98

Highlights:
- packages now have version numbers, some are listed more than once with
  different version numbers and different licenses.
- many missing licenses and mis-handling of AND/OR licensing cases are fixed.
- latin1 is converted UTF-8 in a few licenses.
- common stock licenses are now only listed once at the end. The resulting file
  is now almost 5 times smaller than it would otherwise be with the new
  licenses it was missing until now.



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217111 0039d316-1c4b-4281-b951-d872f2087c98

BUG=270055

Review URL: https://chromiumcodereview.appspot.com/22630011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217110 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes how omnibox popup results are truncated. Previously content
text would be truncated at 70% which might leave empty space if the description
was short. I've made the following changes to the truncation code:
  - move the truncation logic to the button cell
  - have the content text fill up unused space when truncating
  - use a fade effect to truncate instead of ellipses

BUG=9977, 252988

Review URL: https://chromiumcodereview.appspot.com/17774002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217109 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a leak of WebRTCIdentityRequestHandle when WebRTCIdentityStoreBackend::FindIdentity returns false.

BUG=

Review URL: https://chromiumcodereview.appspot.com/22888002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217108 0039d316-1c4b-4281-b951-d872f2087c98

This ensures that both sides' flow control states stay in sync even if one side resets a stream.

BUG=269873
R=rch@chromium.org

Review URL: https://codereview.chromium.org/22610006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=bbudge@chromium.org, bradnelson@chromium.org, bradnelson@google.com, darin@chromium.org, jhawkins@chromium.org, jvoung@chromium.org

Review URL: https://codereview.chromium.org/22839005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217106 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112928,269028
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/22964002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217104 0039d316-1c4b-4281-b951-d872f2087c98

kInvalidPlatformFileValue is the invalid platform file handle.

BUG=271533

Review URL: https://chromiumcodereview.appspot.com/22841004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=271005
TEST=Added checks in existing tests
R=rjkroege@chromium.org

Review URL: https://codereview.chromium.org/22354005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217102 0039d316-1c4b-4281-b951-d872f2087c98

INVALID_SOCKET for failure.

R=rsleevi@chromium.org
BUG=271530
TEST=none

Review URL: https://chromiumcodereview.appspot.com/22824005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217101 0039d316-1c4b-4281-b951-d872f2087c98

Add the command line flag --enable-overlay-scrollbars to enable
overlay scrollbars in Aura and Linux.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22422010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217100 0039d316-1c4b-4281-b951-d872f2087c98

Added stub portalled wifi network for testing captive portal UI on the
ChromeOS build. To use it one's need run chrome with the folliwing
switches:
--disable-stub-ethernet
--use-new-network-connection-handler
--default-stub-network-state-idle
--enable-stub-portalled-wifi

BUG=246391
TEST=manual tests on Lumpy

Review URL: https://chromiumcodereview.appspot.com/22364005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217099 0039d316-1c4b-4281-b951-d872f2087c98

In GetDriveEntryPropertiesFunction::OnGetFileInfo(), we should not return failure when no
default task is associated with a particular MIME type. Instead we should still append all
apps that support the file type.

BUG=271570
TEST=manually on device, pass trybot
R=satorux@chromium.org, tbarzic@chromium.org

Review URL: https://codereview.chromium.org/22931003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=264497
TEST=manually
TBR=dbeam

Review URL: https://chromiumcodereview.appspot.com/22840004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217096 0039d316-1c4b-4281-b951-d872f2087c98

Since the addition of CA certificate PEMs, the test of the Shill to ONC translation of OpenVPN networks logged an error.

This commit fixes this error and adds another test of the Shill to ONC translation of WiFi with EAP.

BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/22837002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217095 0039d316-1c4b-4281-b951-d872f2087c98

and disabled state and whether the extension updates from the webstore).

BUG=268666

Review URL: https://chromiumcodereview.appspot.com/22390005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217094 0039d316-1c4b-4281-b951-d872f2087c98

We wish to enable allow better selectivity in ShellUtil::RemoveShortcuts() and ShellUtil::UpdateShortcuts() to decide on which shortcuts to operate on. In this CL:
- BatchShortcutAction() is given a (newly defined) FileFilterCallback predicate that decides whether or not a given shortcut should be operated on.
- Currently this is only created by (newly defined) class FilterTargetEq.
- Also renamed FileOperationCallback to ShortcutOperationCallback.
- This is a refactoring CL, so we retain the old behavior: BatchShortcutAction() only considers shortcuts that have with a specific target.

BUG=235857

Review URL: https://chromiumcodereview.appspot.com/22607006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217092 0039d316-1c4b-4281-b951-d872f2087c98

This CL is almost the same as http://crrev.com/17573006, which was reverted because of a unit test breakage.

BUG=245578
TEST=Test manually.

Review URL: https://chromiumcodereview.appspot.com/22534003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217091 0039d316-1c4b-4281-b951-d872f2087c98

There is currently a race condition on updating the sync footer
visibility on the welcome page. If the web page is created after the
initial sync footer visibility state is sent, it is never sent again.

This CL ensures that on startup, the state will always be correct.

BUG=267352

Review URL: https://chromiumcodereview.appspot.com/22375004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217090 0039d316-1c4b-4281-b951-d872f2087c98

Adding the "Authenticate" step to the "MANUAL_Auth" test case. Also added the username and password command line options.

BUG=134210

Review URL: https://chromiumcodereview.appspot.com/22274016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217089 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217088 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=155929:155942&mode=html
TBR=tdanderson@chromium.org
BUG=

Review URL: https://codereview.chromium.org/22916004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217087 0039d316-1c4b-4281-b951-d872f2087c98