GitLab

https://webrtc.googlesource.com/src.git/+log/b619936dee28..3e77afd0d29b

$ git log b619936de..3e77afd0d --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ifceb169cbffa4eaaf933b10492abb5d4583b8d35
Reviewed-on: https://chromium-review.googlesource.com/959165
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542542}

Bug: 813193
Change-Id: I939aee748e638ae6fc3e5171a27491d83df151c3
Reviewed-on: https://chromium-review.googlesource.com/957484Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542541}

This was introduced as an oversight in r541905. The original code safely
handled null element readers on a URLRequest. This CL restores that
safety.

Bug: 820764
Change-Id: I1c37dc546cda989d7796ea66f2f9c073813fe50f
Reviewed-on: https://chromium-review.googlesource.com/959227Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542540}

This reverts commit 0588d062.

Reason for revert: break Linux Builder (dbg) Build 121988 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29/121988

error: undefined symbol: device::internal::ScopedU2fDiscoveryFactory::ScopedU2fDiscoveryFactory()
>>> referenced by fake_u2f_discovery.cc:85 
error: undefined symbol: device::internal::ScopedU2fDiscoveryFactory::~ScopedU2fDiscoveryFactory()
>>> referenced by fake_u2f_discovery.cc:86 

Original change's description:
> Introduce a generic ScopedU2fDiscoveryFactory override.
> 
>  -- In preparation for introducing ScopedU2fVirtualDiscoveryFactory, create a
>     base class ScopedU2fDiscoveryFactory and let ScopedU2fFakeDiscoveryFactory
>     derive from that.
>  -- In preparation for a wider adoption of FakeU2fDiscovery in tests that could
>     not care less about when a discovery starts, add a version of the fake
>     discovery where SimulateStarted()/SimulateStopped() is called automatically.
> 
> Bug: 785955
> Change-Id: I4b1c9bd962c6e225be45971bbb0d5aad3b05a68a
> Reviewed-on: https://chromium-review.googlesource.com/959001
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542507}

TBR=engedy@chromium.org,jdoerrie@chromium.org

Change-Id: Iff7c0aa010fe3ae83262508795bdded90d1f620c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 785955
Reviewed-on: https://chromium-review.googlesource.com/959282Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542539}

This has been disabled in release builds for a while, and might not work
anymore anyway.

Bug: none
Change-Id: I1cadea9d93944909958067eb75c3c64130da9d41
Reviewed-on: https://chromium-review.googlesource.com/959019Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542538}

Using wpt-import in Chromium 37496521.
With Chromium commits locally applied on WPT:
5abdda89 "Remove duplicate color parsing tests"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13764

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=foolip

No-Export: true
Change-Id: I80bec75d5d71873ffd2dfe86f14bdbb2fb9d4cff
Reviewed-on: https://chromium-review.googlesource.com/958220
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542537}

With this change, I've added a hover offset to the mic button. I've also
generalized some button code so that it can be reused by the mic button.
(Specifically, you can now set the corner radius of the disc button, and
we may want to rename this class eventually).

Bug: 818008
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0884b90ae19d34952c639653850ede4754e16fc8
Reviewed-on: https://chromium-review.googlesource.com/958221Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542536}

TBR=kinuko@chromium.org

Bug: 809583
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I0050d598ad4531280085e397403e9597c54977f2
Reviewed-on: https://chromium-review.googlesource.com/959226
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542535}

They simply truncated x, y, width and height to integer, which may not
be what we want and may hide some errors.

The usages of them may be in the following cases:
1. The input rect is already in integral geometry, so all methods of
   IntRect conversion will get the same result;
2. The IntRect is just used for informative purpose so differences of
   1 to 2 pixels at the edges don't matter.

We should use EnclosingIntRect(), EnclosedIntRect(), etc. to explicitly
specify the way to convert.

Convert the usages of them to
- EnclosingIntRect if we are getting a visual rect or a rect that needs
  to cover the input rect;
- Floored size for page size when printing to keep the original behavior.
- PixelSnappedIntRect or RoundedIntRect for others.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ifc81334e39db105d32a046cfa868baa35340a479
Reviewed-on: https://chromium-review.googlesource.com/949571
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542534}

https://pdfium.googlesource.com/pdfium.git/+log/0e2e8db7e6e8..735eda96cf24

$ git log 0e2e8db7e..735eda96c --date=short --no-merges --format='%ad %ae %s'
2018-03-12 rharrison Remove all usages of FXSYS_iswASCIIalpha
2018-03-12 rharrison Remove all usages of FXSYS_iswASCIIalnum
2018-03-12 dsinclair Handle inserting negative values without a selection

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I6476233762914a1c9b23ecca6dc7044e85191e36
Reviewed-on: https://chromium-review.googlesource.com/959119Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542533}

The Ready callback passed to SetReadyCallback is executed
on the task runner thread, and not the UI thread.

This causes a crash in startup when launching Chrome.

Also adding a DCHECK to catch this in tests in the
future.

Bug: 820925, 734095
Change-Id: I59d2b152bbc6538d857f3e6884544217b347885e
Reviewed-on: https://chromium-review.googlesource.com/959017
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542532}

This reverts commit bae82629.

Reason for revert: Breaks Linux Builder (dbg):
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29/121988

Original change's description:
> Reland "Don't have two copies of //device/fido."
> 
> This is a reland of e23bd4d7, now without
> `dllimport`-annotated classes with inline MOCK_METHODs.
> 
> Original change's description:
> > Don't have two copies of //device/fido.
> >
> > Prior to this change, both libcontents.so and content_unittests would
> > each have a copy of //device/fido because the test_support code would
> > pull in a copy directly. This caused there two be two copies of
> > |U2fDiscovery::g_factory_func_| – one used by the test_support code and
> > one by the code that's used for actual processing. That obviously breaks
> > things.
> >
> > This CL makes //device/fido a `component` instead of a `source_set`,
> > which, however, necessitates adding COMPONENT_EXPORT annotations to all
> > exported classes/functions/constants.
> >
> > The CL also cleans up the components by:
> >  -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and
> >  -- moving dependencies included in public headers into `public_deps`.
> >
> > Bug: 785955, 820441
> > Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a
> > Reviewed-on: https://chromium-review.googlesource.com/955698
> > Commit-Queue: Balazs Engedy <engedy@chromium.org>
> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Reviewed-by: Adam Langley <agl@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#542472}
> 
> TBR=jdoerrie@chromium.org
> 
> Bug: 785955, 820441
> Change-Id: I9ed13c7d1105f133c5f54cce7f0a4d74f1d57904
> Reviewed-on: https://chromium-review.googlesource.com/958863
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542523}

TBR=agl@chromium.org,engedy@chromium.org,jdoerrie@chromium.org

Change-Id: Ib21d588a4db7d1b3eed53f44d1ff82f4eb2ef8a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 785955, 820441
Reviewed-on: https://chromium-review.googlesource.com/959242Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542531}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7e11bad4..fbbe951b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ia4647d0b841e3417f480583f9586c5c6ffa298e4
Reviewed-on: https://chromium-review.googlesource.com/957914Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542530}

A large amount of time hit testing is spent converting LayoutRects
to IntRects for the purposes of intersecting. This patch updates
HitTestLocation's bounding_box_ rect to be a LayoutRect which is
consistent with the LayoutPoint point and reduces conversions.

With this patch, blink_perf.events.hit-test-lots-of-layers improves
by between 2% and 5%.

Bug: 818772
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic3bc3b846b89e392b7b9f29a6affb42a5be81152
Reviewed-on: https://chromium-review.googlesource.com/957363Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542529}

This is a direct result of the Find Bar moving to under the OmniBox like a bubble and the added margins/spacing from Harmony.

Bug: 805806
Change-Id: Ib618cb80148dd02c24e8f7cae5a011439813d4ea
Reviewed-on: https://chromium-review.googlesource.com/926715Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542528}

The SchemeHostPort always considers tuples with SCHEME_WITHOUT_PORT to
have empty hosts without being invalid (to cater to cases like file
schemes which can have hosts or not).

This led to a mismatch in SchemeHostPost::GetURL where we always
considered URLs with empty hosts to be valid GURLs, but this is not an
assumption that holds true. This CL just punts the valid decision in this
case to GURL for re-parsing, since it should be a rare occurance.

Bug: 820194
Change-Id: I3f4441d8c71a9b9500c71dbe98f0769f42ad13b5
Reviewed-on: https://chromium-review.googlesource.com/956424Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542527}

This reverts commit cdcb0262.

Reason for revert: We believe that this causes the tests to flake on various platforms, due to issue 816620. We'll re-land it when the mojo::edk::Channel fix has landed.


Original change's description:
> Add missing message-received expectation to IPCMojoBootstrapTest.
> 
> Some of these tests expected a message from the child process, and would
> verify that it was valid/invalid as expected, but would still pass if
> no message were received at all.
> 
> Bug: 816620
> Change-Id: Ie8acf85086f4416c7023118673c40d00a2e190d7
> Reviewed-on: https://chromium-review.googlesource.com/955554
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Commit-Queue: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542296}

TBR=wez@chromium.org,rockot@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 816620
Change-Id: I534fa23c12072cf08507ed4c8073e7505edaf262
Reviewed-on: https://chromium-review.googlesource.com/959241Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542526}

Fix 1:
If app_list_controller_ is not ready, which means the model adapter is
inactive, we add this item in Chrome first.

Fix 2:
While sending a whole trunk of model data to Ash, we also send folders
in case folder information was updated.

Bug: 733662
Bug: 820873
Change-Id: I60aa899acff2a5a5203496498b278f2d6e6cfddb
Reviewed-on: https://chromium-review.googlesource.com/958244
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542525}

Bug: 793323
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id1cb2ae98a0969fe324e3c521e6414c81152d23b
Reviewed-on: https://chromium-review.googlesource.com/957427Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542524}

This is a reland of e23bd4d7, now without
`dllimport`-annotated classes with inline MOCK_METHODs.

Original change's description:
> Don't have two copies of //device/fido.
>
> Prior to this change, both libcontents.so and content_unittests would
> each have a copy of //device/fido because the test_support code would
> pull in a copy directly. This caused there two be two copies of
> |U2fDiscovery::g_factory_func_| – one used by the test_support code and
> one by the code that's used for actual processing. That obviously breaks
> things.
>
> This CL makes //device/fido a `component` instead of a `source_set`,
> which, however, necessitates adding COMPONENT_EXPORT annotations to all
> exported classes/functions/constants.
>
> The CL also cleans up the components by:
>  -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and
>  -- moving dependencies included in public headers into `public_deps`.
>
> Bug: 785955, 820441
> Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a
> Reviewed-on: https://chromium-review.googlesource.com/955698
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Reviewed-by: Adam Langley <agl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542472}

TBR=jdoerrie@chromium.org

Bug: 785955, 820441
Change-Id: I9ed13c7d1105f133c5f54cce7f0a4d74f1d57904
Reviewed-on: https://chromium-review.googlesource.com/958863
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542523}

In trying to change the Cronet sample app to use jars from the
cronet/ output directory I ran into various GN errors about
duplication of output files.  I worry from my crbug.com/816981
experience that this could be causing underlying issues, so
I'm proposing this change to address it here.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I5f05d54b2e6c06f7addad3894e576c7ba6c80dac
Reviewed-on: https://chromium-review.googlesource.com/959142Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542522}

This reverts to a pre crrev.com/c/726079 state, while ensuring that changes related to interactive doodles, the one google bar, using css variables, etc are not affected.

Bug: 812065
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I336351f35077cacecf4682bddfa47322db882eba
Reviewed-on: https://chromium-review.googlesource.com/950105
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542521}

Standard C++ doesn't allow implicit conversion from pointer-to-function to
void*.  MSVC does allow it, and so does clang-cl (but with a warning).
This fixes these warnings. It also enables the warning, so that converting
a function pointer to an object pointer will get a diagnostic both when
targeting Windows and non-Windows.

I first tried using FARPROC instead of void* all over the place (here:
https://chromium-review.googlesource.com/c/chromium/src/+/937443) since having
a pointer-to-function instead of a poiner-to-object seemed more correct to me.
But dcheng pointed out that a void* can't be accidentally called without
casting it to the right type while the FARPROC could be called with too few
parameters, so now I keep the sandbox function pointers void* and just add
casts where needed.

TBR=jochen

Bug: 550065
Change-Id: I0c369275d4b56f786cb32b2fa8d101ee12bea62d
Reviewed-on: https://chromium-review.googlesource.com/957129
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542520}

Adds two tests for MEI on Android. The first is a unit test that ensures
that MEI flags are disabled on Android. The second modifies the browser
tests to make sure that MEI has no effect on Android.

BUG=819315

Change-Id: I6577da1dcd4fb92cb8234289cd20c7393e19dae6
Reviewed-on: https://chromium-review.googlesource.com/957730Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542519}

First step in several to move YUV support into public interfaces
that are not in core, for consumption by chrome. See
https://skia-review.googlesource.com/c/skia/+/110880

R=fmalita@chromium.org

Change-Id: I237adcc03cd54402a2ca021dd91b821d0b2ad7db
Reviewed-on: https://chromium-review.googlesource.com/941661Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542518}

In Cocoa the NSTextInputContext automatically enables secure text input
when activated and it's in the secure text entry mode.

RenderWidgetHostViewMac did the similar thing for ages following the
WebKit example.

views::Textfield needs to do the same thing in a fashion that's
sycnrhonized with RenderWidgetHostViewMac, otherwise the race conditions
are possible when the Textfield gets focus, activates the secure text
input mode and the RWHVM loses focus immediately afterwards and disables
the secure text input instead of leaving it in the enabled state.

BUG=818133,677220

Change-Id: I6db6c4b59e4a1a72cbb7f8c7056f71b04a3df08b
Reviewed-on: https://chromium-review.googlesource.com/943064
Commit-Queue: Michail Pishchagin <mblsha@yandex-team.ru>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542517}

BUG=None
TBR=estade@chromium.org

Change-Id: Ib338d415f8396d674bb80b3c076fb23645e78b51
Reviewed-on: https://chromium-review.googlesource.com/959175Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542516}

The test is flaky.

TBR=jam@chromium.org

Bug: 820995
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2b0f7baa9491e29184595febf039fb2402358af5
Reviewed-on: https://chromium-review.googlesource.com/959014Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542515}

This CL has no behavior changes.

Bug: 770603
Change-Id: If833ca44fbf30eaa592905d4283c593f353908af
Reviewed-on: https://chromium-review.googlesource.com/958765Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542514}

For mash, the ash window manager runs outside the browser process.
Remove direct access to ash::Shell from ChromeVoxPanel.

* Init the panel widget using mus properties
* Introduce mojo API for setting whether the panel should be fullscreen
* Remove mash checks from AccessibilityManager
* Close ChromeVoxPanel immediately on shutdown and during reloads
by session state changes and multi-profile user switching. This helps
prevent having multiple panels open during shutdown, especially in
tests.

ChromeVox doesn't read things yet under mash, but at least the panel
opens now.

Bug: 628655
Test: existing ash_unittests, browser_tests
Change-Id: I14cbf946809787791115930ad33c1c1d3357bf88
Reviewed-on: https://chromium-review.googlesource.com/956235Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542513}

This rebaselines the following tests, which had minor visual
differences from their refs:

media/audio-controls-rendering.html
media/controls-after-reload.html
media/controls-layout-direction.html
media/controls-styling.html
media/controls-styling-strict.html
media/controls-without-preload.html
media/media-controls-clone.html
media/video-controls-rendering.html
media/video-display-toggle.html
media/video-empty-source.html

Change-Id: Ic664381c7d16a85f94724d69fa65cb179ef5ea66
Bug: 612442, 654477, 821025
Reviewed-on: https://chromium-review.googlesource.com/956227
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542512}

Change-Id: I2a22b99caa64cc0d1c3b8d74425375b76b1dca67
Reviewed-on: https://chromium-review.googlesource.com/957737Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#542511}

Remove BottomSheetContentController and all of the related
classes/logic. The only type of bottom sheet content left is
SuggestionsBottomSheetContent.

There is a new ContextualSuggestionsManager that simply constructs
and shows SuggestionsBottomSheetContent in the bottom sheet. This class
will evolve soon.

BUG=814528

Change-Id: I479deba21393b377dc228f1959624506754c502d
Reviewed-on: https://chromium-review.googlesource.com/956722Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542510}

Per feedback from dev and design, this makes the doodle too small.  Ignoring
new spec and reverting to old spec.

Bug: 805645
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic8b01e028ef504f4d03760e67d89808fe95ed9f4
Reviewed-on: https://chromium-review.googlesource.com/957916Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542509}

This flag was really only for development while we weren't sure how to
handle VR Intents. With Chrome VR browsing already shipped, there's no
reason not to allow Intents to launch it.

Change-Id: Ibbc7e5ea41668c073a4a04340ec45bfe40025b0f
Reviewed-on: https://chromium-review.googlesource.com/959051
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542508}

 -- In preparation for introducing ScopedU2fVirtualDiscoveryFactory, create a
    base class ScopedU2fDiscoveryFactory and let ScopedU2fFakeDiscoveryFactory
    derive from that.
 -- In preparation for a wider adoption of FakeU2fDiscovery in tests that could
    not care less about when a discovery starts, add a version of the fake
    discovery where SimulateStarted()/SimulateStopped() is called automatically.

Bug: 785955
Change-Id: I4b1c9bd962c6e225be45971bbb0d5aad3b05a68a
Reviewed-on: https://chromium-review.googlesource.com/959001
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542507}

This reverts commit 9dd1ef42.

Reason for revert: Latest canary data did not have expected recovery on Omnibox.CharTypedToRepaintLatency and had a regression on Omnibox.CharTypedToRepaintLatency.ToPaint. Reverting to see if that movement is related to this CL or whether there were other changes in the meanwhile.

Original change's description:
> Cache brand code on Windows.
> 
> Querying the registry is expensive and contributes to start up time,
> omnibox query time and idle. Since the brand code is not expected to
> change on Windows during the course of a session, this CL caches
> the value, so that future queries are free.
> 
> This should restore the Omnibox perf that regressed by
> https://chromium-review.googlesource.com/c/chromium/src/+/824363
> and also improve perf elsewhere since the caching is now done at
> a lower level than that change. Since this is expensive only on
> Windows, the caching is done in the Windows codepath only.
> 
> Bug: 816698, 806130
> Change-Id: I458fad29f18b1b1ff2d55b9334ae733fa448eec9
> Reviewed-on: https://chromium-review.googlesource.com/947522
> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541009}

TBR=pkasting@chromium.org,asvitkine@chromium.org,grt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 816698, 806130
Change-Id: I09e12c17011f72f25ecb369ca3075e2067013f8a
Reviewed-on: https://chromium-review.googlesource.com/958012Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542506}

We're just about to destroy said object, and since this is only issuing
"local" (client-only, no ancestors) invalidations they will have no
effect.

Bug: 769774
Change-Id: Ib8d0afecb65a80bd89990906940e792cadcc2dcb
Reviewed-on: https://chromium-review.googlesource.com/958903Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#542505}

Bug: 805636
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I38c1003c7bf4935bbc1071efad166fb113ba471b
Reviewed-on: https://chromium-review.googlesource.com/957915Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542504}

This fixes a problem on iOS where <select> elements with negative tabindex
values are not being filled. This is because on iOS they are considered
non-focusable and autofill manager does not autofill nonfocusable fields.

This doesn't change the behavior on other platforms since filling
non-focusable <select> elements is already allowed:
https://cs.chromium.org/chromium/src/components/autofill/content/renderer/form_autofill_util.cc?l=881

Bug: 820618
Change-Id: Ie01f2611362dcaadf4ec22c39f645cfe51652d04
Reviewed-on: https://chromium-review.googlesource.com/959106
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542503}