- 19 Dec, 2019 40 commits
-
-
Hirokazu Honda authored
This enables V4L2IP to work with GpuMemoryBuffer based VideoFrame on input and output. on kukui Bug: 1033799, 1011281 Test: IP test --gtest_filter=NV12DownScaling/ImageProcessorParamTest.* Test: VD tests on hana, kukui Change-Id: I3001c1bb4d782c448e7e45fa52f4be7ed58dd88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965789 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726358}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4de162fd4924..1cc63223019c git log 4de162fd4924..1cc63223019c --date=short --first-parent --format='%ad %ae %s' 2019-12-19 fmayer@google.com Merge "Show self_max in heap_profile_allocation." Created with: gclient setdep -r src/third_party/perfetto@1cc63223019c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia7b80ce3ab4fca34fc4ec7ab03f916241d6c9f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976031Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726357}
-
Hirokazu Honda authored
This enables V4L2IP to read and write buffers with respect of offsets specified by VideoFrame. ConvertOneTime_GmbToGmb on kukui Bug: 1033799, 1011281 Test: IP test --gtest_filter=NV12DownScaling/ImageProcessorParamTest. Test: VD tests on hana, kukui Change-Id: I557a64533afd5e0f75c862d323fe392b179a51c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966804 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: -
Camille Lamy authored
Now that the reporting API is enabled by default, these tests can be enabled. Bug: 694525,704259,850170 Change-Id: I36b4e9cda576d48f3543e7bf265a0d9dff66e3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971917Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#726355}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3e618bf6..71befefb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia0d0688716cf12c4af275be284ed1b947b2389bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975832Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726354}
-
Stephane Zermatten authored
Before this change, the set of updated script from GetActionsResponse.update_script_list was only applied at the end of a script. With this change, the set of updated scripts reported by GetActionsResponse.updated_script_list is applied right away. This limitation was put in place to avoid issues with pointers to scripts becoming invalid at any time. To avoid this issues, this change avoids storing Script* anywhere else than the list of scripts, preferring to reference scripts by their path, when necessary. This change also strictly separates scripts from interrupts, to avoid confusion and to keep things a bit simpler. It is not possible anymore to define a script that is both an interrupt and a normal script, that is proposed as a runnable script on the UI. This feature was never used. Bug: b/146314751 Change-Id: I466adb9c9ec3e79c659bac0798df46b5311739a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968992Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#726353}
-
Hirokazu Honda authored
media/gpu/V4L2Buffer: GetVideoFrame() returns VideoFrame whose number of fds are the same as the number of planes Dmabuf-backed VideoFrame and GpuMemoryBuffer-based VideoFrame created by using NativePixmap interface and GpuMemoryBuffer interface always has the same number of fds as the number of planes. So some code assumes that the condition is always true. V4L2Buffer::GetVideoFrame() returns Dmabuf-backed VideoFrame whose number of fds are the same as v4l2 planes. For example, the number of fds are one if the format is V4L2_PIX_FMT_NV12, and three if V4L2_PIX_FMT_NV12M. This breaks the assumption and thus causes an issue. We would rather make GetVideoFrame() return VideoFrame whose has the same number of fds as the number of planes, than handling this exception on several code places. Bug: 1033799 Test: VDA test on kukui Change-Id: If96551e2b9a70c3e49e4bff98ccbffad657d250d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967016 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#726352}
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Change-Id: Ife0f8850b452437aea01a4230d66c5cbc7c3b0ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971836 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#726351}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ed56d990. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." fadf6027 "[css-pseudo] Recalculate viewport units in ::marker" 044ad8ad "[OT-PW] Make it work with OOP-R" 9899425d "[css-layout-api] IntrinsicSizes Implementation" 7d838af7 "[scroll-to-text-fragment] Apply :target CSS pseudo-class to match." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic4871dcc160a3fc64e4c616e90c1268fb04fe5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975831Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726350}
-
sandromaggi authored
The privacy notice is no longer required, removing it from tests where it was only added due to this requirement. Add new test for empty card network to make sure we don't exclude all cards in this case. Bug: b/146126954 Bug: b/146424039 Change-Id: I35ae536c00d8774efac23eb4a586fa53f472642a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975911Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#726349}
-
Antonio Gomes authored
... instead of static helper functions all over the place. BUG=787254 R=guidou@chromium.org Change-Id: Id6367e7818e9094129e2b9ee6978d79b575e1fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974002Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#726348}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/12d9cc3132f1..52cef46d51d3 git log 12d9cc3132f1..52cef46d51d3 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 janscheffler@chromium.org Refactor Cookie implementation 2019-12-19 szuend@chromium.org [cleanup] Remove unused method in DebuggerPlugin Created with: gclient setdep -r src/third_party/devtools-frontend/src@52cef46d51d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1030258 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1cc24760173e79b56efb284f6abe9c6c6378cf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976032Reviewed-by:
-
Andreas Haas authored
Using byteLengthAsSizeT should not be a problem here, as the receivers are already either of type size_t or uint64_t. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I805e58ee5d42fc95fb2c3ab262796945b01264a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975874Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#726346}
-
Antonio Gomes authored
.. to use WTF counterparts. BUG=787254 R=haraken@chromium.org Change-Id: I849f0db979269268a7947562fa767615cb587ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973999Reviewed-by:
-
Chih-Yu Huang authored
The Chromium smart pointer guidelines [1] says "don't pass or return a smart pointer by reference". This CL remove "const scoped_refptr<T>&" at MailboxVideoFrameConverter. [1] https://www.chromium.org/developers/smart-pointer-guidelines Bug: 1020668 Test: ninja media/gpu/chromeos Change-Id: I09feb2e97e9528c23c8c3d92ecdc0fdea2478f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974724 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#726344}
-
Marc Treib authored
"Subscription" is the correct terminology wrt topics. No behavior changes. TBR=droger for trivial call site update in ios/chrome/browser/prefs/browser_prefs.mm Bug: 1029698 Change-Id: I4ffc95393008f8710c1658b182402775ec6f9538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974232 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#726343}
-
Anatoliy Potapchuk authored
Bug: 1035097 Change-Id: I52c1a725ec6cc96a9952137b5449491974df6911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972840 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#726342}
-
Andreas Haas authored
As discussed in https://crrev.com/c/1970172, this CL introduces a helper function to check the size of an ArrayBuffer and creates an error if it exceeds the maximum supported size. R=kbr@chromium.org Bug: chromium:1008840 Change-Id: If8eaa8686f9f787484e094e78deaf741cdc436d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972145 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#726341}
-
Clemens Arbesser authored
Bug: 1033877 Change-Id: I281c73f0844d3682ae7a2c8a720d6ec4165aea4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975715 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#726340}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/nfc. Bug: 1001114 Change-Id: I5471df724b1a967202b26ec937cd71e779df65b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969133Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#726339}
-
Fabian Sommer authored
Also, change the focus indicator for the arrow button from a rectangle to a circle that matches the button. Bug: 1024254 Change-Id: Ie39a3fa98f1c39a62a7db70b90fa80b410668495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946471Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@google.com> Cr-Commit-Position: refs/heads/master@{#726338}
-
Antonio Gomes authored
... to use THREAD_CHECKER instead. Reason: Blink does not currently make use of sequences [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU BUG=787254 R=haraken@chromium.org Change-Id: I7ad47acabde0a0b34d2b4f302fd0c6e192d4aecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973997Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/763d35f18f56..e0643720ad76 Created with: gclient setdep -r src-internal@e0643720ad76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022981 Tbr: jbudorick@google.com Change-Id: Ie844fcc7dd92fe8a1f66dcc16440fa74df72baf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975663Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726336}
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: I9cb270dbcb9981ebe1e00cb8d9102315f482324b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974110 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/849b3de2b2d7..12d9cc3132f1 git log 849b3de2b2d7..12d9cc3132f1 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 janscheffler@chromium.org Update list of predefined aria-attributes Created with: gclient setdep -r src/third_party/devtools-frontend/src@12d9cc3132f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I281147721e1e116488208bc486d26776f501fb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975661Reviewed-by:
-
Marc Grimme authored
The default policy for allowed or blocked hosts is overwriting from different contexts(profile) and can lead to wrong policies being applied to extensions (see bug #1028577). This fix creates a static map that stores the profile (by id) and the relevant default_policy_allowed_hosts/default_policy_blocked_hosts in a struct. TODO: Write integration tests (crbug.com/1031179) R=marcgrimme Bug: 1028577 Change-Id: Ie08447ddd5175562b474fa5801f6959315372c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946368Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Marc Grimme <marcgrimme@chromium.org> Cr-Commit-Position: refs/heads/master@{#726333}
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Change-Id: I9f24a89c2e9b9f8998d892bd8d6cb2857b4e45e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971833 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
sandromaggi authored
Previously the source for contacts and shipping addresses was the same sorted list of profiles. There may be cases where we want to sort them differently, which is enabled by splitting the list in two. On view we transform the profiles into either Contacts or Addresses. Note: This change breaks the default selection based on the account's address. This is moved to native in crrev/c/1954393 and has not been recreated here. Bug: b/144005336 Change-Id: I1e8e085f1de2fc7710969e778078495b3b54704b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961197 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a1e2eee578bf..4de162fd4924 git log a1e2eee578bf..4de162fd4924 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 taylori@google.com Merge "perfetto-ui: Add origin trial" Created with: gclient setdep -r src/third_party/perfetto@4de162fd4924 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2912e8cef779a8bbfa81e8eb6fc4052d7574b897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975654Reviewed-by:
-
Mathias Carlen authored
Remove the trusted apps whitelist and the AGREED_TO_TC logic that was introduced for a now obsolete flow. Bug: b/145907489 Bug: 1031697 Change-Id: I330f1ee91e43c93ccdaedd90126737bf064e957b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967241Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4b80fbc8f94a..f321db9a8ea2 git log 4b80fbc8f94a..f321db9a8ea2 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 38d7fbaad0a3..e70b009b0f1e (1 commits) 2019-12-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 21be09d8e699..4fd7fccd6db5 (4 commits) 2019-12-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 2b19f3916726..e8e8f32d1b7a (4 commits) 2019-12-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 9c5719ab7149..246503e9c085 (1 commits) Created with: gclient setdep -r src/third_party/angle@f321db9a8ea2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I587fc36de24b668a94bb03d7ba525461e195fa47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974927Reviewed-by:
-
Dan Elphick authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: I21c9733cd10e46b1983c936b7b9b7d9081329e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970563 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Mike West authored
This patch partially reverts [1], which began applying the context document's CSP to the document fragment produced from `DOMParser.parseFromString`. This application broke the expectations of GMail's dynamic email feature, and we ought to pull it out until we understand whether our CSP implementation is wrong, or whether GMail is wrong. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1917532 Bug: 1030830, 951536 Change-Id: Id7e86ca85df8790bb58fda15827a3f34e00239fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975710Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#726326}
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: Ia60ab1c6c3607e85fe07dd1887ce144c8c8f790a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973811Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1a5c0d36940b..849b3de2b2d7 git log 1a5c0d36940b..849b3de2b2d7 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 changhaohan@chromium.org bypass URL trimming for style panel URL Created with: gclient setdep -r src/third_party/devtools-frontend/src@849b3de2b2d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1027168 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e6086ef48cd039206f70269e4f2b74e3af21513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975650Reviewed-by:
-
Philipp Hancke authored
adds calculators for the number of retransmitted packets and bytes sent Bug: none Change-Id: I3b5622c16e307c858c09cdcf14fc2ca7dd9e3d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972834Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#726323}
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Change-Id: I8c3270ba0369681dba7e5710e6d8ea580666e33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973824Reviewed-by:
-
Mathias Bynens authored
A long time ago in a galaxy far, far away, there was a property order mismatch between the DevTools Console Preview and the expanded view. For example: input> ({ c: 1, b: 1, a: 1 }) preview> {c: 1, b: 1, a: 1} expanded> {a: 1, b: 1, c: 1, __proto__: Object} We then attempted [1] to remove the confusing mismatch as follows: input> ({ c: 1, b: 1, a: 1 }) preview> {c: 1, b: 1, a: 1} expanded> {c: 1, b: 1, a: 1, __proto__: Object} In addition to avoiding the mismatch, this patch made DevTools more closely resemble the internal shapes of objects [2] instead of hiding this information from developers. However, since shipping, we've heard overwhelming feedback in favor of restoring the old behavior, where the expanded view is sorted. As a result of this feedback, a DevTools patch [3] restores the sorting logic. Now that the DevTools front-end change has landed and rolled into Chromium [4], we can re-enable the tests. Note that their expectations have already been updated as part of a prior CL [5] which disabled them. [This patch updates the test expectations accordingly. Note that for each test, only the order in which properties/values are printed changes. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1806457 [2]: https://mathiasbynens.be/notes/shapes-ics [3]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1969479 [4]: https://chromium-review.googlesource.com/c/chromium/src/+/1972163 [5]: https://chromium-review.googlesource.com/c/chromium/src/+/1971832 Bug: chromium:989514, chromium:1008910 Change-Id: I17aa627cd91ee9edbc28bf4778db6be056b89bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973814 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#726321}
-
Mathias Carlen authored
Before this patch, building desktop chrome using code from autofill_assistant doesn't link. This patch moves the static member in wait for navigation to the cc file to resolve that. R=sandromaggi@google.com Bug: b/143736397 Change-Id: I9c0c70657037b66316dff42d07494c6536956596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975530Reviewed-by:
-
Emanuel Ziegler authored
This CL replaces calls to deprecatedByteLengthAsUnsigned by calls to byteLengthAsSizeT. If the byte length is larger then a RangeError is thrown to avoid problems in passing a wrongly cast size to the underlying stack. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=jsbell@chromium.org Bug: chromium:1008840 Change-Id: Icb8a40032624405458d180ec107f354b166dc60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964491Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#726319}
-
